[
https://issues.apache.org/jira/browse/CALCITE-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168920#comment-16168920
]
Dian Fu commented on CALCITE-1986:
--
[~julianhyde] I have left a few minor comments on y
[
https://issues.apache.org/jira/browse/CALCITE-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168560#comment-16168560
]
Julian Hyde commented on CALCITE-1986:
--
I have sketched out RelBuilder.patternConca
[
https://issues.apache.org/jira/browse/CALCITE-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168529#comment-16168529
]
Julian Hyde commented on CALCITE-1986:
--
I will also change the `List` parameters to
[
https://issues.apache.org/jira/browse/CALCITE-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168427#comment-16168427
]
Julian Hyde commented on CALCITE-1986:
--
I would rename the method {{RelBuilder.matc
[
https://issues.apache.org/jira/browse/CALCITE-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166014#comment-16166014
]
Zhiqiang He commented on CALCITE-1986:
--
It's OK. I'm already review it. I think thi
[
https://issues.apache.org/jira/browse/CALCITE-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165840#comment-16165840
]
Dian Fu commented on CALCITE-1986:
--
{quote}
when do we need to create a matchrecoginize
[
https://issues.apache.org/jira/browse/CALCITE-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165810#comment-16165810
]
Zhiqiang He commented on CALCITE-1986:
--
[~dian.fu] your test case is only create.
[
https://issues.apache.org/jira/browse/CALCITE-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165739#comment-16165739
]
Dian Fu commented on CALCITE-1986:
--
[~julianhyde] Could you help to review when it's co
