[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839900#comment-16839900 ] Danny Chan commented on CALCITE-2282: - I would merge this PR if there are no more comments in 24

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839028#comment-16839028 ] Danny Chan commented on CALCITE-2282: - [~julianhyde] Thx for you nice review, i just remove the

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838935#comment-16838935 ] Julian Hyde commented on CALCITE-2282: -- I reviewed your latest. Just one thing:

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837975#comment-16837975 ] Danny Chan commented on CALCITE-2282: - [~julianhyde] I think we can, there only needs a flag to 

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837930#comment-16837930 ] Julian Hyde commented on CALCITE-2282: -- [~danny0405], I reviewed your PR. It looks basically good.

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830001#comment-16830001 ] Lai Zhou commented on CALCITE-2282: --- [~zhztheplayer] ,thanks, you're right. " That said, you can put

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826600#comment-16826600 ] Danny Chan commented on CALCITE-2282: - [~julianhyde] i'm planning to remove the sql operator table

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826328#comment-16826328 ] Julian Hyde commented on CALCITE-2282: -- Regarding DIVIDE. I'm trying to choose the lesser evil

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826033#comment-16826033 ] Danny Chan commented on CALCITE-2282: - [~julianhyde] I did more tests and i make sure we can

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825923#comment-16825923 ] Lai Zhou commented on CALCITE-2282: --- [~zhztheplayer], It likes what I commented before, {code:java}

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825802#comment-16825802 ] Hongze Zhang commented on CALCITE-2282: --- {quote}I didn't find the way as Hongze Zhang said to

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825709#comment-16825709 ] Danny Chan commented on CALCITE-2282: - [~hhlai1990] Seems you really have much requests about

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825653#comment-16825653 ] Lai Zhou commented on CALCITE-2282: --- [~danny0405]， it's the way how I override the built-in

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825443#comment-16825443 ] Julian Hyde commented on CALCITE-2282: -- Because the built-in operators are static. For example, we

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824872#comment-16824872 ] Danny Chan commented on CALCITE-2282: - [~julianhyde] I'm a little confused about this:

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824858#comment-16824858 ] Julian Hyde commented on CALCITE-2282: -- I don’t think we need to worry about CASE or VALUES, or

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824786#comment-16824786 ] Danny Chan commented on CALCITE-2282: - [~julianhyde] We did have an identifier in sql call[1], now

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824425#comment-16824425 ] Julian Hyde commented on CALCITE-2282: -- Good analysis - thanks. Does the un-validated

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823836#comment-16823836 ] Danny Chan commented on CALCITE-2282: - [~julianhyde] After i remove the code snippet, the unparsed

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823623#comment-16823623 ] Danny Chan commented on CALCITE-2282: - [~julianhyde] Seems that this code snippet is useless now, i

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823413#comment-16823413 ] Julian Hyde commented on CALCITE-2282: -- The {{opTab}} field is only used in one place: {code}

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821082#comment-16821082 ] Hongze Zhang commented on CALCITE-2282: --- The std operator table in parsers shouldn't prevent you

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821049#comment-16821049 ] Danny Chan commented on CALCITE-2282: - [~zhztheplayer] The parser has a hard code SqlStdOperator

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820965#comment-16820965 ] Hongze Zhang commented on CALCITE-2282: --- {quote} I use a customized parser to override the

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820939#comment-16820939 ] Lai Zhou commented on CALCITE-2282: --- [~julianhyde], I think we should let the validator to resolve

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820897#comment-16820897 ] Julian Hyde commented on CALCITE-2282: -- Do we really REALLY need an operator table in the parser,

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818921#comment-16818921 ] Lai Zhou commented on CALCITE-2282: --- +1.[~julianhyde] , is there a good way to solve this ? I use a

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454382#comment-16454382 ] Laurent Goujon commented on CALCITE-2282: - That would have been my preferred approach too, but

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454373#comment-16454373 ] Julian Hyde commented on CALCITE-2282: -- I think we should pass an operator table in as a

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454342#comment-16454342 ] Laurent Goujon commented on CALCITE-2282: - [~sudheeshkatkam] maybe you can explain what problem

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453520#comment-16453520 ] Julian Hyde commented on CALCITE-2282: -- This is one of those "drill a hole" changes I hate. Isn't