[jira] [Commented] (CALCITE-2302) Implicit type cast support

2019-08-29 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919078#comment-16919078 ] Julian Hyde commented on CALCITE-2302: -- Thanks for your patience in getting this to completion,

[jira] [Commented] (CALCITE-2302) Implicit type cast support

2019-08-29 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918405#comment-16918405 ] Danny Chan commented on CALCITE-2302: - [~julianhyde] Thanks. There seems to be 2 style type

[jira] [Commented] (CALCITE-2302) Implicit type cast support

2019-08-28 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917951#comment-16917951 ] Julian Hyde commented on CALCITE-2302: -- [~danny0405] Do I understand correctly that after this

[jira] [Commented] (CALCITE-2302) Implicit type cast support

2019-08-28 Thread Stamatis Zampetakis (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917850#comment-16917850 ] Stamatis Zampetakis commented on CALCITE-2302: -- Hey Danny, this issue is going to have a

[jira] [Commented] (CALCITE-2302) Implicit type cast support

2019-08-25 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915414#comment-16915414 ] Danny Chan commented on CALCITE-2302: - [~julianhyde] Does the latest commit solve your review

[jira] [Commented] (CALCITE-2302) Implicit type cast support

2019-08-23 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914070#comment-16914070 ] Danny Chan commented on CALCITE-2302: - I have made the latest change in commit 

[jira] [Commented] (CALCITE-2302) Implicit type cast support

2019-08-22 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913843#comment-16913843 ] Danny Chan commented on CALCITE-2302: - Thanks, [~julianhyde] I kind of agree with your point that

[jira] [Commented] (CALCITE-2302) Implicit type cast support

2019-08-22 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913576#comment-16913576 ] Julian Hyde commented on CALCITE-2302: -- I just noticed that we have

[jira] [Commented] (CALCITE-2302) Implicit type cast support

2019-08-21 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912840#comment-16912840 ] Danny Chan commented on CALCITE-2302: - [~julianhyde] Does my reply answer your questions ? I'm

[jira] [Commented] (CALCITE-2302) Implicit type cast support

2019-08-21 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912839#comment-16912839 ] Danny Chan commented on CALCITE-2302: - For "9/2 returns 4.5", we indeed do the type coercion

[jira] [Commented] (CALCITE-2302) Implicit type cast support

2019-08-21 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911967#comment-16911967 ] Julian Hyde commented on CALCITE-2302: -- [~danny0405] Not sure that the policy for deriving the

[jira] [Commented] (CALCITE-2302) Implicit type cast support

2019-08-21 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911987#comment-16911987 ] Danny Chan commented on CALCITE-2302: - [~julianhyde] Personally i propose to add this policy to

[jira] [Commented] (CALCITE-2302) Implicit type cast support

2019-08-20 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911921#comment-16911921 ] Haisheng Yuan commented on CALCITE-2302: +1 on the patch, overall. Given the default behavior

[jira] [Commented] (CALCITE-2302) Implicit type cast support

2019-08-18 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910144#comment-16910144 ] Danny Chan commented on CALCITE-2302: - Thanks [~zabetak], most of the sql contexts that need

[jira] [Commented] (CALCITE-2302) Implicit type cast support

2019-08-16 Thread Stamatis Zampetakis (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909601#comment-16909601 ] Stamatis Zampetakis commented on CALCITE-2302: -- I think we agreed that it should be

[jira] [Commented] (CALCITE-2302) Implicit type cast support

2019-08-16 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908903#comment-16908903 ] Danny Chan commented on CALCITE-2302: - Thanks so much for your review [~hyuan] ! I have add a new

[jira] [Commented] (CALCITE-2302) Implicit type cast support

2019-08-15 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908576#comment-16908576 ] Haisheng Yuan commented on CALCITE-2302: Let me repeat my comment here. My only concern is that

[jira] [Commented] (CALCITE-2302) Implicit type cast support

2019-08-14 Thread Stamatis Zampetakis (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907122#comment-16907122 ] Stamatis Zampetakis commented on CALCITE-2302: -- Hey [~hyuan], it seems that you reviewed

[jira] [Commented] (CALCITE-2302) Implicit type cast support

2019-07-30 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896156#comment-16896156 ] Danny Chan commented on CALCITE-2302: - Thanks, [~julianhyde], i have rebase the code again ~ >

[jira] [Commented] (CALCITE-2302) Implicit type cast support

2019-07-29 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895534#comment-16895534 ] Julian Hyde commented on CALCITE-2302: -- Let's get this reviewed and into 1.21. It's a useful

[jira] [Commented] (CALCITE-2302) Implicit type cast support

2019-03-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790307#comment-16790307 ] Danny Chan commented on CALCITE-2302: - Hi [~julianhyde] is there any possibility that this patch

[jira] [Commented] (CALCITE-2302) Implicit type cast support

2018-05-31 Thread Yuzhao Chen (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497520#comment-16497520 ] Yuzhao Chen commented on CALCITE-2302: -- Hi, committers, can you give me some suggestions? Our

[jira] [Commented] (CALCITE-2302) Implicit type cast support

2018-05-30 Thread Yuzhao Chen (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495975#comment-16495975 ] Yuzhao Chen commented on CALCITE-2302: -- Hi, [~julianhyde] Can you give me some suggestions? I'm

[jira] [Commented] (CALCITE-2302) Implicit type cast support

2018-05-30 Thread Yuzhao Chen (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494723#comment-16494723 ] Yuzhao Chen commented on CALCITE-2302: -- hi, [~julianhyde] I have made a PR here

[jira] [Commented] (CALCITE-2302) Implicit type cast support

2018-05-07 Thread Yuzhao Chen (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466732#comment-16466732 ] Yuzhao Chen commented on CALCITE-2302: -- Most common cases are: # 1='1' comparison # UDF/UDAF which

[jira] [Commented] (CALCITE-2302) Implicit type cast support

2018-05-07 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466270#comment-16466270 ] Julian Hyde commented on CALCITE-2302: -- Calcite already does some implicit conversions. I agree we