[ 
https://issues.apache.org/jira/browse/CALCITE-2463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725009#comment-16725009
 ] 

Volodymyr Vysotskyi commented on CALCITE-2463:
----------------------------------------------

+1. Good improvement, I will merge it after the release process is finished.

> Silence ERROR logs from CalciteException, SqlValidatorException
> ---------------------------------------------------------------
>
>                 Key: CALCITE-2463
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2463
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.17.0
>            Reporter: Vladimir Sitnikov
>            Assignee: Julian Hyde
>            Priority: Major
>
> CalciteException and SqlValidatorException log exceptions at ERROR level.
> This is not appropriate since
> 1) the exception might be expected by the caller
> 2) exception might contain sensitive information
> 3) ERROR level is not appropriate, since error in validation does not imply 
> business-level error.
> I suggest to remove `LOGGER.error` calls from Calcite code.
> Logging exceptions at TRACE level is fine from my point of view, so client 
> can enable trace logging if required for debug purposes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to