[
https://issues.apache.org/jira/browse/CALCITE-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1826#comment-1826
]
Stamatis Zampetakis commented on CALCITE-2617:
--
Thanks for the review and the added tests
[
https://issues.apache.org/jira/browse/CALCITE-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651422#comment-16651422
]
Stamatis Zampetakis commented on CALCITE-2617:
--
[~julianhyde] , I updated the PR with your
[
https://issues.apache.org/jira/browse/CALCITE-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649073#comment-16649073
]
Aman Sinha commented on CALCITE-2617:
-
[~julianhyde], [~zabetak] if the tests pass with these
[
https://issues.apache.org/jira/browse/CALCITE-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648976#comment-16648976
]
Stamatis Zampetakis commented on CALCITE-2617:
--
[~julianhyde]
{quote}
I think that we
[
https://issues.apache.org/jira/browse/CALCITE-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648634#comment-16648634
]
Julian Hyde commented on CALCITE-2617:
--
Reviewing the PR:
* I don't see any need for a new
[
https://issues.apache.org/jira/browse/CALCITE-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648631#comment-16648631
]
Julian Hyde commented on CALCITE-2617:
--
[~rubenql], Do not change the {{containsOver}} call. It is
[
https://issues.apache.org/jira/browse/CALCITE-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646827#comment-16646827
]
Ruben Quesada Lopez commented on CALCITE-2617:
--
No problem [~zabetak], I can close my PR,
[
https://issues.apache.org/jira/browse/CALCITE-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646806#comment-16646806
]
Stamatis Zampetakis commented on CALCITE-2617:
--
[~rubenql] , I just saw that you already
[
https://issues.apache.org/jira/browse/CALCITE-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646510#comment-16646510
]
Stamatis Zampetakis commented on CALCITE-2617:
--
I'm sorry [~julianhyde] but I am not sure
[
https://issues.apache.org/jira/browse/CALCITE-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646494#comment-16646494
]
Stamatis Zampetakis commented on CALCITE-2617:
--
Always pushing filters in the presence of
[
https://issues.apache.org/jira/browse/CALCITE-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646476#comment-16646476
]
Julian Hyde commented on CALCITE-2617:
--
How significant is the risk of regressions? (As opposed to
[
https://issues.apache.org/jira/browse/CALCITE-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646434#comment-16646434
]
Stamatis Zampetakis commented on CALCITE-2617:
--
{quote}
Should it be enabled by default?
[
https://issues.apache.org/jira/browse/CALCITE-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646402#comment-16646402
]
Vladimir Sitnikov commented on CALCITE-2617:
Should it be enabled by default?
Should it be
13 matches
Mail list logo