[jira] [Commented] (CALCITE-3005) Implement string functions: LEFT, RIGHT

2019-06-10 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16860532#comment-16860532 ] Julian Hyde commented on CALCITE-3005: -- Thanks for taking responsibility, but it w

[jira] [Commented] (CALCITE-3005) Implement string functions: LEFT, RIGHT

2019-06-10 Thread Forward Xu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16860487#comment-16860487 ] Forward Xu commented on CALCITE-3005: - hi [~julianhyde] Thank you very much, this i

[jira] [Commented] (CALCITE-3005) Implement string functions: LEFT, RIGHT

2019-06-10 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859781#comment-16859781 ] Julian Hyde commented on CALCITE-3005: -- Fixed in [90a431691|https://github.com/apa

[jira] [Commented] (CALCITE-3005) Implement string functions: LEFT, RIGHT

2019-06-09 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859755#comment-16859755 ] Julian Hyde commented on CALCITE-3005: -- Yes. My bad. I have a fix and I’m testing

[jira] [Commented] (CALCITE-3005) Implement string functions: LEFT, RIGHT

2019-06-09 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859664#comment-16859664 ] Danny Chan commented on CALCITE-3005: - An compile warning of JavaCC throws: {code:j

[jira] [Commented] (CALCITE-3005) Implement string functions: LEFT, RIGHT

2019-06-03 Thread Forward Xu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854703#comment-16854703 ] Forward Xu commented on CALCITE-3005: - hi [~julianhyde] Thank you very much for you

[jira] [Commented] (CALCITE-3005) Implement string functions: LEFT, RIGHT

2019-06-03 Thread Forward Xu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854426#comment-16854426 ] Forward Xu commented on CALCITE-3005: - hi [~julianhyde] well ,Thank you very much,

[jira] [Commented] (CALCITE-3005) Implement string functions: LEFT, RIGHT

2019-06-03 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854306#comment-16854306 ] Julian Hyde commented on CALCITE-3005: -- I have made some changes; please review h

[jira] [Commented] (CALCITE-3005) Implement string functions: LEFT, RIGHT

2019-06-02 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854121#comment-16854121 ] Julian Hyde commented on CALCITE-3005: -- Reviewing revised PR now. > Implement str

[jira] [Commented] (CALCITE-3005) Implement string functions: LEFT, RIGHT

2019-06-02 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853914#comment-16853914 ] Julian Hyde commented on CALCITE-3005: -- * A lot of duplication: LEFT and RIGHT fun

[jira] [Commented] (CALCITE-3005) Implement string functions: LEFT, RIGHT

2019-06-02 Thread Forward Xu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853910#comment-16853910 ] Forward Xu commented on CALCITE-3005: - hi [~Chunwei Lei] [~julianhyde] Thank you ve

[jira] [Commented] (CALCITE-3005) Implement string functions: LEFT, RIGHT

2019-05-30 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851594#comment-16851594 ] Chunwei Lei commented on CALCITE-3005: -- [~x1q1j1], you can reference how it deal w

[jira] [Commented] (CALCITE-3005) Implement string functions: LEFT, RIGHT

2019-05-23 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847175#comment-16847175 ] Julian Hyde commented on CALCITE-3005: -- This is not a surprise, because {{LEFT}} i

[jira] [Commented] (CALCITE-3005) Implement string functions: LEFT, RIGHT

2019-05-23 Thread Forward Xu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847166#comment-16847166 ] Forward Xu commented on CALCITE-3005: - hi @julianhyde @chunweilei @pengzhiwei2018 T

[jira] [Commented] (CALCITE-3005) Implement string functions: LEFT, RIGHT

2019-05-21 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845093#comment-16845093 ] Julian Hyde commented on CALCITE-3005: -- FWIW, the functions are not in Oracle. {{s

[jira] [Commented] (CALCITE-3005) Implement string functions: LEFT, RIGHT

2019-05-13 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838925#comment-16838925 ] Julian Hyde commented on CALCITE-3005: -- It seems they are in the JDBC spec. See ap

[jira] [Commented] (CALCITE-3005) Implement string functions: LEFT, RIGHT

2019-04-28 Thread Forward Xu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16828876#comment-16828876 ] Forward Xu commented on CALCITE-3005: - hi [~julianhyde] [~Chunwei Lei] This LEFT an

[jira] [Commented] (CALCITE-3005) Implement string functions: LEFT, RIGHT

2019-04-17 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16819897#comment-16819897 ] Julian Hyde commented on CALCITE-3005: -- When proposing functions, please state whi

[jira] [Commented] (CALCITE-3005) Implement string functions: LEFT, RIGHT

2019-04-16 Thread Forward Xu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16819650#comment-16819650 ] Forward Xu commented on CALCITE-3005: - well, I find this discussion very meaningful

[jira] [Commented] (CALCITE-3005) Implement string functions: LEFT, RIGHT

2019-04-16 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16819151#comment-16819151 ] Chunwei Lei commented on CALCITE-3005: --  Since it may face some issue as [ CALCIT