[jira] [Commented] (CALCITE-3167) Remove overriding equals and hashCode methods in EnumerableTableScan

2019-08-20 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911878#comment-16911878 ] jin xing commented on CALCITE-3167: --- Fixed in

[jira] [Commented] (CALCITE-3167) Remove overriding equals and hashCode methods in EnumerableTableScan

2019-08-20 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911877#comment-16911877 ] jin xing commented on CALCITE-3167: --- [~julianhyde] Thanks a lot for merging ! > Remove overriding

[jira] [Commented] (CALCITE-3167) Remove overriding equals and hashCode methods in EnumerableTableScan

2019-08-15 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908527#comment-16908527 ] Julian Hyde commented on CALCITE-3167: -- Reviewing and testing now; will commit shortly. > Remove

[jira] [Commented] (CALCITE-3167) Remove overriding equals and hashCode methods in EnumerableTableScan

2019-08-14 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906923#comment-16906923 ] jin xing commented on CALCITE-3167: --- [~julianhyde] Thanks a lot for approve. I updated the patch

[jira] [Commented] (CALCITE-3167) Remove overriding equals and hashCode methods in EnumerableTableScan

2019-08-13 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906838#comment-16906838 ] Julian Hyde commented on CALCITE-3167: -- I would add \{\@inheritDoc\} to the two methods, but

[jira] [Commented] (CALCITE-3167) Remove overriding equals and hashCode methods in EnumerableTableScan

2019-08-13 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906823#comment-16906823 ] jin xing commented on CALCITE-3167: --- [~julianhyde] Gentle ping ~ In current change, I made

[jira] [Commented] (CALCITE-3167) Remove overriding equals and hashCode methods in EnumerableTableScan

2019-07-19 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1611#comment-1611 ] jin xing commented on CALCITE-3167: --- [~amargoor] Gentle ping ~ ideas on this ? > Remove overriding

[jira] [Commented] (CALCITE-3167) Remove overriding equals and hashCode methods in EnumerableTableScan

2019-07-04 Thread Amogh Margoor (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878659#comment-16878659 ] Amogh Margoor commented on CALCITE-3167: Sure, I was travelling. Will take a look as soon as I

[jira] [Commented] (CALCITE-3167) Remove overriding equals and hashCode methods in EnumerableTableScan

2019-07-03 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878284#comment-16878284 ] jin xing commented on CALCITE-3167: --- [~amargoor]  Gentle ping~ It's great if you can share some

[jira] [Commented] (CALCITE-3167) Remove overriding equals and hashCode methods in EnumerableTableScan

2019-07-03 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878107#comment-16878107 ] Julian Hyde commented on CALCITE-3167: -- I disagree with your point 2. For some purposes, you might

[jira] [Commented] (CALCITE-3167) Remove overriding equals and hashCode methods in EnumerableTableScan

2019-07-03 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877833#comment-16877833 ] jin xing commented on CALCITE-3167: --- Thanks a lot for reply [~julianhyde] # I also think it's a good

[jira] [Commented] (CALCITE-3167) Remove overriding equals and hashCode methods in EnumerableTableScan

2019-07-02 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877237#comment-16877237 ] Julian Hyde commented on CALCITE-3167: -- I tend to agree that sub-classes of {{RelNode}} should not