[jira] [Commented] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2020-06-25 Thread Stamatis Zampetakis (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145846#comment-17145846 ] Stamatis Zampetakis commented on CALCITE-3224: -- I went over the design doc

[jira] [Commented] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2020-06-25 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145699#comment-17145699 ] Julian Hyde commented on CALCITE-3224: -- Wow, this PR fixes (and has test cases for

[jira] [Commented] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2020-06-25 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145084#comment-17145084 ] Julian Hyde commented on CALCITE-3224: -- I am dusting this one off, because it bloc

[jira] [Commented] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2020-02-20 Thread Stamatis Zampetakis (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17040847#comment-17040847 ] Stamatis Zampetakis commented on CALCITE-3224: -- I was supposed to look but

[jira] [Commented] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2020-02-19 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17040658#comment-17040658 ] Feng Zhu commented on CALCITE-3224: --- The codegen component is not intuitive, and it s

[jira] [Commented] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2020-02-19 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17040647#comment-17040647 ] Danny Chen commented on CALCITE-3224: - Is this issue going to be resolved in releas

[jira] [Commented] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2020-02-12 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035312#comment-17035312 ] Danny Chen commented on CALCITE-3224: - Thanks for the reminder [~zabetak], that is

[jira] [Commented] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2020-02-12 Thread Stamatis Zampetakis (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035212#comment-17035212 ] Stamatis Zampetakis commented on CALCITE-3224: -- The problem of the 64KB is

[jira] [Commented] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2020-02-11 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035027#comment-17035027 ] Feng Zhu commented on CALCITE-3224: --- This patch does not cover the 64kb problem. But

[jira] [Commented] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2020-02-11 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035023#comment-17035023 ] Danny Chen commented on CALCITE-3224: - Can this patch solve the problem for generat

[jira] [Commented] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2019-12-08 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16991128#comment-16991128 ] Feng Zhu commented on CALCITE-3224: --- Hi, [~zabetak], thanks for your review. Let me a

[jira] [Commented] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2019-12-06 Thread Stamatis Zampetakis (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989915#comment-16989915 ] Stamatis Zampetakis commented on CALCITE-3224: -- Hey [~donnyzone], thanks a

[jira] [Commented] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2019-11-06 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968325#comment-16968325 ] Feng Zhu commented on CALCITE-3224: --- I post a detailed design & implementation doc fo

[jira] [Commented] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2019-09-19 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16934044#comment-16934044 ] Feng Zhu commented on CALCITE-3224: --- [~jinxing6...@126.com]Yeah, it is used to mark w

[jira] [Commented] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2019-09-19 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1691#comment-1691 ] jin xing commented on CALCITE-3224: --- When you san – – "For each RexNode, the visitor

[jira] [Commented] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2019-08-04 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899597#comment-16899597 ] Feng Zhu commented on CALCITE-3224: --- Hi, [~zabetak], [~julianhyde] Really thanks for

[jira] [Commented] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2019-08-02 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899138#comment-16899138 ] Julian Hyde commented on CALCITE-3224: -- It's useful to split code into separate co

[jira] [Commented] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2019-08-02 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898872#comment-16898872 ] Feng Zhu commented on CALCITE-3224: --- Hi, [~zabetak]. Thanks for your clarification.

[jira] [Commented] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2019-08-01 Thread Stamatis Zampetakis (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897897#comment-16897897 ] Stamatis Zampetakis commented on CALCITE-3224: -- Let me just clarify that I

[jira] [Commented] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2019-08-01 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897886#comment-16897886 ] Feng Zhu commented on CALCITE-3224: --- Yes, [~zabetak], I agree with you. It brings hea

[jira] [Commented] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2019-08-01 Thread Stamatis Zampetakis (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897856#comment-16897856 ] Stamatis Zampetakis commented on CALCITE-3224: -- Hey [~donnyzone] thanks a