[
https://issues.apache.org/jira/browse/CALCITE-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912194#comment-16912194
]
Wang Yanlin commented on CALCITE-3260:
--
Yes, that's better. I will update the PR.
> Add support
[
https://issues.apache.org/jira/browse/CALCITE-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911605#comment-16911605
]
Julian Hyde commented on CALCITE-3260:
--
Instead, in {{Expressions}}, add a method {{public static
[
https://issues.apache.org/jira/browse/CALCITE-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911351#comment-16911351
]
Wang Yanlin commented on CALCITE-3260:
--
Well, then can we make class *Evaluator* public, so that,
[
https://issues.apache.org/jira/browse/CALCITE-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910714#comment-16910714
]
Julian Hyde commented on CALCITE-3260:
--
The evaluate method could use some javadoc, though.
> Add
[
https://issues.apache.org/jira/browse/CALCITE-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910706#comment-16910706
]
Julian Hyde commented on CALCITE-3260:
--
-1 The existing code is concise enough. With the new
