[jira] [Commented] (CALCITE-3263) Add MD5, SHA1 SQL functions

2019-08-21 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912725#comment-16912725 ] Julian Hyde commented on CALCITE-3263: -- Reviewing now. > Add MD5, SHA1 SQL functions >

[jira] [Commented] (CALCITE-3263) Add MD5, SHA1 SQL functions

2019-08-19 Thread ShuMing Li (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910942#comment-16910942 ] ShuMing Li commented on CALCITE-3263: - Thanks for [~julianhyde]'s replies. I will add a review of

[jira] [Commented] (CALCITE-3263) Add MD5, SHA1 SQL functions

2019-08-19 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910662#comment-16910662 ] Julian Hyde commented on CALCITE-3263: -- Please rename the test methods from "testMD5" to