[ https://issues.apache.org/jira/browse/CALCITE-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915492#comment-16915492 ]
jin xing commented on CALCITE-3292: ----------------------------------- If I understand correctly, there's no need to do subquery-substitution for *{{SqlUpdate#condition,}}* {{the subquery-substitution is done when converting}} *{{SqlUpdate#}}sourceSelect* > SqlToRelConverter#substituteSubQuery fails with NullPointerException when > converting SqlUpdate. > ----------------------------------------------------------------------------------------------- > > Key: CALCITE-3292 > URL: https://issues.apache.org/jira/browse/CALCITE-3292 > Project: Calcite > Issue Type: Bug > Components: core > Reporter: jin xing > Assignee: jin xing > Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Current code fails below test > {code:java} > // code placeholder > @Test public void testUpdateSubQueryWithIn1() { > final String sql = "update emp\n" > + "set empno = 1 where emp.empno in (\n" > + " select emp.empno from emp where emp.empno=2)"; > sql(sql).ok(); > } > java.lang.NullPointerExceptionjava.lang.NullPointerException at > org.apache.calcite.rel.logical.LogicalJoin.create(LogicalJoin.java:146) at > org.apache.calcite.rel.logical.LogicalJoin.create(LogicalJoin.java:163) at > org.apache.calcite.sql2rel.SqlToRelConverter.substituteSubQuery(SqlToRelConverter.java:1130) > at > org.apache.calcite.sql2rel.SqlToRelConverter.replaceSubQueries(SqlToRelConverter.java:1014) > at > org.apache.calcite.sql2rel.SqlToRelConverter.convertUpdate(SqlToRelConverter.java:3574) > at > org.apache.calcite.sql2rel.SqlToRelConverter.convertQueryRecursive(SqlToRelConverter.java:3176) > at > org.apache.calcite.sql2rel.SqlToRelConverter.convertQuery(SqlToRelConverter.java:563) > at > org.apache.calcite.test.SqlToRelTestBase$TesterImpl.convertSqlToRel(SqlToRelTestBase.java:616) > at > org.apache.calcite.test.SqlToRelTestBase$TesterImpl.assertConvertsTo(SqlToRelTestBase.java:731) > at > org.apache.calcite.test.SqlToRelConverterTest$Sql.convertsTo(SqlToRelConverterTest.java:3601) > at > org.apache.calcite.test.SqlToRelConverterTest$Sql.ok(SqlToRelConverterTest.java:3593) > {code} > In above case, *Subquery* is used as *{{SqlUpdate#condition}}*, when > converting and trying to replace the subquery in *{{SqlUpdate#condition}}*, > *{{BalckBoard#root}}* is *{{null}}* and it makes no sense to do the subquery > substitution. > -- This message was sent by Atlassian Jira (v8.3.2#803003)