[
https://issues.apache.org/jira/browse/CALCITE-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955692#comment-16955692
]
Danny Chen commented on CALCITE-3414:
-
Reviewing now ~
> Unify Expression'type cast and conversion
[
https://issues.apache.org/jira/browse/CALCITE-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952645#comment-16952645
]
Feng Zhu commented on CALCITE-3414:
---
(1)According to the figures posted above, there are 19
[
https://issues.apache.org/jira/browse/CALCITE-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952595#comment-16952595
]
Danny Chen commented on CALCITE-3414:
-
For (1) i think we can make a fix, for (2) could we make
[
https://issues.apache.org/jira/browse/CALCITE-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952491#comment-16952491
]
Feng Zhu commented on CALCITE-3414:
---
[~danny0405], there are two reasons:
(1)some implementation in
[
https://issues.apache.org/jira/browse/CALCITE-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952480#comment-16952480
]
Danny Chen commented on CALCITE-3414:
-
Thanks Julian for clarifying the strategy, then i think keep
[
https://issues.apache.org/jira/browse/CALCITE-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952470#comment-16952470
]
Feng Zhu commented on CALCITE-3414:
---
Hi, [~julianhyde] , thanks for your clarification on the role of
[
https://issues.apache.org/jira/browse/CALCITE-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952468#comment-16952468
]
Feng Zhu commented on CALCITE-3414:
---
Hi, [~danny0405], we find both of them have limitations. If we
[
https://issues.apache.org/jira/browse/CALCITE-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952170#comment-16952170
]
Julian Hyde commented on CALCITE-3414:
--
I haven't looked at the PR, but let me state the strategy.
[
https://issues.apache.org/jira/browse/CALCITE-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951893#comment-16951893
]
Danny Chen commented on CALCITE-3414:
-
I'm inclined to move the Types#castIfNecessary into Calcite