[
https://issues.apache.org/jira/browse/CALCITE-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407258#comment-17407258
]
Xurenhe commented on CALCITE-3935:
--
Please review this pr:
[
https://issues.apache.org/jira/browse/CALCITE-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134120#comment-17134120
]
Jin Xing commented on CALCITE-3935:
---
Refine the Jira title and give some basic analysis in the
[
https://issues.apache.org/jira/browse/CALCITE-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129254#comment-17129254
]
Xurenhe commented on CALCITE-3935:
--
[~jinxing6...@126.com][~xzh_dz]
Please review this pr:
[
https://issues.apache.org/jira/browse/CALCITE-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085707#comment-17085707
]
Jin Xing commented on CALCITE-3935:
---
Thanks !
I really appreciate your fix ~ I can take a review
[
https://issues.apache.org/jira/browse/CALCITE-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085706#comment-17085706
]
Xurenhe commented on CALCITE-3935:
--
Yes, I think it need to mitigate requirements.
I am making PR for
[
https://issues.apache.org/jira/browse/CALCITE-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085701#comment-17085701
]
Jin Xing commented on CALCITE-3935:
---
Seems the check in [1] is too strict, we should allow