[
https://issues.apache.org/jira/browse/CALCITE-3247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Danny Chan resolved CALCITE-3247.
---------------------------------
Fix Version/s: 1.22.0
Assignee: Danny Chan
Resolution: Fixed
Fixed in
[a7a566b|https://github.com/apache/calcite/commit/a7a566bb004fd73ee6402652f5572ad0012a97c9],
thanks for your PR, [~jackyWoo] !
> In JDBC adapter, when generating SQL for Hive, transform SUBSTRING function
> to correct format
> ---------------------------------------------------------------------------------------------
>
> Key: CALCITE-3247
> URL: https://issues.apache.org/jira/browse/CALCITE-3247
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.19.0
> Reporter: Jacky Woo
> Assignee: Danny Chan
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.22.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Let's assume sql = SELECT SUBSTRING('ABC', 2)
> When we use HiveSqlDialect and transform "sql", we expect SUBSTRING(' abc',
> 2)，but get SUBSTRING(' abc' FROM 2) which is incorrect sql format in hive.
> So maybe HiveSqlDialect behavior should be changed when transform function
> SUBSTRING:
> # {{SELECT SUBSTRING('ABC', 2) => SELECT SUBSTRING('ABC', 2)}}
> # {{SELECT SUBSTRING('ABC', 2, 3) => SELECT SUBSTRING('ABC', 2, 3) }}
> # {{SELECT SUBSTRING('ABC' FROM 2) => SELECT SUBSTRING('ABC', 2) }}
> # {{SELECT SUBSTRING('ABC' FROM 2 FOR 3) => SELECT SUBSTRING('ABC', 2, 3) }}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
