[ 
https://issues.apache.org/jira/browse/CALCITE-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Hyde updated CALCITE-1024:
---------------------------------
    Summary: In a planner test, if a rule should have no effect, state that 
explicitly  (was: When writing planner tests, be explicit that rule has no 
effect)

> In a planner test, if a rule should have no effect, state that explicitly
> -------------------------------------------------------------------------
>
>                 Key: CALCITE-1024
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1024
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Julian Hyde
>            Assignee: Julian Hyde
>
> Add method {{RelOptRulesTestBase.checkPlanUnchanged}} method, and also add a 
> {{boolean unchanged}} parameter to the underlying {{checkPlanning}} method. 
> If a planner test is supposed to have no effect, that is, if the before and 
> after plans are the same, then you must specify that flag.
> This makes it easier to notice if a rule that is supposed to work has stopped 
> working. It also removes redundant plans from the reference file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to