[ 
https://issues.apache.org/jira/browse/CAMEL-12222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen resolved CAMEL-12222.
---------------------------------
       Resolution: Fixed
         Assignee: Claus Ibsen
    Fix Version/s: 2.21.0
                   2.20.3
                   2.19.5

Thanks for the PR.

I fixed the checkstyle issue

http://camel.apache.org/building.html

> ResrSwaggerServlet removes last part of context root
> ----------------------------------------------------
>
>                 Key: CAMEL-12222
>                 URL: https://issues.apache.org/jira/browse/CAMEL-12222
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-swagger
>            Reporter: Darius Cooper
>            Assignee: Claus Ibsen
>            Priority: Minor
>             Fix For: 2.19.5, 2.20.3, 2.21.0
>
>
> The method within RestSwaggerServlet, looks for the last "/" in the context 
> root, and drops anything after that slash.
> {code:java}
> private String translateContextPath(HttpServletRequest request) {
>   String path = request.getContextPath();
>   if (path.isEmpty() || path.equals("/")) {
>       return "";
>   } else {
>      int idx = path.lastIndexOf("/");
>      if (idx > 0) {
>          return path.substring(0, idx);
>      }
>   }
>   return path;
> }{code}
> Even though this has been deprecated, it would be good to fix it. 
> An approach could be to add a servlet init parameter named 
> "translateContextPath" which would default to true, and would work exactly as 
> it does today by default. if set to false, it would return whatever value is 
> in request.getContextPath() , with no translation.
> Also, to avoid the NPE thrown, pass in an empty RestConfiguration to 
> RestSwaggerSupport.renderResourceListing() 
> (See: https://issues.apache.org/jira/browse/CAMEL-12038) 
> I plan on working on this. Creating a Jira to get feedback on the approach



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to