[jira] [Commented] (CAMEL-11715) Camel Spring : unable to mix xml and java routes
[ https://issues.apache.org/jira/browse/CAMEL-11715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151931#comment-16151931 ] Zoran Regvart commented on CAMEL-11715: --- I have a test/fix but I want to run the full tests to see if anything has been broken by the fix, I'll update in a bit. > Camel Spring : unable to mix xml and java routes > > > Key: CAMEL-11715 > URL: https://issues.apache.org/jira/browse/CAMEL-11715 > Project: Camel > Issue Type: Bug > Components: camel-spring, camel-spring-boot >Reporter: Luca Burgazzoli >Assignee: Zoran Regvart > Fix For: 2.20.0 > > > I camel 2.19 it was possible to mix routes from Spring XML and Spring boot > but that does not work anymore with camel 2.20.x. > A sample project can be found here: > https://github.com/lburgazzoli/camel-spring-xml so if you switch camel > version, you'd see that the java route is not more loaded. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (CAMEL-11744) Allow update of OwnerId field
[ https://issues.apache.org/jira/browse/CAMEL-11744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoran Regvart resolved CAMEL-11744. --- Resolution: Fixed Run all the integration tests no issues found. > Allow update of OwnerId field > - > > Key: CAMEL-11744 > URL: https://issues.apache.org/jira/browse/CAMEL-11744 > Project: Camel > Issue Type: Improvement > Components: camel-salesforce >Reporter: Zoran Regvart >Assignee: Zoran Regvart >Priority: Minor > Fix For: 2.20.0 > > > From [pull request #1869|https://github.com/apache/camel/pull/1869], allow > OwnerId field to be modified in update and upsert operations. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (CAMEL-11744) Allow update of OwnerId field
Zoran Regvart created CAMEL-11744: - Summary: Allow update of OwnerId field Key: CAMEL-11744 URL: https://issues.apache.org/jira/browse/CAMEL-11744 Project: Camel Issue Type: Improvement Components: camel-salesforce Reporter: Zoran Regvart Assignee: Zoran Regvart Priority: Minor Fix For: 2.20.0 >From [pull request #1869|https://github.com/apache/camel/pull/1869], allow >OwnerId field to be modified in update and upsert operations. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (CAMEL-11718) Setting camel.dataformat.json-jackson.object-mapper throws exception
[
https://issues.apache.org/jira/browse/CAMEL-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151824#comment-16151824
]
Roman edited comment on CAMEL-11718 at 9/3/17 2:29 PM:
---
Hi [~davsclaus]
Oh yes, I know the bean needs to be defined in Spring. `jacksonObjectMapper` is
the default bean name provided by Spring Boot auto configuration you can [see
it
here|https://github.com/spring-projects/spring-boot/blob/11edff7576085964191f4fea7593dd47eebeec76/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jackson/JacksonAutoConfiguration.java#L91].
While debugging, I've tried to look up the bean from the camel context and it
is definitely there. I've also tried defining my own ObjectMapper bean and use
its name, but it doesn't work. The IntrospectionSupport#setProperty method that
is called by the auto-generated JacksonDataFormatAutoConfiguration is not the
one that supports refs.
was (Author: strelok1):
Hi [~davsclaus]
Oh yes, I know the bean needs to be defined in Spring. `jacksonObjectMapper` is
the default bean name provided by Spring Boot auto configuration you can [see
it
here|https://github.com/spring-projects/spring-boot/blob/11edff7576085964191f4fea7593dd47eebeec76/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jackson/JacksonAutoConfiguration.java#L91].
While debugging, I've tried to look up the bean from the camel context and it
is definitely there. I've also tried defining my own ObjectMapper bean and use
its name, but it doesn't work. The IntrospectionSupport#setProperty method that
is called by the auto-generated JacksonDataFormatConfiguration is not the one
that supports refs.
> Setting camel.dataformat.json-jackson.object-mapper throws exception
>
>
> Key: CAMEL-11718
> URL: https://issues.apache.org/jira/browse/CAMEL-11718
> Project: Camel
> Issue Type: Improvement
> Components: camel-jackson
>Affects Versions: 2.19.2
>Reporter: Roman
>
> I wanted to reuse the Jackson object mapper used by Spring MVC but jackson
> json configuration via YML is not working an causing an exception
> {code:none}
> camel:
> springboot:
> name: ${spring.application.name}
> dataformat:
> json-jackson:
> object-mapper: jacksonObjectMapper
> spring:
> jackson:
> property-naming-strategy:
> com.fasterxml.jackson.databind.PropertyNamingStrategy.SnakeCaseStrategy
> default-property-inclusion: non_null
> serialization:
> WRITE_DATES_AS_TIMESTAMPS: true
> {code}
> Throws the following exception:
> {noformat}
> org.apache.camel.spring.boot.CamelSpringBootInitializationException:
> org.apache.camel.FailedToCreateRouteException: Failed to create route
> test-public: Route(test-public)[[From[rest:get:/test?routeId=test-public&...
> because of java.lang.IllegalArgumentException: Could not find a suitable
> setter for property: objectMapper as there isn't a setter method with same
> type: java.lang.String nor type conversion possible: No type converter
> available to convert from type: java.lang.String to the required type:
> com.fasterxml.jackson.databind.ObjectMapper with value jacksonObjectMapper
> at
> org.apache.camel.spring.boot.RoutesCollector.onApplicationEvent(RoutesCollector.java:225)
> at
> org.apache.camel.spring.boot.RoutesCollector.onApplicationEvent(RoutesCollector.java:52)
> at
> org.springframework.context.event.SimpleApplicationEventMulticaster.invokeListener(SimpleApplicationEventMulticaster.java:167)
> at
> org.springframework.context.event.SimpleApplicationEventMulticaster.multicastEvent(SimpleApplicationEventMulticaster.java:139)
> at
> org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:393)
> at
> org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:347)
> at
> org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:883)
> at
> org.springframework.boot.context.embedded.EmbeddedWebApplicationContext.finishRefresh(EmbeddedWebApplicationContext.java:144)
> at
> org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:546)
> at
> org.springframework.boot.context.embedded.EmbeddedWebApplicationContext.refresh(EmbeddedWebApplicationContext.java:122)
> at
> org.springframework.boot.SpringApplication.refresh(SpringApplication.java:693)
> at
> org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:360)
> at
> org.springframework.boot.SpringApplication.run(SpringApplication.java:303)
> at
>
[jira] [Comment Edited] (CAMEL-11718) Setting camel.dataformat.json-jackson.object-mapper throws exception
[
https://issues.apache.org/jira/browse/CAMEL-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151824#comment-16151824
]
Roman edited comment on CAMEL-11718 at 9/3/17 2:28 PM:
---
Hi [~davsclaus]
Oh yes, I know the bean needs to be defined in Spring. `jacksonObjectMapper` is
the default bean name provided by Spring Boot auto configuration you can [see
it
here|https://github.com/spring-projects/spring-boot/blob/11edff7576085964191f4fea7593dd47eebeec76/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jackson/JacksonAutoConfiguration.java#L91].
While debugging, I've tried to look up the bean from the camel context and it
is definitely there. I've also tried defining my own ObjectMapper bean and use
its name, but it doesn't work. The IntrospectionSupport#setProperty method that
is called by the auto-generated JacksonDataFormatConfiguration is not the one
that supports refs.
was (Author: strelok1):
Hi [~davsclaus]
Oh yes, I know the bean needs to be defined in Spring. `jacksonObjectMapper` is
the default bean name provided by Spring Boot auto configuration you can [see
it
here|https://github.com/spring-projects/spring-boot/blob/11edff7576085964191f4fea7593dd47eebeec76/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jackson/JacksonAutoConfiguration.java#L91].
While debugging, I've tried to look up the bean from the camel context and it
is definitely there. I've also tried defining my own ObjectMapper bean and use
its name, but it doesn't work.
> Setting camel.dataformat.json-jackson.object-mapper throws exception
>
>
> Key: CAMEL-11718
> URL: https://issues.apache.org/jira/browse/CAMEL-11718
> Project: Camel
> Issue Type: Improvement
> Components: camel-jackson
>Affects Versions: 2.19.2
>Reporter: Roman
>
> I wanted to reuse the Jackson object mapper used by Spring MVC but jackson
> json configuration via YML is not working an causing an exception
> {code:none}
> camel:
> springboot:
> name: ${spring.application.name}
> dataformat:
> json-jackson:
> object-mapper: jacksonObjectMapper
> spring:
> jackson:
> property-naming-strategy:
> com.fasterxml.jackson.databind.PropertyNamingStrategy.SnakeCaseStrategy
> default-property-inclusion: non_null
> serialization:
> WRITE_DATES_AS_TIMESTAMPS: true
> {code}
> Throws the following exception:
> {noformat}
> org.apache.camel.spring.boot.CamelSpringBootInitializationException:
> org.apache.camel.FailedToCreateRouteException: Failed to create route
> test-public: Route(test-public)[[From[rest:get:/test?routeId=test-public&...
> because of java.lang.IllegalArgumentException: Could not find a suitable
> setter for property: objectMapper as there isn't a setter method with same
> type: java.lang.String nor type conversion possible: No type converter
> available to convert from type: java.lang.String to the required type:
> com.fasterxml.jackson.databind.ObjectMapper with value jacksonObjectMapper
> at
> org.apache.camel.spring.boot.RoutesCollector.onApplicationEvent(RoutesCollector.java:225)
> at
> org.apache.camel.spring.boot.RoutesCollector.onApplicationEvent(RoutesCollector.java:52)
> at
> org.springframework.context.event.SimpleApplicationEventMulticaster.invokeListener(SimpleApplicationEventMulticaster.java:167)
> at
> org.springframework.context.event.SimpleApplicationEventMulticaster.multicastEvent(SimpleApplicationEventMulticaster.java:139)
> at
> org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:393)
> at
> org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:347)
> at
> org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:883)
> at
> org.springframework.boot.context.embedded.EmbeddedWebApplicationContext.finishRefresh(EmbeddedWebApplicationContext.java:144)
> at
> org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:546)
> at
> org.springframework.boot.context.embedded.EmbeddedWebApplicationContext.refresh(EmbeddedWebApplicationContext.java:122)
> at
> org.springframework.boot.SpringApplication.refresh(SpringApplication.java:693)
> at
> org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:360)
> at
> org.springframework.boot.SpringApplication.run(SpringApplication.java:303)
> at
> org.springframework.boot.SpringApplication.run(SpringApplication.java:1118)
> at
> org.springframework.boot.SpringApplication.run(SpringApplication.java:1107)
> at
>
[jira] [Resolved] (CAMEL-11743) camel-ldap - Make it possible to use ENV when configuring DirContext
[ https://issues.apache.org/jira/browse/CAMEL-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen resolved CAMEL-11743. - Resolution: Fixed Fix Version/s: 2.19.3 > camel-ldap - Make it possible to use ENV when configuring DirContext > > > Key: CAMEL-11743 > URL: https://issues.apache.org/jira/browse/CAMEL-11743 > Project: Camel > Issue Type: Improvement > Components: camel-ldap >Reporter: Claus Ibsen >Assignee: Claus Ibsen > Fix For: 2.20.0, 2.19.3 > > > Reported on the mailing list. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (CAMEL-11742) File consumer - Delete orphan lock files on startup may not match a lock file when using include/antInclude filtering
[ https://issues.apache.org/jira/browse/CAMEL-11742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen resolved CAMEL-11742. - Resolution: Fixed Fix Version/s: 2.19.3 > File consumer - Delete orphan lock files on startup may not match a lock file > when using include/antInclude filtering > - > > Key: CAMEL-11742 > URL: https://issues.apache.org/jira/browse/CAMEL-11742 > Project: Camel > Issue Type: Bug > Components: camel-core >Reporter: Claus Ibsen >Assignee: Claus Ibsen >Priority: Minor > Fix For: 2.20.0, 2.19.3 > > > See CAMEL-8970 and reported on mailing list -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11718) Setting camel.dataformat.json-jackson.object-mapper throws exception
[
https://issues.apache.org/jira/browse/CAMEL-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151824#comment-16151824
]
Roman commented on CAMEL-11718:
---
Hi [~davsclaus]
Oh yes, I know the bean needs to be defined in Spring. `jacksonObjectMapper` is
the default bean name provided by Spring Boot auto configuration you can [see
it
here|https://github.com/spring-projects/spring-boot/blob/11edff7576085964191f4fea7593dd47eebeec76/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jackson/JacksonAutoConfiguration.java#L91].
While debugging, I've tried to look up the bean from the camel context and it
is definitely there. I've also tried defining my own ObjectMapper bean and use
its name, but it doesn't work.
> Setting camel.dataformat.json-jackson.object-mapper throws exception
>
>
> Key: CAMEL-11718
> URL: https://issues.apache.org/jira/browse/CAMEL-11718
> Project: Camel
> Issue Type: Improvement
> Components: camel-jackson
>Affects Versions: 2.19.2
>Reporter: Roman
>
> I wanted to reuse the Jackson object mapper used by Spring MVC but jackson
> json configuration via YML is not working an causing an exception
> {code:none}
> camel:
> springboot:
> name: ${spring.application.name}
> dataformat:
> json-jackson:
> object-mapper: jacksonObjectMapper
> spring:
> jackson:
> property-naming-strategy:
> com.fasterxml.jackson.databind.PropertyNamingStrategy.SnakeCaseStrategy
> default-property-inclusion: non_null
> serialization:
> WRITE_DATES_AS_TIMESTAMPS: true
> {code}
> Throws the following exception:
> {noformat}
> org.apache.camel.spring.boot.CamelSpringBootInitializationException:
> org.apache.camel.FailedToCreateRouteException: Failed to create route
> test-public: Route(test-public)[[From[rest:get:/test?routeId=test-public&...
> because of java.lang.IllegalArgumentException: Could not find a suitable
> setter for property: objectMapper as there isn't a setter method with same
> type: java.lang.String nor type conversion possible: No type converter
> available to convert from type: java.lang.String to the required type:
> com.fasterxml.jackson.databind.ObjectMapper with value jacksonObjectMapper
> at
> org.apache.camel.spring.boot.RoutesCollector.onApplicationEvent(RoutesCollector.java:225)
> at
> org.apache.camel.spring.boot.RoutesCollector.onApplicationEvent(RoutesCollector.java:52)
> at
> org.springframework.context.event.SimpleApplicationEventMulticaster.invokeListener(SimpleApplicationEventMulticaster.java:167)
> at
> org.springframework.context.event.SimpleApplicationEventMulticaster.multicastEvent(SimpleApplicationEventMulticaster.java:139)
> at
> org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:393)
> at
> org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:347)
> at
> org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:883)
> at
> org.springframework.boot.context.embedded.EmbeddedWebApplicationContext.finishRefresh(EmbeddedWebApplicationContext.java:144)
> at
> org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:546)
> at
> org.springframework.boot.context.embedded.EmbeddedWebApplicationContext.refresh(EmbeddedWebApplicationContext.java:122)
> at
> org.springframework.boot.SpringApplication.refresh(SpringApplication.java:693)
> at
> org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:360)
> at
> org.springframework.boot.SpringApplication.run(SpringApplication.java:303)
> at
> org.springframework.boot.SpringApplication.run(SpringApplication.java:1118)
> at
> org.springframework.boot.SpringApplication.run(SpringApplication.java:1107)
> at
> au.com.iag.payments.service.OnlinePaymentsApplicationKt.main(OnlinePaymentsApplication.kt:15)
> Caused by: org.apache.camel.FailedToCreateRouteException: Failed to create
> route test-public:
> Route(test-public)[[From[rest:get:/test?routeId=test-public&... because of
> java.lang.IllegalArgumentException: Could not find a suitable setter for
> property: objectMapper as there isn't a setter method with same type:
> java.lang.String nor type conversion possible: No type converter available to
> convert from type: java.lang.String to the required type:
> com.fasterxml.jackson.databind.ObjectMapper with value jacksonObjectMapper
> at
> org.apache.camel.model.RouteDefinition.addRoutes(RouteDefinition.java:209)
> at
> org.apache.camel.impl.DefaultCamelContext.startRoute(DefaultCamelContext.java:1087)
[jira] [Created] (CAMEL-11743) camel-ldap - Make it possible to use ENV when configuring DirContext
Claus Ibsen created CAMEL-11743: --- Summary: camel-ldap - Make it possible to use ENV when configuring DirContext Key: CAMEL-11743 URL: https://issues.apache.org/jira/browse/CAMEL-11743 Project: Camel Issue Type: Improvement Components: camel-ldap Reporter: Claus Ibsen Assignee: Claus Ibsen Fix For: 2.20.0 Reported on the mailing list. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (CAMEL-11742) File consumer - Delete orphan lock files on startup may not match a lock file when using include/antInclude filtering
[ https://issues.apache.org/jira/browse/CAMEL-11742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen updated CAMEL-11742: Summary: File consumer - Delete orphan lock files on startup may not match a lock file when using include/antInclude filtering (was: File consumer - Delete orphan files has a little issue) > File consumer - Delete orphan lock files on startup may not match a lock file > when using include/antInclude filtering > - > > Key: CAMEL-11742 > URL: https://issues.apache.org/jira/browse/CAMEL-11742 > Project: Camel > Issue Type: Bug > Components: camel-core >Reporter: Claus Ibsen >Assignee: Claus Ibsen >Priority: Minor > Fix For: 2.20.0 > > > See CAMEL-8970 and reported on mailing list -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (CAMEL-11742) File consumer - Delete orphan files has a little issue
Claus Ibsen created CAMEL-11742: --- Summary: File consumer - Delete orphan files has a little issue Key: CAMEL-11742 URL: https://issues.apache.org/jira/browse/CAMEL-11742 Project: Camel Issue Type: Bug Components: camel-core Reporter: Claus Ibsen Assignee: Claus Ibsen Priority: Minor Fix For: 2.20.0 See CAMEL-8970 and reported on mailing list -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11677) TypeConverterLoaderException: Cannot find any type converter classes from the following packages: com.abc.storage.service.converter if application is packaged using sp
[ https://issues.apache.org/jira/browse/CAMEL-11677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151756#comment-16151756 ] Claus Ibsen commented on CAMEL-11677: - Also in the TypeConverter file do NOT use package name only, add a line for each FQN class name of the type converter classes. This is how it should be done. > TypeConverterLoaderException: Cannot find any type converter classes from the > following packages: com.abc.storage.service.converter if application is > packaged using spring-boot-maven-plugin > - > > Key: CAMEL-11677 > URL: https://issues.apache.org/jira/browse/CAMEL-11677 > Project: Camel > Issue Type: Bug > Components: camel-core >Affects Versions: 2.19.1, 2.19.2 >Reporter: Uladzimir Shelhunou >Priority: Minor > Fix For: 2.19.3 > > > Hi, > I am trying to migrate my Camel + Spring application to Camel + Spring Boot. > But my application does not start because of TypeConverterLoaderException. > I tried to debug DefaultPackageScanClassResolver and saw that classes that > are loaded from the package that I specified in > META-INF/services/org/apache/camel/TypeConverter have prefix > "BOOT-INF/classes": > !https://1.downloader.disk.yandex.ru/preview/ccc9ed4bfc32100f001fcba19eae46a29fa9b8b6edae5da75d44b3408076b902/inf/C-QlJpWF-rBzNn3nJbejokmWGYL0VDNzQA3zBqIjk2tezYr3j1PUmAW-VdrJ_NpZqkfglGtj_3LNU3F6JHSXJg%3D%3D?uid=0=2017-08-18_17-30-45.png=inline==0_type=image%2Fpng=v2=XXL=0! > But then in "void doLoadImplementationsInJar(PackageScanFilter test, String > parent, List entries, Setclasses)" there is a condition: > > !https://1.downloader.disk.yandex.ru/preview/b6d67a981d7aea57e508daf15f2c50b212a3a34c6cc34df5efe640cf68334708/inf/C-QlJpWF-rBzNn3nJbejojGWqpbPH2SuVN-N57vCmXMNdvLr-BNHvK5QZTSRHzFp0qFDMsqZtqkVAMtlH9kyNA%3D%3D?uid=0=2017-08-18_17-37-37.png=inline==0_type=image%2Fpng=v2=XXL=0! > And because of "BOOT-INF/classes" nothing is added to classes set and > exception is thrown. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11708) spring boot code generation: the nested property processor does not handle object hierarchies
[
https://issues.apache.org/jira/browse/CAMEL-11708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151742#comment-16151742
]
Luca Burgazzoli commented on CAMEL-11708:
-
Every time we have a common configuration class to share i.e. we have a common
consul configuration class in the model package but we can't reuse it as when
we extend it, the code generation does not take it into account. So we need to
copy and paste classes and update them every time something in the base class
changes.
> spring boot code generation: the nested property processor does not handle
> object hierarchies
> -
>
> Key: CAMEL-11708
> URL: https://issues.apache.org/jira/browse/CAMEL-11708
> Project: Camel
> Issue Type: Bug
> Components: tooling
>Reporter: Luca Burgazzoli
> Fix For: 2.20.0
>
>
> Assuming you have complex configuration object that inherits from another
> configuration object, the spring boot code generation will creates the
> configuration properties object only for the properties of the last class so
> i.e. for a simple hierarchy like:
> {code}
> Common {
> String getX()
> void setX(String);
> }
> Specific extends Common {
> String getY()
> void setY(String);
> }
> {code}
> the generator will provides bindings only for
> {code}
> String getX()
> setX(String)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (CAMEL-11292) support for Scala 2.12.x
[ https://issues.apache.org/jira/browse/CAMEL-11292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen updated CAMEL-11292: Priority: Minor (was: Major) > support for Scala 2.12.x > > > Key: CAMEL-11292 > URL: https://issues.apache.org/jira/browse/CAMEL-11292 > Project: Camel > Issue Type: New Feature > Components: camel-scala >Affects Versions: 2.19.0 >Reporter: Sarunas Valaskevicius >Priority: Minor > > currently camel-scala depends on Scala 2.11. could this be upgraded to 2.12.x > release? > Same with scalatest. > All possible updates can be seen here - > https://mvnrepository.com/artifact/org.apache.camel/camel-scala/2.19.0 > Thanks -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11672) Input stream infinitive loop
[
https://issues.apache.org/jira/browse/CAMEL-11672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151741#comment-16151741
]
Claus Ibsen commented on CAMEL-11672:
-
Try with newer Camel version even so as 2.12.x is EOL.
> Input stream infinitive loop
>
>
> Key: CAMEL-11672
> URL: https://issues.apache.org/jira/browse/CAMEL-11672
> Project: Camel
> Issue Type: Bug
> Components: camel-http
>Affects Versions: 2.12.4
> Environment: IBM Websphere Liberty Core 17.0.0.1
> IBM Websphere Liberty Core 17.0.0.2
> Reproducible using both IBM JDK 8 and Oracle JDK 8
>Reporter: Zeljko Vukovic
>Priority: Minor
>
> Dear Camel team,
> While working on one integration we found issue related to camel-http
> component when solution is deployed on IBM Liberty core.
> Same issue is not reproducible on Jetty and Tomcat.
> Issue is connected to the code in IOHelper and
> CachedOutputStream$WrappedInputStream
> We are using version 2.12.4 but I can see that same code is used also in
> latest versions.
> https://github.com/apache/camel/blob/camel-2.12.4/camel-core/src/main/java/org/apache/camel/util/IOHelper.java
> Problematic part are lines 196, 198 and 204.
> Basically stream reader which is used
> org.apache.camel.converter.stream.CachedOutputStream$WrappedInputStream is
> not returning -1 like response of read method if empty string is provided on
> input.
> This is wrong by specification of InputReader interface.
>// in the case there is input which is empty string
>while ( -1 != n) {
> …
> int n = input.read(buffer); ---> this is never -1 if string is
> empty "" already 0 and we have infinitive loop !!!
> }
>
> For our use case we have applied change in IOHelper to check and directly
> cover if stream reader produce same (non-valid) response to not produce
> infinitive loop.
> If any questions around reproducing issue please let me know
> Best regards,
> Zeljko
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (CAMEL-11677) TypeConverterLoaderException: Cannot find any type converter classes from the following packages: com.abc.storage.service.converter if application is packaged using spr
[ https://issues.apache.org/jira/browse/CAMEL-11677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen resolved CAMEL-11677. - Resolution: Cannot Reproduce We have plenty of spring-boot examples that work fine with type converters. You must do something special. > TypeConverterLoaderException: Cannot find any type converter classes from the > following packages: com.abc.storage.service.converter if application is > packaged using spring-boot-maven-plugin > - > > Key: CAMEL-11677 > URL: https://issues.apache.org/jira/browse/CAMEL-11677 > Project: Camel > Issue Type: Bug > Components: camel-core >Affects Versions: 2.19.1, 2.19.2 >Reporter: Uladzimir Shelhunou >Priority: Minor > Fix For: 2.19.3 > > > Hi, > I am trying to migrate my Camel + Spring application to Camel + Spring Boot. > But my application does not start because of TypeConverterLoaderException. > I tried to debug DefaultPackageScanClassResolver and saw that classes that > are loaded from the package that I specified in > META-INF/services/org/apache/camel/TypeConverter have prefix > "BOOT-INF/classes": > !https://1.downloader.disk.yandex.ru/preview/ccc9ed4bfc32100f001fcba19eae46a29fa9b8b6edae5da75d44b3408076b902/inf/C-QlJpWF-rBzNn3nJbejokmWGYL0VDNzQA3zBqIjk2tezYr3j1PUmAW-VdrJ_NpZqkfglGtj_3LNU3F6JHSXJg%3D%3D?uid=0=2017-08-18_17-30-45.png=inline==0_type=image%2Fpng=v2=XXL=0! > But then in "void doLoadImplementationsInJar(PackageScanFilter test, String > parent, List entries, Setclasses)" there is a condition: > > !https://1.downloader.disk.yandex.ru/preview/b6d67a981d7aea57e508daf15f2c50b212a3a34c6cc34df5efe640cf68334708/inf/C-QlJpWF-rBzNn3nJbejojGWqpbPH2SuVN-N57vCmXMNdvLr-BNHvK5QZTSRHzFp0qFDMsqZtqkVAMtlH9kyNA%3D%3D?uid=0=2017-08-18_17-37-37.png=inline==0_type=image%2Fpng=v2=XXL=0! > And because of "BOOT-INF/classes" nothing is added to classes set and > exception is thrown. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (CAMEL-11691) Should resubscribe when reconnect MQTT
[ https://issues.apache.org/jira/browse/CAMEL-11691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen updated CAMEL-11691: Issue Type: Improvement (was: Bug) > Should resubscribe when reconnect MQTT > -- > > Key: CAMEL-11691 > URL: https://issues.apache.org/jira/browse/CAMEL-11691 > Project: Camel > Issue Type: Improvement > Components: camel-paho >Affects Versions: 2.19.2 >Reporter: abccbaandy > > There is a feature in MqttConnectOptions called setAutomaticReconnect > https://www.eclipse.org/paho/files/javadoc/org/eclipse/paho/client/mqttv3/MqttConnectOptions.html#setAutomaticReconnect-boolean- > But, when it reconnect, it doesn't resubscribe the topics. Paho provide a > callback : MqttCallbackExtended, it got called when connect completed. So we > can subscribe the topics again in that callback. > https://www.eclipse.org/paho/files/javadoc/org/eclipse/paho/client/mqttv3/MqttCallbackExtended.html > I check camel-paho source code, seems it use MqttCallback instead > MqttCallbackExtended. > Can anyone implement this feature? > Thanks -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11691) Should resubscribe when reconnect MQTT
[ https://issues.apache.org/jira/browse/CAMEL-11691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151739#comment-16151739 ] Claus Ibsen commented on CAMEL-11691: - Contributions is welcome > Should resubscribe when reconnect MQTT > -- > > Key: CAMEL-11691 > URL: https://issues.apache.org/jira/browse/CAMEL-11691 > Project: Camel > Issue Type: Bug > Components: camel-paho >Affects Versions: 2.19.2 >Reporter: abccbaandy > > There is a feature in MqttConnectOptions called setAutomaticReconnect > https://www.eclipse.org/paho/files/javadoc/org/eclipse/paho/client/mqttv3/MqttConnectOptions.html#setAutomaticReconnect-boolean- > But, when it reconnect, it doesn't resubscribe the topics. Paho provide a > callback : MqttCallbackExtended, it got called when connect completed. So we > can subscribe the topics again in that callback. > https://www.eclipse.org/paho/files/javadoc/org/eclipse/paho/client/mqttv3/MqttCallbackExtended.html > I check camel-paho source code, seems it use MqttCallback instead > MqttCallbackExtended. > Can anyone implement this feature? > Thanks -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (CAMEL-10086) Remove Pattern.compile usages
[ https://issues.apache.org/jira/browse/CAMEL-10086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen resolved CAMEL-10086. - Resolution: Fixed Assignee: Claus Ibsen Fix Version/s: (was: Future) 2.20.0 Ah yeah lets just close this > Remove Pattern.compile usages > - > > Key: CAMEL-10086 > URL: https://issues.apache.org/jira/browse/CAMEL-10086 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Mateusz Nowakowski >Assignee: Claus Ibsen >Priority: Minor > Fix For: 2.20.0 > > > Please heck Pattern.compile usage across Camel source code - also *not* > direct usage. > For example: > Whenever one of these methods are used from String class a Pattern.compile() > is utilized: > - matches > - replaceFirst > - replaceAll > - replace > - split: has an optimization and for certain characters it doesn’t use > Pattern.compile. > For example: > GenericFileConsumer.isMatched calls name.matches(endpoint.getExclude()) > GenericFileEndpoint could contain also excludePattern as well. > Possible solution: > Walk through the code and replace usages of these methods with static Pattern > variables. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (CAMEL-11683) Allow bean references in to() URI
[
https://issues.apache.org/jira/browse/CAMEL-11683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Claus Ibsen resolved CAMEL-11683.
-
Resolution: Not A Problem
> Allow bean references in to() URI
> -
>
> Key: CAMEL-11683
> URL: https://issues.apache.org/jira/browse/CAMEL-11683
> Project: Camel
> Issue Type: Improvement
> Components: camel-core
>Affects Versions: 2.19.1
>Reporter: Keegan Witt
>Assignee: Claus Ibsen
>
> As a workaround to CAMEL-11528, we tried replacing something like
> {code:java}
> from("direct:start")
> .wireTap("bean:tap")
> .to("mock:result");
> {code}
>
> with
> {code:java}
> from("direct:start")
> .wiretap("direct:tap")
> .to("mock:result");
> from("direct:tap")
> .process("bean:tapper");
> {code}
> We got
> {noformat}Caused by: org.apache.camel.FailedToCreateRouteException: Failed to
> create route route190 at: >>> process[ref:bean:tapper] <<< in route:
> Route(route190)[[From[direct:tap]] -> [OnException[[clas... because of No
> bean could be found in the registry for: bean:tapper of type:
> org.apache.camel.Processor{noformat}
> But if we did
> {code:java}
> public class MyRoute extends RouteBuilder {
> @Resource Tapper tapper;
> public void configure() throws Exception {
> from("direct:start")
> .wiretap("direct:tap")
> .to("mock:result");
> from("direct:tap")
> .process(tapper);
> }
> }
> @Component
> public class Tapper implements Processor {
> public void Process(Exchange exchange) {}
> }
> {code}
> It worked.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (CAMEL-11430) Add support for Spring Boot 2.0.x
[ https://issues.apache.org/jira/browse/CAMEL-11430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151737#comment-16151737 ] Claus Ibsen commented on CAMEL-11430: - Camel 2.20 will not target spring boot 2 - we are stating on 1.5.x. Also we do not want to do releases of 1.x and 2.x -starter components as we have 180+ of those. When we upgrade to spring boot 2.x then we drop support for 1.x on that Camel release going forward. Whether that will be 2.21 or 3.0 or something then time will tell. > Add support for Spring Boot 2.0.x > - > > Key: CAMEL-11430 > URL: https://issues.apache.org/jira/browse/CAMEL-11430 > Project: Camel > Issue Type: Improvement > Components: camel-spring-boot >Reporter: Marcin Grzejszczak > Fix For: Future > > > Hello! > It would be great to add compatibility with Boot 2.0.x . Spring Cloud > Contract uses Camel but in the 2.0.x branch (that is compatible with Boot > 2.0.x ) we can't actually use it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (CAMEL-11430) Add support for Spring Boot 2.0.x
[ https://issues.apache.org/jira/browse/CAMEL-11430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen updated CAMEL-11430: Fix Version/s: (was: 2.20.0) Future > Add support for Spring Boot 2.0.x > - > > Key: CAMEL-11430 > URL: https://issues.apache.org/jira/browse/CAMEL-11430 > Project: Camel > Issue Type: Improvement > Components: camel-spring-boot >Reporter: Marcin Grzejszczak > Fix For: Future > > > Hello! > It would be great to add compatibility with Boot 2.0.x . Spring Cloud > Contract uses Camel but in the 2.0.x branch (that is compatible with Boot > 2.0.x ) we can't actually use it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11708) spring boot code generation: the nested property processor does not handle object hierarchies
[
https://issues.apache.org/jira/browse/CAMEL-11708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151736#comment-16151736
]
Claus Ibsen commented on CAMEL-11708:
-
Where do we have a problem?
I think the source code generation logic is already complex enough and would be
a bit reluctant to make it even more complex. Unless there is a compelling
use-case.
> spring boot code generation: the nested property processor does not handle
> object hierarchies
> -
>
> Key: CAMEL-11708
> URL: https://issues.apache.org/jira/browse/CAMEL-11708
> Project: Camel
> Issue Type: Bug
> Components: tooling
>Reporter: Luca Burgazzoli
> Fix For: 2.20.0
>
>
> Assuming you have complex configuration object that inherits from another
> configuration object, the spring boot code generation will creates the
> configuration properties object only for the properties of the last class so
> i.e. for a simple hierarchy like:
> {code}
> Common {
> String getX()
> void setX(String);
> }
> Specific extends Common {
> String getY()
> void setY(String);
> }
> {code}
> the generator will provides bindings only for
> {code}
> String getX()
> setX(String)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (CAMEL-11723) ManagedCamelContext.dumpRestsAsXml can fail if default charset is not utf-8
[
https://issues.apache.org/jira/browse/CAMEL-11723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Claus Ibsen updated CAMEL-11723:
Priority: Minor (was: Major)
> ManagedCamelContext.dumpRestsAsXml can fail if default charset is not utf-8
> ---
>
> Key: CAMEL-11723
> URL: https://issues.apache.org/jira/browse/CAMEL-11723
> Project: Camel
> Issue Type: Bug
> Components: camel-core, jmx
>Affects Versions: 2.18.4
> Environment: Windows, default charset is not UTF-8
>Reporter: Niels Ull Harremoes
>Priority: Minor
> Labels: easyfix, windows
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> I am trying to access the rest definitions using the swagger servlet.
> My operation description is in Danish and includes the character "æ".
> Thus, the xml string generated in line 371 of
> org.apache.camel.management.mbean.ManagedCamelContext.dumpRestsAsXml
> contains the character "æ".
> In line 376-377, wh have
> {code}
>InputStream is = new ByteArrayInputStream(xml.getBytes());
> Document dom = XmlLineNumberParser.parseXml(is, new ...)
> {code}
> The call to xml.getBytes() uses the default encoding (CP-1252 in my case),
> which will encode æ as a single byte. The xml parser expects UTF-8 (since the
> xml starts with an xml declaration specifying encoding="UTF-8").
> Therefore, it fails with "Invalid byte 2 of 3-byte UTF-8 sequence".
> The fix is simple - change xml.getBytes() to xml.getBytes("UTF-8");
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (CAMEL-11731) Servlet Component isn't really async
[
https://issues.apache.org/jira/browse/CAMEL-11731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Claus Ibsen updated CAMEL-11731:
Issue Type: Improvement (was: Bug)
> Servlet Component isn't really async
>
>
> Key: CAMEL-11731
> URL: https://issues.apache.org/jira/browse/CAMEL-11731
> Project: Camel
> Issue Type: Improvement
> Components: camel-servlet
>Affects Versions: 2.18.4, 2.19.2
> Environment: All
>Reporter: Nick Houghton
> Fix For: 2.20.0
>
>
> So my assumption reading the servlet component doco is that with 2.18+ and a
> Servlet 3+ container, the component supports async, which it kind of does
> with the async=true init config, and there is even a method in CamelServlet
> called "doServiceAsync" but from what i can tell it doesn't really do it in a
> asynchronous manner, where there are no blocked threads while a request is
> awaiting an async operation (like an AHC call for example).
> Looking at:
> https://github.com/apache/camel/blob/master/components/camel-http-common/src/main/java/org/apache/camel/http/common/CamelServlet.java
> While processing a request, we check if we are in async mode and call
> doServiceAsync..
> {code:java}
> @Override
> protected final void service(HttpServletRequest req, HttpServletResponse
> resp) throws ServletException, IOException {
> if (isAsync()) {
> final AsyncContext context = req.startAsync();
> //run async
> context.start(() -> doServiceAsync(context));
> } else {
> doService(req, resp);
> }
> }
> {code}
> then in doServiceAsync() we call doService().. and then we call
> getProcessor().process(exchange), not process(exchange, asyncCallback) which
> is the proper async method..
> {code:java}
> try {
> if (log.isTraceEnabled()) {
> log.trace("Processing request for exchangeId: {}",
> exchange.getExchangeId());
> }
> // process the exchange
> consumer.getProcessor().process(exchange);
> } catch (Exception e) {
> exchange.setException(e);
> }
> {code}
> So the actual behaviour is an inbound request in async mode that ends up just
> blocking waiting for the request to complete, in a totally sync manner. I
> presume this is not the desired behaviour?
> It seems the fix would be to move the doService() logic to doServiceAsync()
> and have doService() call it and use the AsyncProcessorConverterHelper. Or
> the other alternative would be to update the documentation to explicitly note
> that it is actually not async at all.
> I can probably PR it in, just wanted to get thoughts on the actual intention.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (CAMEL-11731) Servlet Component isn't really async
[
https://issues.apache.org/jira/browse/CAMEL-11731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Claus Ibsen updated CAMEL-11731:
Fix Version/s: 2.20.0
> Servlet Component isn't really async
>
>
> Key: CAMEL-11731
> URL: https://issues.apache.org/jira/browse/CAMEL-11731
> Project: Camel
> Issue Type: Bug
> Components: camel-servlet
>Affects Versions: 2.18.4, 2.19.2
> Environment: All
>Reporter: Nick Houghton
> Fix For: 2.20.0
>
>
> So my assumption reading the servlet component doco is that with 2.18+ and a
> Servlet 3+ container, the component supports async, which it kind of does
> with the async=true init config, and there is even a method in CamelServlet
> called "doServiceAsync" but from what i can tell it doesn't really do it in a
> asynchronous manner, where there are no blocked threads while a request is
> awaiting an async operation (like an AHC call for example).
> Looking at:
> https://github.com/apache/camel/blob/master/components/camel-http-common/src/main/java/org/apache/camel/http/common/CamelServlet.java
> While processing a request, we check if we are in async mode and call
> doServiceAsync..
> {code:java}
> @Override
> protected final void service(HttpServletRequest req, HttpServletResponse
> resp) throws ServletException, IOException {
> if (isAsync()) {
> final AsyncContext context = req.startAsync();
> //run async
> context.start(() -> doServiceAsync(context));
> } else {
> doService(req, resp);
> }
> }
> {code}
> then in doServiceAsync() we call doService().. and then we call
> getProcessor().process(exchange), not process(exchange, asyncCallback) which
> is the proper async method..
> {code:java}
> try {
> if (log.isTraceEnabled()) {
> log.trace("Processing request for exchangeId: {}",
> exchange.getExchangeId());
> }
> // process the exchange
> consumer.getProcessor().process(exchange);
> } catch (Exception e) {
> exchange.setException(e);
> }
> {code}
> So the actual behaviour is an inbound request in async mode that ends up just
> blocking waiting for the request to complete, in a totally sync manner. I
> presume this is not the desired behaviour?
> It seems the fix would be to move the doService() logic to doServiceAsync()
> and have doService() call it and use the AsyncProcessorConverterHelper. Or
> the other alternative would be to update the documentation to explicitly note
> that it is actually not async at all.
> I can probably PR it in, just wanted to get thoughts on the actual intention.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (CAMEL-11731) Servlet Component isn't really async
[
https://issues.apache.org/jira/browse/CAMEL-11731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Claus Ibsen updated CAMEL-11731:
Estimated Complexity: Moderate (was: Unknown)
> Servlet Component isn't really async
>
>
> Key: CAMEL-11731
> URL: https://issues.apache.org/jira/browse/CAMEL-11731
> Project: Camel
> Issue Type: Bug
> Components: camel-servlet
>Affects Versions: 2.18.4, 2.19.2
> Environment: All
>Reporter: Nick Houghton
> Fix For: 2.20.0
>
>
> So my assumption reading the servlet component doco is that with 2.18+ and a
> Servlet 3+ container, the component supports async, which it kind of does
> with the async=true init config, and there is even a method in CamelServlet
> called "doServiceAsync" but from what i can tell it doesn't really do it in a
> asynchronous manner, where there are no blocked threads while a request is
> awaiting an async operation (like an AHC call for example).
> Looking at:
> https://github.com/apache/camel/blob/master/components/camel-http-common/src/main/java/org/apache/camel/http/common/CamelServlet.java
> While processing a request, we check if we are in async mode and call
> doServiceAsync..
> {code:java}
> @Override
> protected final void service(HttpServletRequest req, HttpServletResponse
> resp) throws ServletException, IOException {
> if (isAsync()) {
> final AsyncContext context = req.startAsync();
> //run async
> context.start(() -> doServiceAsync(context));
> } else {
> doService(req, resp);
> }
> }
> {code}
> then in doServiceAsync() we call doService().. and then we call
> getProcessor().process(exchange), not process(exchange, asyncCallback) which
> is the proper async method..
> {code:java}
> try {
> if (log.isTraceEnabled()) {
> log.trace("Processing request for exchangeId: {}",
> exchange.getExchangeId());
> }
> // process the exchange
> consumer.getProcessor().process(exchange);
> } catch (Exception e) {
> exchange.setException(e);
> }
> {code}
> So the actual behaviour is an inbound request in async mode that ends up just
> blocking waiting for the request to complete, in a totally sync manner. I
> presume this is not the desired behaviour?
> It seems the fix would be to move the doService() logic to doServiceAsync()
> and have doService() call it and use the AsyncProcessorConverterHelper. Or
> the other alternative would be to update the documentation to explicitly note
> that it is actually not async at all.
> I can probably PR it in, just wanted to get thoughts on the actual intention.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (CAMEL-11731) Servlet Component isn't really async
[
https://issues.apache.org/jira/browse/CAMEL-11731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151735#comment-16151735
]
Claus Ibsen commented on CAMEL-11731:
-
Yeah you are welcome to do a PR, it requires a bit of logic to implement
correct, as all the work after the process, should be done in the AsyncCallback
etc so its a bit more complex to do.
Also the async servlet api is fairly new and therefore not so much in use.
> Servlet Component isn't really async
>
>
> Key: CAMEL-11731
> URL: https://issues.apache.org/jira/browse/CAMEL-11731
> Project: Camel
> Issue Type: Bug
> Components: camel-servlet
>Affects Versions: 2.18.4, 2.19.2
> Environment: All
>Reporter: Nick Houghton
> Fix For: 2.20.0
>
>
> So my assumption reading the servlet component doco is that with 2.18+ and a
> Servlet 3+ container, the component supports async, which it kind of does
> with the async=true init config, and there is even a method in CamelServlet
> called "doServiceAsync" but from what i can tell it doesn't really do it in a
> asynchronous manner, where there are no blocked threads while a request is
> awaiting an async operation (like an AHC call for example).
> Looking at:
> https://github.com/apache/camel/blob/master/components/camel-http-common/src/main/java/org/apache/camel/http/common/CamelServlet.java
> While processing a request, we check if we are in async mode and call
> doServiceAsync..
> {code:java}
> @Override
> protected final void service(HttpServletRequest req, HttpServletResponse
> resp) throws ServletException, IOException {
> if (isAsync()) {
> final AsyncContext context = req.startAsync();
> //run async
> context.start(() -> doServiceAsync(context));
> } else {
> doService(req, resp);
> }
> }
> {code}
> then in doServiceAsync() we call doService().. and then we call
> getProcessor().process(exchange), not process(exchange, asyncCallback) which
> is the proper async method..
> {code:java}
> try {
> if (log.isTraceEnabled()) {
> log.trace("Processing request for exchangeId: {}",
> exchange.getExchangeId());
> }
> // process the exchange
> consumer.getProcessor().process(exchange);
> } catch (Exception e) {
> exchange.setException(e);
> }
> {code}
> So the actual behaviour is an inbound request in async mode that ends up just
> blocking waiting for the request to complete, in a totally sync manner. I
> presume this is not the desired behaviour?
> It seems the fix would be to move the doService() logic to doServiceAsync()
> and have doService() call it and use the AsyncProcessorConverterHelper. Or
> the other alternative would be to update the documentation to explicitly note
> that it is actually not async at all.
> I can probably PR it in, just wanted to get thoughts on the actual intention.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (CAMEL-11690) Done() called two times in RoutingSlip processor
[ https://issues.apache.org/jira/browse/CAMEL-11690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen resolved CAMEL-11690. - Resolution: Won't Fix > Done() called two times in RoutingSlip processor > > > Key: CAMEL-11690 > URL: https://issues.apache.org/jira/browse/CAMEL-11690 > Project: Camel > Issue Type: Bug > Components: camel-core >Affects Versions: 2.17.7, 2.18.4, 2.19.1 >Reporter: Stefan Boller >Priority: Minor > Attachments: RoutingSlipWithInterceptorTest.java > > > Hi, > I found the following issue, if I use the RoutingSlip with an > InterceptStrategy. The done()-method of the interceptor, which intercepts the > RoutingSlip, is called twice instead of only once. The attached test case > reproduces this behavior. > Best regards > STefan -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (CAMEL-11690) Done() called two times in RoutingSlip processor
[ https://issues.apache.org/jira/browse/CAMEL-11690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen updated CAMEL-11690: Priority: Minor (was: Major) > Done() called two times in RoutingSlip processor > > > Key: CAMEL-11690 > URL: https://issues.apache.org/jira/browse/CAMEL-11690 > Project: Camel > Issue Type: Bug > Components: camel-core >Affects Versions: 2.17.7, 2.18.4, 2.19.1 >Reporter: Stefan Boller >Priority: Minor > Attachments: RoutingSlipWithInterceptorTest.java > > > Hi, > I found the following issue, if I use the RoutingSlip with an > InterceptStrategy. The done()-method of the interceptor, which intercepts the > RoutingSlip, is called twice instead of only once. The attached test case > reproduces this behavior. > Best regards > STefan -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11690) Done() called two times in RoutingSlip processor
[ https://issues.apache.org/jira/browse/CAMEL-11690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151734#comment-16151734 ] Claus Ibsen commented on CAMEL-11690: - Dont use InterceptStrategy its being deprecated > Done() called two times in RoutingSlip processor > > > Key: CAMEL-11690 > URL: https://issues.apache.org/jira/browse/CAMEL-11690 > Project: Camel > Issue Type: Bug > Components: camel-core >Affects Versions: 2.17.7, 2.18.4, 2.19.1 >Reporter: Stefan Boller > Attachments: RoutingSlipWithInterceptorTest.java > > > Hi, > I found the following issue, if I use the RoutingSlip with an > InterceptStrategy. The done()-method of the interceptor, which intercepts the > RoutingSlip, is called twice instead of only once. The attached test case > reproduces this behavior. > Best regards > STefan -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (CAMEL-11711) Camel-example-spring-cloud-servicecall doesn't work out of the box
[
https://issues.apache.org/jira/browse/CAMEL-11711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Claus Ibsen updated CAMEL-11711:
Fix Version/s: 2.20.0
> Camel-example-spring-cloud-servicecall doesn't work out of the box
> --
>
> Key: CAMEL-11711
> URL: https://issues.apache.org/jira/browse/CAMEL-11711
> Project: Camel
> Issue Type: Bug
> Components: examples
>Reporter: Andrea Cosentino
>Assignee: Luca Burgazzoli
> Fix For: 2.20.0
>
>
> Currently when you try to use the serviceCall (following the provided steps)
> it fails with
> {code}
> org.apache.camel.http.common.HttpOperationFailedException: HTTP operation
> failed invoking http://localhost:9021/ with statusCode: 404
> at
> org.apache.camel.component.undertow.UndertowClientCallback.lambda$setupResponseListener$2(UndertowClientCallback.java:232)
> at
> org.apache.camel.component.undertow.UndertowClientCallback$ErrorHandlingClientCallback.completed(UndertowClientCallback.java:86)
> at
> io.undertow.client.http.HttpClientExchange.setResponse(HttpClientExchange.java:125)
> at
> io.undertow.client.http.HttpClientConnection$ClientReadListener.handleEvent(HttpClientConnection.java:642)
> at
> io.undertow.client.http.HttpClientConnection$ClientReadListener.handleEvent(HttpClientConnection.java:511)
> at org.xnio.ChannelListeners.invokeChannelListener(ChannelListeners.java:92)
> at
> org.xnio.conduits.ReadReadyHandler$ChannelListenerHandler.readReady(ReadReadyHandler.java:66)
> at org.xnio.nio.NioSocketConduit.handleReady(NioSocketConduit.java:88)
> at org.xnio.nio.WorkerThread.run(WorkerThread.java:561)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (CAMEL-11718) Setting camel.dataformat.json-jackson.object-mapper throws exception
[
https://issues.apache.org/jira/browse/CAMEL-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151733#comment-16151733
]
Claus Ibsen commented on CAMEL-11718:
-
This is not a bug. Camel do not support using spring mvc jackson.
If you can find out if spring mvc exposes the jackson as a bean with a specific
name, then you should be able to refer to it by using that name.
> Setting camel.dataformat.json-jackson.object-mapper throws exception
>
>
> Key: CAMEL-11718
> URL: https://issues.apache.org/jira/browse/CAMEL-11718
> Project: Camel
> Issue Type: Improvement
> Components: camel-jackson
>Affects Versions: 2.19.2
>Reporter: Roman
>
> I wanted to reuse the Jackson object mapper used by Spring MVC but jackson
> json configuration via YML is not working an causing an exception
> {code:none}
> camel:
> springboot:
> name: ${spring.application.name}
> dataformat:
> json-jackson:
> object-mapper: jacksonObjectMapper
> spring:
> jackson:
> property-naming-strategy:
> com.fasterxml.jackson.databind.PropertyNamingStrategy.SnakeCaseStrategy
> default-property-inclusion: non_null
> serialization:
> WRITE_DATES_AS_TIMESTAMPS: true
> {code}
> Throws the following exception:
> {noformat}
> org.apache.camel.spring.boot.CamelSpringBootInitializationException:
> org.apache.camel.FailedToCreateRouteException: Failed to create route
> test-public: Route(test-public)[[From[rest:get:/test?routeId=test-public&...
> because of java.lang.IllegalArgumentException: Could not find a suitable
> setter for property: objectMapper as there isn't a setter method with same
> type: java.lang.String nor type conversion possible: No type converter
> available to convert from type: java.lang.String to the required type:
> com.fasterxml.jackson.databind.ObjectMapper with value jacksonObjectMapper
> at
> org.apache.camel.spring.boot.RoutesCollector.onApplicationEvent(RoutesCollector.java:225)
> at
> org.apache.camel.spring.boot.RoutesCollector.onApplicationEvent(RoutesCollector.java:52)
> at
> org.springframework.context.event.SimpleApplicationEventMulticaster.invokeListener(SimpleApplicationEventMulticaster.java:167)
> at
> org.springframework.context.event.SimpleApplicationEventMulticaster.multicastEvent(SimpleApplicationEventMulticaster.java:139)
> at
> org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:393)
> at
> org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:347)
> at
> org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:883)
> at
> org.springframework.boot.context.embedded.EmbeddedWebApplicationContext.finishRefresh(EmbeddedWebApplicationContext.java:144)
> at
> org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:546)
> at
> org.springframework.boot.context.embedded.EmbeddedWebApplicationContext.refresh(EmbeddedWebApplicationContext.java:122)
> at
> org.springframework.boot.SpringApplication.refresh(SpringApplication.java:693)
> at
> org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:360)
> at
> org.springframework.boot.SpringApplication.run(SpringApplication.java:303)
> at
> org.springframework.boot.SpringApplication.run(SpringApplication.java:1118)
> at
> org.springframework.boot.SpringApplication.run(SpringApplication.java:1107)
> at
> au.com.iag.payments.service.OnlinePaymentsApplicationKt.main(OnlinePaymentsApplication.kt:15)
> Caused by: org.apache.camel.FailedToCreateRouteException: Failed to create
> route test-public:
> Route(test-public)[[From[rest:get:/test?routeId=test-public&... because of
> java.lang.IllegalArgumentException: Could not find a suitable setter for
> property: objectMapper as there isn't a setter method with same type:
> java.lang.String nor type conversion possible: No type converter available to
> convert from type: java.lang.String to the required type:
> com.fasterxml.jackson.databind.ObjectMapper with value jacksonObjectMapper
> at
> org.apache.camel.model.RouteDefinition.addRoutes(RouteDefinition.java:209)
> at
> org.apache.camel.impl.DefaultCamelContext.startRoute(DefaultCamelContext.java:1087)
> at
> org.apache.camel.impl.DefaultCamelContext.startRouteDefinitions(DefaultCamelContext.java:3540)
> at
> org.apache.camel.impl.DefaultCamelContext.doStartCamel(DefaultCamelContext.java:3271)
> at
> org.apache.camel.impl.DefaultCamelContext.access$000(DefaultCamelContext.java:202)
> at
>
[jira] [Updated] (CAMEL-11718) Setting camel.dataformat.json-jackson.object-mapper throws exception
[
https://issues.apache.org/jira/browse/CAMEL-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Claus Ibsen updated CAMEL-11718:
Issue Type: Improvement (was: Bug)
> Setting camel.dataformat.json-jackson.object-mapper throws exception
>
>
> Key: CAMEL-11718
> URL: https://issues.apache.org/jira/browse/CAMEL-11718
> Project: Camel
> Issue Type: Improvement
> Components: camel-jackson
>Affects Versions: 2.19.2
>Reporter: Roman
>
> I wanted to reuse the Jackson object mapper used by Spring MVC but jackson
> json configuration via YML is not working an causing an exception
> {code:none}
> camel:
> springboot:
> name: ${spring.application.name}
> dataformat:
> json-jackson:
> object-mapper: jacksonObjectMapper
> spring:
> jackson:
> property-naming-strategy:
> com.fasterxml.jackson.databind.PropertyNamingStrategy.SnakeCaseStrategy
> default-property-inclusion: non_null
> serialization:
> WRITE_DATES_AS_TIMESTAMPS: true
> {code}
> Throws the following exception:
> {noformat}
> org.apache.camel.spring.boot.CamelSpringBootInitializationException:
> org.apache.camel.FailedToCreateRouteException: Failed to create route
> test-public: Route(test-public)[[From[rest:get:/test?routeId=test-public&...
> because of java.lang.IllegalArgumentException: Could not find a suitable
> setter for property: objectMapper as there isn't a setter method with same
> type: java.lang.String nor type conversion possible: No type converter
> available to convert from type: java.lang.String to the required type:
> com.fasterxml.jackson.databind.ObjectMapper with value jacksonObjectMapper
> at
> org.apache.camel.spring.boot.RoutesCollector.onApplicationEvent(RoutesCollector.java:225)
> at
> org.apache.camel.spring.boot.RoutesCollector.onApplicationEvent(RoutesCollector.java:52)
> at
> org.springframework.context.event.SimpleApplicationEventMulticaster.invokeListener(SimpleApplicationEventMulticaster.java:167)
> at
> org.springframework.context.event.SimpleApplicationEventMulticaster.multicastEvent(SimpleApplicationEventMulticaster.java:139)
> at
> org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:393)
> at
> org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:347)
> at
> org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:883)
> at
> org.springframework.boot.context.embedded.EmbeddedWebApplicationContext.finishRefresh(EmbeddedWebApplicationContext.java:144)
> at
> org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:546)
> at
> org.springframework.boot.context.embedded.EmbeddedWebApplicationContext.refresh(EmbeddedWebApplicationContext.java:122)
> at
> org.springframework.boot.SpringApplication.refresh(SpringApplication.java:693)
> at
> org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:360)
> at
> org.springframework.boot.SpringApplication.run(SpringApplication.java:303)
> at
> org.springframework.boot.SpringApplication.run(SpringApplication.java:1118)
> at
> org.springframework.boot.SpringApplication.run(SpringApplication.java:1107)
> at
> au.com.iag.payments.service.OnlinePaymentsApplicationKt.main(OnlinePaymentsApplication.kt:15)
> Caused by: org.apache.camel.FailedToCreateRouteException: Failed to create
> route test-public:
> Route(test-public)[[From[rest:get:/test?routeId=test-public&... because of
> java.lang.IllegalArgumentException: Could not find a suitable setter for
> property: objectMapper as there isn't a setter method with same type:
> java.lang.String nor type conversion possible: No type converter available to
> convert from type: java.lang.String to the required type:
> com.fasterxml.jackson.databind.ObjectMapper with value jacksonObjectMapper
> at
> org.apache.camel.model.RouteDefinition.addRoutes(RouteDefinition.java:209)
> at
> org.apache.camel.impl.DefaultCamelContext.startRoute(DefaultCamelContext.java:1087)
> at
> org.apache.camel.impl.DefaultCamelContext.startRouteDefinitions(DefaultCamelContext.java:3540)
> at
> org.apache.camel.impl.DefaultCamelContext.doStartCamel(DefaultCamelContext.java:3271)
> at
> org.apache.camel.impl.DefaultCamelContext.access$000(DefaultCamelContext.java:202)
> at
> org.apache.camel.impl.DefaultCamelContext$2.call(DefaultCamelContext.java:3089)
> at
> org.apache.camel.impl.DefaultCamelContext$2.call(DefaultCamelContext.java:3085)
> at
>
[jira] [Commented] (CAMEL-11715) Camel Spring : unable to mix xml and java routes
[ https://issues.apache.org/jira/browse/CAMEL-11715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151732#comment-16151732 ] Claus Ibsen commented on CAMEL-11715: - I wonder if we can build an unit test in camel-spring-boot that can reproduce this? > Camel Spring : unable to mix xml and java routes > > > Key: CAMEL-11715 > URL: https://issues.apache.org/jira/browse/CAMEL-11715 > Project: Camel > Issue Type: Bug > Components: camel-spring, camel-spring-boot >Reporter: Luca Burgazzoli >Assignee: Zoran Regvart > Fix For: 2.20.0 > > > I camel 2.19 it was possible to mix routes from Spring XML and Spring boot > but that does not work anymore with camel 2.20.x. > A sample project can be found here: > https://github.com/lburgazzoli/camel-spring-xml so if you switch camel > version, you'd see that the java route is not more loaded. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11727) Upgrade Groovy to version containing Ivy fixes for cache resolution
[ https://issues.apache.org/jira/browse/CAMEL-11727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151730#comment-16151730 ] Claus Ibsen commented on CAMEL-11727: - Thanks for the information about Ivy adding configurable timeout settings. How would you configure them from a Java API ? > Upgrade Groovy to version containing Ivy fixes for cache resolution > --- > > Key: CAMEL-11727 > URL: https://issues.apache.org/jira/browse/CAMEL-11727 > Project: Camel > Issue Type: Improvement > Components: camel-catalog >Affects Versions: 2.19.2 >Reporter: Aurélien Pupier > > the targeted version is not released yet, the goal is to contain the > following fixes: > - [GROOVY-8305] > - [IVY-1566] via [GROOVY-8304] > there is at least one API break with > org.apache.camel.catalog.maven.TimeoutHttpClientHandler which extends a class > which is no more visible org.apache.ivy.util.url.HttpClientHandler -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (CAMEL-11741) [Documentation] Correct a link
[ https://issues.apache.org/jira/browse/CAMEL-11741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen updated CAMEL-11741: Issue Type: Task (was: Bug) > [Documentation] Correct a link > > > Key: CAMEL-11741 > URL: https://issues.apache.org/jira/browse/CAMEL-11741 > Project: Camel > Issue Type: Task > Components: documentation >Reporter: Farès Hassak >Priority: Trivial > Fix For: 2.20.0 > > > Hello, > There 2 are incorrect link on this webpage : > [http://camel.apache.org/contributing.html|http://camel.apache.org/contributing.html] > Replace http://issues.apache.org/activemq/browse/CAMEL by > https://issues.apache.org/jira/browse/CAMEL > * First link : > Try surfing the our > href="http://issues.apache.org/activemq/browse/CAMEL;>issue tracker > * Second link > Before you can raise an issue in the > href="http://issues.apache.org/activemq/browse/CAMEL;>issue tracker > I have tried to edit this page but i don't have permission to access. > Administration Users > Not Permitted > You are not permitted to perform this operation. > And this page "contributing" does not exist in github. > Farès -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (CAMEL-11741) [Documentation] Correct a link
[ https://issues.apache.org/jira/browse/CAMEL-11741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen resolved CAMEL-11741. - Resolution: Fixed Assignee: Claus Ibsen Fix Version/s: 2.20.0 > [Documentation] Correct a link > > > Key: CAMEL-11741 > URL: https://issues.apache.org/jira/browse/CAMEL-11741 > Project: Camel > Issue Type: Task > Components: documentation >Reporter: Farès Hassak >Assignee: Claus Ibsen >Priority: Trivial > Fix For: 2.20.0 > > > Hello, > There 2 are incorrect link on this webpage : > [http://camel.apache.org/contributing.html|http://camel.apache.org/contributing.html] > Replace http://issues.apache.org/activemq/browse/CAMEL by > https://issues.apache.org/jira/browse/CAMEL > * First link : > Try surfing the our > href="http://issues.apache.org/activemq/browse/CAMEL;>issue tracker > * Second link > Before you can raise an issue in the > href="http://issues.apache.org/activemq/browse/CAMEL;>issue tracker > I have tried to edit this page but i don't have permission to access. > Administration Users > Not Permitted > You are not permitted to perform this operation. > And this page "contributing" does not exist in github. > Farès -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11741) [Documentation] Correct a link
[ https://issues.apache.org/jira/browse/CAMEL-11741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151729#comment-16151729 ] Claus Ibsen commented on CAMEL-11741: - Look at github for the up to date docs https://github.com/apache/camel/blob/master/CONTRIBUTING.md > [Documentation] Correct a link > > > Key: CAMEL-11741 > URL: https://issues.apache.org/jira/browse/CAMEL-11741 > Project: Camel > Issue Type: Bug > Components: documentation >Reporter: Farès Hassak >Priority: Trivial > > Hello, > There 2 are incorrect link on this webpage : > [http://camel.apache.org/contributing.html|http://camel.apache.org/contributing.html] > Replace http://issues.apache.org/activemq/browse/CAMEL by > https://issues.apache.org/jira/browse/CAMEL > * First link : > Try surfing the our > href="http://issues.apache.org/activemq/browse/CAMEL;>issue tracker > * Second link > Before you can raise an issue in the > href="http://issues.apache.org/activemq/browse/CAMEL;>issue tracker > I have tried to edit this page but i don't have permission to access. > Administration Users > Not Permitted > You are not permitted to perform this operation. > And this page "contributing" does not exist in github. > Farès -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (CAMEL-11611) Add a knownHosts option to the camel-ssh component
[ https://issues.apache.org/jira/browse/CAMEL-11611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen resolved CAMEL-11611. - Resolution: Fixed Yes we had a PR merged > Add a knownHosts option to the camel-ssh component > -- > > Key: CAMEL-11611 > URL: https://issues.apache.org/jira/browse/CAMEL-11611 > Project: Camel > Issue Type: Improvement > Components: camel-ssh > Environment: Any. >Reporter: Daniel U. Thibault >Assignee: Andrea Cosentino >Priority: Minor > Labels: known_hosts, ssh > Fix For: 2.20.0 > > > Currently, when one uses camel-ssh to connect to some server, one gets this > message: > [sshd-SshClient[5be46f9d]-nio2-thread-1] WARN > org.apache.sshd.client.keyverifier.AcceptAllServerKeyVerifier - Server at > /: presented unverified EC key: ... > This is an annoyance that would readily be gotten rid of by adding a > knownHosts option similar to certResource: > * name: knownHosts > * default value: null > * description: Path reference to a the list of known hosts public key > certificates (typically ~/.ssh/known_hosts). Prefix path with classpath:, > file:, or http:. > This value would be used by StaticServerKeyVerifier.java to avoid issuing the > warning (as appropriate). com.jcraft.jsch.JSch uses this through its > setKnownHosts method. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
