[jira] [Commented] (CAMEL-12245) Bridged http servlet endpoints should not populate request parameters into exchange headers

2018-02-09 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-12245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358055#comment-16358055
 ] 

ASF GitHub Bot commented on CAMEL-12245:


davsclaus commented on issue #2213: CAMEL-12245 Bridged http servlet endpoints 
should not populate reques…
URL: https://github.com/apache/camel/pull/2213#issuecomment-364362250
 
 
   You set the option on the wrong place its on the http4 producer
   
https://github.com/apache/camel/blob/master/components/camel-http4/src/main/docs/http4-component.adoc


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bridged http servlet endpoints should not populate request parameters into 
> exchange headers
> ---
>
> Key: CAMEL-12245
> URL: https://issues.apache.org/jira/browse/CAMEL-12245
> Project: Camel
>  Issue Type: Bug
>  Components: camel-http-common
>Affects Versions: 2.20.2
>Reporter: john
>Priority: Major
>
> When you create a servlet endpoint and use the bridgeEndpoint option, the 
> queryParameters should NOT be put into the exchange headers, because when you 
> pass this on to the next  (http4) endpoint you have the query parameters and 
> the same parameters as http headers.  So now you are sending additional 
> headers instead of bridging.
>  
> example
>  
> {code:java}
> from("servlet:?matchOnUriPrefix=true&bridgeEndpoint=true")
>   .to("http4://localhost:8080/testService);
> {code}
>  
>                    
> You can work around this by creating a custom httpBinding, but you should not 
> have to do this when the connection is bridged.
> WIll submit PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (CAMEL-12249) Camel-JMS: transferExchange - send ExchangeProperties can not be accessed before first endpoint in route

2018-02-09 Thread Pascal Schumacher (JIRA)
Pascal Schumacher created CAMEL-12249:
-

 Summary: Camel-JMS: transferExchange - send ExchangeProperties can 
not be accessed before first endpoint in route
 Key: CAMEL-12249
 URL: https://issues.apache.org/jira/browse/CAMEL-12249
 Project: Camel
  Issue Type: Bug
  Components: came-jms
Affects Versions: 2.20.2
Reporter: Pascal Schumacher


I am using Camel 2.20.2 and ActiveMQ 5.14.5 with the _transferExchange_ option 
enabled. When I read a message from a queue the send custom 
_ExchangeProperties_ are not set. After the exchange is routed to the first 
endpoint the send _ExchangeProperties_ are set.

Unittest to replicate:

{code:java}
public class JmsTransferExchangeAccessExchangePropertiesBeforeFirstEndpointTest 
extends CamelTestSupport {

@Test
public void 
testSendExchangeAndAccessExchangePropertiesBeforeFirstEndpoint() throws 
Exception {
MockEndpoint mock = getMockEndpoint("mock:result");
mock.expectedBodiesReceived("Hello World");
mock.expectedPropertyReceived("bar", 123);

template.send("direct:start", new Processor() {

public void process(Exchange exchange) throws Exception {
exchange.getIn().setBody("Hello World");
exchange.setProperty("bar", 123);
}
});

assertMockEndpointsSatisfied();
}

@Override
protected RouteBuilder createRouteBuilder() throws Exception {
return new RouteBuilder() {

@Override
public void configure() throws Exception {
from("direct:start").to(getUri());
from(getUri())
// .to("log:debug") this line has uncommented to make 
the test pass

.choice().when(exchangeProperty("bar").isEqualTo(123)).to("mock:result");
}
};
}

protected String getUri() {
return "activemq:queue:foo?transferExchange=true";
}

protected CamelContext createCamelContext() throws Exception {
CamelContext camelContext = super.createCamelContext();

ConnectionFactory connectionFactory = 
CamelJmsTestHelper.createConnectionFactory();
camelContext.addComponent("activemq", 
jmsComponentAutoAcknowledge(connectionFactory));
return camelContext;
}
}
{code}

The test fails, but if I uncomment the __.to("log:debug")__ line it passes.

The test also fails with current master of camel.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (CAMEL-12249) Camel-JMS: transferExchange - send ExchangeProperties can not be accessed before first endpoint in route

2018-02-09 Thread Pascal Schumacher (JIRA)

 [ 
https://issues.apache.org/jira/browse/CAMEL-12249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pascal Schumacher updated CAMEL-12249:
--
Description: 
I am using Camel 2.20.2 and ActiveMQ 5.14.5 with the _transferExchange_ option 
enabled. When I read a message from a queue the send custom 
_ExchangeProperties_ are not set. After the exchange is routed to the first 
endpoint the send _ExchangeProperties_ are set.

Unittest to replicate:

{code:java}
public class JmsTransferExchangeAccessExchangePropertiesBeforeFirstEndpointTest 
extends CamelTestSupport {

@Test
public void 
testSendExchangeAndAccessExchangePropertiesBeforeFirstEndpoint() throws 
Exception {
MockEndpoint mock = getMockEndpoint("mock:result");
mock.expectedBodiesReceived("Hello World");
mock.expectedPropertyReceived("bar", 123);

template.send("direct:start", new Processor() {

public void process(Exchange exchange) throws Exception {
exchange.getIn().setBody("Hello World");
exchange.setProperty("bar", 123);
}
});

assertMockEndpointsSatisfied();
}

@Override
protected RouteBuilder createRouteBuilder() throws Exception {
return new RouteBuilder() {

@Override
public void configure() throws Exception {
from("direct:start").to(getUri());
from(getUri())
// .to("log:debug") this line has uncommented to make 
the test pass

.choice().when(exchangeProperty("bar").isEqualTo(123)).to("mock:result");
}
};
}

protected String getUri() {
return "activemq:queue:foo?transferExchange=true";
}

protected CamelContext createCamelContext() throws Exception {
CamelContext camelContext = super.createCamelContext();

ConnectionFactory connectionFactory = 
CamelJmsTestHelper.createConnectionFactory();
camelContext.addComponent("activemq", 
jmsComponentAutoAcknowledge(connectionFactory));
return camelContext;
}
}
{code}

The test fails, but if I uncomment the _.to("log:debug")_ line it passes.

The test also fails with current master of camel.

  was:
I am using Camel 2.20.2 and ActiveMQ 5.14.5 with the _transferExchange_ option 
enabled. When I read a message from a queue the send custom 
_ExchangeProperties_ are not set. After the exchange is routed to the first 
endpoint the send _ExchangeProperties_ are set.

Unittest to replicate:

{code:java}
public class JmsTransferExchangeAccessExchangePropertiesBeforeFirstEndpointTest 
extends CamelTestSupport {

@Test
public void 
testSendExchangeAndAccessExchangePropertiesBeforeFirstEndpoint() throws 
Exception {
MockEndpoint mock = getMockEndpoint("mock:result");
mock.expectedBodiesReceived("Hello World");
mock.expectedPropertyReceived("bar", 123);

template.send("direct:start", new Processor() {

public void process(Exchange exchange) throws Exception {
exchange.getIn().setBody("Hello World");
exchange.setProperty("bar", 123);
}
});

assertMockEndpointsSatisfied();
}

@Override
protected RouteBuilder createRouteBuilder() throws Exception {
return new RouteBuilder() {

@Override
public void configure() throws Exception {
from("direct:start").to(getUri());
from(getUri())
// .to("log:debug") this line has uncommented to make 
the test pass

.choice().when(exchangeProperty("bar").isEqualTo(123)).to("mock:result");
}
};
}

protected String getUri() {
return "activemq:queue:foo?transferExchange=true";
}

protected CamelContext createCamelContext() throws Exception {
CamelContext camelContext = super.createCamelContext();

ConnectionFactory connectionFactory = 
CamelJmsTestHelper.createConnectionFactory();
camelContext.addComponent("activemq", 
jmsComponentAutoAcknowledge(connectionFactory));
return camelContext;
}
}
{code}

The test fails, but if I uncomment the __.to("log:debug")__ line it passes.

The test also fails with current master of camel.


> Camel-JMS: transferExchange - send ExchangeProperties can not be accessed 
> before first endpoint in route
> 
>
> Key: CAMEL-12249
> URL: https://issues.apache.org/jira/browse/CAMEL-12249
> Project: Camel
>  Issue Type: Bug
>  Components: came-jms
>Affects Versions: 2.20.2
>Reporter: Pascal Schumacher
>Priority: Major
>
> I am using Camel 2.20.2 and ActiveMQ 5.14.5 with the _transferE

[jira] [Created] (CAMEL-12250) Interceptors are not working for route with redelivery strategy

2018-02-09 Thread Krzysztof Borgul (JIRA)
Krzysztof Borgul created CAMEL-12250:


 Summary: Interceptors are not working for route with redelivery 
strategy
 Key: CAMEL-12250
 URL: https://issues.apache.org/jira/browse/CAMEL-12250
 Project: Camel
  Issue Type: Bug
Affects Versions: 2.20.2
Reporter: Krzysztof Borgul


Camel interceptors are not being executed if there is redelivery strategy 
defined. 

 Code below will display BEFORE and AFTER text only if you remove errorHandler 
configuration.

 
{code:java}
public static void main(String[] args) throws Exception {
DefaultCamelContext context = new DefaultCamelContext();
context.addRoutes(new RouteBuilder() {
@Override
public void configure() throws Exception {
errorHandler(new DefaultErrorHandlerBuilder()
.maximumRedeliveries(3)
.redeliveryDelay(2000L));

from("direct:start")
.process(new Processor() {
public void process(Exchange exchange) throws Exception {
System.out.println("PROCESSED");
}
});
}
});
context.addInterceptStrategy(new InterceptStrategy() {
@Override
public Processor wrapProcessorInInterceptors(CamelContext context, 
ProcessorDefinition definition,
Processor target, Processor nextTarget) throws Exception {
System.out.println("INTERCEPTOR");
return new Processor() {
@Override
public void process(Exchange exchange) throws Exception {
System.out.println("BEFORE");
target.process(exchange);
System.out.println("AFTER");

}
};
}
});
context.start();
ProducerTemplate template = context.createProducerTemplate();
template.sendBody("direct:start", "foo");
}{code}
 

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12246) New AsciiDoc documentation has many broken links

2018-02-09 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358353#comment-16358353
 ] 

ASF GitHub Bot commented on CAMEL-12246:


GitHub user fbolton opened a pull request:

https://github.com/apache/camel/pull/2215

CAMEL-12246 Fix broken links

@davsclaus and @oscerd, here are the changes to the AsciiDoc linking that 
we discussed. Here's a summary of what was done:

* Resolve the duplicate IDs (can't do any harm, and is actually required 
for our downstream builds)
* Take into account the -eip suffix, which might reduce the number of 
unresolved links.
* All resolvable links to be transformed to AsciiDoc cross-reference 
format, as follows:
```
link:LINKNAME.html[Text of Link]  =>  <>
```
  Where, in some cases, `LINKNAME` might be augmented by a `-component`, 
`-dataformat`, `-language`, or `-eip` suffix.
* Identify the broken EIP links and leave them alone. These will continue 
to show up as broken links, but we can easily fix them later.
* All other unresolved links will be removed. Probably do this by replacing:
```
link:LINKNAME.html[Text of Link]   =>  Text of Link
```

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fbolton/camel fix-broken-links

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/camel/pull/2215.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2215


commit 9641a6edb74138dc8313deba80a0a46d4236a6e4
Author: Fintan Bolton 
Date:   2018-02-08T17:13:29Z

CAMEL-12246 Fixed a duplicate ID in the AsciiDoc source

commit b61b7a18999594a32c67061eb41c3d6762db756a
Author: Fintan Bolton 
Date:   2018-02-09T10:56:09Z

CAMEL-12246 Replaced file links with AsciiDoc internal cross references

commit 5b6d0a8fcb2c36216d812d8c0bac77262f9fe743
Author: Fintan Bolton 
Date:   2018-02-09T12:18:06Z

CAMEL-12246 Replaced file links that were split over two lines (manually)

commit 8b850266f845e42901005cee568c68f73ed58661
Author: Fintan Bolton 
Date:   2018-02-09T12:38:18Z

CAMEL-12246 Replaced bad links with plain text, except for the files in 
camel-core/src/main/docs/eips/, which will be fixed later




> New AsciiDoc documentation has many broken links
> 
>
> Key: CAMEL-12246
> URL: https://issues.apache.org/jira/browse/CAMEL-12246
> Project: Camel
>  Issue Type: Bug
>  Components: documentation
>Affects Versions: 2.21.0
>Reporter: Fintan Bolton
>Priority: Major
> Fix For: 2.21.0
>
>
> There are a fair number of broken links in the new AsciiDoc documentation (in 
> the main Camel repo). In other words, links like {{link:LINKNAME.html[Link 
> Text]}} ought to have a matching target ID, {{[[LINKNAME]]}}, in the AsciiDoc 
> source. But I found 245 LINKNAMEs in links that have no corresponding target 
> ID defined.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12246) New AsciiDoc documentation has many broken links

2018-02-09 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358352#comment-16358352
 ] 

ASF GitHub Bot commented on CAMEL-12246:


fbolton opened a new pull request #2215: CAMEL-12246 Fix broken links
URL: https://github.com/apache/camel/pull/2215
 
 
   @davsclaus and @oscerd, here are the changes to the AsciiDoc linking that we 
discussed. Here's a summary of what was done:
   
   * Resolve the duplicate IDs (can't do any harm, and is actually required for 
our downstream builds)
   * Take into account the -eip suffix, which might reduce the number of 
unresolved links.
   * All resolvable links to be transformed to AsciiDoc cross-reference format, 
as follows:
   ```
   link:LINKNAME.html[Text of Link]  =>  <>
   ```
 Where, in some cases, `LINKNAME` might be augmented by a `-component`, 
`-dataformat`, `-language`, or `-eip` suffix.
   * Identify the broken EIP links and leave them alone. These will continue to 
show up as broken links, but we can easily fix them later.
   * All other unresolved links will be removed. Probably do this by replacing:
   ```
   link:LINKNAME.html[Text of Link]   =>  Text of Link
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> New AsciiDoc documentation has many broken links
> 
>
> Key: CAMEL-12246
> URL: https://issues.apache.org/jira/browse/CAMEL-12246
> Project: Camel
>  Issue Type: Bug
>  Components: documentation
>Affects Versions: 2.21.0
>Reporter: Fintan Bolton
>Priority: Major
> Fix For: 2.21.0
>
>
> There are a fair number of broken links in the new AsciiDoc documentation (in 
> the main Camel repo). In other words, links like {{link:LINKNAME.html[Link 
> Text]}} ought to have a matching target ID, {{[[LINKNAME]]}}, in the AsciiDoc 
> source. But I found 245 LINKNAMEs in links that have no corresponding target 
> ID defined.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (CAMEL-12237) Camel-AWS: Create a KMS component

2018-02-09 Thread Andrea Cosentino (JIRA)

 [ 
https://issues.apache.org/jira/browse/CAMEL-12237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino resolved CAMEL-12237.
--
Resolution: Fixed

> Camel-AWS: Create a KMS component
> -
>
> Key: CAMEL-12237
> URL: https://issues.apache.org/jira/browse/CAMEL-12237
> Project: Camel
>  Issue Type: New Feature
>  Components: camel-aws
>Reporter: Andrea Cosentino
>Assignee: Andrea Cosentino
>Priority: Major
> Fix For: 2.21.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (CAMEL-12251) Do not hide (so much) blueprint.container.ComponentDefinitionException

2018-02-09 Thread Grzegorz Grzybek (JIRA)
Grzegorz Grzybek created CAMEL-12251:


 Summary: Do not hide (so much) 
blueprint.container.ComponentDefinitionException
 Key: CAMEL-12251
 URL: https://issues.apache.org/jira/browse/CAMEL-12251
 Project: Camel
  Issue Type: Improvement
  Components: camel-blueprint
Affects Versions: 2.20.2
Reporter: Grzegorz Grzybek
Assignee: Grzegorz Grzybek






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (CAMEL-12246) New AsciiDoc documentation has many broken links

2018-02-09 Thread Andrea Cosentino (JIRA)

 [ 
https://issues.apache.org/jira/browse/CAMEL-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino reassigned CAMEL-12246:


Assignee: Andrea Cosentino

> New AsciiDoc documentation has many broken links
> 
>
> Key: CAMEL-12246
> URL: https://issues.apache.org/jira/browse/CAMEL-12246
> Project: Camel
>  Issue Type: Bug
>  Components: documentation
>Affects Versions: 2.21.0
>Reporter: Fintan Bolton
>Assignee: Andrea Cosentino
>Priority: Major
> Fix For: 2.21.0
>
>
> There are a fair number of broken links in the new AsciiDoc documentation (in 
> the main Camel repo). In other words, links like {{link:LINKNAME.html[Link 
> Text]}} ought to have a matching target ID, {{[[LINKNAME]]}}, in the AsciiDoc 
> source. But I found 245 LINKNAMEs in links that have no corresponding target 
> ID defined.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12246) New AsciiDoc documentation has many broken links

2018-02-09 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358367#comment-16358367
 ] 

ASF GitHub Bot commented on CAMEL-12246:


oscerd commented on issue #2215: CAMEL-12246 Fix broken links
URL: https://github.com/apache/camel/pull/2215#issuecomment-364432933
 
 
   Thanks for the PR :-)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> New AsciiDoc documentation has many broken links
> 
>
> Key: CAMEL-12246
> URL: https://issues.apache.org/jira/browse/CAMEL-12246
> Project: Camel
>  Issue Type: Bug
>  Components: documentation
>Affects Versions: 2.21.0
>Reporter: Fintan Bolton
>Priority: Major
> Fix For: 2.21.0
>
>
> There are a fair number of broken links in the new AsciiDoc documentation (in 
> the main Camel repo). In other words, links like {{link:LINKNAME.html[Link 
> Text]}} ought to have a matching target ID, {{[[LINKNAME]]}}, in the AsciiDoc 
> source. But I found 245 LINKNAMEs in links that have no corresponding target 
> ID defined.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (CAMEL-12246) New AsciiDoc documentation has many broken links

2018-02-09 Thread Andrea Cosentino (JIRA)

 [ 
https://issues.apache.org/jira/browse/CAMEL-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino resolved CAMEL-12246.
--
Resolution: Fixed

> New AsciiDoc documentation has many broken links
> 
>
> Key: CAMEL-12246
> URL: https://issues.apache.org/jira/browse/CAMEL-12246
> Project: Camel
>  Issue Type: Bug
>  Components: documentation
>Affects Versions: 2.21.0
>Reporter: Fintan Bolton
>Assignee: Andrea Cosentino
>Priority: Major
> Fix For: 2.21.0
>
>
> There are a fair number of broken links in the new AsciiDoc documentation (in 
> the main Camel repo). In other words, links like {{link:LINKNAME.html[Link 
> Text]}} ought to have a matching target ID, {{[[LINKNAME]]}}, in the AsciiDoc 
> source. But I found 245 LINKNAMEs in links that have no corresponding target 
> ID defined.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12251) Do not hide (so much) blueprint.container.ComponentDefinitionException

2018-02-09 Thread Grzegorz Grzybek (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-12251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358374#comment-16358374
 ] 

Grzegorz Grzybek commented on CAMEL-12251:
--

When I have blueprint XML file, where component bean is (possibly indirectly) 
dependent on property placeholder resolution, there may be 
ComponentDefinitionException which is printed at TRACE level only, but because 
components are instantiated inside 
{{org.apache.camel.blueprint.handler.CamelNamespaceHandler.CamelDependenciesFinder#process()}},
 they have to be defined correctly.

> Do not hide (so much) blueprint.container.ComponentDefinitionException
> --
>
> Key: CAMEL-12251
> URL: https://issues.apache.org/jira/browse/CAMEL-12251
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-blueprint
>Affects Versions: 2.20.2
>Reporter: Grzegorz Grzybek
>Assignee: Grzegorz Grzybek
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (CAMEL-12251) Do not hide (so much) blueprint.container.ComponentDefinitionException

2018-02-09 Thread Grzegorz Grzybek (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-12251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358374#comment-16358374
 ] 

Grzegorz Grzybek edited comment on CAMEL-12251 at 2/9/18 1:34 PM:
--

When I have blueprint XML file, where component bean is (possibly indirectly) 
dependent on property placeholder resolution, there may be 
ComponentDefinitionException which is printed at TRACE level only, but because 
components are instantiated inside 
{{org.apache.camel.blueprint.handler.CamelNamespaceHandler.CamelDependenciesFinder#process()}},
 they have to be defined correctly, so definition problems should be printed 
with higher level.


was (Author: gzres):
When I have blueprint XML file, where component bean is (possibly indirectly) 
dependent on property placeholder resolution, there may be 
ComponentDefinitionException which is printed at TRACE level only, but because 
components are instantiated inside 
{{org.apache.camel.blueprint.handler.CamelNamespaceHandler.CamelDependenciesFinder#process()}},
 they have to be defined correctly.

> Do not hide (so much) blueprint.container.ComponentDefinitionException
> --
>
> Key: CAMEL-12251
> URL: https://issues.apache.org/jira/browse/CAMEL-12251
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-blueprint
>Affects Versions: 2.20.2
>Reporter: Grzegorz Grzybek
>Assignee: Grzegorz Grzybek
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12246) New AsciiDoc documentation has many broken links

2018-02-09 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358376#comment-16358376
 ] 

ASF GitHub Bot commented on CAMEL-12246:


oscerd commented on issue #2215: CAMEL-12246 Fix broken links
URL: https://github.com/apache/camel/pull/2215#issuecomment-364434924
 
 
   This will work once the docs will be generated, but actually with this the 
link won't work in Github.
   
   @davsclaus do we have to revert?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> New AsciiDoc documentation has many broken links
> 
>
> Key: CAMEL-12246
> URL: https://issues.apache.org/jira/browse/CAMEL-12246
> Project: Camel
>  Issue Type: Bug
>  Components: documentation
>Affects Versions: 2.21.0
>Reporter: Fintan Bolton
>Assignee: Andrea Cosentino
>Priority: Major
> Fix For: 2.21.0
>
>
> There are a fair number of broken links in the new AsciiDoc documentation (in 
> the main Camel repo). In other words, links like {{link:LINKNAME.html[Link 
> Text]}} ought to have a matching target ID, {{[[LINKNAME]]}}, in the AsciiDoc 
> source. But I found 245 LINKNAMEs in links that have no corresponding target 
> ID defined.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (CAMEL-12167) [XChange] Get the list of supported currency pairs

2018-02-09 Thread Thomas Diesler (JIRA)

 [ 
https://issues.apache.org/jira/browse/CAMEL-12167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thomas Diesler resolved CAMEL-12167.

   Resolution: Fixed
Fix Version/s: 2.21.0

Done

> [XChange] Get the list of supported currency pairs
> --
>
> Key: CAMEL-12167
> URL: https://issues.apache.org/jira/browse/CAMEL-12167
> Project: Camel
>  Issue Type: New Feature
>Reporter: Thomas Diesler
>Assignee: Thomas Diesler
>Priority: Major
> Fix For: 2.21.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (CAMEL-12168) [XChange] Add initial support for market data queries

2018-02-09 Thread Thomas Diesler (JIRA)

 [ 
https://issues.apache.org/jira/browse/CAMEL-12168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thomas Diesler resolved CAMEL-12168.

   Resolution: Fixed
Fix Version/s: 2.21.0

Done

> [XChange] Add initial support for market data queries
> -
>
> Key: CAMEL-12168
> URL: https://issues.apache.org/jira/browse/CAMEL-12168
> Project: Camel
>  Issue Type: New Feature
>Reporter: Thomas Diesler
>Assignee: Thomas Diesler
>Priority: Major
> Fix For: 2.21.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12170) [XChange] Add initial support for account management

2018-02-09 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-12170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358386#comment-16358386
 ] 

ASF GitHub Bot commented on CAMEL-12170:


GitHub user tdiesler opened a pull request:

https://github.com/apache/camel/pull/2216

[XChange] Add initial support for account management

Resolves CAMEL-12170

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tdiesler/camel CAMEL-12170

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/camel/pull/2216.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2216


commit 7942c7509994582ba0b09e2d08dba12174db8fc9
Author: Thomas Diesler 
Date:   2018-02-07T11:32:31Z

[XChange] Add initial support for account management

Resolves CAMEL-12170




> [XChange] Add initial support for account management
> 
>
> Key: CAMEL-12170
> URL: https://issues.apache.org/jira/browse/CAMEL-12170
> Project: Camel
>  Issue Type: New Feature
>Reporter: Thomas Diesler
>Assignee: Thomas Diesler
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12246) New AsciiDoc documentation has many broken links

2018-02-09 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358412#comment-16358412
 ] 

ASF GitHub Bot commented on CAMEL-12246:


fbolton commented on issue #2215: CAMEL-12246 Fix broken links
URL: https://github.com/apache/camel/pull/2215#issuecomment-364439529
 
 
   @oscerd yes, but I have the impression that most links were already broken 
in GitHub anyway. For example, if you look at the camel-http doc page in the 
commit *before* this PR was merged:
   
https://github.com/apache/camel/blob/ee26d31bcc10fad113fa46cbf0bf4b36f9f0cfbc/components/camel-http/src/main/docs/http-component.adoc
   
   Search for the link to "Jetty Component". When you click on it, you get a 
404. My impression is that this is fairly typical of the links that were 
already there.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> New AsciiDoc documentation has many broken links
> 
>
> Key: CAMEL-12246
> URL: https://issues.apache.org/jira/browse/CAMEL-12246
> Project: Camel
>  Issue Type: Bug
>  Components: documentation
>Affects Versions: 2.21.0
>Reporter: Fintan Bolton
>Assignee: Andrea Cosentino
>Priority: Major
> Fix For: 2.21.0
>
>
> There are a fair number of broken links in the new AsciiDoc documentation (in 
> the main Camel repo). In other words, links like {{link:LINKNAME.html[Link 
> Text]}} ought to have a matching target ID, {{[[LINKNAME]]}}, in the AsciiDoc 
> source. But I found 245 LINKNAMEs in links that have no corresponding target 
> ID defined.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (CAMEL-12251) Do not hide (so much) blueprint.container.ComponentDefinitionException

2018-02-09 Thread Grzegorz Grzybek (JIRA)

 [ 
https://issues.apache.org/jira/browse/CAMEL-12251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Grzegorz Grzybek updated CAMEL-12251:
-
Fix Version/s: 2.17.7
   2.18.5
   2.21.0
   2.20.3
   2.19.5

> Do not hide (so much) blueprint.container.ComponentDefinitionException
> --
>
> Key: CAMEL-12251
> URL: https://issues.apache.org/jira/browse/CAMEL-12251
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-blueprint
>Affects Versions: 2.20.2
>Reporter: Grzegorz Grzybek
>Assignee: Grzegorz Grzybek
>Priority: Major
> Fix For: 2.17.7, 2.18.5, 2.19.5, 2.20.3, 2.21.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12251) Do not hide (so much) blueprint.container.ComponentDefinitionException

2018-02-09 Thread Grzegorz Grzybek (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-12251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358414#comment-16358414
 ] 

Grzegorz Grzybek commented on CAMEL-12251:
--

Fixed with these pushes:
{noformat}
To github.com:apache/camel.git
   ac9208a19e2..6f2767b2e88  camel-2.17.x -> camel-2.17.x
   1b8bbc970da..7b51f218621  camel-2.18.x -> camel-2.18.x
   90943cefeb8..270fedcbd57  camel-2.19.x -> camel-2.19.x
   c8ad9dad29e..02e96925f04  camel-2.20.x -> camel-2.20.x
   66cbe09d8f8..0bce5ce21f2  master -> master
{noformat}

> Do not hide (so much) blueprint.container.ComponentDefinitionException
> --
>
> Key: CAMEL-12251
> URL: https://issues.apache.org/jira/browse/CAMEL-12251
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-blueprint
>Affects Versions: 2.20.2
>Reporter: Grzegorz Grzybek
>Assignee: Grzegorz Grzybek
>Priority: Major
> Fix For: 2.17.7, 2.18.5, 2.19.5, 2.20.3, 2.21.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (CAMEL-12251) Do not hide (so much) blueprint.container.ComponentDefinitionException

2018-02-09 Thread Grzegorz Grzybek (JIRA)

 [ 
https://issues.apache.org/jira/browse/CAMEL-12251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Grzegorz Grzybek resolved CAMEL-12251.
--
Resolution: Fixed

> Do not hide (so much) blueprint.container.ComponentDefinitionException
> --
>
> Key: CAMEL-12251
> URL: https://issues.apache.org/jira/browse/CAMEL-12251
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-blueprint
>Affects Versions: 2.20.2
>Reporter: Grzegorz Grzybek
>Assignee: Grzegorz Grzybek
>Priority: Major
> Fix For: 2.19.5, 2.20.3, 2.21.0, 2.18.5, 2.17.7
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12246) New AsciiDoc documentation has many broken links

2018-02-09 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358417#comment-16358417
 ] 

ASF GitHub Bot commented on CAMEL-12246:


oscerd commented on issue #2215: CAMEL-12246 Fix broken links
URL: https://github.com/apache/camel/pull/2215#issuecomment-364440428
 
 
   Yeah, true. You're right.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> New AsciiDoc documentation has many broken links
> 
>
> Key: CAMEL-12246
> URL: https://issues.apache.org/jira/browse/CAMEL-12246
> Project: Camel
>  Issue Type: Bug
>  Components: documentation
>Affects Versions: 2.21.0
>Reporter: Fintan Bolton
>Assignee: Andrea Cosentino
>Priority: Major
> Fix For: 2.21.0
>
>
> There are a fair number of broken links in the new AsciiDoc documentation (in 
> the main Camel repo). In other words, links like {{link:LINKNAME.html[Link 
> Text]}} ought to have a matching target ID, {{[[LINKNAME]]}}, in the AsciiDoc 
> source. But I found 245 LINKNAMEs in links that have no corresponding target 
> ID defined.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-11370) Problem with MTOM in Camel-CXF

2018-02-09 Thread Peter Keller (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-11370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358539#comment-16358539
 ] 

Peter Keller commented on CAMEL-11370:
--

I tried v2.20.2 with the same effect. I implemented a small sample project 
which can be found on https://github.com/peterkeller/camel-cxf-memory.git


> Problem with MTOM in Camel-CXF
> --
>
> Key: CAMEL-11370
> URL: https://issues.apache.org/jira/browse/CAMEL-11370
> Project: Camel
>  Issue Type: Bug
>  Components: camel-cxf
>Reporter: Joerg Kessler
>Priority: Minor
> Attachments: MTOM-conversion.patch, 
> accept-also-sub-classes-of-orgapachecxfjaxbJAXBDataB.patch, mtom.test.zip
>
>
> I originally opened the issue on CXF:
> https://issues.apache.org/jira/browse/CXF-7388
> but ther CXF guys think the problem is in camel-cxf. Please have a look at 
> this ticket. Basically the MTOM conversion seems not to work anymore when 
> using CXF in Camel. I provided a unit test that demonstrates the observed 
> behaviour.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12245) Bridged http servlet endpoints should not populate request parameters into exchange headers

2018-02-09 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-12245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358544#comment-16358544
 ] 

ASF GitHub Bot commented on CAMEL-12245:


transamericamoon commented on issue #2213: CAMEL-12245 Bridged http servlet 
endpoints should not populate reques…
URL: https://github.com/apache/camel/pull/2213#issuecomment-364463877
 
 
   Thanks Claus, my mistake.  We are trying to change all of our restlet 
endpoints to http4 endpoints to simplify things.  I think for some reason in 
the old camel-restlet some of our headers did not get mapped...
   
   The restlet base library is becoming a mess, where http4 is very simple and 
clean. For example: 
https://restlet.com/open-source/documentation/user-guide/2.3/core/http-headers-mapping
   
   Thanks for the help.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bridged http servlet endpoints should not populate request parameters into 
> exchange headers
> ---
>
> Key: CAMEL-12245
> URL: https://issues.apache.org/jira/browse/CAMEL-12245
> Project: Camel
>  Issue Type: Bug
>  Components: camel-http-common
>Affects Versions: 2.20.2
>Reporter: john
>Priority: Major
>
> When you create a servlet endpoint and use the bridgeEndpoint option, the 
> queryParameters should NOT be put into the exchange headers, because when you 
> pass this on to the next  (http4) endpoint you have the query parameters and 
> the same parameters as http headers.  So now you are sending additional 
> headers instead of bridging.
>  
> example
>  
> {code:java}
> from("servlet:?matchOnUriPrefix=true&bridgeEndpoint=true")
>   .to("http4://localhost:8080/testService);
> {code}
>  
>                    
> You can work around this by creating a custom httpBinding, but you should not 
> have to do this when the connection is bridged.
> WIll submit PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12245) Bridged http servlet endpoints should not populate request parameters into exchange headers

2018-02-09 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-12245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358545#comment-16358545
 ] 

ASF GitHub Bot commented on CAMEL-12245:


transamericamoon closed pull request #2213: CAMEL-12245 Bridged http servlet 
endpoints should not populate reques…
URL: https://github.com/apache/camel/pull/2213
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/components/camel-http-common/src/main/java/org/apache/camel/http/common/DefaultHttpBinding.java
 
b/components/camel-http-common/src/main/java/org/apache/camel/http/common/DefaultHttpBinding.java
index 4bf1b76c2dd..9bb64f2e6e4 100644
--- 
a/components/camel-http-common/src/main/java/org/apache/camel/http/common/DefaultHttpBinding.java
+++ 
b/components/camel-http-common/src/main/java/org/apache/camel/http/common/DefaultHttpBinding.java
@@ -171,7 +171,15 @@ protected void readHeaders(HttpServletRequest request, 
HttpMessage message) {
 }
 
 try {
-populateRequestParameters(request, message);
+// only populate request parameters if we are not bridged
+boolean bridged = false;
+Endpoint endpoint = message.getExchange().getFromEndpoint();
+if (endpoint instanceof HttpCommonEndpoint && 
((HttpCommonEndpoint)endpoint).isBridgeEndpoint()) {
+bridged = true;
+} 
+if (!bridged) {
+populateRequestParameters(request, message);
+}
 } catch (Exception e) {
 throw new RuntimeCamelException("Cannot read request parameters 
due " + e.getMessage(), e);
 }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bridged http servlet endpoints should not populate request parameters into 
> exchange headers
> ---
>
> Key: CAMEL-12245
> URL: https://issues.apache.org/jira/browse/CAMEL-12245
> Project: Camel
>  Issue Type: Bug
>  Components: camel-http-common
>Affects Versions: 2.20.2
>Reporter: john
>Priority: Major
>
> When you create a servlet endpoint and use the bridgeEndpoint option, the 
> queryParameters should NOT be put into the exchange headers, because when you 
> pass this on to the next  (http4) endpoint you have the query parameters and 
> the same parameters as http headers.  So now you are sending additional 
> headers instead of bridging.
>  
> example
>  
> {code:java}
> from("servlet:?matchOnUriPrefix=true&bridgeEndpoint=true")
>   .to("http4://localhost:8080/testService);
> {code}
>  
>                    
> You can work around this by creating a custom httpBinding, but you should not 
> have to do this when the connection is bridged.
> WIll submit PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12245) Bridged http servlet endpoints should not populate request parameters into exchange headers

2018-02-09 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-12245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358546#comment-16358546
 ] 

ASF GitHub Bot commented on CAMEL-12245:


Github user transamericamoon closed the pull request at:

https://github.com/apache/camel/pull/2213


> Bridged http servlet endpoints should not populate request parameters into 
> exchange headers
> ---
>
> Key: CAMEL-12245
> URL: https://issues.apache.org/jira/browse/CAMEL-12245
> Project: Camel
>  Issue Type: Bug
>  Components: camel-http-common
>Affects Versions: 2.20.2
>Reporter: john
>Priority: Major
>
> When you create a servlet endpoint and use the bridgeEndpoint option, the 
> queryParameters should NOT be put into the exchange headers, because when you 
> pass this on to the next  (http4) endpoint you have the query parameters and 
> the same parameters as http headers.  So now you are sending additional 
> headers instead of bridging.
>  
> example
>  
> {code:java}
> from("servlet:?matchOnUriPrefix=true&bridgeEndpoint=true")
>   .to("http4://localhost:8080/testService);
> {code}
>  
>                    
> You can work around this by creating a custom httpBinding, but you should not 
> have to do this when the connection is bridged.
> WIll submit PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (CAMEL-12245) Bridged http servlet endpoints should not populate request parameters into exchange headers

2018-02-09 Thread john (JIRA)

 [ 
https://issues.apache.org/jira/browse/CAMEL-12245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

john closed CAMEL-12245.

Resolution: Not A Bug

> Bridged http servlet endpoints should not populate request parameters into 
> exchange headers
> ---
>
> Key: CAMEL-12245
> URL: https://issues.apache.org/jira/browse/CAMEL-12245
> Project: Camel
>  Issue Type: Bug
>  Components: camel-http-common
>Affects Versions: 2.20.2
>Reporter: john
>Priority: Major
>
> When you create a servlet endpoint and use the bridgeEndpoint option, the 
> queryParameters should NOT be put into the exchange headers, because when you 
> pass this on to the next  (http4) endpoint you have the query parameters and 
> the same parameters as http headers.  So now you are sending additional 
> headers instead of bridging.
>  
> example
>  
> {code:java}
> from("servlet:?matchOnUriPrefix=true&bridgeEndpoint=true")
>   .to("http4://localhost:8080/testService);
> {code}
>  
>                    
> You can work around this by creating a custom httpBinding, but you should not 
> have to do this when the connection is bridged.
> WIll submit PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12233) spring-boot: add threadNamePattern property

2018-02-09 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358645#comment-16358645
 ] 

ASF GitHub Bot commented on CAMEL-12233:


PascalSchumacher opened a new pull request #2217: CAMEL-12233: spring-boot: add 
threadNamePattern property
URL: https://github.com/apache/camel/pull/2217
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> spring-boot: add threadNamePattern property
> ---
>
> Key: CAMEL-12233
> URL: https://issues.apache.org/jira/browse/CAMEL-12233
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-spring-boot
>Reporter: Pascal Schumacher
>Priority: Minor
> Fix For: 2.21.0
>
>
> In spring xml is is possible to configure the _threadNamePattern_ as an 
> attribute of the _camelContext_ element.
> I could not find a way to configure with camel-spring-boot.
> It would be nice if _threadNamePattern_ was added to 
> _CamelConfigurationProperties_.
> Thanks in advance!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12233) spring-boot: add threadNamePattern property

2018-02-09 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358646#comment-16358646
 ] 

ASF GitHub Bot commented on CAMEL-12233:


GitHub user PascalSchumacher opened a pull request:

https://github.com/apache/camel/pull/2217

CAMEL-12233: spring-boot: add threadNamePattern property



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PascalSchumacher/camel 
spring_boot_threadNamePattern

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/camel/pull/2217.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2217


commit 084aa0c83843577190f31188f3a6df476882eb82
Author: Pascal Schumacher 
Date:   2018-02-09T16:45:30Z

CAMEL-12233: spring-boot: add threadNamePattern property




> spring-boot: add threadNamePattern property
> ---
>
> Key: CAMEL-12233
> URL: https://issues.apache.org/jira/browse/CAMEL-12233
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-spring-boot
>Reporter: Pascal Schumacher
>Priority: Minor
> Fix For: 2.21.0
>
>
> In spring xml is is possible to configure the _threadNamePattern_ as an 
> attribute of the _camelContext_ element.
> I could not find a way to configure with camel-spring-boot.
> It would be nice if _threadNamePattern_ was added to 
> _CamelConfigurationProperties_.
> Thanks in advance!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (CAMEL-12252) Dynamic setting the DESTINATION_OVERRIDE_URL doesn't work on CXFRS producer

2018-02-09 Thread Xilai Dai (JIRA)
Xilai Dai created CAMEL-12252:
-

 Summary: Dynamic setting the DESTINATION_OVERRIDE_URL doesn't work 
on CXFRS producer
 Key: CAMEL-12252
 URL: https://issues.apache.org/jira/browse/CAMEL-12252
 Project: Camel
  Issue Type: Bug
  Components: camel-cxfrs
Affects Versions: 2.20.2, 2.19.4, 2.18.5, 2.17.0
 Environment: Java 8
Reporter: Xilai Dai


Given the sample MyProcessor, setting the DESTINATION_OVERRIDE_URL dynamically 
during the invoke:
{code}
public void process(Exchange exchange) throws Exception {
String env = (String)exchange.getIn().getHeader("Environnement");
if (env.equalsIgnoreCase("DEV")) {
exchange.getIn().setHeader(exchange.DESTINATION_OVERRIDE_URL,
"http://esbdev11.local:8080/server1/metaServlet";);
} else {
exchange.getIn().setHeader(exchange.DESTINATION_OVERRIDE_URL,
"http://esblab11.local:8080/server2/metaServlet";);
}
}
{code}

Given the sample Route:
{code}
from("cxfrs:bean:MyREST")
.process(new HeaderProcessor())
.setHeader("Environnement")
.simple("${header.http_query[env][0]}")
.process(new MyProcessor())
.setHeader(org.apache.camel.Exchange.HTTP_METHOD, constant("GET"))
.setHeader(org.apache.camel.Exchange.ACCEPT_CONTENT_TYPE, 
constant("*/*"))
.setHeader(org.apache.camel.Exchange.HTTP_PATH, constant("/"))
.to("cxfrs:bean:restClient?maxClientCacheSize=5");
{code}

Send request to cxfrs:bean:MyREST with different http header "dev", then the 
cxfrs:bean:restClient always make call to the last setting Address.

(Only it works as expected when setting maxClientCacheSize=0 on the 
cxfrs:bean:restClient)

There is no this issue on Camel 2.16.x, but start problem from Camel 2.17.x and 
later versions. Investigations show that the CxfRsEndpoint becoming Singleton 
after CAMEL-9628, that explain why the last Address setting always applied.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12252) Dynamic setting the DESTINATION_OVERRIDE_URL doesn't work on CXFRS producer

2018-02-09 Thread Xilai Dai (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-12252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359284#comment-16359284
 ] 

Xilai Dai commented on CAMEL-12252:
---

To fix it, the address has to be set on the JAXRSClientFactoryBean object of 
the ClientFactoryBeanCache of the CxfRsProducer, then even the Endpoint is 
Singleton, the Address still can be set dynamiclly.

> Dynamic setting the DESTINATION_OVERRIDE_URL doesn't work on CXFRS producer
> ---
>
> Key: CAMEL-12252
> URL: https://issues.apache.org/jira/browse/CAMEL-12252
> Project: Camel
>  Issue Type: Bug
>  Components: camel-cxfrs
>Affects Versions: 2.17.0, 2.18.5, 2.19.4, 2.20.2
> Environment: Java 8
>Reporter: Xilai Dai
>Priority: Major
>
> Given the sample MyProcessor, setting the DESTINATION_OVERRIDE_URL 
> dynamically during the invoke:
> {code}
> public void process(Exchange exchange) throws Exception {
> String env = (String)exchange.getIn().getHeader("Environnement");
> if (env.equalsIgnoreCase("DEV")) {
> exchange.getIn().setHeader(exchange.DESTINATION_OVERRIDE_URL,
> "http://esbdev11.local:8080/server1/metaServlet";);
> } else {
> exchange.getIn().setHeader(exchange.DESTINATION_OVERRIDE_URL,
> "http://esblab11.local:8080/server2/metaServlet";);
> }
> }
> {code}
> Given the sample Route:
> {code}
> from("cxfrs:bean:MyREST")
> .process(new HeaderProcessor())
> .setHeader("Environnement")
> .simple("${header.http_query[env][0]}")
> .process(new MyProcessor())
> .setHeader(org.apache.camel.Exchange.HTTP_METHOD, constant("GET"))
> .setHeader(org.apache.camel.Exchange.ACCEPT_CONTENT_TYPE, 
> constant("*/*"))
> .setHeader(org.apache.camel.Exchange.HTTP_PATH, constant("/"))
> .to("cxfrs:bean:restClient?maxClientCacheSize=5");
> {code}
> Send request to cxfrs:bean:MyREST with different http header "dev", then the 
> cxfrs:bean:restClient always make call to the last setting Address.
> (Only it works as expected when setting maxClientCacheSize=0 on the 
> cxfrs:bean:restClient)
> There is no this issue on Camel 2.16.x, but start problem from Camel 2.17.x 
> and later versions. Investigations show that the CxfRsEndpoint becoming 
> Singleton after CAMEL-9628, that explain why the last Address setting always 
> applied.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12252) Dynamic setting the DESTINATION_OVERRIDE_URL doesn't work on CXFRS producer

2018-02-09 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-12252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359286#comment-16359286
 ] 

ASF GitHub Bot commented on CAMEL-12252:


xldai opened a new pull request #2218: fix CAMEL-12252 and add test case for it
URL: https://github.com/apache/camel/pull/2218
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Dynamic setting the DESTINATION_OVERRIDE_URL doesn't work on CXFRS producer
> ---
>
> Key: CAMEL-12252
> URL: https://issues.apache.org/jira/browse/CAMEL-12252
> Project: Camel
>  Issue Type: Bug
>  Components: camel-cxfrs
>Affects Versions: 2.17.0, 2.18.5, 2.19.4, 2.20.2
> Environment: Java 8
>Reporter: Xilai Dai
>Priority: Major
>
> Given the sample MyProcessor, setting the DESTINATION_OVERRIDE_URL 
> dynamically during the invoke:
> {code}
> public void process(Exchange exchange) throws Exception {
> String env = (String)exchange.getIn().getHeader("Environnement");
> if (env.equalsIgnoreCase("DEV")) {
> exchange.getIn().setHeader(exchange.DESTINATION_OVERRIDE_URL,
> "http://esbdev11.local:8080/server1/metaServlet";);
> } else {
> exchange.getIn().setHeader(exchange.DESTINATION_OVERRIDE_URL,
> "http://esblab11.local:8080/server2/metaServlet";);
> }
> }
> {code}
> Given the sample Route:
> {code}
> from("cxfrs:bean:MyREST")
> .process(new HeaderProcessor())
> .setHeader("Environnement")
> .simple("${header.http_query[env][0]}")
> .process(new MyProcessor())
> .setHeader(org.apache.camel.Exchange.HTTP_METHOD, constant("GET"))
> .setHeader(org.apache.camel.Exchange.ACCEPT_CONTENT_TYPE, 
> constant("*/*"))
> .setHeader(org.apache.camel.Exchange.HTTP_PATH, constant("/"))
> .to("cxfrs:bean:restClient?maxClientCacheSize=5");
> {code}
> Send request to cxfrs:bean:MyREST with different http header "dev", then the 
> cxfrs:bean:restClient always make call to the last setting Address.
> (Only it works as expected when setting maxClientCacheSize=0 on the 
> cxfrs:bean:restClient)
> There is no this issue on Camel 2.16.x, but start problem from Camel 2.17.x 
> and later versions. Investigations show that the CxfRsEndpoint becoming 
> Singleton after CAMEL-9628, that explain why the last Address setting always 
> applied.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12252) Dynamic setting the DESTINATION_OVERRIDE_URL doesn't work on CXFRS producer

2018-02-09 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-12252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359287#comment-16359287
 ] 

ASF GitHub Bot commented on CAMEL-12252:


GitHub user xldai opened a pull request:

https://github.com/apache/camel/pull/2218

fix CAMEL-12252 and add test case for it



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xldai/camel master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/camel/pull/2218.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2218


commit 80be0842ea7696066c7d570cc537e270d738d503
Author: xldai 
Date:   2018-02-10T06:41:24Z

fix CAMEL-12252 and add test case for it




> Dynamic setting the DESTINATION_OVERRIDE_URL doesn't work on CXFRS producer
> ---
>
> Key: CAMEL-12252
> URL: https://issues.apache.org/jira/browse/CAMEL-12252
> Project: Camel
>  Issue Type: Bug
>  Components: camel-cxfrs
>Affects Versions: 2.17.0, 2.18.5, 2.19.4, 2.20.2
> Environment: Java 8
>Reporter: Xilai Dai
>Priority: Major
>
> Given the sample MyProcessor, setting the DESTINATION_OVERRIDE_URL 
> dynamically during the invoke:
> {code}
> public void process(Exchange exchange) throws Exception {
> String env = (String)exchange.getIn().getHeader("Environnement");
> if (env.equalsIgnoreCase("DEV")) {
> exchange.getIn().setHeader(exchange.DESTINATION_OVERRIDE_URL,
> "http://esbdev11.local:8080/server1/metaServlet";);
> } else {
> exchange.getIn().setHeader(exchange.DESTINATION_OVERRIDE_URL,
> "http://esblab11.local:8080/server2/metaServlet";);
> }
> }
> {code}
> Given the sample Route:
> {code}
> from("cxfrs:bean:MyREST")
> .process(new HeaderProcessor())
> .setHeader("Environnement")
> .simple("${header.http_query[env][0]}")
> .process(new MyProcessor())
> .setHeader(org.apache.camel.Exchange.HTTP_METHOD, constant("GET"))
> .setHeader(org.apache.camel.Exchange.ACCEPT_CONTENT_TYPE, 
> constant("*/*"))
> .setHeader(org.apache.camel.Exchange.HTTP_PATH, constant("/"))
> .to("cxfrs:bean:restClient?maxClientCacheSize=5");
> {code}
> Send request to cxfrs:bean:MyREST with different http header "dev", then the 
> cxfrs:bean:restClient always make call to the last setting Address.
> (Only it works as expected when setting maxClientCacheSize=0 on the 
> cxfrs:bean:restClient)
> There is no this issue on Camel 2.16.x, but start problem from Camel 2.17.x 
> and later versions. Investigations show that the CxfRsEndpoint becoming 
> Singleton after CAMEL-9628, that explain why the last Address setting always 
> applied.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)