[jira] [Resolved] (CAMEL-12679) ensure camel-xmlsecurity can try key directly to decrypt message
[
https://issues.apache.org/jira/browse/CAMEL-12679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Freeman Fang resolved CAMEL-12679.
--
Resolution: Fixed
Fix Version/s: 2.23.0
> ensure camel-xmlsecurity can try key directly to decrypt message
>
>
> Key: CAMEL-12679
> URL: https://issues.apache.org/jira/browse/CAMEL-12679
> Project: Camel
> Issue Type: Improvement
>Reporter: Freeman Fang
>Assignee: Freeman Fang
>Priority: Major
> Fix For: 2.23.0
>
>
> If there is no EncryptedKey can be used,try the key directly to decrypt
> message as fallback
> As both message
> {code}
> http://www.w3.org/2001/04/xmlenc#;
> Type="http://www.w3.org/2001/04/xmlenc#Element;> Algorithm="http://www.w3.org/2001/04/xmlenc#tripledes-cbc"/> xmlns:ds="http://www.w3.org/2000/09/xmldsig#;> xmlns:xenc="http://www.w3.org/2001/04/xmlenc#;> Algorithm="http://www.w3.org/2001/04/xmlenc#kw-tripledes"/>/5nDlLI7jrETNrNG/5Nsw3qB9dSnZVwyj5OZZsUvZaHb/8oIayoMeg==yP17O2otQdraY+W42w8i8U/pQQac1g84vWaGWqbS1tgCduFfjhnIz2ZqbFJ6n7Ow1cIeF5HyAoHRGaoDd4gbVw==
> {code}
> {code}
>
>Algorithm="http://www.w3.org/2001/04/xmlenc#tripledes-cbc;>
> 168
>
>
> mykey
>
>
>
> yP17O2otQdraY+W42w8i8U/pQQac1g84vWaGWqbS1tgCduFfjhnIz2ZqbFJ6n7Ow1cIeF5HyAoHRGaoDd4gbVw==
>
>
> {code}
> are valid per the spec.
> Currently camel-xmlsecurity can handle the first case but not the second
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CAMEL-12681) BreadcrumbId not required for aws-sqs aws-sns endpoints
[ https://issues.apache.org/jira/browse/CAMEL-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554819#comment-16554819 ] ASF GitHub Bot commented on CAMEL-12681: GitHub user saravanakumar1987 opened a pull request: https://github.com/apache/camel/pull/2439 CAMEL-12681 : BreadcrumbId not required for aws-sqs aws-sns endpoints PR for https://issues.apache.org/jira/browse/CAMEL-12681 Thanks, Saravanakumar You can merge this pull request into a Git repository by running: $ git pull https://github.com/saravanakumar1987/camel master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/camel/pull/2439.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2439 commit e9fa4ebce80a6dd8b02a519c7c2cb345ea63e616 Author: Saravanakumar Selvaraj Date: 2018-07-24T21:26:57Z CAMEL-12681 : BreadcrumbId not required for aws-sqs aws-sns endpoints > BreadcrumbId not required for aws-sqs aws-sns endpoints > --- > > Key: CAMEL-12681 > URL: https://issues.apache.org/jira/browse/CAMEL-12681 > Project: Camel > Issue Type: Bug > Components: camel-aws >Affects Versions: 2.21.1 >Reporter: Saravanakumar Selvaraj >Priority: Minor > > Currently in each message sent through aws-sqs aws-sns endpoints, there is an > extra message attribute 'breadcrumbId' appears. > BreadcrumbId need not be passed to aws-sqs aws-sns producer endpoints. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12681) BreadcrumbId not required for aws-sqs aws-sns endpoints
[ https://issues.apache.org/jira/browse/CAMEL-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554818#comment-16554818 ] ASF GitHub Bot commented on CAMEL-12681: saravanakumar1987 opened a new pull request #2439: CAMEL-12681 : BreadcrumbId not required for aws-sqs aws-sns endpoints URL: https://github.com/apache/camel/pull/2439 PR for https://issues.apache.org/jira/browse/CAMEL-12681 Thanks, Saravanakumar This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > BreadcrumbId not required for aws-sqs aws-sns endpoints > --- > > Key: CAMEL-12681 > URL: https://issues.apache.org/jira/browse/CAMEL-12681 > Project: Camel > Issue Type: Bug > Components: camel-aws >Affects Versions: 2.21.1 >Reporter: Saravanakumar Selvaraj >Priority: Minor > > Currently in each message sent through aws-sqs aws-sns endpoints, there is an > extra message attribute 'breadcrumbId' appears. > BreadcrumbId need not be passed to aws-sqs aws-sns producer endpoints. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (CAMEL-12681) BreadcrumbId not required for aws-sqs aws-sns endpoints
Saravanakumar Selvaraj created CAMEL-12681: -- Summary: BreadcrumbId not required for aws-sqs aws-sns endpoints Key: CAMEL-12681 URL: https://issues.apache.org/jira/browse/CAMEL-12681 Project: Camel Issue Type: Bug Components: camel-aws Affects Versions: 2.21.1 Reporter: Saravanakumar Selvaraj Currently in each message sent through aws-sqs aws-sns endpoints, there is an extra message attribute 'breadcrumbId' appears. BreadcrumbId need not be passed to aws-sqs aws-sns producer endpoints. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12674) Update sshd-version
[ https://issues.apache.org/jira/browse/CAMEL-12674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554775#comment-16554775 ] ASF GitHub Bot commented on CAMEL-12674: oscerd commented on issue #2434: CAMEL-12674 - upgrade sshd-core and replace it specific ones by versi… URL: https://github.com/apache/camel/pull/2434#issuecomment-407544828 I'll test the PR tomorrow and check the SB tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update sshd-version > --- > > Key: CAMEL-12674 > URL: https://issues.apache.org/jira/browse/CAMEL-12674 > Project: Camel > Issue Type: Improvement > Components: camel-ftp, camel-jsch, camel-ssh >Reporter: Önder Sezgin >Assignee: Önder Sezgin >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12674) Update sshd-version
[ https://issues.apache.org/jira/browse/CAMEL-12674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554774#comment-16554774 ] ASF GitHub Bot commented on CAMEL-12674: onderson commented on issue #2434: CAMEL-12674 - upgrade sshd-core and replace it specific ones by versi… URL: https://github.com/apache/camel/pull/2434#issuecomment-407544555 @oscerd , do you have any idea why the test may hang on local box? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update sshd-version > --- > > Key: CAMEL-12674 > URL: https://issues.apache.org/jira/browse/CAMEL-12674 > Project: Camel > Issue Type: Improvement > Components: camel-ftp, camel-jsch, camel-ssh >Reporter: Önder Sezgin >Assignee: Önder Sezgin >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12078) MIME-Mutipart DataFormat reads attachment DataSource twice
[
https://issues.apache.org/jira/browse/CAMEL-12078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554671#comment-16554671
]
ASF GitHub Bot commented on CAMEL-12078:
aldettinger commented on a change in pull request #2185: Failing test for
CAMEL-12078
URL: https://github.com/apache/camel/pull/2185#discussion_r204873667
##
File path:
components/camel-mail/src/test/java/org/apache/camel/dataformat/mime/multipart/MimeMultipartDataFormatTest.java
##
@@ -351,6 +351,41 @@ public void unmarshalInlineHeadersNonMimeBodyStream()
throws UnsupportedEncoding
assertEquals("This is not a MIME-Multipart", bodyStr);
}
+@Test
+public void attachmentReadOnce() throws IOException {
+String attContentType = "text/plain";
+String attText = "Attachment Text";
+InputStream attInputStream = new
ByteArrayInputStream(attText.getBytes());
+String attFileName = "Attachment File Name";
+in.setBody("Body text");
+in.setHeader(Exchange.CONTENT_TYPE,
"text/plain;charset=iso8859-1;other-parameter=true");
+in.setHeader(Exchange.CONTENT_ENCODING, "UTF8");
+Map headers = new HashMap();
+headers.put("Content-Description", "Sample Attachment Data");
+headers.put("X-AdditionalData", "additional data");
+CountingByteArrayDataSource attachmentDs = new
CountingByteArrayDataSource(attInputStream, attContentType);
+addAttachment(attachmentDs, attFileName, headers);
+Exchange result = template.send("direct:roundtrip", exchange);
+Message out = result.getOut();
+assertEquals("Body text", out.getBody(String.class));
+assertThat(out.getHeader(Exchange.CONTENT_TYPE, String.class),
startsWith("text/plain"));
+assertEquals("UTF8", out.getHeader(Exchange.CONTENT_ENCODING));
+assertTrue(out.hasAttachments());
+assertEquals(1, out.getAttachmentNames().size());
+assertThat(out.getAttachmentNames(), hasItem(attFileName));
+Attachment att = out.getAttachmentObject(attFileName);
+DataHandler dh = att.getDataHandler();
+assertNotNull(dh);
+assertEquals(attContentType, dh.getContentType());
+InputStream is = dh.getInputStream();
+ByteArrayOutputStream os = new ByteArrayOutputStream();
+IOHelper.copyAndCloseInput(is, os);
+assertEquals(attText, new String(os.toByteArray()));
+assertEquals("Sample Attachment Data",
att.getHeader("content-description"));
+assertEquals("additional data", att.getHeader("X-AdditionalData"));
+assertEquals(1, attachmentDs.readCounts); // Fails - input is read
twice
Review comment:
@tdudgeon, IMHO the proposed test does not yet exhibit an issue as a valid
DataSource.getInputStream() implementation would return [a new stream
positioned at the beginning of the data each time it is
called](https://docs.oracle.com/javase/8/docs/api/javax/activation/DataSource.html#getInputStream--).
There I have 2 questions:
Could it be that you faced an issue involving a wrong DataSource
implementation ?
Or, was your issue linked to a DataSource returning an input stream that
don't support mark / reset ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> MIME-Mutipart DataFormat reads attachment DataSource twice
> --
>
> Key: CAMEL-12078
> URL: https://issues.apache.org/jira/browse/CAMEL-12078
> Project: Camel
> Issue Type: Bug
> Components: camel-mail
>Affects Versions: 2.20.1
>Reporter: Tim Dudgeon
>Priority: Minor
> Fix For: Future
>
>
> As reported on mailing list if an attachment for MIME-Mutipart DataFormat is
> defined using a DataSource that can only be read once you get an exception.
> http://mail-archives.apache.org/mod_mbox/camel-users/201712.mbox/%3C0e0d4b2e-dc32-c61e-3ccd-7ee14238c485%40gmail.com%3E
> For instance, this happens if the DataSource is created using an InputStream
> that cannot be read multiple times
> It should be possible to post the data only reading the input a single time.
> I will add a test case shortly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CAMEL-12638) DefaultFluentProducerTemplate is not thread safe
[
https://issues.apache.org/jira/browse/CAMEL-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554613#comment-16554613
]
Lukasz commented on CAMEL-12638:
{quote}So I just add a comment that we need treat FluentProducerTemplate as a
Builder.
{quote}
[~njiang] I kind of feel like this is not enough... If we want to avoid further
confusion and potential production issues (our case) I think the class should
be either made thread-safe for all operations *or* **it should not be possible
to use it as a _ProducerTemplate_ (and don't create a singleton of this class
as part of spring-boot-starter).
> DefaultFluentProducerTemplate is not thread safe
>
>
> Key: CAMEL-12638
> URL: https://issues.apache.org/jira/browse/CAMEL-12638
> Project: Camel
> Issue Type: Bug
> Components: camel-core
>Affects Versions: 2.20.2
>Reporter: Lukasz
>Priority: Major
> Attachments: image-2018-07-12-17-58-09-225.png
>
>
> I think we have rediscovered the CAMEL-10820 bug. A body of one request gets
> replaced with a body of proceeding request, in our case we use *request()*
> method instead of *asyncSend()*.
> We use camel together with spring-boot. Consider following code:
>
> {code:java}
> @Service
> public class UseCamelService {
>private FluentProducerTemplate producer;
>@Autowired
>public UseCamelService(FluentProducerTemplate producer) {
> this.producer = producer;
>}
>public String getValueFromCamel(String body) {
> return producer.to("route").withBody(body).request(String.class);
>}
> }
> {code}
> If *UseCamelService.getValueFromCamel()* gets called from two different
> threads it is possible for the latter one to override the body of the first
> one.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CAMEL-12668) Aggregate with forcecompleteonstop doesn't seem to be honored
[ https://issues.apache.org/jira/browse/CAMEL-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554396#comment-16554396 ] Andrea Cosentino commented on CAMEL-12668: -- For sure the fix won't be for 2.17. It's not maintained anymore. 2.21 or 2.22. By the way when someone will have time this will be fixed. If you need something faster than this you need to switch to commercial support. Contributors work on Camel in their free time. > Aggregate with forcecompleteonstop doesn't seem to be honored > - > > Key: CAMEL-12668 > URL: https://issues.apache.org/jira/browse/CAMEL-12668 > Project: Camel > Issue Type: Bug > Components: camel-core >Affects Versions: 2.17.0 >Reporter: Chirag Anand >Priority: Major > Fix For: 2.22.0 > > > I have a camel project where I am using twitter component of the camel and > using the streaming/filter endpoint. The route is something like > from().aggregate().completionSize().forceCompletionOnStop().process(). > The problem here is when I stop the context the remaining aggregated > exchanges are not being flushed to the processor. Earlier I was using version > 2.16.2 and it worked fine, but with the latest release i.e 2.22.0 I am facing > this issue. The configuration hasn’t changed a bit. To be certain i tried it > with version 2.17.0 also, doesn't work either. > > I tried debugging and I noticed at somepoint there is a > RejectedExecutionException, not sure why because there is no change in the > configuration. > > Can you please resolve this at the earliest? or at least tell me if there has > been any change in the functionality/usage? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12668) Aggregate with forcecompleteonstop doesn't seem to be honored
[
https://issues.apache.org/jira/browse/CAMEL-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554378#comment-16554378
]
Chirag Anand commented on CAMEL-12668:
--
[~dmvolod] I have tried the same scenario with camel-stream component using the
same aggregation logic. It succeeded for version 2.16.2 but when i am using
2.17.0 it fails again. The route i am using is as follows -
from("stream:file?fileName=C:/Test/ABC.txt")
.aggregate(constant(true), new CamelAggregator()).completionSize(50)
.forceCompletionOnStop().process(new Processor() {
@Override
public void process(Exchange exchange) throws Exception {
List statusObjects =
exchange.getIn().getBody(List.class);
System.out.println(statusObjects.size());
}
}).end();
Can we please fix it at the earliest now? It's very important that this gets
fixed soon.
> Aggregate with forcecompleteonstop doesn't seem to be honored
> -
>
> Key: CAMEL-12668
> URL: https://issues.apache.org/jira/browse/CAMEL-12668
> Project: Camel
> Issue Type: Bug
> Components: camel-core
>Affects Versions: 2.17.0
>Reporter: Chirag Anand
>Priority: Major
> Fix For: 2.22.0
>
>
> I have a camel project where I am using twitter component of the camel and
> using the streaming/filter endpoint. The route is something like
> from().aggregate().completionSize().forceCompletionOnStop().process().
> The problem here is when I stop the context the remaining aggregated
> exchanges are not being flushed to the processor. Earlier I was using version
> 2.16.2 and it worked fine, but with the latest release i.e 2.22.0 I am facing
> this issue. The configuration hasn’t changed a bit. To be certain i tried it
> with version 2.17.0 also, doesn't work either.
>
> I tried debugging and I noticed at somepoint there is a
> RejectedExecutionException, not sure why because there is no change in the
> configuration.
>
> Can you please resolve this at the earliest? or at least tell me if there has
> been any change in the functionality/usage?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (CAMEL-12656) camel-zipkin - Root Span Id is not reported if the route calls multiple route
[
https://issues.apache.org/jira/browse/CAMEL-12656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ramu updated CAMEL-12656:
-
Description:
Camel-Zipkin does not report traces with root span id when there are multiple
routes.
For example:
{code:java}
from("direct:foo")
.delay(1000)
.to("direct:bar")
.to("direct:moo")
.to("direct:tar");
from("direct:bar")
.delay(2000);
from("direct:moo")
.delay(1000);
from("direct:tar")
.delay(3000);
{code}
Root SpanId(TraceId) should be for service-name = direct:foo and the trace in
UI should show all the 4 routes in one sequence. But it breaks. Check the
attached screenshot: Traces Breaking.png
I looked into the code and figured out why its happening. Here is the code
which is breaking the functionality.
Class Name: ZipkinTracer.ZipkinRoutePolicy
Inside onExchangeBegin() method
{code:java}
// add on completion after the route is done, but before the consumer writes
the response
// this allows us to track the zipkin event before returning the response which
is the right time
exchange.addOnCompletion(new SynchronizationAdapter() {
@Override
public void onAfterRoute(Route route, Exchange exchange) {
String serviceName = getServiceName(exchange, route.getEndpoint(),
true, false);
Brave brave = getBrave(serviceName);
if (brave != null) {
serverResponse(brave, serviceName, exchange);
}
}
@Override
public String toString() {
return "ZipkinTracerOnCompletion[" + routeId + "]";
}
});
{code}
Using onAfterRoute() : if the exchange is being routed through multiple
routes, there will be callbacks for each route.
I have fix for it:
If I use onExchangeDone() instead of above code. The traces are reported
properly. Check screenshots.
[https://zipkin.io/pages/instrumenting.html]
*Note* This process must be repeated if the service makes multiple downstream
calls. That is each subsequent span will have the same trace id and parent id,
but a new and different span id.
was:
Camel-Zipkin does not report traces with root span id when there are multiple
routes.
For example:
{code:java}
from("direct:foo")
.delay(1000)
.to("direct:bar")
.to("direct:moo")
.to("direct:tar");
from("direct:bar")
.delay(2000);
from("direct:moo")
.delay(1000);
from("direct:tar")
.delay(3000);
{code}
Root SpanId(TraceId) should be for service-name = direct:foo and the trace in
UI should show all the 4 routes in one sequence. But it breaks. Check the
attached screenshot: Traces Breaking.png
I looked into the code and figured out why its happening. Here is the code
which is breaking the functionality.
Class Name: ZipkinTracer.ZipkinRoutePolicy
Inside onExchangeBegin() method
{code:java}
// add on completion after the route is done, but before the consumer writes
the response
// this allows us to track the zipkin event before returning the response which
is the right time
exchange.addOnCompletion(new SynchronizationAdapter() {
@Override
public void onAfterRoute(Route route, Exchange exchange) {
String serviceName = getServiceName(exchange, route.getEndpoint(),
true, false);
Brave brave = getBrave(serviceName);
if (brave != null) {
serverResponse(brave, serviceName, exchange);
}
}
@Override
public String toString() {
return "ZipkinTracerOnCompletion[" + routeId + "]";
}
});
{code}
Using onAfterRoute() : if the exchange is being routed through multiple
routes, there will be callbacks for each route.
I have fix for it:
If I use onExchangeDone() instead of above code. The traces are reported
properly. Check screenshots.
https://zipkin.io/pages/instrumenting.html
*Note* This process must be repeated if the service makes multiple downstream
calls. That is each subsequent span will have the same trace id and parent id,
but a new and different span id.
> camel-zipkin - Root Span Id is not reported if the route calls multiple route
> -
>
> Key: CAMEL-12656
> URL: https://issues.apache.org/jira/browse/CAMEL-12656
> Project: Camel
> Issue Type: Bug
> Components: camel-zipkin
>Affects Versions: 2.21.1
>Reporter: Sourabh Taletiya
>Priority: Major
> Fix For: 2.22.1, 2.23.0, 2.21.3
>
> Attachments: Traces breaking.png, Traces fixed 1.png, Traces fixed
> 2.png
>
>
> Camel-Zipkin does not report traces with root span id when there are multiple
> routes.
> For example:
>
> {code:java}
> from("direct:foo")
> .delay(1000)
> .to("direct:bar")
> .to("direct:moo")
> .to("direct:tar");
> from("direct:bar")
>
[jira] [Commented] (CAMEL-12558) camel-catalog - Transacted and Policy should not have outputs
[ https://issues.apache.org/jira/browse/CAMEL-12558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554192#comment-16554192 ] Aurélien Pupier commented on CAMEL-12558: - Shouldn't the xsd updated too? > camel-catalog - Transacted and Policy should not have outputs > - > > Key: CAMEL-12558 > URL: https://issues.apache.org/jira/browse/CAMEL-12558 > Project: Camel > Issue Type: Bug > Components: camel-catalog >Affects Versions: 2.21.1 >Reporter: Claus Ibsen >Assignee: Claus Ibsen >Priority: Major > Fix For: 2.21.2, 2.22.0 > > > These 2 eips should not have output: true in the camel-catalog json meta-data. > For Camel 3.0 we will change their base class in the model so they are no > outputs -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (CAMEL-12625) Create FHIR Camel component with example
[ https://issues.apache.org/jira/browse/CAMEL-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Poth updated CAMEL-12625: -- Description: Create Camel component to integrate with [FHIR|http://hapifhir.io] endpoints. I'll submit a PR (was: Create Camel component to integrate with [FHIR|[http://example.com|http://hapifhir.io/doc_rest_server.html]] endpoints. I'll submit a PR) > Create FHIR Camel component with example > > > Key: CAMEL-12625 > URL: https://issues.apache.org/jira/browse/CAMEL-12625 > Project: Camel > Issue Type: New Feature > Components: camel-fhir >Reporter: John Poth >Assignee: John Poth >Priority: Major > Fix For: 2.23.0 > > > Create Camel component to integrate with [FHIR|http://hapifhir.io] endpoints. > I'll submit a PR -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (CAMEL-12680) Fix syntax for micrometer endpoint
[ https://issues.apache.org/jira/browse/CAMEL-12680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Cosentino resolved CAMEL-12680. -- Resolution: Fixed > Fix syntax for micrometer endpoint > -- > > Key: CAMEL-12680 > URL: https://issues.apache.org/jira/browse/CAMEL-12680 > Project: Camel > Issue Type: Bug >Affects Versions: 2.22.0 >Reporter: Aurélien Pupier >Assignee: Andrea Cosentino >Priority: Major > Fix For: 2.22.1, 2.23.0 > > > provided syntax is micrometer:metricsType:meterName but it should be > micrometer:metricsType:metricsName > (the component camel-micrometer is missing) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (CAMEL-12680) Fix syntax for micrometer endpoint
[ https://issues.apache.org/jira/browse/CAMEL-12680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Cosentino updated CAMEL-12680: - Fix Version/s: 2.23.0 2.22.1 > Fix syntax for micrometer endpoint > -- > > Key: CAMEL-12680 > URL: https://issues.apache.org/jira/browse/CAMEL-12680 > Project: Camel > Issue Type: Bug >Affects Versions: 2.22.0 >Reporter: Aurélien Pupier >Assignee: Andrea Cosentino >Priority: Major > Fix For: 2.22.1, 2.23.0 > > > provided syntax is micrometer:metricsType:meterName but it should be > micrometer:metricsType:metricsName > (the component camel-micrometer is missing) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (CAMEL-12680) Fix syntax for micrometer endpoint
[ https://issues.apache.org/jira/browse/CAMEL-12680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Cosentino reassigned CAMEL-12680: Assignee: Andrea Cosentino > Fix syntax for micrometer endpoint > -- > > Key: CAMEL-12680 > URL: https://issues.apache.org/jira/browse/CAMEL-12680 > Project: Camel > Issue Type: Bug >Affects Versions: 2.22.0 >Reporter: Aurélien Pupier >Assignee: Andrea Cosentino >Priority: Major > Fix For: 2.22.1, 2.23.0 > > > provided syntax is micrometer:metricsType:meterName but it should be > micrometer:metricsType:metricsName > (the component camel-micrometer is missing) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12558) camel-catalog - Transacted and Policy should not have outputs
[ https://issues.apache.org/jira/browse/CAMEL-12558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554166#comment-16554166 ] Aurélien Pupier commented on CAMEL-12558: - Can you precise a bit more the reasons why they should not have outputs? They were previously ignored when there was some? > camel-catalog - Transacted and Policy should not have outputs > - > > Key: CAMEL-12558 > URL: https://issues.apache.org/jira/browse/CAMEL-12558 > Project: Camel > Issue Type: Bug > Components: camel-catalog >Affects Versions: 2.21.1 >Reporter: Claus Ibsen >Assignee: Claus Ibsen >Priority: Major > Fix For: 2.21.2, 2.22.0 > > > These 2 eips should not have output: true in the camel-catalog json meta-data. > For Camel 3.0 we will change their base class in the model so they are no > outputs -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (CAMEL-12680) Fix syntax for micrometer endpoint
Aurélien Pupier created CAMEL-12680: --- Summary: Fix syntax for micrometer endpoint Key: CAMEL-12680 URL: https://issues.apache.org/jira/browse/CAMEL-12680 Project: Camel Issue Type: Bug Affects Versions: 2.22.0 Reporter: Aurélien Pupier provided syntax is micrometer:metricsType:meterName but it should be micrometer:metricsType:metricsName (the component camel-micrometer is missing) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (CAMEL-12238) Camel-AWS: Create an IAM component
[ https://issues.apache.org/jira/browse/CAMEL-12238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Cosentino updated CAMEL-12238: - Fix Version/s: (was: Future) 2.23.0 > Camel-AWS: Create an IAM component > -- > > Key: CAMEL-12238 > URL: https://issues.apache.org/jira/browse/CAMEL-12238 > Project: Camel > Issue Type: New Feature > Components: camel-aws >Reporter: Andrea Cosentino >Assignee: Andrea Cosentino >Priority: Major > Fix For: 2.23.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (CAMEL-12238) Camel-AWS: Create an IAM component
[ https://issues.apache.org/jira/browse/CAMEL-12238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Cosentino resolved CAMEL-12238. -- Resolution: Fixed > Camel-AWS: Create an IAM component > -- > > Key: CAMEL-12238 > URL: https://issues.apache.org/jira/browse/CAMEL-12238 > Project: Camel > Issue Type: New Feature > Components: camel-aws >Reporter: Andrea Cosentino >Assignee: Andrea Cosentino >Priority: Major > Fix For: 2.23.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (CAMEL-12679) ensure camel-xmlsecurity can try key directly to decrypt message
[
https://issues.apache.org/jira/browse/CAMEL-12679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Freeman Fang reassigned CAMEL-12679:
Assignee: Freeman Fang
> ensure camel-xmlsecurity can try key directly to decrypt message
>
>
> Key: CAMEL-12679
> URL: https://issues.apache.org/jira/browse/CAMEL-12679
> Project: Camel
> Issue Type: Improvement
>Reporter: Freeman Fang
>Assignee: Freeman Fang
>Priority: Major
>
> If there is no EncryptedKey can be used,try the key directly to decrypt
> message as fallback
> As both message
> {code}
> http://www.w3.org/2001/04/xmlenc#;
> Type="http://www.w3.org/2001/04/xmlenc#Element;> Algorithm="http://www.w3.org/2001/04/xmlenc#tripledes-cbc"/> xmlns:ds="http://www.w3.org/2000/09/xmldsig#;> xmlns:xenc="http://www.w3.org/2001/04/xmlenc#;> Algorithm="http://www.w3.org/2001/04/xmlenc#kw-tripledes"/>/5nDlLI7jrETNrNG/5Nsw3qB9dSnZVwyj5OZZsUvZaHb/8oIayoMeg==yP17O2otQdraY+W42w8i8U/pQQac1g84vWaGWqbS1tgCduFfjhnIz2ZqbFJ6n7Ow1cIeF5HyAoHRGaoDd4gbVw==
> {code}
> {code}
>
>Algorithm="http://www.w3.org/2001/04/xmlenc#tripledes-cbc;>
> 168
>
>
> mykey
>
>
>
> yP17O2otQdraY+W42w8i8U/pQQac1g84vWaGWqbS1tgCduFfjhnIz2ZqbFJ6n7Ow1cIeF5HyAoHRGaoDd4gbVw==
>
>
> {code}
> are valid per the spec.
> Currently camel-xmlsecurity can handle the first case but not the second
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (CAMEL-12679) ensure camel-xmlsecurity can try key directly to decrypt message
Freeman Fang created CAMEL-12679:
Summary: ensure camel-xmlsecurity can try key directly to decrypt
message
Key: CAMEL-12679
URL: https://issues.apache.org/jira/browse/CAMEL-12679
Project: Camel
Issue Type: Improvement
Reporter: Freeman Fang
If there is no EncryptedKey can be used,try the key directly to decrypt message
as fallback
As both message
{code}
http://www.w3.org/2001/04/xmlenc#;
Type="http://www.w3.org/2001/04/xmlenc#Element;>http://www.w3.org/2001/04/xmlenc#tripledes-cbc"/>http://www.w3.org/2000/09/xmldsig#;>http://www.w3.org/2001/04/xmlenc#;>http://www.w3.org/2001/04/xmlenc#kw-tripledes"/>/5nDlLI7jrETNrNG/5Nsw3qB9dSnZVwyj5OZZsUvZaHb/8oIayoMeg==yP17O2otQdraY+W42w8i8U/pQQac1g84vWaGWqbS1tgCduFfjhnIz2ZqbFJ6n7Ow1cIeF5HyAoHRGaoDd4gbVw==
{code}
{code}
http://www.w3.org/2001/04/xmlenc#tripledes-cbc;>
168
mykey
yP17O2otQdraY+W42w8i8U/pQQac1g84vWaGWqbS1tgCduFfjhnIz2ZqbFJ6n7Ow1cIeF5HyAoHRGaoDd4gbVw==
{code}
are valid per the spec.
Currently camel-xmlsecurity can handle the first case but not the second
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (CAMEL-12654) RabbitMQ Headers - Headers with null value are skipped.
[ https://issues.apache.org/jira/browse/CAMEL-12654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Volodin resolved CAMEL-12654. Resolution: Fixed > RabbitMQ Headers - Headers with null value are skipped. > --- > > Key: CAMEL-12654 > URL: https://issues.apache.org/jira/browse/CAMEL-12654 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 2.21.1 >Reporter: Prakhar >Assignee: Dmitry Volodin >Priority: Minor > Labels: headers, rabbitmq > Fix For: 2.22.1, 2.23.0, 2.21.3 > > > Reference: Conversation with Claus Ibsen on > [Stackoverflow|https://stackoverflow.com/questions/50583749/apache-camel-how-to-setheader-value-as-null] > org.apache.camel.component.rabbitmq.RabbitMQMessageConverter.buildProperties() > skips the headers which have value null. The actual java client for RabbitMQ > does not have this check. It accepts a basic Map which can > accept null value. > [Reference|https://rabbitmq.github.io/rabbitmq-java-client/api/current/com/rabbitmq/client/AMQP.BasicProperties.Builder.html] > . Check the definition of headers() method > *The business scenario where we use it*. On the RabbitMQ, we accept messages > from multiple sources. Depending on whether a specific header is null or not, > we route these message downstream in our processing pipeline. > If required, I could provide a working example of rabbitmq java-client to > demonstrate that the headers with null value are not skipped -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (CAMEL-12654) RabbitMQ Headers - Headers with null value are skipped.
[ https://issues.apache.org/jira/browse/CAMEL-12654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Volodin reassigned CAMEL-12654: -- Assignee: Dmitry Volodin > RabbitMQ Headers - Headers with null value are skipped. > --- > > Key: CAMEL-12654 > URL: https://issues.apache.org/jira/browse/CAMEL-12654 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 2.21.1 >Reporter: Prakhar >Assignee: Dmitry Volodin >Priority: Minor > Labels: headers, rabbitmq > Fix For: 2.22.1, 2.23.0, 2.21.3 > > > Reference: Conversation with Claus Ibsen on > [Stackoverflow|https://stackoverflow.com/questions/50583749/apache-camel-how-to-setheader-value-as-null] > org.apache.camel.component.rabbitmq.RabbitMQMessageConverter.buildProperties() > skips the headers which have value null. The actual java client for RabbitMQ > does not have this check. It accepts a basic Map which can > accept null value. > [Reference|https://rabbitmq.github.io/rabbitmq-java-client/api/current/com/rabbitmq/client/AMQP.BasicProperties.Builder.html] > . Check the definition of headers() method > *The business scenario where we use it*. On the RabbitMQ, we accept messages > from multiple sources. Depending on whether a specific header is null or not, > we route these message downstream in our processing pipeline. > If required, I could provide a working example of rabbitmq java-client to > demonstrate that the headers with null value are not skipped -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12668) Aggregate with forcecompleteonstop doesn't seem to be honored
[ https://issues.apache.org/jira/browse/CAMEL-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554086#comment-16554086 ] Dmitry Volodin commented on CAMEL-12668: [~chirag0103] could you check with [came-stream|https://github.com/apache/camel/blob/master/components/camel-stream/src/main/docs/stream-component.adoc] component to isolate problem. It would be nice to have JUnit test project published on github. > Aggregate with forcecompleteonstop doesn't seem to be honored > - > > Key: CAMEL-12668 > URL: https://issues.apache.org/jira/browse/CAMEL-12668 > Project: Camel > Issue Type: Bug > Components: camel-core >Affects Versions: 2.17.0 >Reporter: Chirag Anand >Priority: Major > Fix For: 2.22.0 > > > I have a camel project where I am using twitter component of the camel and > using the streaming/filter endpoint. The route is something like > from().aggregate().completionSize().forceCompletionOnStop().process(). > The problem here is when I stop the context the remaining aggregated > exchanges are not being flushed to the processor. Earlier I was using version > 2.16.2 and it worked fine, but with the latest release i.e 2.22.0 I am facing > this issue. The configuration hasn’t changed a bit. To be certain i tried it > with version 2.17.0 also, doesn't work either. > > I tried debugging and I noticed at somepoint there is a > RejectedExecutionException, not sure why because there is no change in the > configuration. > > Can you please resolve this at the earliest? or at least tell me if there has > been any change in the functionality/usage? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12677) Create FHIR spring boot quickstart
[ https://issues.apache.org/jira/browse/CAMEL-12677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554050#comment-16554050 ] ASF GitHub Bot commented on CAMEL-12677: oscerd commented on issue #2438: CAMEL-12677 Added missing sample output URL: https://github.com/apache/camel/pull/2438#issuecomment-407355609 Thanks @rkorytkowski. Merged on master. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create FHIR spring boot quickstart > -- > > Key: CAMEL-12677 > URL: https://issues.apache.org/jira/browse/CAMEL-12677 > Project: Camel > Issue Type: Task > Components: examples >Reporter: Rafal Korytkowski >Assignee: Andrea Cosentino >Priority: Major > Fix For: 2.23.0 > > > Base the example on > https://github.com/apache/camel/tree/master/examples/camel-example-fhir -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12677) Create FHIR spring boot quickstart
[
https://issues.apache.org/jira/browse/CAMEL-12677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554051#comment-16554051
]
ASF GitHub Bot commented on CAMEL-12677:
oscerd closed pull request #2438: CAMEL-12677 Added missing sample output
URL: https://github.com/apache/camel/pull/2438
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/examples/camel-example-fhir-spring-boot/readme.adoc
b/examples/camel-example-fhir-spring-boot/readme.adoc
index d682d9b68e0..a1b33be1972 100644
--- a/examples/camel-example-fhir-spring-boot/readme.adoc
+++ b/examples/camel-example-fhir-spring-boot/readme.adoc
@@ -36,7 +36,9 @@ $ mvn spring-boot:run
When the Camel application runs, you should see a folder created under
`target/work/fhir/input`. Copy the file `hl7v2.patient`
located in the `src/main/data` folder into it. You should see the following
output:
```
-
+2018-07-24 11:52:51.615 INFO 30666 --- [work/fhir/input] fhir-example:
Converting hl7v2.patient
+2018-07-24 11:52:52.700 INFO 30666 --- [work/fhir/input] fhir-example:
Inserting Patient:
{"resourceType":"Patient","id":"15056","name":[{"family":"Freeman","given":["Vincent"]}]}
+2018-07-24 11:52:56.995 INFO 30666 --- [ #2 - CamelFhir] fhir-example:
Patient created successfully: ca.uhn.fhir.rest.api.MethodOutcome@270f03f1
```
The Camel application can be stopped pressing ctrl+c in
the shell.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Create FHIR spring boot quickstart
> --
>
> Key: CAMEL-12677
> URL: https://issues.apache.org/jira/browse/CAMEL-12677
> Project: Camel
> Issue Type: Task
> Components: examples
>Reporter: Rafal Korytkowski
>Assignee: Andrea Cosentino
>Priority: Major
> Fix For: 2.23.0
>
>
> Base the example on
> https://github.com/apache/camel/tree/master/examples/camel-example-fhir
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CAMEL-12677) Create FHIR spring boot quickstart
[ https://issues.apache.org/jira/browse/CAMEL-12677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554052#comment-16554052 ] ASF GitHub Bot commented on CAMEL-12677: Github user oscerd closed the pull request at: https://github.com/apache/camel/pull/2438 > Create FHIR spring boot quickstart > -- > > Key: CAMEL-12677 > URL: https://issues.apache.org/jira/browse/CAMEL-12677 > Project: Camel > Issue Type: Task > Components: examples >Reporter: Rafal Korytkowski >Assignee: Andrea Cosentino >Priority: Major > Fix For: 2.23.0 > > > Base the example on > https://github.com/apache/camel/tree/master/examples/camel-example-fhir -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12678) Unmarshalling with JAXBContext does not work: JAXB 2.3.0.1 in camel-spring-boot 2.22.0
[
https://issues.apache.org/jira/browse/CAMEL-12678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554037#comment-16554037
]
Zoran Regvart commented on CAMEL-12678:
---
[~marvinstorage] is the {{ErrorHandler}} class in a package other than
{{org.apache.camel.model}}? If so I think you need to explain to the JAXB
implementation that the two packages belong to the same XML namespace. That is,
in it's package create a {{package-info.java}} with content:
{code:java}
@javax.xml.bind.annotation.XmlSchema(namespace =
"http://camel.apache.org/schema/spring;, elementFormDefault =
javax.xml.bind.annotation.XmlNsForm.QUALIFIED)
package where.error.handler.is;
{code}
I wonder why not just use the
{{org.apache.camel.spring.ErrorHandlerDefinition}} class instead of this custom
{{ErrorHandler}} class?
> Unmarshalling with JAXBContext does not work: JAXB 2.3.0.1 in
> camel-spring-boot 2.22.0
> --
>
> Key: CAMEL-12678
> URL: https://issues.apache.org/jira/browse/CAMEL-12678
> Project: Camel
> Issue Type: Bug
> Components: camel-spring-boot
>Affects Versions: 2.22.0
>Reporter: storage
>Assignee: Zoran Regvart
>Priority: Minor
>
> * camel-spring-boot-starter 2.22.0
> ** camel-spring-boot 2.22.0
> *** jaxb-core 2.3.0.1
> *** jaxb-impl 2.3.0.1
> In some code we have we use JAXB to unmarschall some XML to a POJO class we
> have containing a RedeliveryPolicyDefinition as a property.
> This seems to fail without errors and the property remains null.
> When we replace _*jaxb-core*_ and _*jaxb-impl*_ version *2.3.0.1* to
> *2.2.11* the code seems to work again.
> Unmarshalling code:
> {code:java}
> JAXBContext ctx = JAXBContext.newInstance(ErrorHandler.class);
> JAXBElement errorHandler =
> ctx.createUnmarshaller().unmarshal(beanList.item(i), ErrorHandler.class);
> {code}
> Pojo:
> {code:java}
> @Getter
> @Setter
> @XmlRootElement(name = "errorHandler", namespace =
> "http://camel.apache.org/schema/spring;)
> @XmlAccessorType(XmlAccessType.FIELD)
> public class ErrorHandler {
> @XmlAttribute
> private String id;
> @XmlElement
> private RedeliveryPolicyDefinition redeliveryPolicy;
> @XmlAttribute
> private org.apache.camel.spring.ErrorHandlerType type;
> {code}
> XML:
> {code:xml}
>
> http://camel.apache.org/schema/spring; id="eh-http"
> type="DefaultErrorHandler">
> backOffMultiplier="2" useExponentialBackOff="true"/>
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CAMEL-12677) Create FHIR spring boot quickstart
[ https://issues.apache.org/jira/browse/CAMEL-12677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554028#comment-16554028 ] ASF GitHub Bot commented on CAMEL-12677: rkorytkowski opened a new pull request #2438: CAMEL-12677 Added missing sample output URL: https://github.com/apache/camel/pull/2438 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create FHIR spring boot quickstart > -- > > Key: CAMEL-12677 > URL: https://issues.apache.org/jira/browse/CAMEL-12677 > Project: Camel > Issue Type: Task > Components: examples >Reporter: Rafal Korytkowski >Assignee: Andrea Cosentino >Priority: Major > Fix For: 2.23.0 > > > Base the example on > https://github.com/apache/camel/tree/master/examples/camel-example-fhir -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12677) Create FHIR spring boot quickstart
[ https://issues.apache.org/jira/browse/CAMEL-12677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554029#comment-16554029 ] ASF GitHub Bot commented on CAMEL-12677: GitHub user rkorytkowski opened a pull request: https://github.com/apache/camel/pull/2438 CAMEL-12677 Added missing sample output You can merge this pull request into a Git repository by running: $ git pull https://github.com/rkorytkowski/camel CAMEL-12677 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/camel/pull/2438.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2438 commit 8ad2cd1ee36fcc900e3281f5119d3cc8a4d03ad4 Author: Rafal Korytkowski Date: 2018-07-24T09:54:38Z CAMEL-12677 Added missing sample output > Create FHIR spring boot quickstart > -- > > Key: CAMEL-12677 > URL: https://issues.apache.org/jira/browse/CAMEL-12677 > Project: Camel > Issue Type: Task > Components: examples >Reporter: Rafal Korytkowski >Assignee: Andrea Cosentino >Priority: Major > Fix For: 2.23.0 > > > Base the example on > https://github.com/apache/camel/tree/master/examples/camel-example-fhir -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12668) Aggregate with forcecompleteonstop doesn't seem to be honored
[
https://issues.apache.org/jira/browse/CAMEL-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554012#comment-16554012
]
Chirag Anand commented on CAMEL-12668:
--
Hi [~dmvolod], Thank you for responding. I tried the same thing using file
component and it seemed to work fine but doesn't work when using the twitter
component. I am testing this with Camel version 2.17.0.
The route that i am using for twitter component is as such -
public class CamelRoute extends RouteBuilder {
@Override
public void configure() throws Exception {
from("twitter://streaming/filter?accessToken=xxx=xxx=xxx=xxx=XYZ=event")
.aggregate(constant(true), new
CamelAggregator()).completionSize(50)
.forceCompletionOnStop().process(new Processor() {
@Override
public void process(Exchange exchange) throws Exception {
List statusObjects =
exchange.getIn().getBody(List.class);
System.out.println(statusObjects.size());
}
}).end();
}
}
The custom aggregation logic is as such -
public class CamelAggregator implements AggregationStrategy {
@Override
public Exchange aggregate(Exchange oldExchange, Exchange newExchange) {
Object newBody = newExchange.getIn().getBody(Object.class);
List list = null;
if (oldExchange == null) {
list = new ArrayList<>();
list.add(newBody);
newExchange.getIn().setBody(list);
return newExchange;
} else {
list = oldExchange.getIn().getBody(ArrayList.class);
list.add(newBody);
return oldExchange;
}
}
}
The route which succeeded for the file component is as such -
public class CamelFileRoute extends RouteBuilder {
@Override
public void configure() throws Exception {
from("file://C:/Test")
.aggregate(constant(true), new CamelAggregator()).completionSize(50)
.forceCompletionOnStop().process(new Processor() {
@Override
public void process(Exchange exchange) throws Exception {
List statusObjects =
exchange.getIn().getBody(List.class);
System.out.println(statusObjects.size());
}
}).end();
}
}
Please tell me if i am making any mistake here or if there is any problem with
the twitter component only?
> Aggregate with forcecompleteonstop doesn't seem to be honored
> -
>
> Key: CAMEL-12668
> URL: https://issues.apache.org/jira/browse/CAMEL-12668
> Project: Camel
> Issue Type: Bug
> Components: camel-core
>Affects Versions: 2.17.0
>Reporter: Chirag Anand
>Priority: Major
> Fix For: 2.22.0
>
>
> I have a camel project where I am using twitter component of the camel and
> using the streaming/filter endpoint. The route is something like
> from().aggregate().completionSize().forceCompletionOnStop().process().
> The problem here is when I stop the context the remaining aggregated
> exchanges are not being flushed to the processor. Earlier I was using version
> 2.16.2 and it worked fine, but with the latest release i.e 2.22.0 I am facing
> this issue. The configuration hasn’t changed a bit. To be certain i tried it
> with version 2.17.0 also, doesn't work either.
>
> I tried debugging and I noticed at somepoint there is a
> RejectedExecutionException, not sure why because there is no change in the
> configuration.
>
> Can you please resolve this at the earliest? or at least tell me if there has
> been any change in the functionality/usage?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CAMEL-12654) RabbitMQ Headers - Headers with null value are skipped.
[ https://issues.apache.org/jira/browse/CAMEL-12654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553983#comment-16553983 ] Dmitry Volodin commented on CAMEL-12654: [~Srivastav], I will backport this feature to the 2.22.1 and 2.21.3 versions. To be able pass null values to the headers the allowNullHeaders endpoint and component parameters were introduced. Please see following test file as sample config [RabbitMQProducerIntTest.java|https://github.com/apache/camel/commit/fddedbc44de60ccc214c0c40be420dad7e1d13da#diff-24dcd05dc15db65884aaba68ed79880b] > RabbitMQ Headers - Headers with null value are skipped. > --- > > Key: CAMEL-12654 > URL: https://issues.apache.org/jira/browse/CAMEL-12654 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 2.21.1 >Reporter: Prakhar >Priority: Minor > Labels: headers, rabbitmq > Fix For: 2.22.1, 2.23.0, 2.21.3 > > > Reference: Conversation with Claus Ibsen on > [Stackoverflow|https://stackoverflow.com/questions/50583749/apache-camel-how-to-setheader-value-as-null] > org.apache.camel.component.rabbitmq.RabbitMQMessageConverter.buildProperties() > skips the headers which have value null. The actual java client for RabbitMQ > does not have this check. It accepts a basic Map which can > accept null value. > [Reference|https://rabbitmq.github.io/rabbitmq-java-client/api/current/com/rabbitmq/client/AMQP.BasicProperties.Builder.html] > . Check the definition of headers() method > *The business scenario where we use it*. On the RabbitMQ, we accept messages > from multiple sources. Depending on whether a specific header is null or not, > we route these message downstream in our processing pipeline. > If required, I could provide a working example of rabbitmq java-client to > demonstrate that the headers with null value are not skipped -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (CAMEL-12654) RabbitMQ Headers - Headers with null value are skipped.
[ https://issues.apache.org/jira/browse/CAMEL-12654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Volodin updated CAMEL-12654: --- Fix Version/s: 2.21.3 > RabbitMQ Headers - Headers with null value are skipped. > --- > > Key: CAMEL-12654 > URL: https://issues.apache.org/jira/browse/CAMEL-12654 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 2.21.1 >Reporter: Prakhar >Priority: Minor > Labels: headers, rabbitmq > Fix For: 2.22.1, 2.23.0, 2.21.3 > > > Reference: Conversation with Claus Ibsen on > [Stackoverflow|https://stackoverflow.com/questions/50583749/apache-camel-how-to-setheader-value-as-null] > org.apache.camel.component.rabbitmq.RabbitMQMessageConverter.buildProperties() > skips the headers which have value null. The actual java client for RabbitMQ > does not have this check. It accepts a basic Map which can > accept null value. > [Reference|https://rabbitmq.github.io/rabbitmq-java-client/api/current/com/rabbitmq/client/AMQP.BasicProperties.Builder.html] > . Check the definition of headers() method > *The business scenario where we use it*. On the RabbitMQ, we accept messages > from multiple sources. Depending on whether a specific header is null or not, > we route these message downstream in our processing pipeline. > If required, I could provide a working example of rabbitmq java-client to > demonstrate that the headers with null value are not skipped -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (CAMEL-12654) RabbitMQ Headers - Headers with null value are skipped.
[ https://issues.apache.org/jira/browse/CAMEL-12654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Volodin updated CAMEL-12654: --- Fix Version/s: 2.23.0 2.22.1 > RabbitMQ Headers - Headers with null value are skipped. > --- > > Key: CAMEL-12654 > URL: https://issues.apache.org/jira/browse/CAMEL-12654 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 2.21.1 >Reporter: Prakhar >Priority: Minor > Labels: headers, rabbitmq > Fix For: 2.22.1, 2.23.0 > > > Reference: Conversation with Claus Ibsen on > [Stackoverflow|https://stackoverflow.com/questions/50583749/apache-camel-how-to-setheader-value-as-null] > org.apache.camel.component.rabbitmq.RabbitMQMessageConverter.buildProperties() > skips the headers which have value null. The actual java client for RabbitMQ > does not have this check. It accepts a basic Map which can > accept null value. > [Reference|https://rabbitmq.github.io/rabbitmq-java-client/api/current/com/rabbitmq/client/AMQP.BasicProperties.Builder.html] > . Check the definition of headers() method > *The business scenario where we use it*. On the RabbitMQ, we accept messages > from multiple sources. Depending on whether a specific header is null or not, > we route these message downstream in our processing pipeline. > If required, I could provide a working example of rabbitmq java-client to > demonstrate that the headers with null value are not skipped -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12654) RabbitMQ Headers - Headers with null value are skipped.
[ https://issues.apache.org/jira/browse/CAMEL-12654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553976#comment-16553976 ] Prakhar commented on CAMEL-12654: - [~dmvolod]. Amazing work. Few questions? * These updates would be available for which camel versions? * Could you please provide quick steps on how to use this feature. I will update the original question on StackOverflow. > RabbitMQ Headers - Headers with null value are skipped. > --- > > Key: CAMEL-12654 > URL: https://issues.apache.org/jira/browse/CAMEL-12654 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 2.21.1 >Reporter: Prakhar >Priority: Minor > Labels: headers, rabbitmq > > Reference: Conversation with Claus Ibsen on > [Stackoverflow|https://stackoverflow.com/questions/50583749/apache-camel-how-to-setheader-value-as-null] > org.apache.camel.component.rabbitmq.RabbitMQMessageConverter.buildProperties() > skips the headers which have value null. The actual java client for RabbitMQ > does not have this check. It accepts a basic Map which can > accept null value. > [Reference|https://rabbitmq.github.io/rabbitmq-java-client/api/current/com/rabbitmq/client/AMQP.BasicProperties.Builder.html] > . Check the definition of headers() method > *The business scenario where we use it*. On the RabbitMQ, we accept messages > from multiple sources. Depending on whether a specific header is null or not, > we route these message downstream in our processing pipeline. > If required, I could provide a working example of rabbitmq java-client to > demonstrate that the headers with null value are not skipped -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12654) RabbitMQ Headers - Headers with null value are skipped.
[ https://issues.apache.org/jira/browse/CAMEL-12654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553955#comment-16553955 ] ASF GitHub Bot commented on CAMEL-12654: asfgit closed pull request #2436: CAMEL-12654: RabbitMQ Headers - Headers with null value are skipped URL: https://github.com/apache/camel/pull/2436 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/components/camel-rabbitmq/src/main/docs/rabbitmq-component.adoc b/components/camel-rabbitmq/src/main/docs/rabbitmq-component.adoc index e6e330c384e..823f22b7fbc 100644 --- a/components/camel-rabbitmq/src/main/docs/rabbitmq-component.adoc +++ b/components/camel-rabbitmq/src/main/docs/rabbitmq-component.adoc @@ -47,14 +47,14 @@ exchange name determines which exchange the queue will bind to. === Options // component options: START -The RabbitMQ component supports 49 options, which are listed below. +The RabbitMQ component supports 50 options, which are listed below. [width="100%",cols="2,5,^1,2",options="header"] |=== | Name | Description | Default | Type -| *hostname* (common) | The hostname of the running rabbitmq instance or cluster. | | String +| *hostname* (common) | The hostname of the running RabbitMQ instance or cluster. | | String | *portNumber* (common) | Port number for the host with the running rabbitmq instance or cluster. | 5672 | int | *username* (security) | Username in case of authenticated access | guest | String | *password* (security) | Password for authenticated access | guest | String @@ -102,6 +102,7 @@ The RabbitMQ component supports 49 options, which are listed below. | *deadLetterQueue* (common) | The name of the dead letter queue | | String | *deadLetterRoutingKey* (common) | The routing key for the dead letter exchange | | String | *deadLetterExchangeType* (common) | The type of the dead letter exchange | direct | String +| *allowNullHeaders* (producer) | Allow pass null values to header | false | boolean | *resolveProperty Placeholders* (advanced) | Whether the component should resolve property placeholders on itself when starting. Only properties which are of String type can use property placeholders. | true | boolean |=== // component options: END @@ -126,7 +127,7 @@ with the following path and query parameters: |=== - Query Parameters (61 parameters): + Query Parameters (62 parameters): [width="100%",cols="2,5,^1,2",options="header"] @@ -163,6 +164,7 @@ with the following path and query parameters: | *exceptionHandler* (consumer) | To let the consumer use a custom ExceptionHandler. Notice if the option bridgeErrorHandler is enabled then this options is not in use. By default the consumer will deal with exceptions, that will be logged at WARN or ERROR level and ignored. | | ExceptionHandler | *exchangePattern* (consumer) | Sets the exchange pattern when the consumer creates an exchange. | | ExchangePattern | *threadPoolSize* (consumer) | The consumer uses a Thread Pool Executor with a fixed number of threads. This setting allows you to set that number of threads. | 10 | int +| *allowNullHeaders* (producer) | Allow pass null values to header | false | boolean | *bridgeEndpoint* (producer) | If the bridgeEndpoint is true, the producer will ignore the message header of rabbitmq.EXCHANGE_NAME and rabbitmq.ROUTING_KEY | false | boolean | *channelPoolMaxSize* (producer) | Get maximum number of opened channel in pool | 10 | int | *channelPoolMaxWait* (producer) | Set the maximum number of milliseconds to wait for a channel from the pool | 1000 | long diff --git a/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitMQComponent.java b/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitMQComponent.java index 96c1ac8dfac..69a3e8ac34d 100644 --- a/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitMQComponent.java +++ b/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitMQComponent.java @@ -81,6 +81,8 @@ private String deadLetterQueue; @Metadata(label = "common", defaultValue = "direct", enums = "direct,fanout,headers,topic") private String deadLetterExchangeType = "direct"; +@Metadata(label = "producer") +private boolean allowNullHeaders; @Metadata(label = "security") private String sslProtocol; @Metadata(label = "security") @@ -241,6 +243,7 @@ protected RabbitMQEndpoint createEndpoint(String uri, endpoint.setDeadLetterExchangeType(getDeadLetterExchangeType()); endpoint.setDeadLetterQueue(getDeadLetterQueue());
[jira] [Commented] (CAMEL-12654) RabbitMQ Headers - Headers with null value are skipped.
[ https://issues.apache.org/jira/browse/CAMEL-12654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553956#comment-16553956 ] ASF GitHub Bot commented on CAMEL-12654: Github user asfgit closed the pull request at: https://github.com/apache/camel/pull/2436 > RabbitMQ Headers - Headers with null value are skipped. > --- > > Key: CAMEL-12654 > URL: https://issues.apache.org/jira/browse/CAMEL-12654 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 2.21.1 >Reporter: Prakhar >Priority: Minor > Labels: headers, rabbitmq > > Reference: Conversation with Claus Ibsen on > [Stackoverflow|https://stackoverflow.com/questions/50583749/apache-camel-how-to-setheader-value-as-null] > org.apache.camel.component.rabbitmq.RabbitMQMessageConverter.buildProperties() > skips the headers which have value null. The actual java client for RabbitMQ > does not have this check. It accepts a basic Map which can > accept null value. > [Reference|https://rabbitmq.github.io/rabbitmq-java-client/api/current/com/rabbitmq/client/AMQP.BasicProperties.Builder.html] > . Check the definition of headers() method > *The business scenario where we use it*. On the RabbitMQ, we accept messages > from multiple sources. Depending on whether a specific header is null or not, > we route these message downstream in our processing pipeline. > If required, I could provide a working example of rabbitmq java-client to > demonstrate that the headers with null value are not skipped -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12668) Aggregate with forcecompleteonstop doesn't seem to be honored
[ https://issues.apache.org/jira/browse/CAMEL-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553953#comment-16553953 ] Dmitry Volodin commented on CAMEL-12668: [~chirag0103], please provide a simple unit test. Without twitter source it could be fine. > Aggregate with forcecompleteonstop doesn't seem to be honored > - > > Key: CAMEL-12668 > URL: https://issues.apache.org/jira/browse/CAMEL-12668 > Project: Camel > Issue Type: Bug > Components: camel-core >Affects Versions: 2.17.0 >Reporter: Chirag Anand >Priority: Major > Fix For: 2.22.0 > > > I have a camel project where I am using twitter component of the camel and > using the streaming/filter endpoint. The route is something like > from().aggregate().completionSize().forceCompletionOnStop().process(). > The problem here is when I stop the context the remaining aggregated > exchanges are not being flushed to the processor. Earlier I was using version > 2.16.2 and it worked fine, but with the latest release i.e 2.22.0 I am facing > this issue. The configuration hasn’t changed a bit. To be certain i tried it > with version 2.17.0 also, doesn't work either. > > I tried debugging and I noticed at somepoint there is a > RejectedExecutionException, not sure why because there is no change in the > configuration. > > Can you please resolve this at the earliest? or at least tell me if there has > been any change in the functionality/usage? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12654) RabbitMQ Headers - Headers with null value are skipped.
[ https://issues.apache.org/jira/browse/CAMEL-12654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553951#comment-16553951 ] ASF GitHub Bot commented on CAMEL-12654: dmvolod commented on issue #2436: CAMEL-12654: RabbitMQ Headers - Headers with null value are skipped URL: https://github.com/apache/camel/pull/2436#issuecomment-407323263 @oscerd , thanks. Will do it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > RabbitMQ Headers - Headers with null value are skipped. > --- > > Key: CAMEL-12654 > URL: https://issues.apache.org/jira/browse/CAMEL-12654 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 2.21.1 >Reporter: Prakhar >Priority: Minor > Labels: headers, rabbitmq > > Reference: Conversation with Claus Ibsen on > [Stackoverflow|https://stackoverflow.com/questions/50583749/apache-camel-how-to-setheader-value-as-null] > org.apache.camel.component.rabbitmq.RabbitMQMessageConverter.buildProperties() > skips the headers which have value null. The actual java client for RabbitMQ > does not have this check. It accepts a basic Map which can > accept null value. > [Reference|https://rabbitmq.github.io/rabbitmq-java-client/api/current/com/rabbitmq/client/AMQP.BasicProperties.Builder.html] > . Check the definition of headers() method > *The business scenario where we use it*. On the RabbitMQ, we accept messages > from multiple sources. Depending on whether a specific header is null or not, > we route these message downstream in our processing pipeline. > If required, I could provide a working example of rabbitmq java-client to > demonstrate that the headers with null value are not skipped -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12654) RabbitMQ Headers - Headers with null value are skipped.
[ https://issues.apache.org/jira/browse/CAMEL-12654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553950#comment-16553950 ] ASF GitHub Bot commented on CAMEL-12654: oscerd commented on issue #2436: CAMEL-12654: RabbitMQ Headers - Headers with null value are skipped URL: https://github.com/apache/camel/pull/2436#issuecomment-407322949 Should be fine if the behavior doesn't change it would be good. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > RabbitMQ Headers - Headers with null value are skipped. > --- > > Key: CAMEL-12654 > URL: https://issues.apache.org/jira/browse/CAMEL-12654 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 2.21.1 >Reporter: Prakhar >Priority: Minor > Labels: headers, rabbitmq > > Reference: Conversation with Claus Ibsen on > [Stackoverflow|https://stackoverflow.com/questions/50583749/apache-camel-how-to-setheader-value-as-null] > org.apache.camel.component.rabbitmq.RabbitMQMessageConverter.buildProperties() > skips the headers which have value null. The actual java client for RabbitMQ > does not have this check. It accepts a basic Map which can > accept null value. > [Reference|https://rabbitmq.github.io/rabbitmq-java-client/api/current/com/rabbitmq/client/AMQP.BasicProperties.Builder.html] > . Check the definition of headers() method > *The business scenario where we use it*. On the RabbitMQ, we accept messages > from multiple sources. Depending on whether a specific header is null or not, > we route these message downstream in our processing pipeline. > If required, I could provide a working example of rabbitmq java-client to > demonstrate that the headers with null value are not skipped -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12654) RabbitMQ Headers - Headers with null value are skipped.
[ https://issues.apache.org/jira/browse/CAMEL-12654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553948#comment-16553948 ] ASF GitHub Bot commented on CAMEL-12654: dmvolod commented on issue #2436: CAMEL-12654: RabbitMQ Headers - Headers with null value are skipped URL: https://github.com/apache/camel/pull/2436#issuecomment-407321828 @oscerd what do you think about backport this component to 2.21 and 2.22. I've added a new option but it doesn't change the default behaviour? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > RabbitMQ Headers - Headers with null value are skipped. > --- > > Key: CAMEL-12654 > URL: https://issues.apache.org/jira/browse/CAMEL-12654 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 2.21.1 >Reporter: Prakhar >Priority: Minor > Labels: headers, rabbitmq > > Reference: Conversation with Claus Ibsen on > [Stackoverflow|https://stackoverflow.com/questions/50583749/apache-camel-how-to-setheader-value-as-null] > org.apache.camel.component.rabbitmq.RabbitMQMessageConverter.buildProperties() > skips the headers which have value null. The actual java client for RabbitMQ > does not have this check. It accepts a basic Map which can > accept null value. > [Reference|https://rabbitmq.github.io/rabbitmq-java-client/api/current/com/rabbitmq/client/AMQP.BasicProperties.Builder.html] > . Check the definition of headers() method > *The business scenario where we use it*. On the RabbitMQ, we accept messages > from multiple sources. Depending on whether a specific header is null or not, > we route these message downstream in our processing pipeline. > If required, I could provide a working example of rabbitmq java-client to > demonstrate that the headers with null value are not skipped -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12654) RabbitMQ Headers - Headers with null value are skipped.
[ https://issues.apache.org/jira/browse/CAMEL-12654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553944#comment-16553944 ] ASF GitHub Bot commented on CAMEL-12654: GitHub user dmvolod opened a pull request: https://github.com/apache/camel/pull/2436 CAMEL-12654: RabbitMQ Headers - Headers with null value are skipped You can merge this pull request into a Git repository by running: $ git pull https://github.com/dmvolod/camel CAMEL-12654 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/camel/pull/2436.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2436 commit fddedbc44de60ccc214c0c40be420dad7e1d13da Author: Dmitry Volodin Date: 2018-07-24T08:08:45Z CAMEL-12654: RabbitMQ Headers - Headers with null value are skipped > RabbitMQ Headers - Headers with null value are skipped. > --- > > Key: CAMEL-12654 > URL: https://issues.apache.org/jira/browse/CAMEL-12654 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 2.21.1 >Reporter: Prakhar >Priority: Minor > Labels: headers, rabbitmq > > Reference: Conversation with Claus Ibsen on > [Stackoverflow|https://stackoverflow.com/questions/50583749/apache-camel-how-to-setheader-value-as-null] > org.apache.camel.component.rabbitmq.RabbitMQMessageConverter.buildProperties() > skips the headers which have value null. The actual java client for RabbitMQ > does not have this check. It accepts a basic Map which can > accept null value. > [Reference|https://rabbitmq.github.io/rabbitmq-java-client/api/current/com/rabbitmq/client/AMQP.BasicProperties.Builder.html] > . Check the definition of headers() method > *The business scenario where we use it*. On the RabbitMQ, we accept messages > from multiple sources. Depending on whether a specific header is null or not, > we route these message downstream in our processing pipeline. > If required, I could provide a working example of rabbitmq java-client to > demonstrate that the headers with null value are not skipped -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12654) RabbitMQ Headers - Headers with null value are skipped.
[ https://issues.apache.org/jira/browse/CAMEL-12654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553943#comment-16553943 ] ASF GitHub Bot commented on CAMEL-12654: dmvolod opened a new pull request #2436: CAMEL-12654: RabbitMQ Headers - Headers with null value are skipped URL: https://github.com/apache/camel/pull/2436 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > RabbitMQ Headers - Headers with null value are skipped. > --- > > Key: CAMEL-12654 > URL: https://issues.apache.org/jira/browse/CAMEL-12654 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 2.21.1 >Reporter: Prakhar >Priority: Minor > Labels: headers, rabbitmq > > Reference: Conversation with Claus Ibsen on > [Stackoverflow|https://stackoverflow.com/questions/50583749/apache-camel-how-to-setheader-value-as-null] > org.apache.camel.component.rabbitmq.RabbitMQMessageConverter.buildProperties() > skips the headers which have value null. The actual java client for RabbitMQ > does not have this check. It accepts a basic Map which can > accept null value. > [Reference|https://rabbitmq.github.io/rabbitmq-java-client/api/current/com/rabbitmq/client/AMQP.BasicProperties.Builder.html] > . Check the definition of headers() method > *The business scenario where we use it*. On the RabbitMQ, we accept messages > from multiple sources. Depending on whether a specific header is null or not, > we route these message downstream in our processing pipeline. > If required, I could provide a working example of rabbitmq java-client to > demonstrate that the headers with null value are not skipped -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work started] (CAMEL-12678) Unmarshalling with JAXBContext does not work: JAXB 2.3.0.1 in camel-spring-boot 2.22.0
[
https://issues.apache.org/jira/browse/CAMEL-12678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on CAMEL-12678 started by Zoran Regvart.
-
> Unmarshalling with JAXBContext does not work: JAXB 2.3.0.1 in
> camel-spring-boot 2.22.0
> --
>
> Key: CAMEL-12678
> URL: https://issues.apache.org/jira/browse/CAMEL-12678
> Project: Camel
> Issue Type: Bug
> Components: camel-spring-boot
>Affects Versions: 2.22.0
>Reporter: storage
>Assignee: Zoran Regvart
>Priority: Minor
>
> * camel-spring-boot-starter 2.22.0
> ** camel-spring-boot 2.22.0
> *** jaxb-core 2.3.0.1
> *** jaxb-impl 2.3.0.1
> In some code we have we use JAXB to unmarschall some XML to a POJO class we
> have containing a RedeliveryPolicyDefinition as a property.
> This seems to fail without errors and the property remains null.
> When we replace _*jaxb-core*_ and _*jaxb-impl*_ version *2.3.0.1* to
> *2.2.11* the code seems to work again.
> Unmarshalling code:
> {code:java}
> JAXBContext ctx = JAXBContext.newInstance(ErrorHandler.class);
> JAXBElement errorHandler =
> ctx.createUnmarshaller().unmarshal(beanList.item(i), ErrorHandler.class);
> {code}
> Pojo:
> {code:java}
> @Getter
> @Setter
> @XmlRootElement(name = "errorHandler", namespace =
> "http://camel.apache.org/schema/spring;)
> @XmlAccessorType(XmlAccessType.FIELD)
> public class ErrorHandler {
> @XmlAttribute
> private String id;
> @XmlElement
> private RedeliveryPolicyDefinition redeliveryPolicy;
> @XmlAttribute
> private org.apache.camel.spring.ErrorHandlerType type;
> {code}
> XML:
> {code:xml}
>
> http://camel.apache.org/schema/spring; id="eh-http"
> type="DefaultErrorHandler">
> backOffMultiplier="2" useExponentialBackOff="true"/>
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (CAMEL-12678) Unmarshalling with JAXBContext does not work: JAXB 2.3.0.1 in camel-spring-boot 2.22.0
[
https://issues.apache.org/jira/browse/CAMEL-12678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zoran Regvart reassigned CAMEL-12678:
-
Assignee: Zoran Regvart
> Unmarshalling with JAXBContext does not work: JAXB 2.3.0.1 in
> camel-spring-boot 2.22.0
> --
>
> Key: CAMEL-12678
> URL: https://issues.apache.org/jira/browse/CAMEL-12678
> Project: Camel
> Issue Type: Bug
> Components: camel-spring-boot
>Affects Versions: 2.22.0
>Reporter: storage
>Assignee: Zoran Regvart
>Priority: Minor
>
> * camel-spring-boot-starter 2.22.0
> ** camel-spring-boot 2.22.0
> *** jaxb-core 2.3.0.1
> *** jaxb-impl 2.3.0.1
> In some code we have we use JAXB to unmarschall some XML to a POJO class we
> have containing a RedeliveryPolicyDefinition as a property.
> This seems to fail without errors and the property remains null.
> When we replace _*jaxb-core*_ and _*jaxb-impl*_ version *2.3.0.1* to
> *2.2.11* the code seems to work again.
> Unmarshalling code:
> {code:java}
> JAXBContext ctx = JAXBContext.newInstance(ErrorHandler.class);
> JAXBElement errorHandler =
> ctx.createUnmarshaller().unmarshal(beanList.item(i), ErrorHandler.class);
> {code}
> Pojo:
> {code:java}
> @Getter
> @Setter
> @XmlRootElement(name = "errorHandler", namespace =
> "http://camel.apache.org/schema/spring;)
> @XmlAccessorType(XmlAccessType.FIELD)
> public class ErrorHandler {
> @XmlAttribute
> private String id;
> @XmlElement
> private RedeliveryPolicyDefinition redeliveryPolicy;
> @XmlAttribute
> private org.apache.camel.spring.ErrorHandlerType type;
> {code}
> XML:
> {code:xml}
>
> http://camel.apache.org/schema/spring; id="eh-http"
> type="DefaultErrorHandler">
> backOffMultiplier="2" useExponentialBackOff="true"/>
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (CAMEL-12678) Unmarshalling with JAXBContext does not work: JAXB 2.3.0.1 in camel-spring-boot 2.22.0
storage created CAMEL-12678:
---
Summary: Unmarshalling with JAXBContext does not work: JAXB
2.3.0.1 in camel-spring-boot 2.22.0
Key: CAMEL-12678
URL: https://issues.apache.org/jira/browse/CAMEL-12678
Project: Camel
Issue Type: Bug
Components: camel-spring-boot
Affects Versions: 2.22.0
Reporter: storage
* camel-spring-boot-starter 2.22.0
** camel-spring-boot 2.22.0
*** jaxb-core 2.3.0.1
*** jaxb-impl 2.3.0.1
In some code we have we use JAXB to unmarschall some XML to a POJO class we
have containing a RedeliveryPolicyDefinition as a property.
This seems to fail without errors and the property remains null.
When we replace _*jaxb-core*_ and _*jaxb-impl*_ version *2.3.0.1* to *2.2.11*
the code seems to work again.
Unmarshalling code:
{code:java}
JAXBContext ctx = JAXBContext.newInstance(ErrorHandler.class);
JAXBElement errorHandler =
ctx.createUnmarshaller().unmarshal(beanList.item(i), ErrorHandler.class);
{code}
Pojo:
{code:java}
@Getter
@Setter
@XmlRootElement(name = "errorHandler", namespace =
"http://camel.apache.org/schema/spring;)
@XmlAccessorType(XmlAccessType.FIELD)
public class ErrorHandler {
@XmlAttribute
private String id;
@XmlElement
private RedeliveryPolicyDefinition redeliveryPolicy;
@XmlAttribute
private org.apache.camel.spring.ErrorHandlerType type;
{code}
XML:
{code:xml}
http://camel.apache.org/schema/spring; id="eh-http"
type="DefaultErrorHandler">
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CAMEL-12642) No support for http4 feature authenticationPreemptive in pollEnrich
[
https://issues.apache.org/jira/browse/CAMEL-12642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553868#comment-16553868
]
Frank Olschewski commented on CAMEL-12642:
--
Thanks a lot for the implementation, I'm looking forward to using the feature.
> No support for http4 feature authenticationPreemptive in pollEnrich
> ---
>
> Key: CAMEL-12642
> URL: https://issues.apache.org/jira/browse/CAMEL-12642
> Project: Camel
> Issue Type: New Feature
> Components: camel-http4
>Affects Versions: 2.23.0
>Reporter: Frank Olschewski
>Assignee: Ramu
>Priority: Major
> Fix For: 2.23.0
>
>
> authenticationPreemptive=true does not work with pollEnrich.
> {code:java}
> .pollEnrich("https4:localhost?authenticationPreemptive=true" +
>"=user=passwd"){code}
> In Class /org/apache/camel/component/http4/HttpPollingConsumer.java:79 you
> see the following code:
> {code:java}
> HttpResponse response = httpClient.execute(method, httpClientContext);{code}
> The setup for authenticationPreemptive is missing.
> You can see what to do in
> org.apache.camel.component.http4.HttpProducer#executeMethod:
> {code:java}
> pprotected HttpResponse executeMethod(HttpUriRequest httpRequest) throws
> IOException {
> HttpContext localContext = new BasicHttpContext();
> if (getEndpoint().isAuthenticationPreemptive()) {
> BasicScheme basicAuth = new BasicScheme();
> localContext.setAttribute("preemptive-auth", basicAuth);
> }
> if (httpContext != null) {
> localContext = new BasicHttpContext(httpContext);
> }
> return httpClient.execute(httpRequest, localContext);
> }{code}
> In org.apache.camel.component.http4.HttpPollingConsumer#doReceive
> getEndpoint().isAuthenticationPreemptive() returns the correct value, so
> there is nothing against implementing this feature here as well.
> The problem behind the scene ist that the context attribute "preemptive-auth"
> is missing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (CAMEL-12677) Create FHIR spring boot quickstart
[ https://issues.apache.org/jira/browse/CAMEL-12677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Cosentino resolved CAMEL-12677. -- Resolution: Fixed > Create FHIR spring boot quickstart > -- > > Key: CAMEL-12677 > URL: https://issues.apache.org/jira/browse/CAMEL-12677 > Project: Camel > Issue Type: Task > Components: examples >Reporter: Rafal Korytkowski >Assignee: Andrea Cosentino >Priority: Major > Fix For: 2.23.0 > > > Base the example on > https://github.com/apache/camel/tree/master/examples/camel-example-fhir -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12677) Create FHIR spring boot quickstart
[
https://issues.apache.org/jira/browse/CAMEL-12677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553851#comment-16553851
]
ASF GitHub Bot commented on CAMEL-12677:
oscerd closed pull request #2435: CAMEL-12677 Create FHIR spring boot quickstart
URL: https://github.com/apache/camel/pull/2435
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/examples/README.adoc b/examples/README.adoc
index 524be57168b..8fbdafb8403 100644
--- a/examples/README.adoc
+++ b/examples/README.adoc
@@ -11,7 +11,7 @@ View the individual example READMEs for details.
### Examples
// examples: START
-Number of Examples: 105 (8 deprecated)
+Number of Examples: 107 (8 deprecated)
[width="100%",cols="4,2,4",options="header"]
|===
@@ -29,6 +29,8 @@ Number of Examples: 105 (8 deprecated)
| link:camel-example-console/README.md[Console] (camel-example-console) |
Beginner | An example that reads input from the console
+| link:camel-example-fhir-spring-boot/readme.adoc[Fhir Spring Boot]
(camel-example-fhir-spring-boot) | Beginner | An example showing how to work
with Camel, Fhir and Spring Boot
+
| link:camel-example-ftp/README.md[FTP] (camel-example-ftp) | Beginner | An
example for showing Camel FTP integration
| link:camel-example-java8/readme.adoc[Java8] (camel-example-java8) | Beginner
| An example for showing Camel DSL for Java 8
@@ -169,6 +171,8 @@ Number of Examples: 105 (8 deprecated)
| link:camel-example-cxf-blueprint/README.md[CXF Blueprint]
(camel-example-cxf-blueprint) | OSGi | An example which use a CXF consumer and
the OSGI HTTP Service
+| link:camel-example-fhir-osgi/README.md[Fhir Osgi] (camel-example-fhir-osgi)
| OSGi | An example running Camel FHIR in Apache Karaf
+
| link:camel-example-netty-http/README.md[Netty HTTP]
(camel-example-netty-http) | OSGi | An example showing how to use a shared
Netty HTTP server with multiple Camel applications in OSGi container
| link:camel-example-olingo4-blueprint/README.md[Olingo4 Blueprint]
(camel-example-olingo4-blueprint) | OSGi | An example which use the Olingo4
component in Blueprint
diff --git a/examples/camel-example-fhir-spring-boot/pom.xml
b/examples/camel-example-fhir-spring-boot/pom.xml
new file mode 100644
index 000..7c3477ee412
--- /dev/null
+++ b/examples/camel-example-fhir-spring-boot/pom.xml
@@ -0,0 +1,167 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd;>
+
+ 4.0.0
+
+
+org.apache.camel.example
+examples
+2.23.0-SNAPSHOT
+
+
+ camel-example-fhir-spring-boot
+ Camel :: Example :: Fhir :: Spring Boot
+ An example showing how to work with Camel, Fhir and Spring
Boot
+
+
+Beginner
+
+UTF-8
+UTF-8
+${spring-boot-version}
+
+
+
+
+
+
+org.springframework.boot
+spring-boot-dependencies
+${spring.boot-version}
+pom
+import
+
+
+
+org.apache.camel
+camel-spring-boot-dependencies
+${project.version}
+pom
+import
+
+
+
+
+
+
+
+
+ org.springframework.boot
+ spring-boot-starter-web
+
+
+ org.springframework.boot
+ spring-boot-starter-tomcat
+
+
+
+
+ org.springframework.boot
+ spring-boot-starter-undertow
+
+
+ org.springframework.boot
+ spring-boot-starter-actuator
+
+
+
+
+ org.apache.camel
+ camel-spring-boot-starter
+
+
+
+ org.apache.camel
+ camel-fhir
+
+
+ org.apache.camel
+ camel-hl7
+
+
+
+ ca.uhn.hapi
+ hapi-structures-v24
+
+
+
+
+ org.springframework.boot
+ spring-boot-starter-test
+ test
+
+
+ org.apache.camel
+ camel-test-spring
+ test
+
+
+
+
+
+
+
+org.springframework.boot
+spring-boot-maven-plugin
+${spring-boot-version}
+
+
+
+ repackage
+
+
+
+
+
+
+org.apache.camel
+camel-maven-plugin
+${project.version}
+
+
+
+
+
+
+
+
+ jdk9+-build
+
+[9,)
+
+
+
+
+maven-surefire-plugin
+
+ --add-modules java.xml.bind --add-opens
java.base/java.lang=ALL-UNNAMED
+
+
+
+
+
+
+
diff --git a/examples/camel-example-fhir-spring-boot/readme.adoc
[jira] [Commented] (CAMEL-12677) Create FHIR spring boot quickstart
[ https://issues.apache.org/jira/browse/CAMEL-12677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553852#comment-16553852 ] ASF GitHub Bot commented on CAMEL-12677: Github user oscerd closed the pull request at: https://github.com/apache/camel/pull/2435 > Create FHIR spring boot quickstart > -- > > Key: CAMEL-12677 > URL: https://issues.apache.org/jira/browse/CAMEL-12677 > Project: Camel > Issue Type: Task > Components: examples >Reporter: Rafal Korytkowski >Priority: Major > Fix For: 2.23.0 > > > Base the example on > https://github.com/apache/camel/tree/master/examples/camel-example-fhir -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (CAMEL-12677) Create FHIR spring boot quickstart
[ https://issues.apache.org/jira/browse/CAMEL-12677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Cosentino reassigned CAMEL-12677: Assignee: Andrea Cosentino > Create FHIR spring boot quickstart > -- > > Key: CAMEL-12677 > URL: https://issues.apache.org/jira/browse/CAMEL-12677 > Project: Camel > Issue Type: Task > Components: examples >Reporter: Rafal Korytkowski >Assignee: Andrea Cosentino >Priority: Major > Fix For: 2.23.0 > > > Base the example on > https://github.com/apache/camel/tree/master/examples/camel-example-fhir -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12677) Create FHIR spring boot quickstart
[ https://issues.apache.org/jira/browse/CAMEL-12677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553850#comment-16553850 ] ASF GitHub Bot commented on CAMEL-12677: oscerd commented on issue #2435: CAMEL-12677 Create FHIR spring boot quickstart URL: https://github.com/apache/camel/pull/2435#issuecomment-407292446 Merged on master. Thanks @rkorytkowski This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create FHIR spring boot quickstart > -- > > Key: CAMEL-12677 > URL: https://issues.apache.org/jira/browse/CAMEL-12677 > Project: Camel > Issue Type: Task > Components: examples >Reporter: Rafal Korytkowski >Priority: Major > Fix For: 2.23.0 > > > Base the example on > https://github.com/apache/camel/tree/master/examples/camel-example-fhir -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (CAMEL-12677) Create FHIR spring boot quickstart
[ https://issues.apache.org/jira/browse/CAMEL-12677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Cosentino updated CAMEL-12677: - Fix Version/s: 2.23.0 > Create FHIR spring boot quickstart > -- > > Key: CAMEL-12677 > URL: https://issues.apache.org/jira/browse/CAMEL-12677 > Project: Camel > Issue Type: Task > Components: examples >Reporter: Rafal Korytkowski >Assignee: Andrea Cosentino >Priority: Major > Fix For: 2.23.0 > > > Base the example on > https://github.com/apache/camel/tree/master/examples/camel-example-fhir -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (CAMEL-12676) Strange results w/ Bindy (header, list, footer)
[ https://issues.apache.org/jira/browse/CAMEL-12676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Cosentino resolved CAMEL-12676. -- Resolution: Invalid Please first ask on users mailing list > Strange results w/ Bindy (header, list, footer) > --- > > Key: CAMEL-12676 > URL: https://issues.apache.org/jira/browse/CAMEL-12676 > Project: Camel > Issue Type: Bug > Components: camel-bindy >Affects Versions: 2.22.0 >Reporter: Christian Scharmach >Assignee: Andrea Cosentino >Priority: Minor > > Hello! > I was trying to marshal a CSV file with following format: > HeaderColumn:headerColumn:headerColumn > BodyColumn;BodyColumn;BodyColumn;BodyColumn;BodyColumn > BodyColumn;BodyColumn;BodyColumn;BodyColumn;BodyColumn > FooterColumn;FooterColumn > [etc] > where Body can be 1 or two lines. > I created a CsvEntryHeader, CsvEntryFooter, CsvEntryBody file and a > CsvPackage which shall hold them all together. But I am getting strange > results as soon as I add a CsvEntryBody. > Most likely because all of them have different count of columns. > I *expect* it to be: > HEADER;agency1;00.01;1 > BODY > FOOTER;agency1;;1 > but it *actually is* > HEADER;agency1;00.01;1 > BODY;agency1;;1 > FOOTER;agency1;00.01;1 > Test-Case: > https://github.com/c9pr3/bindy-bug-test -- This message was sent by Atlassian JIRA (v7.6.3#76005)
