[jira] [Commented] (CAMEL-12271) SharedInternalProcessor attempts to call ResultProcessor after camel upgrade
[
https://issues.apache.org/jira/browse/CAMEL-12271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371038#comment-16371038
]
Claus Ibsen commented on CAMEL-12271:
-
Any update on this
> SharedInternalProcessor attempts to call ResultProcessor after camel upgrade
>
>
> Key: CAMEL-12271
> URL: https://issues.apache.org/jira/browse/CAMEL-12271
> Project: Camel
> Issue Type: Bug
> Components: camel-core
>Affects Versions: 2.20.0, 2.20.1
>Reporter: Daniel Fullarton
>Priority: Major
>
> After upgrading from 2.19.4 we are experiencing backwards compatibility
> issues due to the introduction of the SharedInternalProcessor
> A test of handling an empty 200 response body from a camel-http route now
> produces the following error :
> {noformat}
> org.apache.camel.InvalidPayloadException: No body available of type:
> #RESPONSE CLASS# but has value:
> org.apache.camel.converter.stream.InputStreamCache@7cbb65f9 of type:
> org.apache.camel.converter.stream.InputStreamCache on: Message[]. Caused
> by: No type converter available to convert from type:
> org.apache.camel.converter.stream.InputStreamCache to the required type:
> ##RESPONSE CLASS## with value
> org.apache.camel.converter.stream.InputStreamCache@7cbb65f9. Exchange[].
> Caused by: [org.apache.camel.NoTypeConversionAvailableException - No type
> converter available to convert from type:
> org.apache.camel.converter.stream.InputStreamCache to the required type:
> ##RESPONSE CLASS## with value
> org.apache.camel.converter.stream.InputStreamCache@7cbb65f9]
> 14:55:07 [tests] at
> org.apache.camel.impl.MessageSupport.getMandatoryBody(MessageSupport.java:117)
> 14:55:07 [tests] at
> org.apache.camel.processor.ConvertBodyProcessor.process(ConvertBodyProcessor.java:98)
> 14:55:07 [tests] at
> org.apache.camel.util.AsyncProcessorHelper.process(AsyncProcessorHelper.java:109)
> 14:55:07 [tests] at
> org.apache.camel.processor.ConvertBodyProcessor.process(ConvertBodyProcessor.java:69)
> 14:55:07 [tests] at
> org.apache.camel.processor.SharedCamelInternalProcessor$InternalCallback.done(SharedCamelInternalProcessor.java:229)
> 14:55:07 [tests] at
> org.apache.camel.processor.CamelInternalProcessor$InternalCallback.done(CamelInternalProcessor.java:262)
> 14:55:07 [tests] at
> org.apache.camel.processor.Pipeline.process(Pipeline.java:127)
> 14:55:07 [tests] at
> org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:201)
> 14:55:07 [tests] at
> org.apache.camel.component.direct.DirectProducer.process(DirectProducer.java:62)
> 14:55:07 [tests] at
> org.apache.camel.processor.SharedCamelInternalProcessor.process(SharedCamelInternalProcessor.java:186)
> 14:55:07 [tests] at
> org.apache.camel.processor.SharedCamelInternalProcessor.process(SharedCamelInternalProcessor.java:86)
> 14:55:07 [tests] at
> org.apache.camel.impl.ProducerCache$1.doInProducer(ProducerCache.java:541)
> 14:55:07 [tests] at
> org.apache.camel.impl.ProducerCache$1.doInProducer(ProducerCache.java:506)
> 14:55:07 [tests] at
> org.apache.camel.impl.ProducerCache.doInProducer(ProducerCache.java:369)
> 14:55:07 [tests] at
> org.apache.camel.impl.ProducerCache.sendExchange(ProducerCache.java:506)
> 14:55:07 [tests] at
> org.apache.camel.impl.ProducerCache.send(ProducerCache.java:264)
> 14:55:07 [tests] at
> org.apache.camel.impl.DefaultProducerTemplate.requestBodyAndHeaders(DefaultProducerTemplate.java:355)
> 14:55:07 [tests] ... 10 more
> {noformat}
> Digging into the code I can see that:
> [https://github.com/apache/camel/commit/30917aba7d23be2a408660f3e4dd503a9cad5015#diff-ada5b0d990676bbc7d99201682c3065dR223]
> Now calls the resultProcessor in the internal callback, previously it seems
> to have only done this when the underlying pipeline was successful?
> I will try to find a way to replicate this outside of our environment but
> this appears to be a behavioural change in the way errors are handled.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (CAMEL-11519) Add the ability for CAMEL-RABBITMQ to support transactional consumers and producers
[ https://issues.apache.org/jira/browse/CAMEL-11519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Motts updated CAMEL-11519: --- Attachment: RabbitMQEndpoint.patch > Add the ability for CAMEL-RABBITMQ to support transactional consumers and > producers > --- > > Key: CAMEL-11519 > URL: https://issues.apache.org/jira/browse/CAMEL-11519 > Project: Camel > Issue Type: Improvement > Components: camel-rabbitmq >Affects Versions: 2.19.1 >Reporter: Gary Motts >Priority: Minor > Labels: rabbitmq > Attachments: RabbitConsumer.patch, RabbitMQEndpoint.patch > > > Recommend enhancing the camel-rabbitmq component to optionally support > transactional consumers and producers. As a temporary work around to make > the consumer transactional, I added this.channel.txSelect(); to line 57 > (camel 2-19 branch) and this.channel.txCommit(); to line 133 and > this.channel.txRollback(); to line 165 of the RabbitMQConsumer. Recommend > adding an endpoint option to disable or enable TX per channel -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (CAMEL-11519) Add the ability for CAMEL-RABBITMQ to support transactional consumers and producers
[ https://issues.apache.org/jira/browse/CAMEL-11519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Motts updated CAMEL-11519: --- Attachment: RabbitConsumer.patch > Add the ability for CAMEL-RABBITMQ to support transactional consumers and > producers > --- > > Key: CAMEL-11519 > URL: https://issues.apache.org/jira/browse/CAMEL-11519 > Project: Camel > Issue Type: Improvement > Components: camel-rabbitmq >Affects Versions: 2.19.1 >Reporter: Gary Motts >Priority: Minor > Labels: rabbitmq > Attachments: RabbitConsumer.patch, RabbitMQEndpoint.patch > > > Recommend enhancing the camel-rabbitmq component to optionally support > transactional consumers and producers. As a temporary work around to make > the consumer transactional, I added this.channel.txSelect(); to line 57 > (camel 2-19 branch) and this.channel.txCommit(); to line 133 and > this.channel.txRollback(); to line 165 of the RabbitMQConsumer. Recommend > adding an endpoint option to disable or enable TX per channel -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-11519) Add the ability for CAMEL-RABBITMQ to support transactional consumers and producers
[ https://issues.apache.org/jira/browse/CAMEL-11519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370628#comment-16370628 ] Gary Motts commented on CAMEL-11519: Hi Claus/Jose Luis Attaching 2 patch files -RabbitMQEndpoint.patch and RabbitConsumer.patch. We started with Camel 2.19.0 and completed with 2.19.4, so the patch files are based on migrated 2.19.4 source code with other applicable JIRAs applied. The modified RabbitMQEndpoint adds 2 new parameters to the camel-rabbitmq component - *transacted* (boolean) and *transactionRetryInterval*(int). When transacted is set true, the RabbitMQ channel is opened as transactional, enabling camel to resend a rolled back transaction for a specified interval (milliseconds - recommend a default value of 6) . For now we've only added transnational behavior to consumers only and use producer confirms for producers. Sorry no unit tests for now, we verify rollback behavior using end to end tests. Hope this helps, -Gary > Add the ability for CAMEL-RABBITMQ to support transactional consumers and > producers > --- > > Key: CAMEL-11519 > URL: https://issues.apache.org/jira/browse/CAMEL-11519 > Project: Camel > Issue Type: Improvement > Components: camel-rabbitmq >Affects Versions: 2.19.1 >Reporter: Gary Motts >Priority: Minor > Labels: rabbitmq > > Recommend enhancing the camel-rabbitmq component to optionally support > transactional consumers and producers. As a temporary work around to make > the consumer transactional, I added this.channel.txSelect(); to line 57 > (camel 2-19 branch) and this.channel.txCommit(); to line 133 and > this.channel.txRollback(); to line 165 of the RabbitMQConsumer. Recommend > adding an endpoint option to disable or enable TX per channel -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (CAMEL-12262) DEFAULT_CIPHER_SUITES_FILTER_EXCLUDE Incorrect
[
https://issues.apache.org/jira/browse/CAMEL-12262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Claus Ibsen resolved CAMEL-12262.
-
Resolution: Fixed
Okay I created a ticket for Camel 3.0
> DEFAULT_CIPHER_SUITES_FILTER_EXCLUDE Incorrect
> --
>
> Key: CAMEL-12262
> URL: https://issues.apache.org/jira/browse/CAMEL-12262
> Project: Camel
> Issue Type: Task
> Components: documentation
>Reporter: Lyubomir
>Assignee: Claus Ibsen
>Priority: Minor
> Fix For: 2.21.0
>
>
> The [official
> documentation|http://camel.apache.org/camel-configuration-utilities.html]
> states the default cipher suites exclude filters are:
> {code:java}
> .*NULL.*
> .*anon.*
> .*DES.* Camel 2.15.4 =>Means 3DES **is** excluded
> .*EXPORT.* Camel 2.15.4
> {code}
> The default cipher suite exclude filter declared is:
> {code:java}
> /camel-core/src/main/java/org/apache/camel/util/jsse/BaseSSLContextParameters.java
> {code}
> {code:java}
> protected static final List DEFAULT_CIPHER_SUITES_FILTER_EXCLUDE =
> Collections.unmodifiableList(Arrays.asList(".*_NULL_.*",
> ".*_anon_.*", ".*_EXPORT_.*", ".*_DES_.*"));
> {code}
> According to the documentation 3DES will be excluded by default. Based on the
> code only DES will be excluded.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (CAMEL-12281) Camel JSSE filter algorithm aligned as how CXF does it
Claus Ibsen created CAMEL-12281: --- Summary: Camel JSSE filter algorithm aligned as how CXF does it Key: CAMEL-12281 URL: https://issues.apache.org/jira/browse/CAMEL-12281 Project: Camel Issue Type: Improvement Components: camel-core Reporter: Claus Ibsen Fix For: 3.0.0 See CAMEL-12262 comment from Colm. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (CAMEL-12221) Let's create a camel-fhir component
[ https://issues.apache.org/jira/browse/CAMEL-12221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen updated CAMEL-12221: Fix Version/s: 2.21.0 > Let's create a camel-fhir component > --- > > Key: CAMEL-12221 > URL: https://issues.apache.org/jira/browse/CAMEL-12221 > Project: Camel > Issue Type: New Feature >Reporter: John Poth >Priority: Major > Fix For: 2.21.0 > > > Let's create a camel-fhir component based on [HAPI-FHIR|http://hapifhir.io] > I can take care of the PR. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
