[jira] [Commented] (CAMEL-6840) Allow Throttler EIP to specify SLA per client/correlated-group
[ https://issues.apache.org/jira/browse/CAMEL-6840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534242#comment-16534242 ] Önder Sezgin commented on CAMEL-6840: - all tests pass now. more regression unit tests to be added in the following days. > Allow Throttler EIP to specify SLA per client/correlated-group > -- > > Key: CAMEL-6840 > URL: https://issues.apache.org/jira/browse/CAMEL-6840 > Project: Camel > Issue Type: New Feature > Components: camel-core, eip >Reporter: Christian Posta >Assignee: Önder Sezgin >Priority: Major > Fix For: 2.23.0 > > > Basic idea is to allow throttler to have a predicate to determine whether or > not to apply throttling to that exchange. > From this Mailing List discussion: > http://camel.465427.n5.nabble.com/Throttling-by-client-ID-td5741032.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (CAMEL-12627) Use Spring Boot autoconfigure-processor to optimize auto-configurations
brian clozel created CAMEL-12627: Summary: Use Spring Boot autoconfigure-processor to optimize auto-configurations Key: CAMEL-12627 URL: https://issues.apache.org/jira/browse/CAMEL-12627 Project: Camel Issue Type: Improvement Components: camel-spring-boot, camel-spring-cloud Affects Versions: 2.21.1 Reporter: brian clozel As explained in [the its reference documentation|https://github.com/spring-projects/spring-boot/blob/master/spring-boot-project/spring-boot-docs/src/main/asciidoc/spring-boot-features.adoc#autoconfigure-module], Spring Boot provides a {{spring-boot-autoconfigure-processor}}. This should be added as an optional dependency to each module that contains AutoConfiguration classes (and the `spring.factories` file declaring them). Once configured, this annotation processor will generate metadata at compile time and will help Spring Boot process those auto-configurations without loading the actual classes in some cases. In this project, the several modules are declaring auto-configurations but are not using this annotation processor. Could you add it to the build files? {code:xml} org.springframework.boot spring-boot-autoconfigure-processor true {code} Once added, this should generate a {{spring-autoconfigure-metadata.properties}} file in the {{target/classes/META-INF}} folder of earch module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-6840) Allow Throttler EIP to specify SLA per client/correlated-group
[ https://issues.apache.org/jira/browse/CAMEL-6840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534103#comment-16534103 ] Önder Sezgin commented on CAMEL-6840: - yes, happening on mac more often. maybe i can revert again :/ and work on mac too before merging.. > Allow Throttler EIP to specify SLA per client/correlated-group > -- > > Key: CAMEL-6840 > URL: https://issues.apache.org/jira/browse/CAMEL-6840 > Project: Camel > Issue Type: New Feature > Components: camel-core, eip >Reporter: Christian Posta >Assignee: Önder Sezgin >Priority: Major > Fix For: 2.23.0 > > > Basic idea is to allow throttler to have a predicate to determine whether or > not to apply throttling to that exchange. > From this Mailing List discussion: > http://camel.465427.n5.nabble.com/Throttling-by-client-ID-td5741032.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-6840) Allow Throttler EIP to specify SLA per client/correlated-group
[ https://issues.apache.org/jira/browse/CAMEL-6840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533973#comment-16533973 ] Claus Ibsen commented on CAMEL-6840: I notice these interrupts exception as well {code:java} [INFO] --- [INFO] T E S T S [INFO] --- [INFO] Running org.apache.camel.spring.processor.SpringThrottlerTest Exception in thread "pool-19-thread-1" Exception in thread "pool-19-thread-4" Exception in thread "pool-19-thread-2" Exception in thread "pool-19-thread-5" Exception in thread "pool-19-thread-3" org.apache.camel.CamelExecutionException: Exception occurred during execution on the exchange: Exchange[ID-davsclaus-pro-local-1530813464035-6-40] at org.apache.camel.util.ObjectHelper.wrapCamelExecutionException(ObjectHelper.java:1846) at org.apache.camel.util.ExchangeHelper.extractResultBody(ExchangeHelper.java:715) at org.apache.camel.impl.DefaultProducerTemplate.extractResultBody(DefaultProducerTemplate.java:515) at org.apache.camel.impl.DefaultProducerTemplate.extractResultBody(DefaultProducerTemplate.java:511) at org.apache.camel.impl.DefaultProducerTemplate.sendBodyAndHeader(DefaultProducerTemplate.java:189) at org.apache.camel.impl.DefaultProducerTemplate.sendBodyAndHeader(DefaultProducerTemplate.java:183) at org.apache.camel.processor.ThrottlerTest$2.run(ThrottlerTest.java:183) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:748) Caused by: java.lang.InterruptedException at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.reportInterruptAfterWait(AbstractQueuedSynchronizer.java:2014) at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2048) at java.util.concurrent.DelayQueue.take(DelayQueue.java:211) at org.apache.camel.processor.Throttler.process(Throttler.java:157) at org.apache.camel.processor.RedeliveryErrorHandler.process(RedeliveryErrorHandler.java:548) at org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:201) at org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:201) at org.apache.camel.component.direct.DirectBlockingProducer.process(DirectBlockingProducer.java:53) at org.apache.camel.processor.SharedCamelInternalProcessor.process(SharedCamelInternalProcessor.java:186) at org.apache.camel.processor.SharedCamelInternalProcessor.process(SharedCamelInternalProcessor.java:86) at org.apache.camel.impl.ProducerCache$1.doInProducer(ProducerCache.java:541) at org.apache.camel.impl.ProducerCache$1.doInProducer(ProducerCache.java:506) at org.apache.camel.impl.ProducerCache.doInProducer(ProducerCache.java:369) at org.apache.camel.impl.ProducerCache.sendExchange(ProducerCache.java:506) at org.apache.camel.impl.ProducerCache.send(ProducerCache.java:229) at org.apache.camel.impl.DefaultProducerTemplate.send(DefaultProducerTemplate.java:144) at org.apache.camel.impl.DefaultProducerTemplate.sendBodyAndHeader(DefaultProducerTemplate.java:187) ... 5 more org.apache.camel.CamelExecutionException: Exception occurred during execution on the exchange: Exchange[ID-davsclaus-pro-local-1530813464035-6-48] at org.apache.camel.util.ObjectHelper.wrapCamelExecutionException(ObjectHelper.java:1846) at org.apache.camel.util.ExchangeHelper.extractResultBody(ExchangeHelper.java:715) at org.apache.camel.impl.DefaultProducerTemplate.extractResultBody(DefaultProducerTemplate.java:515) at org.apache.camel.impl.DefaultProducerTemplate.extractResultBody(DefaultProducerTemplate.java:511) at org.apache.camel.impl.DefaultProducerTemplate.sendBodyAndHeader(DefaultProducerTemplate.java:189) at org.apache.camel.impl.DefaultProducerTemplate.sendBodyAndHeader(DefaultProducerTemplate.java:183) at org.apache.camel.processor.ThrottlerTest$2.run(ThrottlerTest.java:183) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:748) Caused by: java.lang.InterruptedException at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.reportInterruptAfterWait(AbstractQueuedSynchronizer.java:2014) at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2048) at java.util.concurrent.DelayQueue.take(DelayQueue.java:211) at org.apache.camel.processor.Throttler.process(Throttler.java:157) at org.apache.camel.processor.RedeliveryErrorHandler.process(RedeliveryErrorHandler.java:548) at org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:201) at
[jira] [Commented] (CAMEL-6840) Allow Throttler EIP to specify SLA per client/correlated-group
[ https://issues.apache.org/jira/browse/CAMEL-6840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533970#comment-16533970 ] Claus Ibsen commented on CAMEL-6840: Ah yeah such timing/threading tests can sometimes be hard to reproduce. The CI server also had a failure in a build [https://builds.apache.org/job/Camel/job/master/446/testReport/junit/org.apache.camel.spring.processor/SpringThrottlerTest/testSendLotsOfMessagesSimultaneouslyButOnly3GetThrough/] > Allow Throttler EIP to specify SLA per client/correlated-group > -- > > Key: CAMEL-6840 > URL: https://issues.apache.org/jira/browse/CAMEL-6840 > Project: Camel > Issue Type: New Feature > Components: camel-core, eip >Reporter: Christian Posta >Assignee: Önder Sezgin >Priority: Major > Fix For: 2.23.0 > > > Basic idea is to allow throttler to have a predicate to determine whether or > not to apply throttling to that exchange. > From this Mailing List discussion: > http://camel.465427.n5.nabble.com/Throttling-by-client-ID-td5741032.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-6840) Allow Throttler EIP to specify SLA per client/correlated-group
[ https://issues.apache.org/jira/browse/CAMEL-6840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533931#comment-16533931 ] Önder Sezgin commented on CAMEL-6840: - i dont have the same issue in both windows and centos vm boxes. can not reproduce :/ not sure how to carry on at this point. i ll try to reproduce > Allow Throttler EIP to specify SLA per client/correlated-group > -- > > Key: CAMEL-6840 > URL: https://issues.apache.org/jira/browse/CAMEL-6840 > Project: Camel > Issue Type: New Feature > Components: camel-core, eip >Reporter: Christian Posta >Assignee: Önder Sezgin >Priority: Major > Fix For: 2.23.0 > > > Basic idea is to allow throttler to have a predicate to determine whether or > not to apply throttling to that exchange. > From this Mailing List discussion: > http://camel.465427.n5.nabble.com/Throttling-by-client-ID-td5741032.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-6840) Allow Throttler EIP to specify SLA per client/correlated-group
[ https://issues.apache.org/jira/browse/CAMEL-6840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533806#comment-16533806 ] Claus Ibsen commented on CAMEL-6840: Mind that sometimes we extend unit tests from camel-core in camel-spring, so if you change something in camel-core you may need to change also in camel-spring > Allow Throttler EIP to specify SLA per client/correlated-group > -- > > Key: CAMEL-6840 > URL: https://issues.apache.org/jira/browse/CAMEL-6840 > Project: Camel > Issue Type: New Feature > Components: camel-core, eip >Reporter: Christian Posta >Assignee: Önder Sezgin >Priority: Major > Fix For: 2.23.0 > > > Basic idea is to allow throttler to have a predicate to determine whether or > not to apply throttling to that exchange. > From this Mailing List discussion: > http://camel.465427.n5.nabble.com/Throttling-by-client-ID-td5741032.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (CAMEL-6840) Allow Throttler EIP to specify SLA per client/correlated-group
[ https://issues.apache.org/jira/browse/CAMEL-6840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen reopened CAMEL-6840: > Allow Throttler EIP to specify SLA per client/correlated-group > -- > > Key: CAMEL-6840 > URL: https://issues.apache.org/jira/browse/CAMEL-6840 > Project: Camel > Issue Type: New Feature > Components: camel-core, eip >Reporter: Christian Posta >Assignee: Önder Sezgin >Priority: Major > Fix For: 2.23.0 > > > Basic idea is to allow throttler to have a predicate to determine whether or > not to apply throttling to that exchange. > From this Mailing List discussion: > http://camel.465427.n5.nabble.com/Throttling-by-client-ID-td5741032.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-6840) Allow Throttler EIP to specify SLA per client/correlated-group
[ https://issues.apache.org/jira/browse/CAMEL-6840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533805#comment-16533805 ] Claus Ibsen commented on CAMEL-6840: I suspect this implementation may have caused the spring test to fail in camel-spring: SpringThrottlerTest [ERROR] Failures: [ERROR] org.apache.camel.spring.processor.SpringThrottlerTest.testConfigurationWithChangingHeaderExpression(org.apache.camel.spring.processor.SpringThrottlerTest) [ERROR] Run 1: SpringThrottlerTest>TestSupport.runBare:58->ThrottlerTest.testConfigurationWithChangingHeaderExpression:119->ThrottlerTest.sendMessagesWithHeaderExpression:191->ThrottlerTest.assertThrottlerTiming:145 Should take at least 450ms, was: 1 [ERROR] Run 2: SpringThrottlerTest>TestSupport.runBare:58->ThrottlerTest.testConfigurationWithChangingHeaderExpression:119->ThrottlerTest.sendMessagesWithHeaderExpression:191->ThrottlerTest.assertThrottlerTiming:145 Should take at least 450ms, was: 1 [ERROR] Run 3: SpringThrottlerTest>TestSupport.runBare:58->ThrottlerTest.testConfigurationWithChangingHeaderExpression:119->ThrottlerTest.sendMessagesWithHeaderExpression:191->ThrottlerTest.assertThrottlerTiming:145 Should take at least 450ms, was: 1 > Allow Throttler EIP to specify SLA per client/correlated-group > -- > > Key: CAMEL-6840 > URL: https://issues.apache.org/jira/browse/CAMEL-6840 > Project: Camel > Issue Type: New Feature > Components: camel-core, eip >Reporter: Christian Posta >Assignee: Önder Sezgin >Priority: Major > Fix For: 2.23.0 > > > Basic idea is to allow throttler to have a predicate to determine whether or > not to apply throttling to that exchange. > From this Mailing List discussion: > http://camel.465427.n5.nabble.com/Throttling-by-client-ID-td5741032.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12625) Create FHIR Camel component with example
[ https://issues.apache.org/jira/browse/CAMEL-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533724#comment-16533724 ] ASF GitHub Bot commented on CAMEL-12625: GitHub user johnpoth opened a pull request: https://github.com/apache/camel/pull/2411 Camel 12625 https://issues.apache.org/jira/browse/CAMEL-12625 Thanks! You can merge this pull request into a Git repository by running: $ git pull https://github.com/johnpoth/camel CAMEL-12625 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/camel/pull/2411.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2411 commit 65f2559c2341c421c617e8bc5ce852b21dce161c Author: jpoth Date: 2018-05-03T16:28:29Z Lets make the camel-api-component-maven-plugin handle generic methods with single bounded type parameters commit 21d4dbf0f0727485df759df0f1df0ba7f9401515 Author: jpoth Date: 2018-07-05T14:13:59Z [CAMEL-12625] Create Camel FHIR example commit 1f034f779ab119ea54d79b064efe107d19bc5657 Author: jpoth Date: 2018-07-05T14:15:23Z [CAMEL-12625] Create Camel FHIR component > Create FHIR Camel component with example > > > Key: CAMEL-12625 > URL: https://issues.apache.org/jira/browse/CAMEL-12625 > Project: Camel > Issue Type: New Feature >Reporter: John Poth >Assignee: John Poth >Priority: Major > > Create Camel component to integrate with > [FHIR|[http://example.com|http://hapifhir.io/doc_rest_server.html]] > endpoints. I'll submit a PR -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (CAMEL-12571) Seda component forgets URI setting when duplicates are present
[ https://issues.apache.org/jira/browse/CAMEL-12571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen resolved CAMEL-12571. - Resolution: Fixed > Seda component forgets URI setting when duplicates are present > -- > > Key: CAMEL-12571 > URL: https://issues.apache.org/jira/browse/CAMEL-12571 > Project: Camel > Issue Type: Bug > Components: camel-core >Affects Versions: 2.21.0 >Reporter: Gianandrea Rigoni >Assignee: Claus Ibsen >Priority: Trivial > Fix For: 2.23.0 > > > when {color:#008000}blockWhenFull=true=true > {color}{color:#33}is set twice the option is not set at all{color} > {color:#33}it might out of context but from my point of view the last one > should win (as it is in a properties file){color} > {color:#33}of if an error should be thrown could also be welcome{color} > > {color:#33}I quickly adapted{color} > SedaComponentConfigurationAndDocumentationTest (I know, it uses now > deprecated stuff) and the result is an array of set values ( 2 in this case) > and the test fails. > kind regards > G. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (CAMEL-12626) Camel Tracing is not working for route with redelivery strategy
marvin created CAMEL-12626: -- Summary: Camel Tracing is not working for route with redelivery strategy Key: CAMEL-12626 URL: https://issues.apache.org/jira/browse/CAMEL-12626 Project: Camel Issue Type: Bug Affects Versions: 2.20.2 Reporter: marvin Camel Tracing is not being executed if there is redelivery strategy defined. In our context we have switched on the camel Tracer with the following: {code:java} public static void main(String[] args) throws Exception { DefaultCamelContext context = new DefaultCamelContext(); context.addRoutes(new RouteBuilder() { @Override public void configure() throws Exception { // If errorHandler with redelivery is removed then tracer output is visible again. errorHandler(new DefaultErrorHandlerBuilder().maximumRedeliveries(3).redeliveryDelay(2000L)); from("direct:start").process(new Processor() { public void process(Exchange exchange) throws Exception { System.out.println("PROCESSED"); } }); } }); // Enable Tracer. context.setTracing(true); context.start(); ProducerTemplate template = context.createProducerTemplate(); template.sendBody("direct:start", "foo"); } {code} We noticed that we were missing output from the tracer that we were excepting. If you remove the errohandler with redelivery you can see the output we expected: {code:java} [main] INFO org.apache.camel.processor.interceptor.Tracer - ID-rmm-xxx-xxx-x-x >>> (route1) from(direct://start) --> Processor@0x130d63be <<< Pattern:InOnly, Headers:{breadcrumbId=ID-rmm-xxx-xxx-x-x}, BodyType:String, Body:foo {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (CAMEL-12571) Seda component forgets URI setting when duplicates are present
[ https://issues.apache.org/jira/browse/CAMEL-12571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen updated CAMEL-12571: Fix Version/s: (was: 2.22.1) (was: 2.21.2) > Seda component forgets URI setting when duplicates are present > -- > > Key: CAMEL-12571 > URL: https://issues.apache.org/jira/browse/CAMEL-12571 > Project: Camel > Issue Type: Bug > Components: camel-core >Affects Versions: 2.21.0 >Reporter: Gianandrea Rigoni >Assignee: Claus Ibsen >Priority: Minor > Fix For: 2.23.0 > > > when {color:#008000}blockWhenFull=true=true > {color}{color:#33}is set twice the option is not set at all{color} > {color:#33}it might out of context but from my point of view the last one > should win (as it is in a properties file){color} > {color:#33}of if an error should be thrown could also be welcome{color} > > {color:#33}I quickly adapted{color} > SedaComponentConfigurationAndDocumentationTest (I know, it uses now > deprecated stuff) and the result is an array of set values ( 2 in this case) > and the test fails. > kind regards > G. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (CAMEL-12571) Seda component forgets URI setting when duplicates are present
[ https://issues.apache.org/jira/browse/CAMEL-12571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen updated CAMEL-12571: Priority: Trivial (was: Minor) > Seda component forgets URI setting when duplicates are present > -- > > Key: CAMEL-12571 > URL: https://issues.apache.org/jira/browse/CAMEL-12571 > Project: Camel > Issue Type: Bug > Components: camel-core >Affects Versions: 2.21.0 >Reporter: Gianandrea Rigoni >Assignee: Claus Ibsen >Priority: Trivial > Fix For: 2.23.0 > > > when {color:#008000}blockWhenFull=true=true > {color}{color:#33}is set twice the option is not set at all{color} > {color:#33}it might out of context but from my point of view the last one > should win (as it is in a properties file){color} > {color:#33}of if an error should be thrown could also be welcome{color} > > {color:#33}I quickly adapted{color} > SedaComponentConfigurationAndDocumentationTest (I know, it uses now > deprecated stuff) and the result is an array of set values ( 2 in this case) > and the test fails. > kind regards > G. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12571) Seda component forgets URI setting when duplicates are present
[ https://issues.apache.org/jira/browse/CAMEL-12571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533678#comment-16533678 ] Claus Ibsen commented on CAMEL-12571: - A fix for this has a potential fix in default component so will only do this on master onwards. Its not a big bug or issue as its end user that has misconfigured camel. > Seda component forgets URI setting when duplicates are present > -- > > Key: CAMEL-12571 > URL: https://issues.apache.org/jira/browse/CAMEL-12571 > Project: Camel > Issue Type: Bug > Components: camel-core >Affects Versions: 2.21.0 >Reporter: Gianandrea Rigoni >Assignee: Claus Ibsen >Priority: Minor > Fix For: 2.23.0 > > > when {color:#008000}blockWhenFull=true=true > {color}{color:#33}is set twice the option is not set at all{color} > {color:#33}it might out of context but from my point of view the last one > should win (as it is in a properties file){color} > {color:#33}of if an error should be thrown could also be welcome{color} > > {color:#33}I quickly adapted{color} > SedaComponentConfigurationAndDocumentationTest (I know, it uses now > deprecated stuff) and the result is an array of set values ( 2 in this case) > and the test fails. > kind regards > G. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12503) Kafka component should be able to propagate camel headers to kafka
[ https://issues.apache.org/jira/browse/CAMEL-12503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533675#comment-16533675 ] ASF GitHub Bot commented on CAMEL-12503: tdanylchuk opened a new pull request #2410: CAMEL-12503 : support for propagating camel headers to kafka URL: https://github.com/apache/camel/pull/2410 As part of https://issues.apache.org/jira/browse/CAMEL-12503 the main point why I ported feature to 2.21.x branch is to support 1.5.x Spring boot, we've discussed earlier in gitter about this with members. cherry picked from 2.22.0 commit ee29789 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Kafka component should be able to propagate camel headers to kafka > -- > > Key: CAMEL-12503 > URL: https://issues.apache.org/jira/browse/CAMEL-12503 > Project: Camel > Issue Type: New Feature > Components: camel-kafka >Reporter: Taras Danylchuk >Assignee: Claus Ibsen >Priority: Major > Fix For: 2.22.0 > > > Since 0.11.0 Kafka support headers, and it would be awesome to have such > feature available also in camel component. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12503) Kafka component should be able to propagate camel headers to kafka
[ https://issues.apache.org/jira/browse/CAMEL-12503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533676#comment-16533676 ] ASF GitHub Bot commented on CAMEL-12503: GitHub user tdanylchuk opened a pull request: https://github.com/apache/camel/pull/2410 CAMEL-12503 : support for propagating camel headers to kafka As part of https://issues.apache.org/jira/browse/CAMEL-12503 the main point why I ported feature to 2.21.x branch is to support 1.5.x Spring boot, we've discussed earlier in gitter about this with members. cherry picked from 2.22.0 commit ee29789 You can merge this pull request into a Git repository by running: $ git pull https://github.com/tdanylchuk/camel 2.21.x-propagate-kafka-headers Alternatively you can review and apply these changes as the patch at: https://github.com/apache/camel/pull/2410.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2410 commit 66f8af8a5a4aa05020f180ce1501c0d85655725c Author: Taras Danylchuk Date: 2018-05-10T14:33:03Z CAMEL-12503 : support for propagating camel headers to kafka and vice versa cherry picked from 2.22.0 commit ee29789 > Kafka component should be able to propagate camel headers to kafka > -- > > Key: CAMEL-12503 > URL: https://issues.apache.org/jira/browse/CAMEL-12503 > Project: Camel > Issue Type: New Feature > Components: camel-kafka >Reporter: Taras Danylchuk >Assignee: Claus Ibsen >Priority: Major > Fix For: 2.22.0 > > > Since 0.11.0 Kafka support headers, and it would be awesome to have such > feature available also in camel component. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12594) Rest Producer - Query Parameters : Wrong query parameter name is used when header substitution is performed
[ https://issues.apache.org/jira/browse/CAMEL-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533666#comment-16533666 ] ASF GitHub Bot commented on CAMEL-12594: dmvolod edited a comment on issue #2409: CAMEL-12594 repro URL: https://github.com/apache/camel/pull/2409#issuecomment-402724567 @leonidr could you please to add a fix also to this PR and wait for community review and merge This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Rest Producer - Query Parameters : Wrong query parameter name is used when > header substitution is performed > > > Key: CAMEL-12594 > URL: https://issues.apache.org/jira/browse/CAMEL-12594 > Project: Camel > Issue Type: Bug > Components: camel-core >Affects Versions: 2.22.0 >Reporter: Leonid Remennik >Priority: Major > Labels: rest > Fix For: 2.22.1, 2.23.0 > > > CAMEL-11050 > [https://github.com/apache/camel/commit/35638b280be7ca43031ea4c5d937590f30495e70] > Introduced a bug in this line > [https://github.com/apache/camel/blob/6938a4ea6b68e295fae48f52e8e7cb2628f161a3/camel-core/src/main/java/org/apache/camel/component/rest/RestProducer.java#L409] > > The fix is (probably) to replace the line with : > params.put(entry.getKey(), value); > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12594) Rest Producer - Query Parameters : Wrong query parameter name is used when header substitution is performed
[ https://issues.apache.org/jira/browse/CAMEL-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533662#comment-16533662 ] ASF GitHub Bot commented on CAMEL-12594: dmvolod commented on issue #2409: CAMEL-12594 repro URL: https://github.com/apache/camel/pull/2409#issuecomment-402724567 @leonidr could you please to add fix also to this PR and wait for community review and merge This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Rest Producer - Query Parameters : Wrong query parameter name is used when > header substitution is performed > > > Key: CAMEL-12594 > URL: https://issues.apache.org/jira/browse/CAMEL-12594 > Project: Camel > Issue Type: Bug > Components: camel-core >Affects Versions: 2.22.0 >Reporter: Leonid Remennik >Priority: Major > Labels: rest > Fix For: 2.22.1, 2.23.0 > > > CAMEL-11050 > [https://github.com/apache/camel/commit/35638b280be7ca43031ea4c5d937590f30495e70] > Introduced a bug in this line > [https://github.com/apache/camel/blob/6938a4ea6b68e295fae48f52e8e7cb2628f161a3/camel-core/src/main/java/org/apache/camel/component/rest/RestProducer.java#L409] > > The fix is (probably) to replace the line with : > params.put(entry.getKey(), value); > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12589) Surviving Header AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE affects following aggregations
[ https://issues.apache.org/jira/browse/CAMEL-12589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533622#comment-16533622 ] Gianandrea Rigoni commented on CAMEL-12589: your careful reviewing is always appreciated, thx! > Surviving Header AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE affects following > aggregations > - > > Key: CAMEL-12589 > URL: https://issues.apache.org/jira/browse/CAMEL-12589 > Project: Camel > Issue Type: Bug > Components: camel-core >Affects Versions: 2.21.0, 2.21.1 >Reporter: Gianandrea Rigoni >Assignee: Claus Ibsen >Priority: Major > Fix For: 2.21.2, 2.22.1, 2.23.0 > > > When AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE is once set true it survives > current aggregation processing and affects in unexpected way following > aggregation by triggering "forceCompletionOfAllGroups()" again > in next code snippet might be needed some additional handling when the header > is true: > {code:java} > protected void doProcess(Exchange exchange) throws Exception { > ... > // check for the special header to force completion of all groups > (inclusive of the message) > boolean completeAllGroupsInclusive = > exchange.getIn().getHeader(Exchange.AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE, > false, boolean.class); > if (completeAllGroupsInclusive) { > forceCompletionOfAllGroups(); > } > ... > {code} > this consideration is made by analysing similar behavior and lifecycle of > header AGGREGATION_COMPLETE_ALL_GROUPS: > {code:java} > private List doAggregation(String key, Exchange newExchange) throws > CamelExchangeException { > ... > ... > // check for the special exchange property to force completion of all > groups > boolean completeAllGroups = > answer.getProperty(Exchange.AGGREGATION_COMPLETE_ALL_GROUPS, false, > boolean.class); > if (completeAllGroups) { > // remove the exchange property so we do not complete again > answer.removeProperty(Exchange.AGGREGATION_COMPLETE_ALL_GROUPS); > forceCompletionOfAllGroups(); > } else if (isCompletionOnNewCorrelationGroup() && originalExchange == > null) { > // its a new group so force complete of all existing groups > forceCompletionOfAllGroups(); > } > ... > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (CAMEL-12589) Surviving Header AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE affects following aggregations
[ https://issues.apache.org/jira/browse/CAMEL-12589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen updated CAMEL-12589: Fix Version/s: (was: 2.20.4) 2.21.2 > Surviving Header AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE affects following > aggregations > - > > Key: CAMEL-12589 > URL: https://issues.apache.org/jira/browse/CAMEL-12589 > Project: Camel > Issue Type: Bug > Components: camel-core >Affects Versions: 2.21.0, 2.21.1 >Reporter: Gianandrea Rigoni >Assignee: Claus Ibsen >Priority: Major > Fix For: 2.21.2, 2.22.1, 2.23.0 > > > When AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE is once set true it survives > current aggregation processing and affects in unexpected way following > aggregation by triggering "forceCompletionOfAllGroups()" again > in next code snippet might be needed some additional handling when the header > is true: > {code:java} > protected void doProcess(Exchange exchange) throws Exception { > ... > // check for the special header to force completion of all groups > (inclusive of the message) > boolean completeAllGroupsInclusive = > exchange.getIn().getHeader(Exchange.AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE, > false, boolean.class); > if (completeAllGroupsInclusive) { > forceCompletionOfAllGroups(); > } > ... > {code} > this consideration is made by analysing similar behavior and lifecycle of > header AGGREGATION_COMPLETE_ALL_GROUPS: > {code:java} > private List doAggregation(String key, Exchange newExchange) throws > CamelExchangeException { > ... > ... > // check for the special exchange property to force completion of all > groups > boolean completeAllGroups = > answer.getProperty(Exchange.AGGREGATION_COMPLETE_ALL_GROUPS, false, > boolean.class); > if (completeAllGroups) { > // remove the exchange property so we do not complete again > answer.removeProperty(Exchange.AGGREGATION_COMPLETE_ALL_GROUPS); > forceCompletionOfAllGroups(); > } else if (isCompletionOnNewCorrelationGroup() && originalExchange == > null) { > // its a new group so force complete of all existing groups > forceCompletionOfAllGroups(); > } > ... > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (CAMEL-12589) Surviving Header AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE affects following aggregations
[ https://issues.apache.org/jira/browse/CAMEL-12589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen resolved CAMEL-12589. - Resolution: Fixed Fix Version/s: 2.20.4 Thanks for reporting > Surviving Header AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE affects following > aggregations > - > > Key: CAMEL-12589 > URL: https://issues.apache.org/jira/browse/CAMEL-12589 > Project: Camel > Issue Type: Bug > Components: camel-core >Affects Versions: 2.21.0, 2.21.1 >Reporter: Gianandrea Rigoni >Assignee: Claus Ibsen >Priority: Major > Fix For: 2.20.4, 2.22.1, 2.23.0 > > > When AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE is once set true it survives > current aggregation processing and affects in unexpected way following > aggregation by triggering "forceCompletionOfAllGroups()" again > in next code snippet might be needed some additional handling when the header > is true: > {code:java} > protected void doProcess(Exchange exchange) throws Exception { > ... > // check for the special header to force completion of all groups > (inclusive of the message) > boolean completeAllGroupsInclusive = > exchange.getIn().getHeader(Exchange.AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE, > false, boolean.class); > if (completeAllGroupsInclusive) { > forceCompletionOfAllGroups(); > } > ... > {code} > this consideration is made by analysing similar behavior and lifecycle of > header AGGREGATION_COMPLETE_ALL_GROUPS: > {code:java} > private List doAggregation(String key, Exchange newExchange) throws > CamelExchangeException { > ... > ... > // check for the special exchange property to force completion of all > groups > boolean completeAllGroups = > answer.getProperty(Exchange.AGGREGATION_COMPLETE_ALL_GROUPS, false, > boolean.class); > if (completeAllGroups) { > // remove the exchange property so we do not complete again > answer.removeProperty(Exchange.AGGREGATION_COMPLETE_ALL_GROUPS); > forceCompletionOfAllGroups(); > } else if (isCompletionOnNewCorrelationGroup() && originalExchange == > null) { > // its a new group so force complete of all existing groups > forceCompletionOfAllGroups(); > } > ... > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (CAMEL-12594) Rest Producer - Query Parameters : Wrong query parameter name is used when header substitution is performed
[ https://issues.apache.org/jira/browse/CAMEL-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533597#comment-16533597 ] Leonid Remennik edited comment on CAMEL-12594 at 7/5/18 12:32 PM: -- [~dmvolod] - please find repro JUnit modification here - [https://github.com/apache/camel/pull/2409] The code fix was already provided. Repro was blind coded in github editor - so I hope it compiles at all ;) was (Author: leonidre): [~dmvolod] - please find repro JUnit modification here - [https://github.com/apache/camel/pull/2409] The code fix was already provided > Rest Producer - Query Parameters : Wrong query parameter name is used when > header substitution is performed > > > Key: CAMEL-12594 > URL: https://issues.apache.org/jira/browse/CAMEL-12594 > Project: Camel > Issue Type: Bug > Components: camel-core >Affects Versions: 2.22.0 >Reporter: Leonid Remennik >Priority: Major > Labels: rest > Fix For: 2.22.1, 2.23.0 > > > CAMEL-11050 > [https://github.com/apache/camel/commit/35638b280be7ca43031ea4c5d937590f30495e70] > Introduced a bug in this line > [https://github.com/apache/camel/blob/6938a4ea6b68e295fae48f52e8e7cb2628f161a3/camel-core/src/main/java/org/apache/camel/component/rest/RestProducer.java#L409] > > The fix is (probably) to replace the line with : > params.put(entry.getKey(), value); > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12594) Rest Producer - Query Parameters : Wrong query parameter name is used when header substitution is performed
[ https://issues.apache.org/jira/browse/CAMEL-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533597#comment-16533597 ] Leonid Remennik commented on CAMEL-12594: - [~dmvolod] - please find repro JUnit modification here - [https://github.com/apache/camel/pull/2409] The code fix was already provided > Rest Producer - Query Parameters : Wrong query parameter name is used when > header substitution is performed > > > Key: CAMEL-12594 > URL: https://issues.apache.org/jira/browse/CAMEL-12594 > Project: Camel > Issue Type: Bug > Components: camel-core >Affects Versions: 2.22.0 >Reporter: Leonid Remennik >Priority: Major > Labels: rest > Fix For: 2.22.1, 2.23.0 > > > CAMEL-11050 > [https://github.com/apache/camel/commit/35638b280be7ca43031ea4c5d937590f30495e70] > Introduced a bug in this line > [https://github.com/apache/camel/blob/6938a4ea6b68e295fae48f52e8e7cb2628f161a3/camel-core/src/main/java/org/apache/camel/component/rest/RestProducer.java#L409] > > The fix is (probably) to replace the line with : > params.put(entry.getKey(), value); > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12589) Surviving Header AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE affects following aggregations
[ https://issues.apache.org/jira/browse/CAMEL-12589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533591#comment-16533591 ] Claus Ibsen commented on CAMEL-12589: - Okay it was not a minor as you cannot easily workaround this in the custom aggregation repository, where you can remove these headers yourself. > Surviving Header AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE affects following > aggregations > - > > Key: CAMEL-12589 > URL: https://issues.apache.org/jira/browse/CAMEL-12589 > Project: Camel > Issue Type: Bug > Components: camel-core >Affects Versions: 2.21.0, 2.21.1 >Reporter: Gianandrea Rigoni >Assignee: Claus Ibsen >Priority: Major > Fix For: 2.22.1, 2.23.0 > > > When AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE is once set true it survives > current aggregation processing and affects in unexpected way following > aggregation by triggering "forceCompletionOfAllGroups()" again > in next code snippet might be needed some additional handling when the header > is true: > {code:java} > protected void doProcess(Exchange exchange) throws Exception { > ... > // check for the special header to force completion of all groups > (inclusive of the message) > boolean completeAllGroupsInclusive = > exchange.getIn().getHeader(Exchange.AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE, > false, boolean.class); > if (completeAllGroupsInclusive) { > forceCompletionOfAllGroups(); > } > ... > {code} > this consideration is made by analysing similar behavior and lifecycle of > header AGGREGATION_COMPLETE_ALL_GROUPS: > {code:java} > private List doAggregation(String key, Exchange newExchange) throws > CamelExchangeException { > ... > ... > // check for the special exchange property to force completion of all > groups > boolean completeAllGroups = > answer.getProperty(Exchange.AGGREGATION_COMPLETE_ALL_GROUPS, false, > boolean.class); > if (completeAllGroups) { > // remove the exchange property so we do not complete again > answer.removeProperty(Exchange.AGGREGATION_COMPLETE_ALL_GROUPS); > forceCompletionOfAllGroups(); > } else if (isCompletionOnNewCorrelationGroup() && originalExchange == > null) { > // its a new group so force complete of all existing groups > forceCompletionOfAllGroups(); > } > ... > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12594) Rest Producer - Query Parameters : Wrong query parameter name is used when header substitution is performed
[ https://issues.apache.org/jira/browse/CAMEL-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533593#comment-16533593 ] ASF GitHub Bot commented on CAMEL-12594: GitHub user leonidr opened a pull request: https://github.com/apache/camel/pull/2409 CAMEL-12594 repro CAMEL-12594 repro You can merge this pull request into a Git repository by running: $ git pull https://github.com/leonidr/camel patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/camel/pull/2409.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2409 commit 850681be7b9da8aaf80a7ae4e21b83e3bca13911 Author: leonidr Date: 2018-07-05T12:27:50Z CAMEL-12594 repro CAMEL-12594 repro > Rest Producer - Query Parameters : Wrong query parameter name is used when > header substitution is performed > > > Key: CAMEL-12594 > URL: https://issues.apache.org/jira/browse/CAMEL-12594 > Project: Camel > Issue Type: Bug > Components: camel-core >Affects Versions: 2.22.0 >Reporter: Leonid Remennik >Priority: Major > Labels: rest > Fix For: 2.22.1, 2.23.0 > > > CAMEL-11050 > [https://github.com/apache/camel/commit/35638b280be7ca43031ea4c5d937590f30495e70] > Introduced a bug in this line > [https://github.com/apache/camel/blob/6938a4ea6b68e295fae48f52e8e7cb2628f161a3/camel-core/src/main/java/org/apache/camel/component/rest/RestProducer.java#L409] > > The fix is (probably) to replace the line with : > params.put(entry.getKey(), value); > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12594) Rest Producer - Query Parameters : Wrong query parameter name is used when header substitution is performed
[ https://issues.apache.org/jira/browse/CAMEL-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533592#comment-16533592 ] ASF GitHub Bot commented on CAMEL-12594: leonidr opened a new pull request #2409: CAMEL-12594 repro URL: https://github.com/apache/camel/pull/2409 CAMEL-12594 repro This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Rest Producer - Query Parameters : Wrong query parameter name is used when > header substitution is performed > > > Key: CAMEL-12594 > URL: https://issues.apache.org/jira/browse/CAMEL-12594 > Project: Camel > Issue Type: Bug > Components: camel-core >Affects Versions: 2.22.0 >Reporter: Leonid Remennik >Priority: Major > Labels: rest > Fix For: 2.22.1, 2.23.0 > > > CAMEL-11050 > [https://github.com/apache/camel/commit/35638b280be7ca43031ea4c5d937590f30495e70] > Introduced a bug in this line > [https://github.com/apache/camel/blob/6938a4ea6b68e295fae48f52e8e7cb2628f161a3/camel-core/src/main/java/org/apache/camel/component/rest/RestProducer.java#L409] > > The fix is (probably) to replace the line with : > params.put(entry.getKey(), value); > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (CAMEL-12589) Surviving Header AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE affects following aggregations
[ https://issues.apache.org/jira/browse/CAMEL-12589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen updated CAMEL-12589: Priority: Major (was: Minor) > Surviving Header AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE affects following > aggregations > - > > Key: CAMEL-12589 > URL: https://issues.apache.org/jira/browse/CAMEL-12589 > Project: Camel > Issue Type: Bug > Components: camel-core >Affects Versions: 2.21.0, 2.21.1 >Reporter: Gianandrea Rigoni >Assignee: Claus Ibsen >Priority: Major > Fix For: 2.22.1, 2.23.0 > > > When AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE is once set true it survives > current aggregation processing and affects in unexpected way following > aggregation by triggering "forceCompletionOfAllGroups()" again > in next code snippet might be needed some additional handling when the header > is true: > {code:java} > protected void doProcess(Exchange exchange) throws Exception { > ... > // check for the special header to force completion of all groups > (inclusive of the message) > boolean completeAllGroupsInclusive = > exchange.getIn().getHeader(Exchange.AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE, > false, boolean.class); > if (completeAllGroupsInclusive) { > forceCompletionOfAllGroups(); > } > ... > {code} > this consideration is made by analysing similar behavior and lifecycle of > header AGGREGATION_COMPLETE_ALL_GROUPS: > {code:java} > private List doAggregation(String key, Exchange newExchange) throws > CamelExchangeException { > ... > ... > // check for the special exchange property to force completion of all > groups > boolean completeAllGroups = > answer.getProperty(Exchange.AGGREGATION_COMPLETE_ALL_GROUPS, false, > boolean.class); > if (completeAllGroups) { > // remove the exchange property so we do not complete again > answer.removeProperty(Exchange.AGGREGATION_COMPLETE_ALL_GROUPS); > forceCompletionOfAllGroups(); > } else if (isCompletionOnNewCorrelationGroup() && originalExchange == > null) { > // its a new group so force complete of all existing groups > forceCompletionOfAllGroups(); > } > ... > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (CAMEL-12589) Surviving Header AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE affects following aggregations
[ https://issues.apache.org/jira/browse/CAMEL-12589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen reassigned CAMEL-12589: --- Assignee: Claus Ibsen > Surviving Header AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE affects following > aggregations > - > > Key: CAMEL-12589 > URL: https://issues.apache.org/jira/browse/CAMEL-12589 > Project: Camel > Issue Type: Bug > Components: camel-core >Affects Versions: 2.21.0, 2.21.1 >Reporter: Gianandrea Rigoni >Assignee: Claus Ibsen >Priority: Minor > Fix For: 2.22.1, 2.23.0 > > > When AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE is once set true it survives > current aggregation processing and affects in unexpected way following > aggregation by triggering "forceCompletionOfAllGroups()" again > in next code snippet might be needed some additional handling when the header > is true: > {code:java} > protected void doProcess(Exchange exchange) throws Exception { > ... > // check for the special header to force completion of all groups > (inclusive of the message) > boolean completeAllGroupsInclusive = > exchange.getIn().getHeader(Exchange.AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE, > false, boolean.class); > if (completeAllGroupsInclusive) { > forceCompletionOfAllGroups(); > } > ... > {code} > this consideration is made by analysing similar behavior and lifecycle of > header AGGREGATION_COMPLETE_ALL_GROUPS: > {code:java} > private List doAggregation(String key, Exchange newExchange) throws > CamelExchangeException { > ... > ... > // check for the special exchange property to force completion of all > groups > boolean completeAllGroups = > answer.getProperty(Exchange.AGGREGATION_COMPLETE_ALL_GROUPS, false, > boolean.class); > if (completeAllGroups) { > // remove the exchange property so we do not complete again > answer.removeProperty(Exchange.AGGREGATION_COMPLETE_ALL_GROUPS); > forceCompletionOfAllGroups(); > } else if (isCompletionOnNewCorrelationGroup() && originalExchange == > null) { > // its a new group so force complete of all existing groups > forceCompletionOfAllGroups(); > } > ... > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (CAMEL-12589) Surviving Header AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE affects following aggregations
[ https://issues.apache.org/jira/browse/CAMEL-12589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen updated CAMEL-12589: Fix Version/s: 2.23.0 2.22.1 > Surviving Header AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE affects following > aggregations > - > > Key: CAMEL-12589 > URL: https://issues.apache.org/jira/browse/CAMEL-12589 > Project: Camel > Issue Type: Bug > Components: camel-core >Affects Versions: 2.21.0, 2.21.1 >Reporter: Gianandrea Rigoni >Priority: Minor > Fix For: 2.22.1, 2.23.0 > > > When AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE is once set true it survives > current aggregation processing and affects in unexpected way following > aggregation by triggering "forceCompletionOfAllGroups()" again > in next code snippet might be needed some additional handling when the header > is true: > {code:java} > protected void doProcess(Exchange exchange) throws Exception { > ... > // check for the special header to force completion of all groups > (inclusive of the message) > boolean completeAllGroupsInclusive = > exchange.getIn().getHeader(Exchange.AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE, > false, boolean.class); > if (completeAllGroupsInclusive) { > forceCompletionOfAllGroups(); > } > ... > {code} > this consideration is made by analysing similar behavior and lifecycle of > header AGGREGATION_COMPLETE_ALL_GROUPS: > {code:java} > private List doAggregation(String key, Exchange newExchange) throws > CamelExchangeException { > ... > ... > // check for the special exchange property to force completion of all > groups > boolean completeAllGroups = > answer.getProperty(Exchange.AGGREGATION_COMPLETE_ALL_GROUPS, false, > boolean.class); > if (completeAllGroups) { > // remove the exchange property so we do not complete again > answer.removeProperty(Exchange.AGGREGATION_COMPLETE_ALL_GROUPS); > forceCompletionOfAllGroups(); > } else if (isCompletionOnNewCorrelationGroup() && originalExchange == > null) { > // its a new group so force complete of all existing groups > forceCompletionOfAllGroups(); > } > ... > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (CAMEL-12589) Surviving Header AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE affects following aggregations
[ https://issues.apache.org/jira/browse/CAMEL-12589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen updated CAMEL-12589: Priority: Minor (was: Major) > Surviving Header AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE affects following > aggregations > - > > Key: CAMEL-12589 > URL: https://issues.apache.org/jira/browse/CAMEL-12589 > Project: Camel > Issue Type: Bug > Components: camel-core >Affects Versions: 2.21.0, 2.21.1 >Reporter: Gianandrea Rigoni >Priority: Minor > > When AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE is once set true it survives > current aggregation processing and affects in unexpected way following > aggregation by triggering "forceCompletionOfAllGroups()" again > in next code snippet might be needed some additional handling when the header > is true: > {code:java} > protected void doProcess(Exchange exchange) throws Exception { > ... > // check for the special header to force completion of all groups > (inclusive of the message) > boolean completeAllGroupsInclusive = > exchange.getIn().getHeader(Exchange.AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE, > false, boolean.class); > if (completeAllGroupsInclusive) { > forceCompletionOfAllGroups(); > } > ... > {code} > this consideration is made by analysing similar behavior and lifecycle of > header AGGREGATION_COMPLETE_ALL_GROUPS: > {code:java} > private List doAggregation(String key, Exchange newExchange) throws > CamelExchangeException { > ... > ... > // check for the special exchange property to force completion of all > groups > boolean completeAllGroups = > answer.getProperty(Exchange.AGGREGATION_COMPLETE_ALL_GROUPS, false, > boolean.class); > if (completeAllGroups) { > // remove the exchange property so we do not complete again > answer.removeProperty(Exchange.AGGREGATION_COMPLETE_ALL_GROUPS); > forceCompletionOfAllGroups(); > } else if (isCompletionOnNewCorrelationGroup() && originalExchange == > null) { > // its a new group so force complete of all existing groups > forceCompletionOfAllGroups(); > } > ... > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (CAMEL-12609) DefaultExchangeFormatter: Make it easy to override the header and property formatting
[ https://issues.apache.org/jira/browse/CAMEL-12609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen resolved CAMEL-12609. - Resolution: Fixed Assignee: Claus Ibsen Fix Version/s: 2.23.0 Thanks for the PR > DefaultExchangeFormatter: Make it easy to override the header and property > formatting > -- > > Key: CAMEL-12609 > URL: https://issues.apache.org/jira/browse/CAMEL-12609 > Project: Camel > Issue Type: Improvement >Reporter: Darius Cooper >Assignee: Claus Ibsen >Priority: Minor > Fix For: 2.23.0 > > > To omit certain headers (or mask their values) in ExchangeFormatter, one can > write a custom implementation. > In > [DefaultExchangeFormatter|[https://github.com/apache/camel/blob/apache-master/camel-core/src/main/java/org/apache/camel/processor/DefaultExchangeFormatter.java],] > ... it would be nice if the header-formatting (maybe the Property > formatting) was done as separate methods that we could over-ride, while > keeping the rest of the functionality. > Not sure if it would be acceptable to do this without also changing the > ExchangeFormatter interface to add such methods. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (CAMEL-12594) Rest Producer - Query Parameters : Wrong query parameter name is used when header substitution is performed
[ https://issues.apache.org/jira/browse/CAMEL-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen updated CAMEL-12594: Fix Version/s: 2.23.0 2.22.1 > Rest Producer - Query Parameters : Wrong query parameter name is used when > header substitution is performed > > > Key: CAMEL-12594 > URL: https://issues.apache.org/jira/browse/CAMEL-12594 > Project: Camel > Issue Type: Bug > Components: camel-core >Affects Versions: 2.22.0 >Reporter: Leonid Remennik >Priority: Major > Labels: rest > Fix For: 2.22.1, 2.23.0 > > > CAMEL-11050 > [https://github.com/apache/camel/commit/35638b280be7ca43031ea4c5d937590f30495e70] > Introduced a bug in this line > [https://github.com/apache/camel/blob/6938a4ea6b68e295fae48f52e8e7cb2628f161a3/camel-core/src/main/java/org/apache/camel/component/rest/RestProducer.java#L409] > > The fix is (probably) to replace the line with : > params.put(entry.getKey(), value); > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12609) DefaultExchangeFormatter: Make it easy to override the header and property formatting
[ https://issues.apache.org/jira/browse/CAMEL-12609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533572#comment-16533572 ] ASF GitHub Bot commented on CAMEL-12609: davsclaus closed pull request #2408: CAMEL-12609: Filter Headers/Properties in DefaultExchangeFormatter URL: https://github.com/apache/camel/pull/2408 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/camel-core/src/main/java/org/apache/camel/processor/DefaultExchangeFormatter.java b/camel-core/src/main/java/org/apache/camel/processor/DefaultExchangeFormatter.java index 3f05e306813..b98395d7a2b 100644 --- a/camel-core/src/main/java/org/apache/camel/processor/DefaultExchangeFormatter.java +++ b/camel-core/src/main/java/org/apache/camel/processor/DefaultExchangeFormatter.java @@ -111,13 +111,13 @@ public String format(Exchange exchange) { if (multiline) { sb.append(SEPARATOR); } - sb.append(style("Properties")).append(sortMap(exchange.getProperties())); + sb.append(style("Properties")).append(sortMap(filterHeaderAndProperties(exchange.getProperties(; } if (showAll || showHeaders) { if (multiline) { sb.append(SEPARATOR); } -sb.append(style("Headers")).append(sortMap(in.getHeaders())); + sb.append(style("Headers")).append(sortMap(filterHeaderAndProperties(in.getHeaders(; } if (showAll || showBodyType) { if (multiline) { @@ -173,7 +173,7 @@ public String format(Exchange exchange) { if (multiline) { sb.append(SEPARATOR); } - sb.append(style("OutHeaders")).append(sortMap(out.getHeaders())); + sb.append(style("OutHeaders")).append(sortMap(filterHeaderAndProperties(out.getHeaders(; } if (showAll || showBodyType) { if (multiline) { @@ -235,6 +235,15 @@ public String format(Exchange exchange) { } } +/** + * Filters the headers or properties before formatting them. No default behavior, but can be overridden. + * @param map + * @return + */ +protected Map filterHeaderAndProperties(Map map) { +return map; +} + public boolean isShowExchangeId() { return showExchangeId; } This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > DefaultExchangeFormatter: Make it easy to override the header and property > formatting > -- > > Key: CAMEL-12609 > URL: https://issues.apache.org/jira/browse/CAMEL-12609 > Project: Camel > Issue Type: Improvement >Reporter: Darius Cooper >Priority: Minor > > To omit certain headers (or mask their values) in ExchangeFormatter, one can > write a custom implementation. > In > [DefaultExchangeFormatter|[https://github.com/apache/camel/blob/apache-master/camel-core/src/main/java/org/apache/camel/processor/DefaultExchangeFormatter.java],] > ... it would be nice if the header-formatting (maybe the Property > formatting) was done as separate methods that we could over-ride, while > keeping the rest of the functionality. > Not sure if it would be acceptable to do this without also changing the > ExchangeFormatter interface to add such methods. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12609) DefaultExchangeFormatter: Make it easy to override the header and property formatting
[ https://issues.apache.org/jira/browse/CAMEL-12609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533573#comment-16533573 ] ASF GitHub Bot commented on CAMEL-12609: Github user davsclaus closed the pull request at: https://github.com/apache/camel/pull/2408 > DefaultExchangeFormatter: Make it easy to override the header and property > formatting > -- > > Key: CAMEL-12609 > URL: https://issues.apache.org/jira/browse/CAMEL-12609 > Project: Camel > Issue Type: Improvement >Reporter: Darius Cooper >Priority: Minor > > To omit certain headers (or mask their values) in ExchangeFormatter, one can > write a custom implementation. > In > [DefaultExchangeFormatter|[https://github.com/apache/camel/blob/apache-master/camel-core/src/main/java/org/apache/camel/processor/DefaultExchangeFormatter.java],] > ... it would be nice if the header-formatting (maybe the Property > formatting) was done as separate methods that we could over-ride, while > keeping the rest of the functionality. > Not sure if it would be acceptable to do this without also changing the > ExchangeFormatter interface to add such methods. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12609) DefaultExchangeFormatter: Make it easy to override the header and property formatting
[ https://issues.apache.org/jira/browse/CAMEL-12609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533489#comment-16533489 ] ASF GitHub Bot commented on CAMEL-12609: davsclaus commented on a change in pull request #2408: CAMEL-12609: Filter Headers/Properties in DefaultExchangeFormatter URL: https://github.com/apache/camel/pull/2408#discussion_r200305047 ## File path: camel-core/src/main/java/org/apache/camel/processor/DefaultExchangeFormatter.java ## @@ -235,6 +235,16 @@ public String format(Exchange exchange) { } } +/** + * Filters the headers or properties before formatting them. No default behavior, but can be overridden. + * + * @param map Review comment: Can you remove these empty/no-used javadoc lines This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > DefaultExchangeFormatter: Make it easy to override the header and property > formatting > -- > > Key: CAMEL-12609 > URL: https://issues.apache.org/jira/browse/CAMEL-12609 > Project: Camel > Issue Type: Improvement >Reporter: Darius Cooper >Priority: Minor > > To omit certain headers (or mask their values) in ExchangeFormatter, one can > write a custom implementation. > In > [DefaultExchangeFormatter|[https://github.com/apache/camel/blob/apache-master/camel-core/src/main/java/org/apache/camel/processor/DefaultExchangeFormatter.java],] > ... it would be nice if the header-formatting (maybe the Property > formatting) was done as separate methods that we could over-ride, while > keeping the rest of the functionality. > Not sure if it would be acceptable to do this without also changing the > ExchangeFormatter interface to add such methods. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12609) DefaultExchangeFormatter: Make it easy to override the header and property formatting
[ https://issues.apache.org/jira/browse/CAMEL-12609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533484#comment-16533484 ] ASF GitHub Bot commented on CAMEL-12609: DariusX opened a new pull request #2408: CAMEL-12609: Filter Headers/Properties in DefaultExchangeFormatter URL: https://github.com/apache/camel/pull/2408 DefaultExchangeFormatter: Add a NOP method that can be used by child classes to filter headers and properties. I This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > DefaultExchangeFormatter: Make it easy to override the header and property > formatting > -- > > Key: CAMEL-12609 > URL: https://issues.apache.org/jira/browse/CAMEL-12609 > Project: Camel > Issue Type: Improvement >Reporter: Darius Cooper >Priority: Minor > > To omit certain headers (or mask their values) in ExchangeFormatter, one can > write a custom implementation. > In > [DefaultExchangeFormatter|[https://github.com/apache/camel/blob/apache-master/camel-core/src/main/java/org/apache/camel/processor/DefaultExchangeFormatter.java],] > ... it would be nice if the header-formatting (maybe the Property > formatting) was done as separate methods that we could over-ride, while > keeping the rest of the functionality. > Not sure if it would be acceptable to do this without also changing the > ExchangeFormatter interface to add such methods. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12609) DefaultExchangeFormatter: Make it easy to override the header and property formatting
[ https://issues.apache.org/jira/browse/CAMEL-12609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533485#comment-16533485 ] ASF GitHub Bot commented on CAMEL-12609: GitHub user DariusX opened a pull request: https://github.com/apache/camel/pull/2408 CAMEL-12609: Filter Headers/Properties in DefaultExchangeFormatter DefaultExchangeFormatter: Add a NOP method that can be used by child classes to filter headers and properties. I You can merge this pull request into a Git repository by running: $ git pull https://github.com/DariusX/camel CAMEL-12609-DefaultExchangeFormatter Alternatively you can review and apply these changes as the patch at: https://github.com/apache/camel/pull/2408.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2408 commit 6e20f4bb59ead9a84a027573893f08a95c9d5bfa Author: dariusx Date: 2018-07-05T10:22:54Z CAMEL-12609: Filter Headers/Properties in DefaultExchangeFormatter > DefaultExchangeFormatter: Make it easy to override the header and property > formatting > -- > > Key: CAMEL-12609 > URL: https://issues.apache.org/jira/browse/CAMEL-12609 > Project: Camel > Issue Type: Improvement >Reporter: Darius Cooper >Priority: Minor > > To omit certain headers (or mask their values) in ExchangeFormatter, one can > write a custom implementation. > In > [DefaultExchangeFormatter|[https://github.com/apache/camel/blob/apache-master/camel-core/src/main/java/org/apache/camel/processor/DefaultExchangeFormatter.java],] > ... it would be nice if the header-formatting (maybe the Property > formatting) was done as separate methods that we could over-ride, while > keeping the rest of the functionality. > Not sure if it would be acceptable to do this without also changing the > ExchangeFormatter interface to add such methods. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (CAMEL-12607) When using Tokenizer skipFirst - java.util.NoSuchElementException if only one element
[ https://issues.apache.org/jira/browse/CAMEL-12607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Volodin resolved CAMEL-12607. Resolution: Fixed Thanks [~ssavenko] for reporting. > When using Tokenizer skipFirst - java.util.NoSuchElementException if only one > element > - > > Key: CAMEL-12607 > URL: https://issues.apache.org/jira/browse/CAMEL-12607 > Project: Camel > Issue Type: Bug > Components: camel-core >Affects Versions: 2.21.1 >Reporter: Sergey Savenko >Assignee: Dmitry Volodin >Priority: Minor > Fix For: 2.21.2, 2.22.1, 2.23.0 > > > I use {{.split().tokenize("\n", 1, true).streaming()}} to stream csv file > with header row and skip first line. > When file contains ONLY header row - {{java.util.NoSuchElementException}} is > thrown in > [https://github.com/apache/camel/blob/camel-2.21.1/camel-core/src/main/java/org/apache/camel/util/GroupTokenIterator.java#L158], > because when it skips first line - it does not check if it has next line and > just calls next(). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (CAMEL-12610) Camel bean component invokes cached instance of bean in Registry
[ https://issues.apache.org/jira/browse/CAMEL-12610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang reassigned CAMEL-12610: Assignee: Willem Jiang > Camel bean component invokes cached instance of bean in Registry > > > Key: CAMEL-12610 > URL: https://issues.apache.org/jira/browse/CAMEL-12610 > Project: Camel > Issue Type: Bug > Components: camel-core >Affects Versions: 2.20.0, 2.20.1, 2.20.2, 2.20.3, 2.21.0, 2.21.1, 2.22.0 > Environment: N/A >Reporter: Jan Bednar >Assignee: Willem Jiang >Priority: Major > Attachments: Referring objects for originalInstance.png, Stack during > second invocation of SomeDependentBean.txt > > > Related SO question: > [https://stackoverflow.com/questions/51108913/camel-bean-component-invokes-cached-instance-of-named-dependent-bean] > Every invocation of bean component should query Registry for actual instance. > Now it is cached in {{BeanProcessor#delegate}} variable, even if endpoint > parameter {{cache=false}} specified. > This behavior breaks java-ee compliance: > [https://docs.oracle.com/javaee/7/api/javax/enterprise/context/Dependent.html] > {quote}Every invocation of the [{{Context.get(Contextual, > CreationalContext)}}|https://docs.oracle.com/javaee/7/api/javax/enterprise/context/spi/Context.html#get-javax.enterprise.context.spi.Contextual-javax.enterprise.context.spi.CreationalContext-] > operation of the context object for the {{@Dependent}} scope returns a new > instance of the given bean. > {quote} > Marking this as Major, because upgrading of Camel from 2.19.x to 2.2x.x leads > to unpredictable results in CDI environment. Since this is tied to CDI > environment, this issue is hard to notice even in well junit covered > application and can result in major issues in pre-production or production > environment. > Full reproducible project with unit test and deployable WAR package, which > passes with 2.19.x and lower. Fails with 2.20.x and higher [on > Github|https://github.com/bedlaj/camel-dependent-bean]. > Attachments are based on version 2.21.1 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (CAMEL-12625) Create FHIR Camel component with example
John Poth created CAMEL-12625: - Summary: Create FHIR Camel component with example Key: CAMEL-12625 URL: https://issues.apache.org/jira/browse/CAMEL-12625 Project: Camel Issue Type: New Feature Reporter: John Poth Assignee: John Poth Create Camel component to integrate with [FHIR|[http://example.com|http://hapifhir.io/doc_rest_server.html]] endpoints. I'll submit a PR -- This message was sent by Atlassian JIRA (v7.6.3#76005)