[jira] [Updated] (CAMEL-13006) Missing properties on Olingo4 consumer initialisation

2018-12-20 Thread Dmitry Volodin (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-13006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dmitry Volodin updated CAMEL-13006:
---
Fix Version/s: 2.23.1
   2.24.0
   3.0.0
   2.22.3
   2.21.4

> Missing properties on Olingo4 consumer initialisation
> -
>
> Key: CAMEL-13006
> URL: https://issues.apache.org/jira/browse/CAMEL-13006
> Project: Camel
>  Issue Type: Bug
>  Components: camel-olingo4
>Affects Versions: 2.21.0
>Reporter: Paul Richardson
>Assignee: Dmitry Volodin
>Priority: Major
> Fix For: 2.21.4, 2.22.3, 3.0.0, 2.24.0, 2.23.1
>
> Attachments: 
> 0001-CAMEL-13006-Fix-for-required-properties-in-odata-con.patch
>
>
> Essentially, after replacing the olingo4 component in the context to bypass 
> the null [serviceUri 
> issue|https://issues.apache.org/jira/browse/CAMEL-13005], the route moves on 
> to initialising the Olingo4Consumer. The latter tests the '_read_' method to 
> ensure all properties have been set [#(1)]. However, this fails due to the 
> properties '_edm_' and '_responseHandler_' being missing.
> Have come up with a test [#(2)] that demonstrates the problem.
> These properties are not documented (since they appear to be output 
> properties). However
> , they are added into the property names collection of the endpoint [#(3)]. 
> This collection is compared against the method signatures in the 
> Olingo4AppEndpointConfiguration and neither _s/getEdm_ or 
> _s/getResponseHandler_ exist hence the exception thrown.
> {anchor:(1)} [1] 
> https://github.com/apache/camel/blob/master/camel-core/src/main/java/org/apache/camel/util/component/ApiConsumerHelper.java#L55
> {anchor:(2)} [2] 
> https://gist.github.com/phantomjinx/90ee08a989ddff4366d792cc621b36a9#file-properties-issue-java
> {anchor:(3)} [3] 
> https://github.com/apache/camel/blob/master/components/camel-olingo4/camel-olingo4-component/src/main/java/org/apache/camel/component/olingo4/Olingo4Endpoint.java#L150



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (CAMEL-13006) Missing properties on Olingo4 consumer initialisation

2018-12-20 Thread Dmitry Volodin (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-13006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dmitry Volodin resolved CAMEL-13006.

Resolution: Fixed

Thanks [~phantomjinx] for reporting and provided fix.

> Missing properties on Olingo4 consumer initialisation
> -
>
> Key: CAMEL-13006
> URL: https://issues.apache.org/jira/browse/CAMEL-13006
> Project: Camel
>  Issue Type: Bug
>  Components: camel-olingo4
>Affects Versions: 2.21.0
>Reporter: Paul Richardson
>Assignee: Dmitry Volodin
>Priority: Major
> Fix For: 2.21.4, 2.22.3, 3.0.0, 2.24.0, 2.23.1
>
> Attachments: 
> 0001-CAMEL-13006-Fix-for-required-properties-in-odata-con.patch
>
>
> Essentially, after replacing the olingo4 component in the context to bypass 
> the null [serviceUri 
> issue|https://issues.apache.org/jira/browse/CAMEL-13005], the route moves on 
> to initialising the Olingo4Consumer. The latter tests the '_read_' method to 
> ensure all properties have been set [#(1)]. However, this fails due to the 
> properties '_edm_' and '_responseHandler_' being missing.
> Have come up with a test [#(2)] that demonstrates the problem.
> These properties are not documented (since they appear to be output 
> properties). However
> , they are added into the property names collection of the endpoint [#(3)]. 
> This collection is compared against the method signatures in the 
> Olingo4AppEndpointConfiguration and neither _s/getEdm_ or 
> _s/getResponseHandler_ exist hence the exception thrown.
> {anchor:(1)} [1] 
> https://github.com/apache/camel/blob/master/camel-core/src/main/java/org/apache/camel/util/component/ApiConsumerHelper.java#L55
> {anchor:(2)} [2] 
> https://gist.github.com/phantomjinx/90ee08a989ddff4366d792cc621b36a9#file-properties-issue-java
> {anchor:(3)} [3] 
> https://github.com/apache/camel/blob/master/components/camel-olingo4/camel-olingo4-component/src/main/java/org/apache/camel/component/olingo4/Olingo4Endpoint.java#L150



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-13025) camel-core - File read lock changed - If file gets deleted then break out loop

2018-12-20 Thread Claus Ibsen (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-13025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726274#comment-16726274
 ] 

Claus Ibsen commented on CAMEL-13025:
-

Contributions is welcome

In the file FileChangedExclusiveReadLockStrategy we need to add check if the 
target file exists, in the while loop

> camel-core - File read lock changed - If file gets deleted then break out loop
> --
>
> Key: CAMEL-13025
> URL: https://issues.apache.org/jira/browse/CAMEL-13025
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Affects Versions: 2.18.5
>Reporter: Claus Ibsen
>Priority: Major
> Fix For: 3.0.0, 2.24.0
>
>
> See SO
> https://stackoverflow.com/questions/53865940/apache-camel-route-hangs-when-file-is-deleted-during-processing?noredirect=1#comment94587192_53865940
> So if the target file gets deleted during the check interval and you have 
> timeout = 0, then it will keep looping. So we should add a check if the file 
> still exists in the looping.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (CAMEL-13025) camel-core - File read lock changed - If file gets deleted then break out loop

2018-12-20 Thread Claus Ibsen (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-13025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen updated CAMEL-13025:

Fix Version/s: 2.24.0
   3.0.0

> camel-core - File read lock changed - If file gets deleted then break out loop
> --
>
> Key: CAMEL-13025
> URL: https://issues.apache.org/jira/browse/CAMEL-13025
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Affects Versions: 2.18.5
>Reporter: Claus Ibsen
>Priority: Major
> Fix For: 3.0.0, 2.24.0
>
>
> See SO
> https://stackoverflow.com/questions/53865940/apache-camel-route-hangs-when-file-is-deleted-during-processing?noredirect=1#comment94587192_53865940
> So if the target file gets deleted during the check interval and you have 
> timeout = 0, then it will keep looping. So we should add a check if the file 
> still exists in the looping.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (CAMEL-13025) camel-core - File read lock changed - If file gets deleted then break out loop

2018-12-20 Thread Claus Ibsen (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-13025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen updated CAMEL-13025:

Estimated Complexity: Novice  (was: Unknown)

> camel-core - File read lock changed - If file gets deleted then break out loop
> --
>
> Key: CAMEL-13025
> URL: https://issues.apache.org/jira/browse/CAMEL-13025
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Affects Versions: 2.18.5
>Reporter: Claus Ibsen
>Priority: Major
>
> See SO
> https://stackoverflow.com/questions/53865940/apache-camel-route-hangs-when-file-is-deleted-during-processing?noredirect=1#comment94587192_53865940
> So if the target file gets deleted during the check interval and you have 
> timeout = 0, then it will keep looping. So we should add a check if the file 
> still exists in the looping.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (CAMEL-13025) camel-core - File read lock changed - If file gets deleted then break out loop

2018-12-20 Thread Claus Ibsen (JIRA)
Claus Ibsen created CAMEL-13025:
---

 Summary: camel-core - File read lock changed - If file gets 
deleted then break out loop
 Key: CAMEL-13025
 URL: https://issues.apache.org/jira/browse/CAMEL-13025
 Project: Camel
  Issue Type: Improvement
  Components: camel-core
Affects Versions: 2.18.5
Reporter: Claus Ibsen


See SO
https://stackoverflow.com/questions/53865940/apache-camel-route-hangs-when-file-is-deleted-during-processing?noredirect=1#comment94587192_53865940

So if the target file gets deleted during the check interval and you have 
timeout = 0, then it will keep looping. So we should add a check if the file 
still exists in the looping.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (CAMEL-13002) Fix Karaf features in Camel 3

2018-12-20 Thread Andrea Cosentino (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-13002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino updated CAMEL-13002:
-
Priority: Critical  (was: Major)

> Fix Karaf features in Camel 3
> -
>
> Key: CAMEL-13002
> URL: https://issues.apache.org/jira/browse/CAMEL-13002
> Project: Camel
>  Issue Type: Task
>  Components: karaf
>Reporter: Andrea Cosentino
>Priority: Critical
> Fix For: 3.0.0
>
>
> In 3.x branch, currently, the Karaf features are not working because of the 
> refactoring of Camel-core. We need to take a look. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (CAMEL-13024) Camel-Mail breaks some attachment names with many special characters

2018-12-20 Thread Stephan Siano (JIRA)
Stephan Siano created CAMEL-13024:
-

 Summary: Camel-Mail breaks some attachment names with many special 
characters
 Key: CAMEL-13024
 URL: https://issues.apache.org/jira/browse/CAMEL-13024
 Project: Camel
  Issue Type: Bug
  Components: camel-mail
Affects Versions: 2.23.0
Reporter: Stephan Siano
 Attachments: MailBindingAttachmentEncodedFilenameTest.java

The patch for CAMEL-12630 introduced the following line for Attachment file 
names in the MailBinding class.
{code:java}
String fileName = FileUtil.stripPath(part.getFileName());{code}
This code usually makes sense, it strips paths from attachment names. However, 
if the file name of the attachment contains many non-ASCII characters (more 
than ASCII characters) the file name provided by the mail is Base64 encoded, 
e.g.: "=?UTF-8?B?6Kq/5pW0?="

As the / is a valid character in Base64 encoding (but is not a path delimiter 
there) the stripPath() call on that string will mutilate the filename to 
"5pW0?=".

A workaround for this issue is to set the Java system property 
"mail.mime.decodefilename" to "true". In this case the part.getFileName() will 
decode the filename before stripping paths.

The attached unit test might demonstrate the issue.

I am not sure how this can be fixed in a compatible way. One option would be to 
perform a MimeUtility.decodeText() call on the file name (if it is not null), 
which will essentially have the same effect as setting the system property 
(which means that the attachment filename is decoded before processing it 
further), but this will be kind of incompatible.

Note: The issue will not occur if there are more ASCII characters than 
non-ASCII characters in the filename, because in that case the non-ASCII 
characters will be encoded using quoted printable encoding (which does not 
include a "/" character), and even if the file name is Base64 encoded it does 
not necessarily mean that the Base64 encoded filename contains a "/", so you 
might hardly see that issue in real life.

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Work logged] (CAMEL-13008) Odata-connector assumes '/' at end of URI

2018-12-20 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-13008?focusedWorklogId=177497=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-177497
 ]

ASF GitHub Bot logged work on CAMEL-13008:
--

Author: ASF GitHub Bot
Created on: 20/Dec/18 13:48
Start Date: 20/Dec/18 13:48
Worklog Time Spent: 10m 
  Work Description: dmvolod opened a new pull request #2681: CAMEL-13008: 
Odata-connector assumes '/' at end of URI
URL: https://github.com/apache/camel/pull/2681
 
 
   @phantomjinx, could you please review this fix. Is it enough for this issue?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 177497)
Time Spent: 10m
Remaining Estimate: 0h

> Odata-connector assumes '/' at end of URI
> -
>
> Key: CAMEL-13008
> URL: https://issues.apache.org/jira/browse/CAMEL-13008
> Project: Camel
>  Issue Type: Bug
>  Components: camel-olingo4
>Affects Versions: 2.21.0
>Reporter: Paul Richardson
>Assignee: Dmitry Volodin
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> An issue comes to light when testing certain odata implementations that do 
> not handle a '/' being added to the end of the consumed URI, eg.
> * Implementation of the olingo4 
> [tutorial|https://olingo.apache.org/doc/odata4/tutorials/read/tutorial_read.html]
> * Services deployed using current implementations of [teiid|http://teiid.io/]
> Use of the odata-connector on these services results in a _malformed URI_ 
> error.
> Essentially, when the service URI is concatenated with the resource path, the 
> constructed URI is 
> [appended|https://github.com/apache/camel/blob/master/components/camel-olingo4/camel-olingo4-api/src/main/java/org/apache/camel/component/olingo4/api/impl/Olingo4AppImpl.java#L781]
>  with a '/' and a '?' prior to the addition of the query parameters.
> This works fine for the reference odata 
> [implementation|https://services.odata.org/TripPinRESTierService/(S(4gus0w41xmxedlzbywj2srqo))/People/?$filter=FirstName%20eq%20%27Scott%27]
>  since can handle the extra '/'.
> Since both teiid and the olingo4 tutorial use the olingo4 libraries, it would 
> seem that the problem might be solved with them. However, it might be 
> advantageous, given odata implementations already deployed, whether this 
> odata-connector might check whether the '/' was supported before appending it?
> (note. a bug [report|https://issues.jboss.org/browse/TEIID-5573] has been 
> logged with the teiid project to this affect).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (CAMEL-13023) Add camel-rest-swagger as Karaf feature

2018-12-20 Thread Claus Ibsen (JIRA)
Claus Ibsen created CAMEL-13023:
---

 Summary: Add camel-rest-swagger as Karaf feature
 Key: CAMEL-13023
 URL: https://issues.apache.org/jira/browse/CAMEL-13023
 Project: Camel
  Issue Type: New Feature
  Components: karaf
Reporter: Claus Ibsen
 Fix For: 3.0.0, 2.24.0


Can we try to get camel-rest-swagger added as a Karaf feature.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (CAMEL-13022) camel-restlet - sending PATCH operation should include body

2018-12-20 Thread Claus Ibsen (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-13022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen resolved CAMEL-13022.
-
Resolution: Fixed

> camel-restlet - sending PATCH operation should include body
> ---
>
> Key: CAMEL-13022
> URL: https://issues.apache.org/jira/browse/CAMEL-13022
> Project: Camel
>  Issue Type: Bug
>  Components: camel-restlet
>Affects Versions: 2.23.0
>Reporter: Claus Ibsen
>Assignee: Claus Ibsen
>Priority: Minor
> Fix For: 2.22.3, 3.0.0, 2.24.0, 2.23.1
>
>
> We currently only include body for PUT and POST. But we should include the 
> body for PATCH as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (CAMEL-13022) camel-restlet - sending PATCH operation should include body

2018-12-20 Thread Claus Ibsen (JIRA)
Claus Ibsen created CAMEL-13022:
---

 Summary: camel-restlet - sending PATCH operation should include 
body
 Key: CAMEL-13022
 URL: https://issues.apache.org/jira/browse/CAMEL-13022
 Project: Camel
  Issue Type: Bug
  Components: camel-restlet
Affects Versions: 2.23.0
Reporter: Claus Ibsen
Assignee: Claus Ibsen
 Fix For: 2.22.3, 3.0.0, 2.24.0, 2.23.1


We currently only include body for PUT and POST. But we should include the body 
for PATCH as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (CAMEL-13021) Remove camel-example-swagger-xml

2018-12-20 Thread Claus Ibsen (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-13021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen resolved CAMEL-13021.
-
Resolution: Fixed

> Remove camel-example-swagger-xml
> 
>
> Key: CAMEL-13021
> URL: https://issues.apache.org/jira/browse/CAMEL-13021
> Project: Camel
>  Issue Type: Task
>  Components: examples
>Reporter: Claus Ibsen
>Assignee: Claus Ibsen
>Priority: Minor
> Fix For: 3.0.0, 2.24.0
>
>
> This example downloads from 3rd party repo - lets avoid this and we have 100 
> other examples already.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (CAMEL-13021) Remove camel-example-swagger-xml

2018-12-20 Thread Claus Ibsen (JIRA)
Claus Ibsen created CAMEL-13021:
---

 Summary: Remove camel-example-swagger-xml
 Key: CAMEL-13021
 URL: https://issues.apache.org/jira/browse/CAMEL-13021
 Project: Camel
  Issue Type: Task
  Components: examples
Reporter: Claus Ibsen
Assignee: Claus Ibsen
 Fix For: 3.0.0, 2.24.0


This example downloads from 3rd party repo - lets avoid this and we have 100 
other examples already.




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (CAMEL-13020) Wrong Jetty Maven plugin referenced

2018-12-20 Thread Zoran Regvart (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-13020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zoran Regvart resolved CAMEL-13020.
---
Resolution: Fixed

> Wrong Jetty Maven plugin referenced
> ---
>
> Key: CAMEL-13020
> URL: https://issues.apache.org/jira/browse/CAMEL-13020
> Project: Camel
>  Issue Type: Bug
>  Components: build system
>Reporter: Zoran Regvart
>Assignee: Zoran Regvart
>Priority: Major
> Fix For: 3.0.0
>
>
> Seems that we have modules that reference 
> {{org.mortbay.jetty:jetty-maven-plugin}} instead of 
> {{org.eclipse.jetty:org.eclipse.jetty}} with the same 
> {{${jetty-plugin-version}}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (CAMEL-13020) Wrong Jetty Maven plugin referenced

2018-12-20 Thread Zoran Regvart (JIRA)
Zoran Regvart created CAMEL-13020:
-

 Summary: Wrong Jetty Maven plugin referenced
 Key: CAMEL-13020
 URL: https://issues.apache.org/jira/browse/CAMEL-13020
 Project: Camel
  Issue Type: Wish
  Components: build system
Reporter: Zoran Regvart
Assignee: Zoran Regvart
 Fix For: 3.0.0


Seems that we have modules that reference 
{{org.mortbay.jetty:jetty-maven-plugin}} instead of 
{{org.eclipse.jetty:org.eclipse.jetty}} with the same 
{{${jetty-plugin-version}}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (CAMEL-13020) Wrong Jetty Maven plugin referenced

2018-12-20 Thread Zoran Regvart (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-13020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zoran Regvart updated CAMEL-13020:
--
Issue Type: Bug  (was: Wish)

> Wrong Jetty Maven plugin referenced
> ---
>
> Key: CAMEL-13020
> URL: https://issues.apache.org/jira/browse/CAMEL-13020
> Project: Camel
>  Issue Type: Bug
>  Components: build system
>Reporter: Zoran Regvart
>Assignee: Zoran Regvart
>Priority: Major
> Fix For: 3.0.0
>
>
> Seems that we have modules that reference 
> {{org.mortbay.jetty:jetty-maven-plugin}} instead of 
> {{org.eclipse.jetty:org.eclipse.jetty}} with the same 
> {{${jetty-plugin-version}}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (CAMEL-13015) camel-spring-boot - load multiple route xml files

2018-12-20 Thread Claus Ibsen (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-13015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen resolved CAMEL-13015.
-
   Resolution: Fixed
Fix Version/s: 2.23.1
   2.22.3

> camel-spring-boot - load multiple route xml files 
> --
>
> Key: CAMEL-13015
> URL: https://issues.apache.org/jira/browse/CAMEL-13015
> Project: Camel
>  Issue Type: New Feature
>  Components: camel-spring-boot
>Reporter: W.Y
>Assignee: Claus Ibsen
>Priority: Minor
> Fix For: 2.22.3, 3.0.0, 2.24.0, 2.23.1
>
>
> When  I use SpringDSL , i want to load two route files 
> For Example route1.xml and route2.xml
> If I put two files in same directory like below , it is working
> camel.springboot.xmlRoutes: file :directory/*.xml 
>  
> If I put two files into different directories , it does not work
> camel.springboot.xmlRoutes: 
> [file:directory1/route1.xml|file:///directory1/route1.xml] , 
> directory2/route2.xml
> Could you please implement this feature?
> Thanks



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (CAMEL-13015) camel-spring-boot - load multiple route xml files

2018-12-20 Thread W.Y (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-13015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

W.Y updated CAMEL-13015:

Description: 
When  I use SpringDSL , i want to load two route files 

For Example route1.xml and route2.xml

If I put two files in same directory like below , it is working

camel.springboot.xmlRoutes: file :directory/*.xml 

 

If I put two files into different directories , it does not work

camel.springboot.xmlRoutes: 
[file:directory1/route1.xml|file:///directory1/route1.xml] , 
directory2/route2.xml

Could you please implement this feature?

Thanks

  was:
why I use SpringDSL , i want to load two route files 

For Example route1.xml and route2.xml

If I put two files in same directory like below , it is working

camel.springboot.xmlRoutes: file :directory/*.xml 

 

If I put two files into different directories , it does not work

camel.springboot.xmlRoutes: 
[file:directory1/route1.xml|file:///directory1/route1.xml] , 
directory2/route2.xml

Could you please implement this feature?

Thanks


> camel-spring-boot - load multiple route xml files 
> --
>
> Key: CAMEL-13015
> URL: https://issues.apache.org/jira/browse/CAMEL-13015
> Project: Camel
>  Issue Type: New Feature
>  Components: camel-spring-boot
>Reporter: W.Y
>Assignee: Claus Ibsen
>Priority: Minor
> Fix For: 3.0.0, 2.24.0
>
>
> When  I use SpringDSL , i want to load two route files 
> For Example route1.xml and route2.xml
> If I put two files in same directory like below , it is working
> camel.springboot.xmlRoutes: file :directory/*.xml 
>  
> If I put two files into different directories , it does not work
> camel.springboot.xmlRoutes: 
> [file:directory1/route1.xml|file:///directory1/route1.xml] , 
> directory2/route2.xml
> Could you please implement this feature?
> Thanks



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (CAMEL-13015) camel-spring-boot - load multiple route xml files

2018-12-20 Thread Claus Ibsen (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-13015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen reassigned CAMEL-13015:
---

Assignee: Claus Ibsen

> camel-spring-boot - load multiple route xml files 
> --
>
> Key: CAMEL-13015
> URL: https://issues.apache.org/jira/browse/CAMEL-13015
> Project: Camel
>  Issue Type: New Feature
>  Components: camel-spring-boot
>Reporter: W.Y
>Assignee: Claus Ibsen
>Priority: Minor
> Fix For: 3.0.0, 2.24.0
>
>
> why I use SpringDSL , i want to load two route files 
> For Example route1.xml and route2.xml
> If I put two files in same directory like below , it is working
> camel.springboot.xmlRoutes: file :directory/*.xml 
>  
> If I put two files into different directories , it does not work
> camel.springboot.xmlRoutes: 
> [file:directory1/route1.xml|file:///directory1/route1.xml] , 
> directory2/route2.xml
> Could you please implement this feature?
> Thanks



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (CAMEL-13015) camel-spring-boot - load multiple route xml files

2018-12-20 Thread Claus Ibsen (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-13015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen updated CAMEL-13015:

Summary: camel-spring-boot - load multiple route xml files   (was: load 
multiple route xml files )

> camel-spring-boot - load multiple route xml files 
> --
>
> Key: CAMEL-13015
> URL: https://issues.apache.org/jira/browse/CAMEL-13015
> Project: Camel
>  Issue Type: New Feature
>Reporter: W.Y
>Priority: Major
>
> why I use SpringDSL , i want to load two route files 
> For Example route1.xml and route2.xml
> If I put two files in same directory like below , it is working
> camel.springboot.xmlRoutes: file :directory/*.xml 
>  
> If I put two files into different directories , it does not work
> camel.springboot.xmlRoutes: 
> [file:directory1/route1.xml|file:///directory1/route1.xml] , 
> directory2/route2.xml
> Could you please implement this feature?
> Thanks



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (CAMEL-13015) camel-spring-boot - load multiple route xml files

2018-12-20 Thread Claus Ibsen (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-13015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen updated CAMEL-13015:

Fix Version/s: 2.24.0
   3.0.0

> camel-spring-boot - load multiple route xml files 
> --
>
> Key: CAMEL-13015
> URL: https://issues.apache.org/jira/browse/CAMEL-13015
> Project: Camel
>  Issue Type: New Feature
>  Components: camel-spring-boot
>Reporter: W.Y
>Priority: Minor
> Fix For: 3.0.0, 2.24.0
>
>
> why I use SpringDSL , i want to load two route files 
> For Example route1.xml and route2.xml
> If I put two files in same directory like below , it is working
> camel.springboot.xmlRoutes: file :directory/*.xml 
>  
> If I put two files into different directories , it does not work
> camel.springboot.xmlRoutes: 
> [file:directory1/route1.xml|file:///directory1/route1.xml] , 
> directory2/route2.xml
> Could you please implement this feature?
> Thanks



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-13006) Missing properties on Olingo4 consumer initialisation

2018-12-20 Thread Paul Richardson (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-13006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725788#comment-16725788
 ] 

Paul Richardson commented on CAMEL-13006:
-

Hi [~dmvolod]

Attached a possible fix for this for your consideration.

> Missing properties on Olingo4 consumer initialisation
> -
>
> Key: CAMEL-13006
> URL: https://issues.apache.org/jira/browse/CAMEL-13006
> Project: Camel
>  Issue Type: Bug
>  Components: camel-olingo4
>Affects Versions: 2.21.0
>Reporter: Paul Richardson
>Assignee: Dmitry Volodin
>Priority: Major
> Attachments: 
> 0001-CAMEL-13006-Fix-for-required-properties-in-odata-con.patch
>
>
> Essentially, after replacing the olingo4 component in the context to bypass 
> the null [serviceUri 
> issue|https://issues.apache.org/jira/browse/CAMEL-13005], the route moves on 
> to initialising the Olingo4Consumer. The latter tests the '_read_' method to 
> ensure all properties have been set [#(1)]. However, this fails due to the 
> properties '_edm_' and '_responseHandler_' being missing.
> Have come up with a test [#(2)] that demonstrates the problem.
> These properties are not documented (since they appear to be output 
> properties). However
> , they are added into the property names collection of the endpoint [#(3)]. 
> This collection is compared against the method signatures in the 
> Olingo4AppEndpointConfiguration and neither _s/getEdm_ or 
> _s/getResponseHandler_ exist hence the exception thrown.
> {anchor:(1)} [1] 
> https://github.com/apache/camel/blob/master/camel-core/src/main/java/org/apache/camel/util/component/ApiConsumerHelper.java#L55
> {anchor:(2)} [2] 
> https://gist.github.com/phantomjinx/90ee08a989ddff4366d792cc621b36a9#file-properties-issue-java
> {anchor:(3)} [3] 
> https://github.com/apache/camel/blob/master/components/camel-olingo4/camel-olingo4-component/src/main/java/org/apache/camel/component/olingo4/Olingo4Endpoint.java#L150



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (CAMEL-13006) Missing properties on Olingo4 consumer initialisation

2018-12-20 Thread Paul Richardson (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-13006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Richardson updated CAMEL-13006:

Attachment: 0001-CAMEL-13006-Fix-for-required-properties-in-odata-con.patch

> Missing properties on Olingo4 consumer initialisation
> -
>
> Key: CAMEL-13006
> URL: https://issues.apache.org/jira/browse/CAMEL-13006
> Project: Camel
>  Issue Type: Bug
>  Components: camel-olingo4
>Affects Versions: 2.21.0
>Reporter: Paul Richardson
>Assignee: Dmitry Volodin
>Priority: Major
> Attachments: 
> 0001-CAMEL-13006-Fix-for-required-properties-in-odata-con.patch
>
>
> Essentially, after replacing the olingo4 component in the context to bypass 
> the null [serviceUri 
> issue|https://issues.apache.org/jira/browse/CAMEL-13005], the route moves on 
> to initialising the Olingo4Consumer. The latter tests the '_read_' method to 
> ensure all properties have been set [#(1)]. However, this fails due to the 
> properties '_edm_' and '_responseHandler_' being missing.
> Have come up with a test [#(2)] that demonstrates the problem.
> These properties are not documented (since they appear to be output 
> properties). However
> , they are added into the property names collection of the endpoint [#(3)]. 
> This collection is compared against the method signatures in the 
> Olingo4AppEndpointConfiguration and neither _s/getEdm_ or 
> _s/getResponseHandler_ exist hence the exception thrown.
> {anchor:(1)} [1] 
> https://github.com/apache/camel/blob/master/camel-core/src/main/java/org/apache/camel/util/component/ApiConsumerHelper.java#L55
> {anchor:(2)} [2] 
> https://gist.github.com/phantomjinx/90ee08a989ddff4366d792cc621b36a9#file-properties-issue-java
> {anchor:(3)} [3] 
> https://github.com/apache/camel/blob/master/components/camel-olingo4/camel-olingo4-component/src/main/java/org/apache/camel/component/olingo4/Olingo4Endpoint.java#L150



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (CAMEL-13015) camel-spring-boot - load multiple route xml files

2018-12-20 Thread Claus Ibsen (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-13015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen updated CAMEL-13015:

Priority: Minor  (was: Major)

> camel-spring-boot - load multiple route xml files 
> --
>
> Key: CAMEL-13015
> URL: https://issues.apache.org/jira/browse/CAMEL-13015
> Project: Camel
>  Issue Type: New Feature
>  Components: camel-spring-boot
>Reporter: W.Y
>Priority: Minor
>
> why I use SpringDSL , i want to load two route files 
> For Example route1.xml and route2.xml
> If I put two files in same directory like below , it is working
> camel.springboot.xmlRoutes: file :directory/*.xml 
>  
> If I put two files into different directories , it does not work
> camel.springboot.xmlRoutes: 
> [file:directory1/route1.xml|file:///directory1/route1.xml] , 
> directory2/route2.xml
> Could you please implement this feature?
> Thanks



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (CAMEL-13019) camel-spring-boot - XMLRoutes and XMLRests should allow to load from multiple folders

2018-12-20 Thread Claus Ibsen (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-13019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen resolved CAMEL-13019.
-
Resolution: Duplicate

> camel-spring-boot - XMLRoutes and XMLRests should allow to load from multiple 
> folders
> -
>
> Key: CAMEL-13019
> URL: https://issues.apache.org/jira/browse/CAMEL-13019
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-spring-boot
>Reporter: Claus Ibsen
>Priority: Major
>
> They currently only support one resource loaded via spring and it only 
> support loading from classpath or file using a single entry (wildcard 
> supported)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (CAMEL-13015) camel-spring-boot - load multiple route xml files

2018-12-20 Thread Claus Ibsen (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-13015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen updated CAMEL-13015:

Component/s: camel-spring-boot

> camel-spring-boot - load multiple route xml files 
> --
>
> Key: CAMEL-13015
> URL: https://issues.apache.org/jira/browse/CAMEL-13015
> Project: Camel
>  Issue Type: New Feature
>  Components: camel-spring-boot
>Reporter: W.Y
>Priority: Major
>
> why I use SpringDSL , i want to load two route files 
> For Example route1.xml and route2.xml
> If I put two files in same directory like below , it is working
> camel.springboot.xmlRoutes: file :directory/*.xml 
>  
> If I put two files into different directories , it does not work
> camel.springboot.xmlRoutes: 
> [file:directory1/route1.xml|file:///directory1/route1.xml] , 
> directory2/route2.xml
> Could you please implement this feature?
> Thanks



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (CAMEL-13019) camel-spring-boot - XMLRoutes and XMLRests should allow to load from multiple folders

2018-12-20 Thread Claus Ibsen (JIRA)
Claus Ibsen created CAMEL-13019:
---

 Summary: camel-spring-boot - XMLRoutes and XMLRests should allow 
to load from multiple folders
 Key: CAMEL-13019
 URL: https://issues.apache.org/jira/browse/CAMEL-13019
 Project: Camel
  Issue Type: Improvement
  Components: camel-spring-boot
Reporter: Claus Ibsen


They currently only support one resource loaded via spring and it only support 
loading from classpath or file using a single entry (wildcard supported)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (CAMEL-13017) root-Path handling for SFTP on windows bug

2018-12-20 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/CAMEL-13017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Önder Sezgin resolved CAMEL-13017.
--
   Resolution: Fixed
Fix Version/s: 2.23.1
   2.24.0
   2.22.3

> root-Path handling for SFTP on windows bug
> --
>
> Key: CAMEL-13017
> URL: https://issues.apache.org/jira/browse/CAMEL-13017
> Project: Camel
>  Issue Type: Bug
>  Components: camel-ftp
>Affects Versions: 2.23.0
> Environment: 2.23.0 / executing on windows jdk8 / remote sftp server 
> linux
>  
>Reporter: Jens Kleemann
>Assignee: Önder Sezgin
>Priority: Major
> Fix For: 2.22.3, 2.24.0, 2.23.1
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> In SftpOperations.java the commit 0d3612672f2927d0428c2b79686759c16be88791
> has introduced a remoting bug when running on windows and connecting to sftp 
> server.
> If the sfpt/camel is running on windows, then it assumes that the path 
> include a "root-path" like "C://" which is not necessarily true for sftp 
> connections. 
> So instead of "/" it creates a root path of "/hom" when working with an sftp 
> path like "/home/jkleemann/transfer/:" and fails when trying to change 
> directory to this root path.
> see 
> [https://github.com/apache/camel/commit/0d3612672f2927d0428c2b79686759c16be88791]
> for the changes
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (CAMEL-11495) Incrporate logo

2018-12-20 Thread Zoran Regvart (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-11495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zoran Regvart resolved CAMEL-11495.
---
Resolution: Fixed

I managed to get the logo to render properly by tweaking the export options for 
optimized SVG from Inkscape. I've changed the logo on the website and in the 
doc/img of camel repository.

> Incrporate logo
> ---
>
> Key: CAMEL-11495
> URL: https://issues.apache.org/jira/browse/CAMEL-11495
> Project: Camel
>  Issue Type: Sub-task
>  Components: website
>Reporter: Zoran Regvart
>Priority: Major
>  Labels: help-wanted
>
> Incorporate the logo in the header of the landing page, a smaller version in 
> the header of other pages. Create favourite icons and replace the current 
> HTML5 boilerplate ones.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Work logged] (CAMEL-13017) root-Path handling for SFTP on windows bug

2018-12-20 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-13017?focusedWorklogId=177385=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-177385
 ]

ASF GitHub Bot logged work on CAMEL-13017:
--

Author: ASF GitHub Bot
Created on: 20/Dec/18 09:08
Start Date: 20/Dec/18 09:08
Worklog Time Spent: 10m 
  Work Description: onderson closed pull request #2679: CAMEL-13017 - 
handle root path on windows
URL: https://github.com/apache/camel/pull/2679
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpOperations.java
 
b/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpOperations.java
index 1ecce010b46..5f75910641a 100644
--- 
a/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpOperations.java
+++ 
b/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpOperations.java
@@ -618,12 +618,17 @@ public synchronized void changeCurrentDirectory(String 
path) throws GenericFileO
 // that
 if (FileUtil.hasLeadingSeparator(path)) {
 // change to root path
-if (!FileUtil.isWindows()) {
+if (!path.matches("^[a-zA-Z]:(//|).*$")) {
 doChangeDirectory(path.substring(0, 1));
 path = path.substring(1);
 } else {
-doChangeDirectory(path.substring(0, 4));
-path = path.substring(4);
+if(path.matches("^[a-zA-Z]:(//).*$")) {
+doChangeDirectory(path.substring(0, 3));
+path = path.substring(3);
+} else if(path.matches("^[a-zA-Z]:().*$")) {
+doChangeDirectory(path.substring(0, 4));
+path = path.substring(4);
+}
 }
 }
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 177385)
Time Spent: 20m  (was: 10m)

> root-Path handling for SFTP on windows bug
> --
>
> Key: CAMEL-13017
> URL: https://issues.apache.org/jira/browse/CAMEL-13017
> Project: Camel
>  Issue Type: Bug
>  Components: camel-ftp
>Affects Versions: 2.23.0
> Environment: 2.23.0 / executing on windows jdk8 / remote sftp server 
> linux
>  
>Reporter: Jens Kleemann
>Assignee: Önder Sezgin
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> In SftpOperations.java the commit 0d3612672f2927d0428c2b79686759c16be88791
> has introduced a remoting bug when running on windows and connecting to sftp 
> server.
> If the sfpt/camel is running on windows, then it assumes that the path 
> include a "root-path" like "C://" which is not necessarily true for sftp 
> connections. 
> So instead of "/" it creates a root path of "/hom" when working with an sftp 
> path like "/home/jkleemann/transfer/:" and fails when trying to change 
> directory to this root path.
> see 
> [https://github.com/apache/camel/commit/0d3612672f2927d0428c2b79686759c16be88791]
> for the changes
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-11495) Incrporate logo

2018-12-20 Thread Zoran Regvart (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-11495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725656#comment-16725656
 ] 

Zoran Regvart commented on CAMEL-11495:
---

The logo is incorporated. We might want to polish the SVG a bit, seems that the 
gradients are not showing when presented on the main page.

> Incrporate logo
> ---
>
> Key: CAMEL-11495
> URL: https://issues.apache.org/jira/browse/CAMEL-11495
> Project: Camel
>  Issue Type: Sub-task
>  Components: website
>Reporter: Zoran Regvart
>Priority: Major
>  Labels: help-wanted
>
> Incorporate the logo in the header of the landing page, a smaller version in 
> the header of other pages. Create favourite icons and replace the current 
> HTML5 boilerplate ones.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)