[jira] [Commented] (CAMEL-19348) camel-tracing - Upgrade to 1.1.1
[ https://issues.apache.org/jira/browse/CAMEL-19348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722880#comment-17722880 ] Marcin Grzejszczak commented on CAMEL-19348: I fixed the build with this PR https://github.com/apache/camel/pull/10091 - what we fixed in Tracing broke sth in Camel but I applied a fix. I will need to one day figure out if how Camel actually plays around with scopes and parent-child relationship between spans is OK. > camel-tracing - Upgrade to 1.1.1 > > > Key: CAMEL-19348 > URL: https://issues.apache.org/jira/browse/CAMEL-19348 > Project: Camel > Issue Type: Dependency upgrade > Components: camel-micrometer >Reporter: Claus Ibsen >Priority: Major > Fix For: 4.0-RC1, 4.0 > > > There are some test errors when upgrading in camel-observation. Also when > upgrading to a newer 1.0.x release. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (CAMEL-19348) camel-tracing - Upgrade to 1.1.0
[ https://issues.apache.org/jira/browse/CAMEL-19348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722362#comment-17722362 ] Marcin Grzejszczak commented on CAMEL-19348: We messed up the release . You need to upgrade to 1.1.1 for the 1.1.x branch or 1.0.6 for the 1.0.x branch > camel-tracing - Upgrade to 1.1.0 > > > Key: CAMEL-19348 > URL: https://issues.apache.org/jira/browse/CAMEL-19348 > Project: Camel > Issue Type: Dependency upgrade > Components: camel-micrometer >Reporter: Claus Ibsen >Priority: Major > Fix For: 4.0-RC1, 4.0 > > > There are some test errors when upgrading in camel-observation. Also when > upgrading to a newer 1.0.x release. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CAMEL-19124) Tracer doesn't continue spans for AbstractInternalSpanDecorator
Marcin Grzejszczak created CAMEL-19124:
--
Summary: Tracer doesn't continue spans for
AbstractInternalSpanDecorator
Key: CAMEL-19124
URL: https://issues.apache.org/jira/browse/CAMEL-19124
Project: Camel
Issue Type: Bug
Components: camel-tracing
Affects Versions: 3.20.2, 3.x, 4.0
Reporter: Marcin Grzejszczak
Attachments: trace_view_with_fix.png, trace_view_without_fix.png
As discussed in the [PR|https://github.com/apache/camel/pull/9389] it seems
that the `Tracer`component from `camel-tracing` is not continuing spans if a
`AbstractInternalSpanDecorator` is being created. So for the following route
{code:java}
from("direct://foo")
.log("hello")
.to("direct://bar")
.to("http://example.org;);
from("direct://bar")
.log("hello")
.to("direct://micrometer")
.to("http://example.org;);
from("direct://micrometer")
.setHeader(MicrometerConstants.HEADER_METRIC_NAME, constant("new.name"))
.setHeader(MicrometerConstants.HEADER_METRIC_TAGS,
constant(Tags.of("dynamic-key", "dynamic-value")))
.to("micrometer:counter:name.not.used?tags=key=value")
.to("direct://baz");
from("direct://baz")
.log("hello")
.to("bean:com.example.cameldemo.MyBean")
.to("exec:wc?args=--words
/usr/share/dict/words")
.process(exchange -> {
// Use the Camel Exec String type
converter to convert the ExecResult to String
// In this case, the stdout is
considered as output
String wordCountOutput =
exchange.getIn().getBody(String.class);
// do something with the word count
System.out.println(wordCountOutput);
})
.to("file:///tmp/camel-outputdir?flatten=true")
.to("http://example.org;);
{code}
you will get multiple traces since the `direct` components are not linked
together (they are treated as a start of a new trace).
!trace_view_without_fix.png!
I think we agreed that for this route example, multiple routes are linked
together but all in all they form a single trace. So if
`org.apache.camel.tracing.Tracer.TracingEventNotifier#shouldExclude` would be
changed from
{code:java}
private boolean shouldExclude(SpanDecorator sd, Exchange exchange, Endpoint
endpoint) {
return sd instanceof AbstractInternalSpanDecorator || !sd.newSpan()
|| isExcluded(exchange, endpoint);
}
{code}
to
{code:java}
private boolean shouldExclude(SpanDecorator sd, Exchange exchange, Endpoint
endpoint) {
return !sd.newSpan()
|| isExcluded(exchange, endpoint);
}
{code}
then the span parent-child relationship gets maintained the way it should
!trace_view_with_fix.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (CAMEL-19023) Add support for Micrometer Observation
Marcin Grzejszczak created CAMEL-19023: -- Summary: Add support for Micrometer Observation Key: CAMEL-19023 URL: https://issues.apache.org/jira/browse/CAMEL-19023 Project: Camel Issue Type: New Feature Components: came-core Reporter: Marcin Grzejszczak I'm a co-maintainer of Spring Cloud Sleuth and Micrometer projects (together with Tommy Ludwig and Jonatan Ivanov). [Micrometer Observation|https://micrometer.io/docs/observation] is coming as part of the Micrometer 1.10 release and [Micrometer Tracing|https://micrometer.io/docs/tracing] is a new project. The idea of Micrometer Observation is that you instrument code once but you get multiple benefits out of it - e.g. you can get tracing, metrics, logging or whatever you see fit). Since Camel already supports Micrometer I was curious if there's interest in adding Micrometer Observation support so that automatically (when on classpath) except for metrics, spans could be created and tracing context propagation could happen too. In other words metrics and tracing of Camel itself could be created + if there are Micrometer Observation compatible projects, then they will join the whole graph (e.g. whole Spring Framework 6 is, Apache Dubbo, Resilience4j etc.). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CAMEL-19023) Add support for Micrometer Observation
[ https://issues.apache.org/jira/browse/CAMEL-19023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcin Grzejszczak updated CAMEL-19023: --- Description: I'm a co-maintainer of Spring Cloud Sleuth and Micrometer projects (together with Tommy Ludwig and Jonatan Ivanov). [Micrometer Observation|https://micrometer.io/docs/observation] is coming as part of the Micrometer 1.10 release and [Micrometer Tracing|https://micrometer.io/docs/tracing] is a new project. The idea of Micrometer Observation is that you instrument code once but you get multiple benefits out of it - e.g. you can get tracing, metrics, logging or whatever you see fit). Since Camel already supports Micrometer I was curious if there's interest in adding Micrometer Observation support so that automatically (when on classpath) except for metrics, spans could be created and tracing context propagation could happen too. In other words metrics and tracing of Camel itself could be created + if there are Micrometer Observation compatible projects, then they will join the whole graph (e.g. whole Spring Framework 6 is, Apache Dubbo, Resilience4j etc.). If there's interest in adding that feature, I can provide a PR. was: I'm a co-maintainer of Spring Cloud Sleuth and Micrometer projects (together with Tommy Ludwig and Jonatan Ivanov). [Micrometer Observation|https://micrometer.io/docs/observation] is coming as part of the Micrometer 1.10 release and [Micrometer Tracing|https://micrometer.io/docs/tracing] is a new project. The idea of Micrometer Observation is that you instrument code once but you get multiple benefits out of it - e.g. you can get tracing, metrics, logging or whatever you see fit). Since Camel already supports Micrometer I was curious if there's interest in adding Micrometer Observation support so that automatically (when on classpath) except for metrics, spans could be created and tracing context propagation could happen too. In other words metrics and tracing of Camel itself could be created + if there are Micrometer Observation compatible projects, then they will join the whole graph (e.g. whole Spring Framework 6 is, Apache Dubbo, Resilience4j etc.). > Add support for Micrometer Observation > -- > > Key: CAMEL-19023 > URL: https://issues.apache.org/jira/browse/CAMEL-19023 > Project: Camel > Issue Type: New Feature > Components: came-core >Reporter: Marcin Grzejszczak >Priority: Major > > I'm a co-maintainer of Spring Cloud Sleuth and Micrometer projects (together > with Tommy Ludwig and Jonatan Ivanov). > [Micrometer Observation|https://micrometer.io/docs/observation] is coming as > part of the Micrometer 1.10 release and [Micrometer > Tracing|https://micrometer.io/docs/tracing] is a new project. The idea of > Micrometer Observation is that you instrument code once but you get multiple > benefits out of it - e.g. you can get tracing, metrics, logging or whatever > you see fit). > Since Camel already supports Micrometer I was curious if there's interest in > adding Micrometer Observation support so that automatically (when on > classpath) except for metrics, spans could be created and tracing context > propagation could happen too. In other words metrics and tracing of Camel > itself could be created + if there are Micrometer Observation compatible > projects, then they will join the whole graph (e.g. whole Spring Framework 6 > is, Apache Dubbo, Resilience4j etc.). > If there's interest in adding that feature, I can provide a PR. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (CAMEL-15428) Create a proper camel BOM (for camel-spring-boot)
[ https://issues.apache.org/jira/browse/CAMEL-15428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183277#comment-17183277 ] Marcin Grzejszczak commented on CAMEL-15428: Great! When are you planning to release 3.4.4 ? > Create a proper camel BOM (for camel-spring-boot) > - > > Key: CAMEL-15428 > URL: https://issues.apache.org/jira/browse/CAMEL-15428 > Project: Camel > Issue Type: New Feature > Components: camel-spring-boot >Reporter: Marcin Grzejszczak >Assignee: Claus Ibsen >Priority: Major > Fix For: 3.5.0, 3.4.4 > > > Hi! > > In Spring Cloud Contract I wanted to reference camel project versions without > providing versions for each of them. So I referenced the `camel-dependencies` > project in the dependencies management section. > The problem is that also includes all the non project related library > versions (e.g. had a conflict with jackson-databind, Camel downgraded my > library). > It would be great to have a `camel-bom` module that would include only camel > related projects without any other dependencies. Then `camel-dependencies` > would import `camel-bom` and all the necessary dependencies. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-15428) Create a proper camel BOM
[
https://issues.apache.org/jira/browse/CAMEL-15428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180614#comment-17180614
]
Marcin Grzejszczak commented on CAMEL-15428:
Maybe I wasn't too clear. I am the maintainer of Spring Cloud Contract and I
know how BOMs work :) The problem is that when I add the camel `dependencies`
pom, it's breaking my dependencies. What I would like to have is just a
definition of camel based projects.
[https://mvnrepository.com/artifact/org.apache.camel.springboot/camel-spring-boot-dependencies/3.4.3]
- you're enforcing versions of projects (e.g. com.fasterxml.jackson.dataformat
» jackson-dataformat-yaml 2.10.4)
or
{{}}
{{httpunit}}
{{httpunit}}
{{1.7}}
{{}}
{{}}
{{io.apicurio}}
{{apicurio-data-models}}
{{1.0.16.Final}}
{{}}
{{}}
{{io.krakens}}
{{java-grok}}
{{0.1.9}}
{{}}
{{}}
{{io.methvin}}
{{directory-watcher}}
{{0.9.10}}
{{}}
>From my perspective I don't care about these versions nor do I want to
>override my versions. What I want to have is the whole management section of
>Camel specific projects. That's why I'd prefer to have a BOM and
>`-dependencies` that reference the BOM.
> Create a proper camel BOM
> -
>
> Key: CAMEL-15428
> URL: https://issues.apache.org/jira/browse/CAMEL-15428
> Project: Camel
> Issue Type: New Feature
>Reporter: Marcin Grzejszczak
>Priority: Major
>
> Hi!
>
> In Spring Cloud Contract I wanted to reference camel project versions without
> providing versions for each of them. So I referenced the `camel-dependencies`
> project in the dependencies management section.
> The problem is that also includes all the non project related library
> versions (e.g. had a conflict with jackson-databind, Camel downgraded my
> library).
> It would be great to have a `camel-bom` module that would include only camel
> related projects without any other dependencies. Then `camel-dependencies`
> would import `camel-bom` and all the necessary dependencies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (CAMEL-15428) Create a proper camel BOM
Marcin Grzejszczak created CAMEL-15428: -- Summary: Create a proper camel BOM Key: CAMEL-15428 URL: https://issues.apache.org/jira/browse/CAMEL-15428 Project: Camel Issue Type: New Feature Reporter: Marcin Grzejszczak Hi! In Spring Cloud Contract I wanted to reference camel project versions without providing versions for each of them. So I referenced the `camel-dependencies` project in the dependencies management section. The problem is that also includes all the non project related library versions (e.g. had a conflict with jackson-databind, Camel downgraded my library). It would be great to have a `camel-bom` module that would include only camel related projects without any other dependencies. Then `camel-dependencies` would import `camel-bom` and all the necessary dependencies. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-11430) Add support for Spring Boot 2.0.x
[ https://issues.apache.org/jira/browse/CAMEL-11430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161117#comment-16161117 ] Marcin Grzejszczak commented on CAMEL-11430: Thanks! I've just started watching CAMEL-11756 . > Add support for Spring Boot 2.0.x > - > > Key: CAMEL-11430 > URL: https://issues.apache.org/jira/browse/CAMEL-11430 > Project: Camel > Issue Type: Improvement > Components: camel-spring-boot >Reporter: Marcin Grzejszczak > Fix For: Future > > > Hello! > It would be great to add compatibility with Boot 2.0.x . Spring Cloud > Contract uses Camel but in the 2.0.x branch (that is compatible with Boot > 2.0.x ) we can't actually use it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11430) Add support for Spring Boot 2.0.x
[ https://issues.apache.org/jira/browse/CAMEL-11430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153543#comment-16153543 ] Marcin Grzejszczak commented on CAMEL-11430: Ok, so please comment on this issue once you have this resolved. Until then I'll drop the support of Apache Camel in 2.0.x Boot based versions of Spring Cloud Contract > Add support for Spring Boot 2.0.x > - > > Key: CAMEL-11430 > URL: https://issues.apache.org/jira/browse/CAMEL-11430 > Project: Camel > Issue Type: Improvement > Components: camel-spring-boot >Reporter: Marcin Grzejszczak > Fix For: Future > > > Hello! > It would be great to add compatibility with Boot 2.0.x . Spring Cloud > Contract uses Camel but in the 2.0.x branch (that is compatible with Boot > 2.0.x ) we can't actually use it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11430) Add support for Spring Boot 2.0.x
[ https://issues.apache.org/jira/browse/CAMEL-11430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140052#comment-16140052 ] Marcin Grzejszczak commented on CAMEL-11430: Hi guys! Do you need help with this? If that's the case can you point me which release branch should I pick to fix this? > Add support for Spring Boot 2.0.x > - > > Key: CAMEL-11430 > URL: https://issues.apache.org/jira/browse/CAMEL-11430 > Project: Camel > Issue Type: Improvement > Components: camel-spring-boot >Reporter: Marcin Grzejszczak > Fix For: 2.20.0 > > > Hello! > It would be great to add compatibility with Boot 2.0.x . Spring Cloud > Contract uses Camel but in the 2.0.x branch (that is compatible with Boot > 2.0.x ) we can't actually use it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11430) Add support for Spring Boot 2.0.x
[
https://issues.apache.org/jira/browse/CAMEL-11430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16055569#comment-16055569
]
Marcin Grzejszczak commented on CAMEL-11430:
Yup the stacktrace looks like this
{code}
Caused by: java.lang.NoClassDefFoundError:
org/springframework/boot/bind/RelaxedPropertyResolver
at
org.apache.camel.component.direct.springboot.DirectComponentAutoConfiguration$Condition.isEnabled(DirectComponentAutoConfiguration.java:101)
at
org.apache.camel.component.direct.springboot.DirectComponentAutoConfiguration$Condition.getMatchOutcome(DirectComponentAutoConfiguration.java:87)
at
org.springframework.boot.autoconfigure.condition.SpringBootCondition.matches(SpringBootCondition.java:47)
... 53 common frames omitted
Caused by: java.lang.ClassNotFoundException:
org.springframework.boot.bind.RelaxedPropertyResolver
at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:335)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
... 56 common frames omitted
{code}
> Add support for Spring Boot 2.0.x
> -
>
> Key: CAMEL-11430
> URL: https://issues.apache.org/jira/browse/CAMEL-11430
> Project: Camel
> Issue Type: Bug
> Components: camel-spring-boot
>Reporter: Marcin Grzejszczak
>
> Hello!
> It would be great to add compatibility with Boot 2.0.x . Spring Cloud
> Contract uses Camel but in the 2.0.x branch (that is compatible with Boot
> 2.0.x ) we can't actually use it.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (CAMEL-11430) Add support for Spring Boot 2.0.x
Marcin Grzejszczak created CAMEL-11430: -- Summary: Add support for Spring Boot 2.0.x Key: CAMEL-11430 URL: https://issues.apache.org/jira/browse/CAMEL-11430 Project: Camel Issue Type: Bug Components: camel-spring-boot Reporter: Marcin Grzejszczak Hello! It would be great to add compatibility with Boot 2.0.x . Spring Cloud Contract uses Camel but in the 2.0.x branch (that is compatible with Boot 2.0.x ) we can't actually use it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
