[GitHub] carbondata issue #978: [CARBONDATA-1109] Acquire semaphore before submit a p...

2017-06-01 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/978 Not required any check, entry count check handled inside On Fri, 2 Jun 2017 at 11:13 AM, manishgupta88 wrote: > *@manishgupta88* commented on

[GitHub] carbondata pull request #978: [CARBONDATA-1109] Acquire semaphore before sub...

2017-06-01 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/978#discussion_r119785140 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerColumnar.java --- @@ -488,13 +488,19 @@ private

[GitHub] carbondata pull request #971: [CARBONDATA-1015] Extract interface in data lo...

2017-06-01 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/971#discussion_r119783989 --- Diff: docs/useful-tips-on-carbondata.md --- @@ -127,7 +127,7 @@ query performance. The create table command can be modified as below :

[GitHub] carbondata pull request #971: [CARBONDATA-1015] Extract interface in data lo...

2017-06-01 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/971#discussion_r119783944 --- Diff: docs/faq.md --- @@ -123,7 +123,7 @@ id cityname 3 davishenzhen ``` -As result shows, the second column is

[GitHub] carbondata pull request #971: [CARBONDATA-1015] Extract interface in data lo...

2017-06-01 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/971#discussion_r119783972 --- Diff: docs/release-guide.md --- @@ -109,7 +109,7 @@ staging repository and promote the artifacts to Maven Central. 4. Choose `User Token`

[GitHub] carbondata pull request #971: [CARBONDATA-1015] Extract interface in data lo...

2017-06-01 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/971#discussion_r119783933 --- Diff: docs/dml-operation-on-carbondata.md --- @@ -211,7 +211,7 @@ By default the above configuration will be false. ### Examples

[GitHub] carbondata pull request #971: [CARBONDATA-1015] Extract interface in data lo...

2017-06-01 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/971#discussion_r119783237 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/MeasurePageStatistics.java --- @@ -0,0 +1,88 @@ +/* + *

[GitHub] carbondata issue #948: [CARBONDATA-1093] During single pass load user data i...

2017-06-01 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/948 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2145/ --- If your project is set up for it, you can reply to this email and have your

[GitHub] carbondata pull request #971: [CARBONDATA-1015] Extract interface in data lo...

2017-06-01 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/971#discussion_r119782441 --- Diff: LICENSE --- @@ -157,7 +157,7 @@ negligent acts) or agreed to in writing, shall any Contributor be liable to You for

[GitHub] carbondata issue #988: [CARBONDATA-1110] put if clause out of the for clause

2017-06-01 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/988 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2144/ --- If your project is set up for it, you can reply to this email and have your

[GitHub] carbondata pull request #971: [CARBONDATA-1015] Extract interface in data lo...

2017-06-01 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/971#discussion_r119781980 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/ColumnPageStatistics.java --- @@ -114,6 +115,46 @@ private int

[GitHub] carbondata issue #948: [CARBONDATA-1093] During single pass load user data i...

2017-06-01 Thread gvramana
Github user gvramana commented on the issue: https://github.com/apache/carbondata/pull/948 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] carbondata pull request #971: [CARBONDATA-1015] Extract interface in data lo...

2017-06-01 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/971#discussion_r119781704 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/ColumnPageStatistics.java --- @@ -33,30 +34,30 @@ * the

[GitHub] carbondata pull request #971: [CARBONDATA-1015] Extract interface in data lo...

2017-06-01 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/971#discussion_r119781493 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/TablePage.java --- @@ -65,20 +68,20 @@ this.pageSize = pageSize;

[GitHub] carbondata issue #980: [CARBONDATA-1110] put if clause out of the for clause

2017-06-01 Thread mayunSaicmotor
Github user mayunSaicmotor commented on the issue: https://github.com/apache/carbondata/pull/980 closed this pr, raised a new pr https://github.com/apache/carbondata/pull/988 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] carbondata pull request #988: [CARBONDATA-1110] put if clause out of the for...

2017-06-01 Thread mayunSaicmotor
GitHub user mayunSaicmotor opened a pull request: https://github.com/apache/carbondata/pull/988 [CARBONDATA-1110] put if clause out of the for clause it should be better to put if clause out of the for clause You can merge this pull request into a Git repository by running: $

[GitHub] carbondata pull request #980: [CARBONDATA-1110] put if clause out of the for...

2017-06-01 Thread mayunSaicmotor
Github user mayunSaicmotor closed the pull request at: https://github.com/apache/carbondata/pull/980 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] carbondata pull request #964: [CARBONDATA-1099] Fixed bug for carbon-spark-s...

2017-06-01 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/964#discussion_r119761693 --- Diff: core/src/main/java/org/apache/carbondata/core/cache/dictionary/ReverseDictionaryCache.java --- @@ -43,7 +43,7 @@ * Attribute for

[GitHub] carbondata issue #987: [WIP] Use ColumnPage for measure encoding and compres...

2017-06-01 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/987 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2143/ --- If your project is set up for it, you can reply to this email and have your

[GitHub] carbondata pull request #987: [WIP] Use ColumnPage for measure encoding and ...

2017-06-01 Thread jackylk
GitHub user jackylk opened a pull request: https://github.com/apache/carbondata/pull/987 [WIP] Use ColumnPage for measure encoding and compression [WIP] This PR should be merged after #971 In this PR, following interfaces are added: ###ColumnPageEncoder encoder for

[GitHub] carbondata issue #831: Branch 1.1

2017-06-01 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/831 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] carbondata issue #856: log.txt

2017-06-01 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/856 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] carbondata issue #884: Create project-xmlns

2017-06-01 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/884 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] carbondata issue #980: [CARBONDATA-1110] put if clause out of the for clause

2017-06-01 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/980 @mayunSaicmotor please squash all commits to one commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] carbondata pull request #979: [CARBONDATA-1102] resolved int,short type bug ...

2017-06-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/979 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] carbondata pull request #964: [CARBONDATA-1099] Fixed bug for carbon-spark-s...

2017-06-01 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/964#discussion_r119642951 --- Diff: core/src/main/java/org/apache/carbondata/core/cache/dictionary/ReverseDictionaryCache.java --- @@ -43,7 +43,7 @@ * Attribute for

[GitHub] carbondata pull request #986: [CARBONDATA-1108][CARBONDATA-1112] Supported I...

2017-06-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/986 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] carbondata issue #986: [CARBONDATA-1108][CARBONDATA-1112] Supported IUD for ...

2017-06-01 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/986 LGTM. verified at my local machine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] carbondata issue #962: Only for test ci(vacuous PR-don't merge)

2017-06-01 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/962 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2142/ --- If your project is set up for it, you can reply to this email and have your

[GitHub] carbondata issue #962: Only for test ci(vacuous PR-don't merge)

2017-06-01 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/962 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] carbondata issue #972: [CARBONDATA-1065] Added set command in carbon to upda...

2017-06-01 Thread gvramana
Github user gvramana commented on the issue: https://github.com/apache/carbondata/pull/972 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[jira] [Created] (CARBONDATA-1117) Update SET & RESET command details in online help documentation

2017-06-01 Thread Manohar Vanam (JIRA)
Manohar Vanam created CARBONDATA-1117: - Summary: Update SET & RESET command details in online help documentation Key: CARBONDATA-1117 URL: https://issues.apache.org/jira/browse/CARBONDATA-1117

[GitHub] carbondata issue #978: [CARBONDATA-1109] Acquire semaphore before submit a p...

2017-06-01 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/978 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2140/ --- If your project is set up for it, you can reply to this email and have your

[GitHub] carbondata issue #986: [CARBONDATA-1108][CARBONDATA-1112] Supported IUD for ...

2017-06-01 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/986 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2139/ --- If your project is set up for it, you can reply to this email and have your

[GitHub] carbondata issue #978: [CARBONDATA-1109] Cover the case when last page is no...

2017-06-01 Thread watermen
Github user watermen commented on the issue: https://github.com/apache/carbondata/pull/978 @ravipesala Thanks for your solution, PR updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] carbondata issue #986: [CARBONDATA-1108][CARBONDATA-1112] Supported IUD for ...

2017-06-01 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/986 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] carbondata issue #972: [CARBONDATA-1065] Added set command in carbon to upda...

2017-06-01 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/972 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2137/ --- If your project is set up for it, you can reply to this email and have your

[GitHub] carbondata issue #979: [CARBONDATA-1102] resolved int,short type bug for hiv...

2017-06-01 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/979 LGTM, @chenliang613 please merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Closed] (CARBONDATA-1116) Not able to connect with Carbonsession while starting carbon spark shell and beeline

2017-06-01 Thread Ravindra Pesala (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravindra Pesala closed CARBONDATA-1116. --- Resolution: Duplicate Duplicated to

[jira] [Updated] (CARBONDATA-1112) Cannot run queries on Spark 2.1

2017-06-01 Thread Ravindra Pesala (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravindra Pesala updated CARBONDATA-1112: Summary: Cannot run queries on Spark 2.1 (was: fix failing IUD test case) >

[jira] [Updated] (CARBONDATA-1112) fix failing IUD test case

2017-06-01 Thread Ravindra Pesala (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravindra Pesala updated CARBONDATA-1112: Description: while running any query in spark 2.1 fails with following error

[jira] [Commented] (CARBONDATA-1116) Not able to connect with Carbonsession while starting carbon spark shell and beeline

2017-06-01 Thread chenerlu (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16032668#comment-16032668 ] chenerlu commented on CARBONDATA-1116: -- Hi, I met same issue when I ran CarbonSessionExample on

[GitHub] carbondata issue #978: [CARBONDATA-1109] Cover the case when last page is no...

2017-06-01 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/978 @watermen Thank you for giving reproduce steps, I can reproduce it. But the fix you have given is not right, This issue happens because of missing `semaphore.acquire()` in `finish` method.

[jira] [Created] (CARBONDATA-1116) Not able to connect with Carbonsession while starting carbon spark shell and beeline

2017-06-01 Thread Vandana Yadav (JIRA)
Vandana Yadav created CARBONDATA-1116: - Summary: Not able to connect with Carbonsession while starting carbon spark shell and beeline Key: CARBONDATA-1116 URL:

[GitHub] carbondata issue #986: [CARBONDATA-1108] Supported IUD for vector reader in ...

2017-06-01 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/986 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2135/ --- If your project is set up for it, you can reply to this email and have your

[GitHub] carbondata pull request #986: [CARBONDATA-1108] Supported IUD for vector rea...

2017-06-01 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/986#discussion_r119545242 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedVectorResultCollector.java --- @@ -144,6 +144,8 @@

[GitHub] carbondata issue #978: [CARBONDATA-1109] Cover the case when last page is no...

2017-06-01 Thread watermen
Github user watermen commented on the issue: https://github.com/apache/carbondata/pull/978 @ravipesala You can reproduce this case by add some log and run loading sample.csv testcase(TestDataLoadWithFileName). It's hard to reproducer, so I add sleep in Producer to simulate the

[jira] [Created] (CARBONDATA-1115) load csv data fail

2017-06-01 Thread hyd (JIRA)
hyd created CARBONDATA-1115: --- Summary: load csv data fail Key: CARBONDATA-1115 URL: https://issues.apache.org/jira/browse/CARBONDATA-1115 Project: CarbonData Issue Type: Bug Components:

[GitHub] carbondata issue #986: [CARBONDATA-1108] Supported IUD for vector reader in ...

2017-06-01 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/986 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2134/ --- If your project is set up for it, you can reply to this email and have your

[GitHub] carbondata issue #249: [CARBONDATA-329] constant final class changed to inte...

2017-06-01 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/249 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] carbondata issue #942: [CARBONDATA-1084]added documentation for V3 Data Form...

2017-06-01 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/942 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] carbondata issue #943: [CARBONDATA-1086]Added documentation for BATCH SORT S...

2017-06-01 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/943 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] carbondata issue #964: [CARBONDATA-1099] Fixed bug for carbon-spark-shell in...

2017-06-01 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/964 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] carbondata issue #975: [Documentation] Single pass condition for high cardin...

2017-06-01 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/975 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] carbondata issue #972: [WIP] Added set command in carbon to update propertie...

2017-06-01 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/972 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2133/ --- If your project is set up for it, you can reply to this email and have your

[GitHub] carbondata issue #981: [CARBONDATA-1111]Improve No dictionary column Include...

2017-06-01 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/981 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2132/ --- If your project is set up for it, you can reply to this email and have your