[GitHub] carbondata issue #2843: [CARBONDATA-3034] Carding parameters,Organized by pa...

2018-10-24 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2843 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/987/ ---

[GitHub] carbondata issue #2843: [CARBONDATA-3034] Carding parameters,Organized by pa...

2018-10-24 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2843 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9252/ ---

[GitHub] carbondata pull request #2818: [CARBONDATA-3011] Add carbon property to conf...

2018-10-24 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2818#discussion_r227709881 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/CarbonLateDecodeStrategy.scala --- @@ -337,19 +340,35 @@

[GitHub] carbondata pull request #2818: [CARBONDATA-3011] Add carbon property to conf...

2018-10-24 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2818#discussion_r227709784 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala --- @@ -228,9 +230,12 @@ class

[GitHub] carbondata issue #2818: [CARBONDATA-3011] Add carbon property to configure v...

2018-10-24 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2818 @jackylk @xuchuanyin For testing purpose we are trying to configure it. Once it proved that for all types of queries can be used this path, we can remove this property or defaults to false

[GitHub] carbondata pull request #2818: [CARBONDATA-3011] Add carbon property to conf...

2018-10-24 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2818#discussion_r227708688 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/CarbonLateDecodeStrategy.scala --- @@ -374,10 +410,27 @@

[GitHub] carbondata pull request #2818: [CARBONDATA-3011] Add carbon property to conf...

2018-10-24 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2818#discussion_r227707418 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/CarbonLateDecodeStrategy.scala --- @@ -337,19 +340,35 @@

[jira] [Resolved] (CARBONDATA-2998) Refresh column schema for old store(before V3) for SORT_COLUMNS option

2018-10-24 Thread Manish Gupta (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Gupta resolved CARBONDATA-2998. -- Resolution: Fixed Fix Version/s: 1.5.1 > Refresh column schema for old

[GitHub] carbondata pull request #2806: [CARBONDATA-2998] Refresh column schema for o...

2018-10-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2806 ---

[GitHub] carbondata pull request #2818: [CARBONDATA-3011] Add carbon property to conf...

2018-10-24 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2818#discussion_r227704173 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala --- @@ -748,4 +754,8 @@ class

[GitHub] carbondata pull request #2818: [CARBONDATA-3011] Add carbon property to conf...

2018-10-24 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2818#discussion_r227703819 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala --- @@ -228,9 +230,12 @@ class

[GitHub] carbondata pull request #2818: [CARBONDATA-3011] Add carbon property to conf...

2018-10-24 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2818#discussion_r227702948 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java --- @@ -1530,6 +1530,12 @@ public int

[GitHub] carbondata issue #2849: [CARBONDATA-2896] Added TestCases for Adaptive encod...

2018-10-24 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2849 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9251/ ---

[jira] [Created] (CARBONDATA-3040) Add folder check before merging bloom index

2018-10-24 Thread jiangmanhua (JIRA)
jiangmanhua created CARBONDATA-3040: --- Summary: Add folder check before merging bloom index Key: CARBONDATA-3040 URL: https://issues.apache.org/jira/browse/CARBONDATA-3040 Project: CarbonData

[GitHub] carbondata issue #2843: [CARBONDATA-3034] Carding parameters,Organized by pa...

2018-10-24 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2843 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1199/ ---

[GitHub] carbondata issue #2849: [CARBONDATA-2896] Added TestCases for Adaptive encod...

2018-10-24 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2849 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1198/ ---

[GitHub] carbondata issue #2850: [WIP] Added concurrent reading through SDK

2018-10-24 Thread NamanRastogi
Github user NamanRastogi commented on the issue: https://github.com/apache/carbondata/pull/2850 @xuchuanyin Since `CarbonReader` is iterator based, we can only read a line when user wants. So, even if we keep the parallelism internally before the build method, it will still

[GitHub] carbondata issue #2843: [CARBONDATA-3034] Carding parameters,Organized by pa...

2018-10-24 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2843 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/986/ ---

[GitHub] carbondata issue #2830: [CARBONDATA-3025]Added CLI enhancements

2018-10-24 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2830 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1196/ ---

[GitHub] carbondata issue #2810: [WIP] Add CarbonSession Java Example

2018-10-24 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/2810 Hi, are you still working on this PR? ---

[jira] [Resolved] (CARBONDATA-3035) Optimize parameters for unsafe working and sort memory

2018-10-24 Thread Jacky Li (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacky Li resolved CARBONDATA-3035. -- Resolution: Fixed Fix Version/s: 1.5.1 > Optimize parameters for unsafe working

[GitHub] carbondata pull request #2844: [CARBONDATA-3035] Optimize parameters for uns...

2018-10-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2844 ---

[GitHub] carbondata issue #2844: [CARBONDATA-3035] Optimize parameters for unsafe wor...

2018-10-24 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/2844 LGTM ---

[GitHub] carbondata pull request #2816: [CARBONDATA-3003] Suppor read batch row in CS...

2018-10-24 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2816#discussion_r227681835 --- Diff: README.md --- @@ -61,6 +61,7 @@ CarbonData is built using Apache Maven, to [build CarbonData](https://github.com * [CarbonData

[GitHub] carbondata pull request #2816: [CARBONDATA-3003] Suppor read batch row in CS...

2018-10-24 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2816#discussion_r227681593 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java --- @@ -1521,4 +1521,294 @@ public boolean accept(File dir,

[GitHub] carbondata pull request #2816: [CARBONDATA-3003] Suppor read batch row in CS...

2018-10-24 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2816#discussion_r227681343 --- Diff: store/CSDK/main.cpp --- @@ -21,6 +21,8 @@ #include #include #include "CarbonReader.h" +#include "CarbonRow.h"

[GitHub] carbondata pull request #2816: [CARBONDATA-3003] Suppor read batch row in CS...

2018-10-24 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2816#discussion_r227681257 --- Diff: store/CSDK/main.cpp --- @@ -21,6 +21,8 @@ #include #include #include "CarbonReader.h" +#include "CarbonRow.h"

[GitHub] carbondata pull request #2816: [CARBONDATA-3003] Suppor read batch row in CS...

2018-10-24 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2816#discussion_r227680646 --- Diff: store/CSDK/CarbonReader.cpp --- @@ -17,6 +17,7 @@ #include "CarbonReader.h" #include +#include --- End diff --

[GitHub] carbondata pull request #2816: [CARBONDATA-3003] Suppor read batch row in CS...

2018-10-24 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2816#discussion_r227680374 --- Diff: store/CSDK/CMakeLists.txt --- @@ -1,17 +1,17 @@ -cmake_minimum_required (VERSION 2.8) -project (CJDK)

[GitHub] carbondata pull request #2816: [CARBONDATA-3003] Suppor read batch row in CS...

2018-10-24 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2816#discussion_r227679865 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/result/iterator/ChunkRowIterator.java --- @@ -74,4 +76,13 @@ public

[GitHub] carbondata issue #2850: [WIP] Added concurrent reading through SDK

2018-10-24 Thread xuchuanyin
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2850 @NamanRastogi I think we can further optimize this function. 1. We can enable the parallel reading and set the parallelism while creating a CarbonReader; 2. Inside CarbonReader,

[GitHub] carbondata pull request #2829: [CARBONDATA-3025]add more metadata in carbon ...

2018-10-24 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2829#discussion_r227679135 --- Diff: format/src/main/thrift/carbondata.thrift --- @@ -206,6 +206,7 @@ struct FileFooter3{ 4: optional list blocklet_info_list3; //

[GitHub] carbondata pull request #2829: [CARBONDATA-3025]add more metadata in carbon ...

2018-10-24 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2829#discussion_r227678463 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1845,6 +1845,21 @@ public static final int

[GitHub] carbondata issue #2830: [CARBONDATA-3025]Added CLI enhancements

2018-10-24 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2830 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9250/ ---

[GitHub] carbondata issue #2814: [WIP][CARBONDATA-3001] configurable page size in MB

2018-10-24 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2814 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1197/ ---

[GitHub] carbondata issue #2849: [CARBONDATA-2896] Added TestCases for Adaptive encod...

2018-10-24 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2849 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/985/ ---

[GitHub] carbondata issue #2830: [CARBONDATA-3025]Added CLI enhancements

2018-10-24 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2830 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/984/ ---

[GitHub] carbondata issue #2850: [WIP] Added concurrent reading through SDK

2018-10-24 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2850 Can one of the admins verify this patch? ---

[GitHub] carbondata issue #2814: [WIP][CARBONDATA-3001] configurable page size in MB

2018-10-24 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2814 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9248/ ---

[GitHub] carbondata pull request #2814: [WIP][CARBONDATA-3001] configurable page size...

2018-10-24 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2814#discussion_r227667228 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerColumnar.java --- @@ -221,50 +224,106 @@ public

[GitHub] carbondata pull request #2850: Added concurrent reading through SDK

2018-10-24 Thread NamanRastogi
GitHub user NamanRastogi opened a pull request: https://github.com/apache/carbondata/pull/2850 Added concurrent reading through SDK Added another API for _CarbonReader.split_ to enable concurrent reading of carbondata files through SDK. ```java List multipleReaders =

[GitHub] carbondata pull request #2849: [CARBONDATA-2896] Added TestCases for Adaptiv...

2018-10-24 Thread dhatchayani
GitHub user dhatchayani opened a pull request: https://github.com/apache/carbondata/pull/2849 [CARBONDATA-2896] Added TestCases for Adaptive encoding Test cases added for Adaptive encoding for primitive types. - [ ] Any interfaces changed? - [ ] Any backward

[GitHub] carbondata issue #2848: [CARBONDATA-3036] Cache Columns And Refresh Table Is...

2018-10-24 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2848 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/983/ ---

[GitHub] carbondata issue #2848: [CARBONDATA-3036] Cache Columns And Refresh Table Is...

2018-10-24 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2848 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9249/ ---

[GitHub] carbondata issue #2848: [CARBONDATA-3036] Cache Columns And Refresh Table Is...

2018-10-24 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2848 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1195/ ---

[GitHub] carbondata issue #2814: [WIP][CARBONDATA-3001] configurable page size in MB

2018-10-24 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2814 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/982/ ---

[GitHub] carbondata issue #2845: [CARBONDATA-3039] Fix Custom Deterministic Expressio...

2018-10-24 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2845 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9247/ ---

[GitHub] carbondata pull request #2847: [WIP]Support Gzip as column compressor

2018-10-24 Thread shardul-cr7
Github user shardul-cr7 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2847#discussion_r227658900 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/compression/GzipCompressor.java --- @@ -0,0 +1,201 @@ +/* + * Licensed

[GitHub] carbondata pull request #2847: [WIP]Support Gzip as column compressor

2018-10-24 Thread shardul-cr7
Github user shardul-cr7 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2847#discussion_r227658842 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/compression/GzipCompressor.java --- @@ -0,0 +1,201 @@ +/* + * Licensed

[GitHub] carbondata issue #2845: [CARBONDATA-3039] Fix Custom Deterministic Expressio...

2018-10-24 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2845 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1194/ ---

<    1   2