[GitHub] [carbondata] akashrn5 commented on issue #3072: [CARBONDATA-3247] Support to select all columns when creating MV datamap

2019-04-21 Thread GitBox
akashrn5 commented on issue #3072: [CARBONDATA-3247] Support to select all columns when creating MV datamap URL: https://github.com/apache/carbondata/pull/3072#issuecomment-485333513 +1 This is an automated message from the

[GitHub] [carbondata] akashrn5 commented on issue #3072: [CARBONDATA-3247] Support to select all columns when creating MV datamap

2019-04-21 Thread GitBox
akashrn5 commented on issue #3072: [CARBONDATA-3247] Support to select all columns when creating MV datamap URL: https://github.com/apache/carbondata/pull/3072#issuecomment-485332427 > > What about add only one line to funtion `isSPJGH` as follow to allow no select? > > ```java > >

[GitHub] [carbondata] akashrn5 commented on issue #3150: [CARBONDATA-3309] MV datamap supports Spark 2.1

2019-04-21 Thread GitBox
akashrn5 commented on issue #3150: [CARBONDATA-3309] MV datamap supports Spark 2.1 URL: https://github.com/apache/carbondata/pull/3150#issuecomment-485332113 @qiuchenjian basically i was making sure that, when we remove 2.1, it should not lead to change core code in MV module. If it is

[GitHub] [carbondata] CarbonDataQA commented on issue #3173: [CARBONDATA-3351] Support Binary Data Type

2019-04-21 Thread GitBox
CarbonDataQA commented on issue #3173: [CARBONDATA-3351] Support Binary Data Type URL: https://github.com/apache/carbondata/pull/3173#issuecomment-485330306 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11187/

[GitHub] [carbondata] akashrn5 commented on issue #3128: [CARBONDATA-3294] Fix that MV datamap throw error when using count(1) and case when expression

2019-04-21 Thread GitBox
akashrn5 commented on issue #3128: [CARBONDATA-3294] Fix that MV datamap throw error when using count(1) and case when expression URL: https://github.com/apache/carbondata/pull/3128#issuecomment-485330137 +1 This is an

[GitHub] [carbondata] akashrn5 commented on issue #3124: [CARBONDATA-3290] No need to apply MV/Preaggregate rules for Command

2019-04-21 Thread GitBox
akashrn5 commented on issue #3124: [CARBONDATA-3290] No need to apply MV/Preaggregate rules for Command URL: https://github.com/apache/carbondata/pull/3124#issuecomment-485329179 LGTM This is an automated message from the

[GitHub] [carbondata] akashrn5 commented on issue #3122: [CARBONDATA-3289] MV datamap doesn't take effect when having clause use alias

2019-04-21 Thread GitBox
akashrn5 commented on issue #3122: [CARBONDATA-3289] MV datamap doesn't take effect when having clause use alias URL: https://github.com/apache/carbondata/pull/3122#issuecomment-485327641 @qiuchenjian you can do that, please refer the new comment given in #3101 , to place all rules in

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3101: [CARBONDATA-3270] MV support groupby columns don't need be existed in the projection

2019-04-21 Thread GitBox
akashrn5 commented on a change in pull request #3101: [CARBONDATA-3270] MV support groupby columns don't need be existed in the projection URL: https://github.com/apache/carbondata/pull/3101#discussion_r277207419 ## File path:

[GitHub] [carbondata] CarbonDataQA commented on issue #3173: [CARBONDATA-3351] Support Binary Data Type

2019-04-21 Thread GitBox
CarbonDataQA commented on issue #3173: [CARBONDATA-3351] Support Binary Data Type URL: https://github.com/apache/carbondata/pull/3173#issuecomment-485321474 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2926/

[GitHub] [carbondata] CarbonDataQA commented on issue #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar

2019-04-21 Thread GitBox
CarbonDataQA commented on issue #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar URL: https://github.com/apache/carbondata/pull/3181#issuecomment-485309564 Build Success with Spark 2.2.1, Please check CI

[GitHub] [carbondata] CarbonDataQA commented on issue #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar

2019-04-21 Thread GitBox
CarbonDataQA commented on issue #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar URL: https://github.com/apache/carbondata/pull/3181#issuecomment-485306153 Build Success with Spark 2.3.2, Please check CI

[GitHub] [carbondata] CarbonDataQA commented on issue #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar

2019-04-21 Thread GitBox
CarbonDataQA commented on issue #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar URL: https://github.com/apache/carbondata/pull/3181#issuecomment-485298851 Build Success with Spark 2.1.0, Please check CI

[GitHub] [carbondata] xubo245 commented on a change in pull request #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar

2019-04-21 Thread GitBox
xubo245 commented on a change in pull request #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar URL: https://github.com/apache/carbondata/pull/3181#discussion_r277189124 ## File path:

[GitHub] [carbondata] xubo245 commented on a change in pull request #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar

2019-04-21 Thread GitBox
xubo245 commented on a change in pull request #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar URL: https://github.com/apache/carbondata/pull/3181#discussion_r277189124 ## File path:

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar

2019-04-21 Thread GitBox
akashrn5 commented on a change in pull request #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar URL: https://github.com/apache/carbondata/pull/3181#discussion_r277157978 ## File path: