vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r513197605
##
File path:
core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java
##
@@ -1143,28 +1148,62 @@ public static void
CarbonDataQA1 commented on pull request #3999:
URL: https://github.com/apache/carbondata/pull/3999#issuecomment-717713614
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2955/
CarbonDataQA1 commented on pull request #3999:
URL: https://github.com/apache/carbondata/pull/3999#issuecomment-717711741
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4712/
Indhumathi27 commented on pull request #3952:
URL: https://github.com/apache/carbondata/pull/3952#issuecomment-717703722
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
akashrn5 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r513171515
##
File path:
core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java
##
@@ -2116,6 +2087,26 @@ public int
CarbonDataQA1 commented on pull request #3999:
URL: https://github.com/apache/carbondata/pull/3999#issuecomment-717678439
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4711/
CarbonDataQA1 commented on pull request #3999:
URL: https://github.com/apache/carbondata/pull/3999#issuecomment-717678491
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2954/
QiangCai commented on a change in pull request #3999:
URL: https://github.com/apache/carbondata/pull/3999#discussion_r513152963
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala
##
@@ -121,7 +121,7 @@ case
QiangCai commented on a change in pull request #3986:
URL: https://github.com/apache/carbondata/pull/3986#discussion_r513147277
##
File path:
core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentUpdateStatusManager.java
##
@@ -415,44 +415,41 @@ public boolean
CarbonDataQA1 commented on pull request #3999:
URL: https://github.com/apache/carbondata/pull/3999#issuecomment-717496054
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2953/
CarbonDataQA1 commented on pull request #3999:
URL: https://github.com/apache/carbondata/pull/3999#issuecomment-717492977
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4710/
ajantha-bhat commented on a change in pull request #3999:
URL: https://github.com/apache/carbondata/pull/3999#discussion_r512886166
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala
##
@@ -121,7 +121,7 @@ case
akashrn5 commented on pull request #3972:
URL: https://github.com/apache/carbondata/pull/3972#issuecomment-717401461
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
akashrn5 commented on pull request #3981:
URL: https://github.com/apache/carbondata/pull/3981#issuecomment-717398581
@marchpure as from the description, i understood that the table status file
after insert overwrite do not contain the `updatetablestatusfile ` name. So why
do we need to
akashrn5 commented on pull request #3981:
URL: https://github.com/apache/carbondata/pull/3981#issuecomment-717398850
> > @marchpure please correct the PR title and please give detailed
explanation of the issue and the fix in the PR description.
>
> Yes. I have modified the PR desc
akashrn5 commented on a change in pull request #3981:
URL: https://github.com/apache/carbondata/pull/3981#discussion_r512875192
##
File path:
core/src/main/java/org/apache/carbondata/core/mutate/CarbonUpdateUtil.java
##
@@ -276,14 +278,13 @@ public static boolean
vikramahuja1001 commented on pull request #3952:
URL: https://github.com/apache/carbondata/pull/3952#issuecomment-717378005
@kunal642 @akashrn5 please merge this
This is an automated message from the Apache Git Service.
To
CarbonDataQA1 commented on pull request #3981:
URL: https://github.com/apache/carbondata/pull/3981#issuecomment-717333719
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4709/
CarbonDataQA1 commented on pull request #3999:
URL: https://github.com/apache/carbondata/pull/3999#issuecomment-717329144
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2951/
CarbonDataQA1 commented on pull request #3981:
URL: https://github.com/apache/carbondata/pull/3981#issuecomment-717328681
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2952/
CarbonDataQA1 commented on pull request #3999:
URL: https://github.com/apache/carbondata/pull/3999#issuecomment-717325746
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4708/
ajantha-bhat commented on a change in pull request #3999:
URL: https://github.com/apache/carbondata/pull/3999#discussion_r512760255
##
File path:
integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
##
@@ -342,7 +342,8 @@ object
marchpure closed pull request #3934:
URL: https://github.com/apache/carbondata/pull/3934
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
CarbonDataQA1 commented on pull request #3988:
URL: https://github.com/apache/carbondata/pull/3988#issuecomment-717268180
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2950/
CarbonDataQA1 commented on pull request #3988:
URL: https://github.com/apache/carbondata/pull/3988#issuecomment-717267646
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4707/
[
https://issues.apache.org/jira/browse/CARBONDATA-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
PURUJIT CHAUGULE closed CARBONDATA-3903.
Document updation is resolved and verified.
> Documentation Issue in Github
marchpure commented on pull request #3981:
URL: https://github.com/apache/carbondata/pull/3981#issuecomment-717259421
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
CarbonDataQA1 commented on pull request #3999:
URL: https://github.com/apache/carbondata/pull/3999#issuecomment-717258126
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2949/
CarbonDataQA1 commented on pull request #3999:
URL: https://github.com/apache/carbondata/pull/3999#issuecomment-717257966
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4706/
[
https://issues.apache.org/jira/browse/CARBONDATA-4010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chetan Bhat closed CARBONDATA-4010.
---
Issue is fixed in Carbon 2.1 version.
> "Alter table set tblproperties should support long
[
https://issues.apache.org/jira/browse/CARBONDATA-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chetan Bhat closed CARBONDATA-3932.
---
Issue is fixed in Carbon 2.1 version.
> need to change discovery.uri and add
>
[
https://issues.apache.org/jira/browse/CARBONDATA-3901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chetan Bhat closed CARBONDATA-3901.
---
Issue is fixed in Carbon 2.1 version
> Documentation issues in
[
https://issues.apache.org/jira/browse/CARBONDATA-3824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chetan Bhat closed CARBONDATA-3824.
---
Issue is fixed in Carbon 2.1 version.
> Error when Secondary index tried to be created on
CarbonDataQA1 commented on pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#issuecomment-717190630
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2948/
CarbonDataQA1 commented on pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#issuecomment-717189509
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4705/
maheshrajus commented on a change in pull request #3912:
URL: https://github.com/apache/carbondata/pull/3912#discussion_r512579906
##
File path:
integration/spark/src/main/scala/org/apache/carbondata/spark/load/DataLoadProcessBuilderOnSpark.scala
##
@@ -143,10 +143,18 @@
akashrn5 commented on a change in pull request #3912:
URL: https://github.com/apache/carbondata/pull/3912#discussion_r503187128
##
File path:
integration/spark/src/main/scala/org/apache/carbondata/spark/load/DataLoadProcessBuilderOnSpark.scala
##
@@ -143,10 +143,18 @@ object
CarbonDataQA1 commented on pull request #3912:
URL: https://github.com/apache/carbondata/pull/3912#issuecomment-717143281
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4704/
CarbonDataQA1 commented on pull request #3912:
URL: https://github.com/apache/carbondata/pull/3912#issuecomment-717141636
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2947/
vikramahuja1001 commented on pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#issuecomment-717131900
retest this please
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/CARBONDATA-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kunal Kapoor resolved CARBONDATA-4007.
--
Fix Version/s: 2.1.0
Resolution: Fixed
> ArrayIndexOutofBoundsException
CarbonDataQA1 commented on pull request #3916:
URL: https://github.com/apache/carbondata/pull/3916#issuecomment-717126913
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2943/
CarbonDataQA1 commented on pull request #3916:
URL: https://github.com/apache/carbondata/pull/3916#issuecomment-717126479
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4700/
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r512553653
##
File path: docs/dml-of-carbondata.md
##
@@ -562,3 +563,50 @@ CarbonData DML statements are documented here,which
includes:
```
CLEAN
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r512553372
##
File path:
core/src/main/java/org/apache/carbondata/core/util/path/TrashUtil.java
##
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache
asfgit closed pull request #3970:
URL: https://github.com/apache/carbondata/pull/3970
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r512552552
##
File path:
core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentStatusManager.java
##
@@ -1049,7 +1049,7 @@ private static
ajantha-bhat commented on pull request #3916:
URL: https://github.com/apache/carbondata/pull/3916#issuecomment-717124467
@akashrn5
a) Please update the PR description about what all problems were there and
what changes done to support it. Now it is not clear.
b) Please confirm here
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r512552754
##
File path:
core/src/main/java/org/apache/carbondata/core/util/path/CarbonTablePath.java
##
@@ -47,6 +47,7 @@
public static final String
ajantha-bhat commented on a change in pull request #3916:
URL: https://github.com/apache/carbondata/pull/3916#discussion_r512505051
##
File path:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
##
@@ -369,7 +369,8 @@ private
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r512551259
##
File path:
core/src/main/java/org/apache/carbondata/core/util/DeleteLoadFolders.java
##
@@ -192,11 +208,17 @@ private static boolean
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r512551385
##
File path:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
##
@@ -1427,6 +1428,25 @@ private
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r512551780
##
File path:
core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java
##
@@ -1105,28 +1109,79 @@ public static void
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r512550744
##
File path:
core/src/main/java/org/apache/carbondata/core/util/DeleteLoadFolders.java
##
@@ -138,8 +143,19 @@ public boolean
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r512550325
##
File path:
core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java
##
@@ -1105,28 +1109,79 @@ public static void
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r512549332
##
File path:
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/cleanfiles/TestCleanFileCommand.scala
##
@@ -0,0 +1,484
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r512548768
##
File path: docs/cleanfiles.md
##
@@ -0,0 +1,78 @@
+
+
+
+## CLEAN FILES
+
+Clean files command is used to remove the Compacted, Marked For
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r512545772
##
File path: docs/cleanfiles.md
##
@@ -0,0 +1,78 @@
+
+
+
+## CLEAN FILES
+
+Clean files command is used to remove the Compacted, Marked For
CarbonDataQA1 commented on pull request #3988:
URL: https://github.com/apache/carbondata/pull/3988#issuecomment-717104688
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2942/
CarbonDataQA1 commented on pull request #3988:
URL: https://github.com/apache/carbondata/pull/3988#issuecomment-717095810
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4699/
akashrn5 edited a comment on pull request #3916:
URL: https://github.com/apache/carbondata/pull/3916#issuecomment-717074706
@ajantha-bhat @QiangCai i have rebased, please have a look.
This is an automated message from the
akashrn5 commented on pull request #3916:
URL: https://github.com/apache/carbondata/pull/3916#issuecomment-717074706
@ajantha-bhat i have rebased, please have a look.
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/CARBONDATA-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221222#comment-17221222
]
Yahui Liu commented on CARBONDATA-4044:
---
I have faced this issue, and try to solve it.
akashrn5 commented on pull request #3986:
URL: https://github.com/apache/carbondata/pull/3986#issuecomment-717054658
> We tested with 10 segments total 10G and update more than 20 times to see
the cost, update row count of each time is 176973.
> The result and comparison before and
CarbonDataQA1 commented on pull request #3970:
URL: https://github.com/apache/carbondata/pull/3970#issuecomment-717049704
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2941/
CarbonDataQA1 commented on pull request #3970:
URL: https://github.com/apache/carbondata/pull/3970#issuecomment-717049604
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4698/
marchpure commented on pull request #3997:
URL: https://github.com/apache/carbondata/pull/3997#issuecomment-717045718
> @marchpure : The reason why we don't have TPCH and TPCDS in UT is we need
a huge data set, loading huge data takes time.
>
> What is the reason behind adding this?
marchpure edited a comment on pull request #3997:
URL: https://github.com/apache/carbondata/pull/3997#issuecomment-717045718
> @marchpure : The reason why we don't have TPCH and TPCDS in UT is we need
a huge data set, loading huge data takes time.
>
> What is the reason behind
dependabot[bot] commented on pull request #3456:
URL: https://github.com/apache/carbondata/pull/3456#issuecomment-717039451
Dependabot tried to update this pull request, but something went wrong.
We're looking into it, but in the meantime you can retry the update by
commenting
dependabot[bot] commented on pull request #3447:
URL: https://github.com/apache/carbondata/pull/3447#issuecomment-717038691
Dependabot tried to update this pull request, but something went wrong.
We're looking into it, but in the meantime you can retry the update by
commenting
ajantha-bhat commented on pull request #3997:
URL: https://github.com/apache/carbondata/pull/3997#issuecomment-717031195
@marchpure : The reason why we don't have TPCH and TPCDS in UT is we need a
huge data set, loading huge data takes time.
What is the reason behind adding this? we
Zhangshunyu commented on pull request #3986:
URL: https://github.com/apache/carbondata/pull/3986#issuecomment-717027548
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Zhangshunyu commented on pull request #3986:
URL: https://github.com/apache/carbondata/pull/3986#issuecomment-717025630
> We tested with 10 segments total 10G and update more than 20 times to see
the cost, update row count of each time is 176973.
> The result and comparison before and
shenjiayu17 commented on pull request #3986:
URL: https://github.com/apache/carbondata/pull/3986#issuecomment-717024597
We tested with 10 segments total 10G and update more than 20 times to see
the cost, update row count of each time is 176973.
The result and comparison before and after
ajantha-bhat commented on pull request #3994:
URL: https://github.com/apache/carbondata/pull/3994#issuecomment-717017303
@marchpure : yes, If update writes into new segment, It can fix the issue.
If you handle this in your PR then I will close mine.
ajantha-bhat closed pull request #3994:
URL: https://github.com/apache/carbondata/pull/3994
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ajantha-bhat commented on pull request #3994:
URL: https://github.com/apache/carbondata/pull/3994#issuecomment-717017602
handled in #3999 , I will close this.
This is an automated message from the Apache Git Service.
To
CarbonDataQA1 commented on pull request #3997:
URL: https://github.com/apache/carbondata/pull/3997#issuecomment-717017353
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2940/
CarbonDataQA1 commented on pull request #3997:
URL: https://github.com/apache/carbondata/pull/3997#issuecomment-717016610
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4697/
marchpure edited a comment on pull request #3994:
URL: https://github.com/apache/carbondata/pull/3994#issuecomment-717015851
> @marchpure : If you dont assign UUID for all update case or compaction
after update case, all testcases will pass. But the original data mismatch will
still
marchpure commented on pull request #3994:
URL: https://github.com/apache/carbondata/pull/3994#issuecomment-717015851
> @marchpure : If you dont assign UUID for all update case or compaction
after update case, all testcases will pass. But the original data mismatch will
still happen for
ajantha-bhat commented on pull request #3994:
URL: https://github.com/apache/carbondata/pull/3994#issuecomment-717014461
@marchpure : If you dont assign UUID for all update case or compaction after
update case, all testcases will pass. But the original data mismatch will still
happen for
marchpure commented on pull request #3994:
URL: https://github.com/apache/carbondata/pull/3994#issuecomment-717010368
> > Hi, Ajantha. I have fixed this in #3999 , please have a check.
>
> @marchpure: I think your PR is not handling all the scenarios, so update
scenario and test
asfgit closed pull request #3996:
URL: https://github.com/apache/carbondata/pull/3996
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
84 matches
Mail list logo
