[GitHub] [carbondata] ajantha-bhat edited a comment on pull request #3807: [WIP][HOTFIX] Fix module problems of mv and spark with spark binary version

2020-11-10 Thread GitBox
ajantha-bhat edited a comment on pull request #3807: URL: https://github.com/apache/carbondata/pull/3807#issuecomment-659305724 @QiangCai : Developer should not manually modify pom to make it work for spark2.4. After this PR both 2.4 and 2.3 works without any manual change and jar names

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4001: [CARBONDATA-4029] [CARBONDATA-3908] Issue while adding segments through alter add segment command

2020-11-10 Thread GitBox
ajantha-bhat commented on a change in pull request #4001: URL: https://github.com/apache/carbondata/pull/4001#discussion_r521116946 ## File path: core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java ## @@ -877,6 +877,10 @@ public SegmentFile

[GitHub] [carbondata] ajantha-bhat commented on pull request #3926: [CARBONDATA-3976]CarbonData Update operation enhancement

2020-11-10 Thread GitBox
ajantha-bhat commented on pull request #3926: URL: https://github.com/apache/carbondata/pull/3926#issuecomment-725200507 @nstang01 , Is this different than #3986 ?? If same may be you can close this PR. This is an automated

[GitHub] [carbondata] ajantha-bhat commented on pull request #3981: [CARBONDATA-4031] Incorrect query result after Update/Delete and Inseā€¦

2020-11-10 Thread GitBox
ajantha-bhat commented on pull request #3981: URL: https://github.com/apache/carbondata/pull/3981#issuecomment-725199629 @marchpure : This is already handled in #3999 , need to close this PR ? This is an automated message

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-11-10 Thread GitBox
CarbonDataQA1 commented on pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#issuecomment-724843083 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4792/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-11-10 Thread GitBox
CarbonDataQA1 commented on pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#issuecomment-724843522 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3034/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-11-10 Thread GitBox
CarbonDataQA1 commented on pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#issuecomment-724751519 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3032/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-11-10 Thread GitBox
CarbonDataQA1 commented on pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#issuecomment-724723673 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2020-11-10 Thread GitBox
ShreelekhyaG commented on a change in pull request #3988: URL: https://github.com/apache/carbondata/pull/3988#discussion_r520572527 ## File path: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/SegmentIndexFileStore.java ## @@ -79,6 +79,11 @@ */

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2020-11-10 Thread GitBox
ShreelekhyaG commented on a change in pull request #3988: URL: https://github.com/apache/carbondata/pull/3988#discussion_r520568975 ## File path: core/src/main/java/org/apache/carbondata/core/mutate/CarbonUpdateUtil.java ## @@ -274,20 +274,22 @@ public static boolean

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2020-11-10 Thread GitBox
ShreelekhyaG commented on a change in pull request #3988: URL: https://github.com/apache/carbondata/pull/3988#discussion_r520568875 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/cleanfiles/TestCleanFileCommand.scala ## @@ -0,0 +1,170 @@

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2020-11-10 Thread GitBox
CarbonDataQA1 commented on pull request #3988: URL: https://github.com/apache/carbondata/pull/3988#issuecomment-724631565 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3030/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2020-11-10 Thread GitBox
CarbonDataQA1 commented on pull request #3988: URL: https://github.com/apache/carbondata/pull/3988#issuecomment-724626204 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4788/