[jira] [Updated] (CARBONDATA-4075) Should refactor to use withEvents instead of fireEvent

[ https://issues.apache.org/jira/browse/CARBONDATA-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Cai updated CARBONDATA-4075: -- Summary: Should refactor to use withEvents instead of fireEvent (was: Should refactor

[GitHub] [carbondata] QiangCai commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

QiangCai commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537294489 ## File path: integration/spark/src/main/scala/org/apache/carbondata/events/package.scala ## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache

[GitHub] [carbondata] QiangCai commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

QiangCai commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537294489 ## File path: integration/spark/src/main/scala/org/apache/carbondata/events/package.scala ## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache

[jira] [Created] (CARBONDATA-4075) Should refactor carbon to use withEvents instead of fireEvent

David Cai created CARBONDATA-4075: - Summary: Should refactor carbon to use withEvents instead of fireEvent Key: CARBONDATA-4075 URL: https://issues.apache.org/jira/browse/CARBONDATA-4075 Project:

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

ajantha-bhat commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537293803 ## File path: integration/spark/src/main/scala/org/apache/carbondata/trash/DataTrashManager.scala ## @@ -0,0 +1,167 @@ +/* + * Licensed to the

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

ajantha-bhat commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537293803 ## File path: integration/spark/src/main/scala/org/apache/carbondata/trash/DataTrashManager.scala ## @@ -0,0 +1,167 @@ +/* + * Licensed to the

[GitHub] [carbondata] QiangCai commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

QiangCai commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537289240 ## File path: core/src/main/java/org/apache/carbondata/core/mutate/CarbonUpdateUtil.java ## @@ -482,176 +482,6 @@ public boolean accept(CarbonFile

[jira] [Created] (CARBONDATA-4074) Should clean stale data in success segments

David Cai created CARBONDATA-4074: - Summary: Should clean stale data in success segments Key: CARBONDATA-4074 URL: https://issues.apache.org/jira/browse/CARBONDATA-4074 Project: CarbonData

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

akashrn5 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537288377 ## File path: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ## @@ -577,38 +556,46 @@ object

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

ajantha-bhat commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537283710 ## File path: integration/spark/src/main/scala/org/apache/carbondata/trash/DataTrashManager.scala ## @@ -0,0 +1,167 @@ +/* + * Licensed to the

[GitHub] [carbondata] QiangCai commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

QiangCai commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537281516 ## File path: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ## @@ -577,38 +556,46 @@ object

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

ajantha-bhat commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537282367 ## File path: integration/spark/src/main/scala/org/apache/carbondata/trash/DataTrashManager.scala ## @@ -0,0 +1,167 @@ +/* + * Licensed to the

[GitHub] [carbondata] QiangCai commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

QiangCai commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537281516 ## File path: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ## @@ -577,38 +556,46 @@ object

[GitHub] [carbondata] QiangCai commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

QiangCai commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537281123 ## File path: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ## @@ -263,15 +249,7 @@ object

[GitHub] [carbondata] ydvpankaj99 commented on pull request #4045: ci_test

ydvpankaj99 commented on pull request #4045: URL: https://github.com/apache/carbondata/pull/4045#issuecomment-739724037 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] QiangCai commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

QiangCai commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537278313 ## File path: core/src/main/java/org/apache/carbondata/core/util/TrashUtil.java ## @@ -192,20 +192,20 @@ public static void emptyTrash(String

[GitHub] [carbondata] QiangCai commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

QiangCai commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537278197 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/events/CleanFilesPostEventListener.scala ## @@ -48,30 +50,61 @@

[GitHub] [carbondata] QiangCai commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

QiangCai commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537277683 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/events/CleanFilesPostEventListener.scala ## @@ -48,30 +50,61 @@

[GitHub] [carbondata] QiangCai commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

QiangCai commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537277613 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/events/CleanFilesPostEventListener.scala ## @@ -48,30 +50,61 @@

[GitHub] [carbondata] QiangCai commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

QiangCai commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537277508 ## File path: integration/spark/src/main/scala/org/apache/carbondata/trash/DataTrashManager.scala ## @@ -0,0 +1,168 @@ +/* + * Licensed to the

[GitHub] [carbondata] QiangCai commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

QiangCai commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537277390 ## File path: integration/spark/src/main/scala/org/apache/carbondata/trash/DataTrashManager.scala ## @@ -0,0 +1,168 @@ +/* + * Licensed to the

[GitHub] [carbondata] QiangCai commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

QiangCai commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537277121 ## File path: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ## @@ -2123,29 +2123,35 @@ public int

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

ajantha-bhat commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537276344 ## File path: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ## @@ -263,15 +249,7 @@ object

[GitHub] [carbondata] QiangCai commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

QiangCai commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537276094 ## File path: core/src/main/java/org/apache/carbondata/core/util/CleanFilesUtil.java ## @@ -163,8 +164,13 @@ private static void

[GitHub] [carbondata] QiangCai commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

QiangCai commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537275990 ## File path: integration/spark/src/main/scala/org/apache/carbondata/trash/DataTrashManager.scala ## @@ -0,0 +1,168 @@ +/* + * Licensed to the

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

ajantha-bhat commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537275885 ## File path: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ## @@ -577,38 +556,46 @@ object

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4044: [CARBONDATA-4062] Refactor clean files feature

CarbonDataQA2 commented on pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#issuecomment-739717520 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5097/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4044: [CARBONDATA-4062] Refactor clean files feature

CarbonDataQA2 commented on pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#issuecomment-739717393 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3316/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4045: ci_test

CarbonDataQA2 commented on pull request #4045: URL: https://github.com/apache/carbondata/pull/4045#issuecomment-739717207 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5096/

[GitHub] [carbondata] QiangCai commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

QiangCai commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537273944 ## File path: core/src/main/java/org/apache/carbondata/core/util/CleanFilesUtil.java ## @@ -163,8 +164,13 @@ private static void

[GitHub] [carbondata] QiangCai commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

QiangCai commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537273799 ## File path: integration/spark/src/main/scala/org/apache/carbondata/api/CarbonStore.scala ## @@ -19,13 +19,13 @@ package org.apache.carbondata.api

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4045: ci_test

CarbonDataQA2 commented on pull request #4045: URL: https://github.com/apache/carbondata/pull/4045#issuecomment-739716584 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3315/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4044: [CARBONDATA-4062] Refactor clean files feature

CarbonDataQA2 commented on pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#issuecomment-739715250 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5074/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator

CarbonDataQA2 commented on pull request #4039: URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739714799 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5094/

[GitHub] [carbondata] CarbonDataQA2 opened a new pull request #4045: ci_test

CarbonDataQA2 opened a new pull request #4045: URL: https://github.com/apache/carbondata/pull/4045 ### Why is this PR needed? CI test ### What changes were proposed in this PR? Nothing ### Does this PR introduce any user interface change? - No

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

akashrn5 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537271584 ## File path: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ## @@ -263,15 +249,7 @@ object

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

akashrn5 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537271258 ## File path: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ## @@ -577,38 +556,46 @@ object

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

akashrn5 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537270696 ## File path: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ## @@ -2123,29 +2123,35 @@ public int

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

ajantha-bhat commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537266114 ## File path: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ## @@ -577,38 +556,46 @@ object

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

ajantha-bhat commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537264650 ## File path: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ## @@ -263,15 +249,7 @@ object

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

ajantha-bhat commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537264650 ## File path: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ## @@ -263,15 +249,7 @@ object

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

ajantha-bhat commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537260678 ## File path: core/src/main/java/org/apache/carbondata/core/util/TrashUtil.java ## @@ -192,20 +192,20 @@ public static void emptyTrash(String

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

ajantha-bhat commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537259682 ## File path: core/src/main/java/org/apache/carbondata/core/util/TrashUtil.java ## @@ -192,20 +192,20 @@ public static void emptyTrash(String

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

ajantha-bhat commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537259682 ## File path: core/src/main/java/org/apache/carbondata/core/util/TrashUtil.java ## @@ -192,20 +192,20 @@ public static void emptyTrash(String

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

ajantha-bhat commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537258139 ## File path: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ## @@ -2123,29 +2123,35 @@ public int

[GitHub] [carbondata] CarbonDataQA2 closed pull request #4014: qa test

CarbonDataQA2 closed pull request #4014: URL: https://github.com/apache/carbondata/pull/4014 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [carbondata] CarbonDataQA2 closed pull request #4016: Qa test2

CarbonDataQA2 closed pull request #4016: URL: https://github.com/apache/carbondata/pull/4016 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

akashrn5 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537252858 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/events/CleanFilesPostEventListener.scala ## @@ -48,30 +50,61 @@

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4044: [CARBONDATA-4062] Refactor clean files feature

CarbonDataQA2 commented on pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#issuecomment-739689562 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3314/

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

akashrn5 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537252530 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/events/CleanFilesPostEventListener.scala ## @@ -48,30 +50,61 @@

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

akashrn5 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537252406 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/events/CleanFilesPostEventListener.scala ## @@ -48,30 +50,61 @@

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4044: [CARBONDATA-4062] Refactor clean files feature

CarbonDataQA2 commented on pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#issuecomment-739688814 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5095/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator

CarbonDataQA2 commented on pull request #4039: URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739688329 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3338/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator

CarbonDataQA2 commented on pull request #4039: URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739688118 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5073/

[GitHub] [carbondata] ydvpankaj99 commented on pull request #4044: [CARBONDATA-4062] Refactor clean files feature

ydvpankaj99 commented on pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#issuecomment-739687768 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4032: [WIP][CARBONDATA-4065] Support MERGE INTO SQL Command

CarbonDataQA2 commented on pull request #4032: URL: https://github.com/apache/carbondata/pull/4032#issuecomment-739687365 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5072/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4032: [WIP][CARBONDATA-4065] Support MERGE INTO SQL Command

CarbonDataQA2 commented on pull request #4032: URL: https://github.com/apache/carbondata/pull/4032#issuecomment-739687262 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4044: [CARBONDATA-4062] Refactor clean files feature

CarbonDataQA2 commented on pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#issuecomment-739687261 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3336/

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

ajantha-bhat commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537248838 ## File path: core/src/main/java/org/apache/carbondata/core/util/CleanFilesUtil.java ## @@ -163,8 +164,13 @@ private static void

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

ajantha-bhat commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537248198 ## File path: core/src/main/java/org/apache/carbondata/core/util/CleanFilesUtil.java ## @@ -163,8 +164,13 @@ private static void

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

vikramahuja1001 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537245787 ## File path: integration/spark/src/main/scala/org/apache/carbondata/trash/DataTrashManager.scala ## @@ -0,0 +1,168 @@ +/* + * Licensed to

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

vikramahuja1001 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537245787 ## File path: integration/spark/src/main/scala/org/apache/carbondata/trash/DataTrashManager.scala ## @@ -0,0 +1,168 @@ +/* + * Licensed to

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

akashrn5 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537245017 ## File path: integration/spark/src/main/scala/org/apache/carbondata/trash/DataTrashManager.scala ## @@ -0,0 +1,168 @@ +/* + * Licensed to the

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

akashrn5 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537230858 ## File path: core/src/main/java/org/apache/carbondata/core/mutate/CarbonUpdateUtil.java ## @@ -482,176 +482,6 @@ public boolean accept(CarbonFile

[GitHub] [carbondata] ajantha-bhat commented on pull request #4044: [CARBONDATA-4062] Refactor clean files feature

ajantha-bhat commented on pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#issuecomment-739671395 @kunal642 , @vikramahuja1001 , @akashrn5 : I think we all 4 are reviewing this PR. Give comments once you find it. don't give all at the end. so that we can avoid

[GitHub] [carbondata] kunal642 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

kunal642 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537236952 ## File path: core/src/main/java/org/apache/carbondata/core/util/CleanFilesUtil.java ## @@ -163,8 +164,13 @@ private static void

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

vikramahuja1001 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537235165 ## File path: integration/spark/src/main/scala/org/apache/carbondata/trash/DataTrashManager.scala ## @@ -0,0 +1,168 @@ +/* + * Licensed to

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator

CarbonDataQA2 commented on pull request #4039: URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739664975 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3313/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4044: [CARBONDATA-4062] Refactor clean files feature

CarbonDataQA2 commented on pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#issuecomment-739664837 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5092/

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

vikramahuja1001 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537232374 ## File path: integration/spark/src/main/scala/org/apache/carbondata/trash/DataTrashManager.scala ## @@ -0,0 +1,168 @@ +/* + * Licensed to

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4044: [CARBONDATA-4062] Refactor clean files feature

CarbonDataQA2 commented on pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#issuecomment-739664259 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3311/

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

vikramahuja1001 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537230866 ## File path: integration/spark/src/main/scala/org/apache/carbondata/api/CarbonStore.scala ## @@ -19,13 +19,13 @@ package

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

vikramahuja1001 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537230288 ## File path: core/src/main/java/org/apache/carbondata/core/util/CleanFilesUtil.java ## @@ -163,8 +164,13 @@ private static void

[GitHub] [carbondata] Indhumathi27 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator

Indhumathi27 commented on pull request #4039: URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739660102 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4044: [CARBONDATA-4062] Refactor clean files feature

CarbonDataQA2 commented on pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#issuecomment-739649949 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5071/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4032: [WIP][CARBONDATA-4065] Support MERGE INTO SQL Command

CarbonDataQA2 commented on pull request #4032: URL: https://github.com/apache/carbondata/pull/4032#issuecomment-739649832 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3312/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

CarbonDataQA2 commented on pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#issuecomment-739649371 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3308/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4040: [WIP][CI TEST]

CarbonDataQA2 commented on pull request #4040: URL: https://github.com/apache/carbondata/pull/4040#issuecomment-739649028 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5070/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4040: [WIP][CI TEST]

CarbonDataQA2 commented on pull request #4040: URL: https://github.com/apache/carbondata/pull/4040#issuecomment-739648939 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5091/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4040: [WIP][CI TEST]

CarbonDataQA2 commented on pull request #4040: URL: https://github.com/apache/carbondata/pull/4040#issuecomment-739648788 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3335/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4029: [HOTFIX] Refact Carbon Util

CarbonDataQA2 commented on pull request #4029: URL: https://github.com/apache/carbondata/pull/4029#issuecomment-739648475 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5064/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4040: [WIP][CI TEST]

CarbonDataQA2 commented on pull request #4040: URL: https://github.com/apache/carbondata/pull/4040#issuecomment-739648469 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3330/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4044: [CARBONDATA-4062] Refactor clean files feature

CarbonDataQA2 commented on pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#issuecomment-739648471 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3334/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

CarbonDataQA2 commented on pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#issuecomment-739648470 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5065/

[GitHub] [carbondata] QiangCai commented on pull request #4044: [CARBONDATA-4062] Refactor clean files feature

QiangCai commented on pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#issuecomment-739642960 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4040: [WIP][CI TEST]

CarbonDataQA2 commented on pull request #4040: URL: https://github.com/apache/carbondata/pull/4040#issuecomment-739635308 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5067/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4040: [WIP][CI TEST]

CarbonDataQA2 commented on pull request #4040: URL: https://github.com/apache/carbondata/pull/4040#issuecomment-739635257 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3310/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4044: [CARBONDATA-4062] Refactor clean files feature

CarbonDataQA2 commented on pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#issuecomment-739635141 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4029: [HOTFIX] Refact Carbon Util

CarbonDataQA2 commented on pull request #4029: URL: https://github.com/apache/carbondata/pull/4029#issuecomment-739634371 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3307/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4044: [CARBONDATA-4062] Refactor clean files feature

CarbonDataQA2 commented on pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#issuecomment-739634201 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4040: [WIP][CI TEST]

CarbonDataQA2 commented on pull request #4040: URL: https://github.com/apache/carbondata/pull/4040#issuecomment-739634188 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5068/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4043: IUD Concurrency Improvement

CarbonDataQA2 commented on pull request #4043: URL: https://github.com/apache/carbondata/pull/4043#issuecomment-739634097 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5062/

[GitHub] [carbondata] Zhangshunyu commented on pull request #4040: [WIP][CI TEST]

Zhangshunyu commented on pull request #4040: URL: https://github.com/apache/carbondata/pull/4040#issuecomment-739621621 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4040: [WIP][CI TEST]

CarbonDataQA2 commented on pull request #4040: URL: https://github.com/apache/carbondata/pull/4040#issuecomment-739620979 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5087/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4029: [HOTFIX] Refact Carbon Util

CarbonDataQA2 commented on pull request #4029: URL: https://github.com/apache/carbondata/pull/4029#issuecomment-739620953 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5088/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4043: IUD Concurrency Improvement

CarbonDataQA2 commented on pull request #4043: URL: https://github.com/apache/carbondata/pull/4043#issuecomment-739620866 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

CarbonDataQA2 commented on pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#issuecomment-739620889 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4040: [WIP][CI TEST]

CarbonDataQA2 commented on pull request #4040: URL: https://github.com/apache/carbondata/pull/4040#issuecomment-739620657 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3306/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4029: [HOTFIX] Refact Carbon Util

CarbonDataQA2 commented on pull request #4029: URL: https://github.com/apache/carbondata/pull/4029#issuecomment-739620454 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3331/

[GitHub] [carbondata] shenjiayu17 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

shenjiayu17 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r533974578 ## File path: geo/src/main/java/org/apache/carbondata/geo/scan/expression/PolylineListExpression.java ## @@ -0,0 +1,202 @@ +/* + * Licensed to

  1   2   >