[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4070: [CARBONDATA-4082] Fix alter table add segment query on adding a segment having delete delta files.

2021-01-18 Thread GitBox
CarbonDataQA2 commented on pull request #4070: URL: https://github.com/apache/carbondata/pull/4070#issuecomment-762637383 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3553/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4070: [CARBONDATA-4082] Fix alter table add segment query on adding a segment having delete delta files.

2021-01-18 Thread GitBox
CarbonDataQA2 commented on pull request #4070: URL: https://github.com/apache/carbondata/pull/4070#issuecomment-762634833 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5313/

[GitHub] [carbondata] Karan980 commented on pull request #4070: [CARBONDATA-4082] Fix alter table add segment query on adding a segment having delete delta files.

2021-01-18 Thread GitBox
Karan980 commented on pull request #4070: URL: https://github.com/apache/carbondata/pull/4070#issuecomment-762604221 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] QiangCai commented on a change in pull request #4025: [WIP] Make TableStatus/UpdateTableStatus/SegmentFile Smaller

2021-01-18 Thread GitBox
QiangCai commented on a change in pull request #4025: URL: https://github.com/apache/carbondata/pull/4025#discussion_r559874151 ## File path: core/pom.xml ## @@ -64,6 +64,11 @@ expiringmap 0.5.9 + + com.alibaba + fastjson + 1.2.68 Review

[GitHub] [carbondata] QiangCai commented on pull request #4076: [CARBONDATA-4107] Added mvExists property for MV fact table and added lock while touchMDTFile

2021-01-18 Thread GitBox
QiangCai commented on pull request #4076: URL: https://github.com/apache/carbondata/pull/4076#issuecomment-762546050 yes, it can avoid to list all tables of some databases. This is an automated message from the Apache Git

[GitHub] [carbondata] nihal0107 commented on pull request #4071: [CARBONDATA-4102] Added UT and FT to improve coverage of SI module.

2021-01-18 Thread GitBox
nihal0107 commented on pull request #4071: URL: https://github.com/apache/carbondata/pull/4071#issuecomment-762305509 ![before2](https://user-images.githubusercontent.com/32429250/104931386-56d60880-59cc-11eb-9914-c38b30f99c72.png)

[GitHub] [carbondata] nihal0107 removed a comment on pull request #4071: [CARBONDATA-4102] Added UT and FT to improve coverage of SI module.

2021-01-18 Thread GitBox
nihal0107 removed a comment on pull request #4071: URL: https://github.com/apache/carbondata/pull/4071#issuecomment-762304031 @Indhumathi27 please find the comparison with master branch and current branch x-special/nautilus-clipboard copy file:///home/nihal/Pictures/after1.png

[GitHub] [carbondata] nihal0107 commented on pull request #4071: [CARBONDATA-4102] Added UT and FT to improve coverage of SI module.

2021-01-18 Thread GitBox
nihal0107 commented on pull request #4071: URL: https://github.com/apache/carbondata/pull/4071#issuecomment-762304031 @Indhumathi27 please find the comparison with master branch and current branch x-special/nautilus-clipboard copy file:///home/nihal/Pictures/after1.png

[GitHub] [carbondata] Indhumathi27 edited a comment on pull request #4076: [CARBONDATA-4107] Added mvExists property for MV fact table and added lock while touchMDTFile

2021-01-18 Thread GitBox
Indhumathi27 edited a comment on pull request #4076: URL: https://github.com/apache/carbondata/pull/4076#issuecomment-762229135 > @Indhumathi27 if the number of mv tables is less than 10 (configurable), maybe we can list all tables; if-else we can store database information only.

[GitHub] [carbondata] Indhumathi27 commented on pull request #4076: [CARBONDATA-4107] Added mvExists property for MV fact table and added lock while touchMDTFile

2021-01-18 Thread GitBox
Indhumathi27 commented on pull request #4076: URL: https://github.com/apache/carbondata/pull/4076#issuecomment-762229135 > @Indhumathi27 if the number of mv tables is less than 10 (configurable), maybe we can list all tables; if-else we can store database information only. actually,

[jira] [Commented] (CARBONDATA-4101) Carbondata Connectivity via JDBC driver

2021-01-18 Thread Nihal kumar ojha (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267164#comment-17267164 ] Nihal kumar ojha commented on CARBONDATA-4101: -- Hi Rohit,     We can connect

[jira] [Closed] (CARBONDATA-4106) Compaction is not working properly

2021-01-18 Thread Ajantha Bhat (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajantha Bhat closed CARBONDATA-4106. Fix Version/s: (was: 2.0.1) Resolution: Not A Bug > Compaction is not

[jira] [Commented] (CARBONDATA-4106) Compaction is not working properly

2021-01-18 Thread Ajantha Bhat (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267160#comment-17267160 ] Ajantha Bhat commented on CARBONDATA-4106: -- closing the defect as it is not an issue and

[GitHub] [carbondata] QiangCai commented on pull request #4076: [CARBONDATA-4107] Added mvExists property for MV fact table and added lock while touchMDTFile

2021-01-18 Thread GitBox
QiangCai commented on pull request #4076: URL: https://github.com/apache/carbondata/pull/4076#issuecomment-762096880 @Indhumathi27 if the number of mv tables is less than 10 (configurable), maybe we can list all tables; if-else we can store database information only.

[GitHub] [carbondata] QiangCai commented on pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2021-01-18 Thread GitBox
QiangCai commented on pull request #3988: URL: https://github.com/apache/carbondata/pull/3988#issuecomment-762090072 how about skip carbonindex files step to generate carbonindexmerge files directly on driver side? This is