[GitHub] [carbondata] Karan980 commented on a change in pull request #4070: [CARBONDATA-4082] Fix alter table add segment query on adding a segment having delete delta files.

2021-01-21 Thread GitBox
Karan980 commented on a change in pull request #4070: URL: https://github.com/apache/carbondata/pull/4070#discussion_r561607408 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAddLoadCommand.scala ## @@ -294,6 +297,49 @@

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4076: [CARBONDATA-4107] Added mvExists property for MV fact table and added lock while touchMDTFile

2021-01-21 Thread GitBox
CarbonDataQA2 commented on pull request #4076: URL: https://github.com/apache/carbondata/pull/4076#issuecomment-764355741 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] Indhumathi27 closed pull request #4079: [TEST]test ci

2021-01-21 Thread GitBox
Indhumathi27 closed pull request #4079: URL: https://github.com/apache/carbondata/pull/4079 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [carbondata] QiangCai commented on pull request #4078: [CARBONDATA-4075] Refactor code to use withEvents instead of fireEvent

2021-01-21 Thread GitBox
QiangCai commented on pull request #4078: URL: https://github.com/apache/carbondata/pull/4078#issuecomment-765053051 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] kunal642 commented on pull request #4064: [CARBONDATA-4096] SDK read fails from cluster and sdk read filter query on sort column giving wrong result with IndexServer

2021-01-21 Thread GitBox
kunal642 commented on pull request #4064: URL: https://github.com/apache/carbondata/pull/4064#issuecomment-764530852 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4076: [CARBONDATA-4107] Added mvExists property for MV fact table and added lock while touchMDTFile

2021-01-21 Thread GitBox
Indhumathi27 commented on a change in pull request #4076: URL: https://github.com/apache/carbondata/pull/4076#discussion_r561693339 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/view/CarbonDropMVCommand.scala ## @@ -90,6 +95,37 @@ case

[GitHub] [carbondata] akkio-97 commented on a change in pull request #4073: [CARBONDATA-4104] Vector filling for complex decimal type needs to be handled

2021-01-21 Thread GitBox
akkio-97 commented on a change in pull request #4073: URL: https://github.com/apache/carbondata/pull/4073#discussion_r561605603 ## File path: core/src/main/java/org/apache/carbondata/core/metadata/datatype/DecimalConverterFactory.java ## @@ -328,9 +328,29 @@ public BigDecimal

[GitHub] [carbondata] asfgit closed pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data

2021-01-21 Thread GitBox
asfgit closed pull request #4018: URL: https://github.com/apache/carbondata/pull/4018 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] Karan980 commented on pull request #4062: [CARBONDATA-4097] ColumnVectors should not be initialized as ColumnVectorWrapperDirect for alter tables.

2021-01-21 Thread GitBox
Karan980 commented on pull request #4062: URL: https://github.com/apache/carbondata/pull/4062#issuecomment-764436367 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4076: [CARBONDATA-4107] Added mvExists property for MV fact table and added lock while touchMDTFile

2021-01-21 Thread GitBox
akashrn5 commented on a change in pull request #4076: URL: https://github.com/apache/carbondata/pull/4076#discussion_r561671488 ## File path: core/src/main/java/org/apache/carbondata/core/view/MVProvider.java ## @@ -569,14 +568,31 @@ private synchronized void touchMDTFile()

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4078: [CARBONDATA-4075] Refactor code to use withEvents instead of fireEvent

2021-01-21 Thread GitBox
CarbonDataQA2 commented on pull request #4078: URL: https://github.com/apache/carbondata/pull/4078#issuecomment-765088260 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] Indhumathi27 commented on pull request #4076: [CARBONDATA-4107] Added mvExists property for MV fact table and added lock while touchMDTFile

2021-01-21 Thread GitBox
Indhumathi27 commented on pull request #4076: URL: https://github.com/apache/carbondata/pull/4076#issuecomment-764288658 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] kunal642 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data

2021-01-21 Thread GitBox
kunal642 commented on pull request #4018: URL: https://github.com/apache/carbondata/pull/4018#issuecomment-764338208 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] kunal642 commented on pull request #4062: [CARBONDATA-4097] ColumnVectors should not be initialized as ColumnVectorWrapperDirect for alter tables.

2021-01-21 Thread GitBox
kunal642 commented on pull request #4062: URL: https://github.com/apache/carbondata/pull/4062#issuecomment-764380634 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4079: [TEST]test ci

2021-01-21 Thread GitBox
CarbonDataQA2 commented on pull request #4079: URL: https://github.com/apache/carbondata/pull/4079#issuecomment-764480479 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4062: [CARBONDATA-4097] ColumnVectors should not be initialized as ColumnVectorWrapperDirect for alter tables.

2021-01-21 Thread GitBox
CarbonDataQA2 commented on pull request #4062: URL: https://github.com/apache/carbondata/pull/4062#issuecomment-764431030 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4078: [CARBONDATA-4075] Refactor code to use withEvents instead of fireEvent

2021-01-21 Thread GitBox
CarbonDataQA2 commented on pull request #4078: URL: https://github.com/apache/carbondata/pull/4078#issuecomment-765091491 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3573/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4078: [CARBONDATA-4075] Refactor code to use withEvents instead of fireEvent

2021-01-21 Thread GitBox
CarbonDataQA2 commented on pull request #4078: URL: https://github.com/apache/carbondata/pull/4078#issuecomment-765088260 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5333/

[GitHub] [carbondata] QiangCai commented on pull request #4078: [CARBONDATA-4075] Refactor code to use withEvents instead of fireEvent

2021-01-21 Thread GitBox
QiangCai commented on pull request #4078: URL: https://github.com/apache/carbondata/pull/4078#issuecomment-765053051 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4076: [CARBONDATA-4107] Added related MV tables Map to fact table and added lock while touchMDTFile

2021-01-21 Thread GitBox
CarbonDataQA2 commented on pull request #4076: URL: https://github.com/apache/carbondata/pull/4076#issuecomment-764825371 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3572/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4076: [CARBONDATA-4107] Added related MV tables Map to fact table and added lock while touchMDTFile

2021-01-21 Thread GitBox
CarbonDataQA2 commented on pull request #4076: URL: https://github.com/apache/carbondata/pull/4076#issuecomment-764822381 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5332/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4076: [CARBONDATA-4107] Added related MV tables Map to fact table and added lock while touchMDTFile

2021-01-21 Thread GitBox
CarbonDataQA2 commented on pull request #4076: URL: https://github.com/apache/carbondata/pull/4076#issuecomment-764626476 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3571/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4076: [CARBONDATA-4107] Added related MV tables Map to fact table and added lock while touchMDTFile

2021-01-21 Thread GitBox
CarbonDataQA2 commented on pull request #4076: URL: https://github.com/apache/carbondata/pull/4076#issuecomment-764623559 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5331/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4079: [TEST]test ci

2021-01-21 Thread GitBox
CarbonDataQA2 commented on pull request #4079: URL: https://github.com/apache/carbondata/pull/4079#issuecomment-764537279 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3570/

[GitHub] [carbondata] Indhumathi27 closed pull request #4079: [TEST]test ci

2021-01-21 Thread GitBox
Indhumathi27 closed pull request #4079: URL: https://github.com/apache/carbondata/pull/4079 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4079: [TEST]test ci

2021-01-21 Thread GitBox
CarbonDataQA2 commented on pull request #4079: URL: https://github.com/apache/carbondata/pull/4079#issuecomment-764534625 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5330/

[GitHub] [carbondata] kunal642 commented on pull request #4064: [CARBONDATA-4096] SDK read fails from cluster and sdk read filter query on sort column giving wrong result with IndexServer

2021-01-21 Thread GitBox
kunal642 commented on pull request #4064: URL: https://github.com/apache/carbondata/pull/4064#issuecomment-764530852 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4076: [CARBONDATA-4107] Added mvExists property for MV fact table and added lock while touchMDTFile

2021-01-21 Thread GitBox
Indhumathi27 commented on a change in pull request #4076: URL: https://github.com/apache/carbondata/pull/4076#discussion_r561714909 ## File path: core/src/main/java/org/apache/carbondata/core/view/MVProvider.java ## @@ -569,14 +568,31 @@ private synchronized void

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4062: [CARBONDATA-4097] ColumnVectors should not be initialized as ColumnVectorWrapperDirect for alter tables.

2021-01-21 Thread GitBox
CarbonDataQA2 commented on pull request #4062: URL: https://github.com/apache/carbondata/pull/4062#issuecomment-764486033 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3567/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4079: [TEST]test ci

2021-01-21 Thread GitBox
CarbonDataQA2 commented on pull request #4079: URL: https://github.com/apache/carbondata/pull/4079#issuecomment-764481057 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5329/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4079: [TEST]test ci

2021-01-21 Thread GitBox
CarbonDataQA2 commented on pull request #4079: URL: https://github.com/apache/carbondata/pull/4079#issuecomment-764480479 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3569/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4062: [CARBONDATA-4097] ColumnVectors should not be initialized as ColumnVectorWrapperDirect for alter tables.

2021-01-21 Thread GitBox
CarbonDataQA2 commented on pull request #4062: URL: https://github.com/apache/carbondata/pull/4062#issuecomment-764480017 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5327/

[GitHub] [carbondata] Indhumathi27 opened a new pull request #4079: [TEST]test ci

2021-01-21 Thread GitBox
Indhumathi27 opened a new pull request #4079: URL: https://github.com/apache/carbondata/pull/4079 ### Why is this PR needed? ### What changes were proposed in this PR? ### Does this PR introduce any user interface change? - No - Yes. (please explain

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4076: [CARBONDATA-4107] Added mvExists property for MV fact table and added lock while touchMDTFile

2021-01-21 Thread GitBox
Indhumathi27 commented on a change in pull request #4076: URL: https://github.com/apache/carbondata/pull/4076#discussion_r561693339 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/view/CarbonDropMVCommand.scala ## @@ -90,6 +95,37 @@ case

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4076: [CARBONDATA-4107] Added mvExists property for MV fact table and added lock while touchMDTFile

2021-01-21 Thread GitBox
CarbonDataQA2 commented on pull request #4076: URL: https://github.com/apache/carbondata/pull/4076#issuecomment-764465842 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5328/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4076: [CARBONDATA-4107] Added mvExists property for MV fact table and added lock while touchMDTFile

2021-01-21 Thread GitBox
CarbonDataQA2 commented on pull request #4076: URL: https://github.com/apache/carbondata/pull/4076#issuecomment-764464803 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3568/

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4076: [CARBONDATA-4107] Added mvExists property for MV fact table and added lock while touchMDTFile

2021-01-21 Thread GitBox
akashrn5 commented on a change in pull request #4076: URL: https://github.com/apache/carbondata/pull/4076#discussion_r561671488 ## File path: core/src/main/java/org/apache/carbondata/core/view/MVProvider.java ## @@ -569,14 +568,31 @@ private synchronized void touchMDTFile()