Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2607#discussion_r207804289
--- Diff:
integration/presto/src/main/scala/org/apache/carbondata/presto/CarbonDictionaryDecodeReadSupport.scala
---
@@ -84,25 +85,31 @@ class
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2412#discussion_r198136493
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataPageSource.java
---
@@ -166,61 +146,31 @@ protected void
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2412#discussion_r198136861
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/readers/ObjectStreamReader.java
---
@@ -17,50 +17,50 @@
package
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2412#discussion_r198107936
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/CarbonVectorBatch.java
---
@@ -20,50 +20,81 @@
import java.util.HashSet
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2265#discussion_r196799725
--- Diff: integration/presto/README.md ---
@@ -113,6 +116,10 @@ Please follow the below steps to query carbondata in
presto
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2265#discussion_r196799800
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataMetadata.java
---
@@ -152,19 +176,20 @@ private
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2265#discussion_r196799513
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataPageSourceProvider.java
---
@@ -129,23 +135,31 @@ private
Github user bhavya411 commented on the issue:
https://github.com/apache/carbondata/pull/2265
retest this please
---
Github user bhavya411 commented on the issue:
https://github.com/apache/carbondata/pull/2265
retest this please
---
Github user bhavya411 commented on the issue:
https://github.com/apache/carbondata/pull/2265
Yes we have created a JIRA for the same CARBONDATA-2583
---
GitHub user bhavya411 opened a pull request:
https://github.com/apache/carbondata/pull/2340
[CARBONDATA-2529] Fixed S3 Issue for Hadoop 2.8.3
This issue fixes the issue while loading the data with S3 as backend.
- [ N] Any interfaces changed?
- [N ] Any backward
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2265#discussion_r189779766
--- Diff: integration/presto/pom.xml ---
@@ -462,12 +462,6 @@
3.0.2
--- End diff --
@chenliang613 we can not remove
Github user bhavya411 commented on the issue:
https://github.com/apache/carbondata/pull/2265
I have resolved the conflicts
---
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2265#discussion_r186359964
--- Diff: integration/presto/pom.xml ---
@@ -462,12 +462,6 @@
3.0.2
--- End diff --
We can not remove this class for now
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2139#discussion_r179913482
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/impl/CarbonTableReader.java
---
@@ -415,14 +440,56 @@ public TBase create
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2139#discussion_r179913431
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/impl/CarbonTableReader.java
---
@@ -415,14 +440,56 @@ public TBase create
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2139#discussion_r179913191
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/impl/CarbonTableReader.java
---
@@ -387,11 +398,25 @@ public TBase create
Github user bhavya411 commented on the issue:
https://github.com/apache/carbondata/pull/1940
This PR Removes the following classes from the PrestoCode
-CarbondataRecordCursor - This class used to get the records row by row
from the iterator, we were using this just
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2114#discussion_r178230596
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/impl/CarbonTableReader.java
---
@@ -366,7 +368,10 @@ public TBase create
GitHub user bhavya411 opened a pull request:
https://github.com/apache/carbondata/pull/2114
[CARBONDATA-2295] Added property for UnsafeMemory configuration
Added property for setting up the unsafe memory limit in MB
- [ X] Testing done
Added a new
Github user bhavya411 commented on the issue:
https://github.com/apache/carbondata/pull/1940
retest sdv please.
---
GitHub user bhavya411 opened a pull request:
https://github.com/apache/carbondata/pull/1940
[CARBONDATA-2140 ] Refactoring code to improve performance and removing
unnecessary code in Presto Integration
This PR is for optimizing Presto performance and refactoring the code
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1581#discussion_r156023011
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/RestructureBasedVectorResultCollector.java
---
@@ -238,7 +238,7
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1581#discussion_r155492390
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataConnector.java
---
@@ -31,13 +31,13 @@
private static final
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1581#discussion_r155438974
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/CarbonVectorBatch.java
---
@@ -0,0 +1,112 @@
+package
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1581#discussion_r155435994
--- Diff: integration/presto/pom.xml ---
@@ -431,14 +435,27 @@
org.apache.spark
- spark-sql_2.11
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1581#discussion_r155185364
--- Diff: integration/presto/pom.xml ---
@@ -431,14 +435,27 @@
org.apache.spark
- spark-sql_2.11
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1581#discussion_r154860147
--- Diff: integration/presto/pom.xml ---
@@ -31,7 +31,7 @@
presto-plugin
-0.186
+0.187
--- End diff
Github user bhavya411 commented on the issue:
https://github.com/apache/carbondata/pull/1581
retest this please.
---
Github user bhavya411 commented on the issue:
https://github.com/apache/carbondata/pull/1538
This PR removes the Spark Dependency from Presto Integration Module for
using the CarbonVectorizedRecordreader, This PR consolidate
CarbonVectorizedRecordReader into one,to make it shared
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1538#discussion_r152498613
--- Diff: integration/presto/pom.xml ---
@@ -31,7 +31,7 @@
presto-plugin
-0.186
--- End diff
GitHub user bhavya411 opened a pull request:
https://github.com/apache/carbondata/pull/1538
[CARBONDATA-1779] GenericVectorizedReader
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- No interfaces changed
Github user bhavya411 commented on the issue:
https://github.com/apache/carbondata/pull/1477
retest this please
---
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1477#discussion_r149945794
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/PrestoFilterUtil.java
---
@@ -261,8 +261,6 @@ else if (type instanceof
Github user bhavya411 commented on the issue:
https://github.com/apache/carbondata/pull/1477
All issues have been resolved
---
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1477#discussion_r149944113
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataPageSource.java
---
@@ -78,10 +78,6 @@ private
GitHub user bhavya411 opened a pull request:
https://github.com/apache/carbondata/pull/1477
[CARBONDATA-1686] Presto Version Upgrade to 0.186
- [No] Any interfaces changed?
- [Yes ] Any backward compatibility impacted? Carbondata will now work
with Presto Server
Github user bhavya411 commented on the issue:
https://github.com/apache/carbondata/pull/1348
retest this please
---
GitHub user bhavya411 opened a pull request:
https://github.com/apache/carbondata/pull/1348
[CARBONDATA-1469] Optimizations for Presto Integration
This PR has added following new features
- Optimized Stream Readers to handle Nulls in vector efficiently
- Added
GitHub user bhavya411 opened a pull request:
https://github.com/apache/carbondata/pull/1307
[CARBONDATA-1433] Added Vectorized Reader for Presto Integration
This PR is for optimizing the Presto Integration Performance
- Added Vectorized Reader for reading the data
- Used
GitHub user bhavya411 opened a pull request:
https://github.com/apache/carbondata/pull/1294
[CARBONDATA-1418] Use CarbonTableInputFormat for creating the Splits and
QueryModel
Refactored Code to use CarbonTableInputFormat for creating splits
Build Successful
All Test
Github user bhavya411 commented on the issue:
https://github.com/apache/carbondata/pull/1236
Hi @steven-qin can you please remove the extra import " import
com.google.common.base.Strings;" from CarbondataRecordCursor. I have verified
the PR for both LongD
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1190#discussion_r129588108
--- Diff: integration/presto/pom.xml ---
@@ -228,6 +228,33 @@
true
Github user bhavya411 commented on the issue:
https://github.com/apache/carbondata/pull/1142
@cenyuhai The performance improved a lot I tested it with 5 Million records
please see the attached results
[Performance.txt](https://github.com/apache/carbondata/files/1135276
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1142#discussion_r126392840
--- Diff:
integration/hive/src/main/java/org/apache/carbondata/hive/DictionaryDecodeReadSupport.java
---
@@ -0,0 +1,288 @@
+/*
+ * Licensed
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1142#discussion_r126392125
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java ---
@@ -444,9 +444,14 @@ protected Expression getFilterPredicates
Github user bhavya411 commented on the issue:
https://github.com/apache/carbondata/pull/984
Sure Liang, I will review it today.
Regards
Bhavya
On Sun, Jul 9, 2017 at 7:39 PM, å²çæµ· <notificati...@github.com> wrote:
> @chenliang613 <https:
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1142#discussion_r126119484
--- Diff:
integration/hive/src/main/java/org/apache/carbondata/hive/DictionaryDecodeReadSupport.java
---
@@ -0,0 +1,288 @@
+/*
+ * Licensed
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1142#discussion_r126119465
--- Diff:
integration/hive/src/main/java/org/apache/carbondata/hive/DictionaryDecodeReadSupport.java
---
@@ -0,0 +1,288 @@
+/*
+ * Licensed
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1142#discussion_r126077264
--- Diff:
core/src/main/java/org/apache/carbondata/core/stats/QueryStatisticsRecorderImpl.java
---
@@ -101,45 +101,47 @@ public String
GitHub user bhavya411 opened a pull request:
https://github.com/apache/carbondata/pull/1142
[CARBONDATA-1271] Enhanced Performance for Hive Integration with Carbondata
There are various fixes added to improve the performance
- Added a DictionaryDecodeReadSupport class in Hive
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/984#discussion_r125279885
--- Diff:
core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentUpdateStatusManager.java
---
@@ -269,9 +270,9 @@ public ICarbonLock
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/984#discussion_r125282321
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/AlterTableCommands.scala
---
@@ -438,11 +457,24 @@ private[sql
Github user bhavya411 closed the pull request at:
https://github.com/apache/carbondata/pull/875
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user bhavya411 commented on the issue:
https://github.com/apache/carbondata/pull/875
Since the feature is not supported in Spark 1.6 , this PR need not be
merged hence closing it.
---
If your project is set up for it, you can reply to this email and have your
reply appear
55 matches
Mail list logo
