Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1294
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1292#discussion_r135672191
--- Diff:
integration/spark-common-test/src/test/resources/IUD/2000_UniqData_2.csv ---
@@ -0,0 +1,5 @@
+CUST_ID,CUST_NAME,DECIMAL_COLUMN1
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1292#discussion_r135672102
--- Diff: examples/spark2/src/main/resources/2000_UniqData_2.csv ---
@@ -0,0 +1,4 @@
+9000,CUST_NAME_1,12345678901.1234
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1294
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1291
@cenyuhai i think, CarbonInputFormat should extend CarbonTableInputFormat
now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1291#discussion_r135560774
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java ---
@@ -133,7 +133,7 @@ public static void setTableInfo
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1286
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1258
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1219
@vandana7 please correct PR's title as per
https://github.com/apache/carbondata/blob/master/docs/How-to-contribute-to-Apache-CarbonData.md
---
If your project is set up for it, you can
Github user chenliang613 closed the pull request at:
https://github.com/apache/carbondata/pull/1244
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1255
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1282
No, after config email, you need to push your commit again.
This PR's commit record still be wrong, as below :
commit 97685add85d5304a485e2632110403aeef6f27f3
Author
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1285
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1257#discussion_r134694501
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataRecordSet.java
---
@@ -79,30 +81,27 @@ private Expression
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1257#discussion_r134692412
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataRecordSetProvider.java
---
@@ -73,27 +60,23 @@ public
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1257#discussion_r134691842
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/constants/PrestoCommonConstants.java
---
@@ -0,0 +1,29
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1282
@Ayushi93 please config your email info in your local git environment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1282
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1257
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1236
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1236
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1234
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1260
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1257#discussion_r133904356
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/memory/AbstractAggregatedMemoryContext.java
---
@@ -0,0 +1,40
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1231
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1231
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1236
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1236
@anubhav100 i prefer to using steven-qin's pull request, because steven-qin
fix it earlier.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1258
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1257#discussion_r133377510
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/readers/DecimalSliceStreamReader.java
---
@@ -0,0 +1,103 @@
+package
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1257#discussion_r133377209
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/readers/DecimalSliceStreamReader.java
---
@@ -0,0 +1,103 @@
+package
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1257#discussion_r133376989
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/readers/BooleanStreamReader.java
---
@@ -0,0 +1,31 @@
+package
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1257#discussion_r133375796
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/memory/AggregatedMemoryContext.java
---
@@ -0,0 +1,62
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1257#discussion_r133375914
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/memory/LocalMemoryContext.java
---
@@ -0,0 +1,40
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1257#discussion_r133375740
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/memory/AbstractAggregatedMemoryContext.java
---
@@ -0,0 +1,37
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1257#discussion_r133372855
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/constants/CarbonCommonConstants.java
---
@@ -0,0 +1,1319
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1257#discussion_r133370557
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/expression/ExpressionResult.java
---
@@ -183,7 +183,7 @@ public String getString
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1257
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1260
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1258
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user chenliang613 opened a pull request:
https://github.com/apache/carbondata/pull/1260
[CARBONDATA-1382] Add more test cases for bucket feature
1.Add more test cases for bucket feature 2.Optimize some test cases's data
load method.
You can merge this pull request
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1255
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1251
i tested it , the link is working fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1251
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1245
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1244
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1244
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1244
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1218
@anubhav100 Yes. Suggest creating a new PR for test cases to cover all
presto functionality.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1218
@anubhav100 please put test cases for this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1218#discussion_r131845008
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/ColumnBasedResultCollector.java
---
@@ -0,0 +1,233
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1218#discussion_r131842839
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -510,9 +511,16 @@
* LOAD_STATUS
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1218#discussion_r131841330
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/ColumnBasedResultCollector.java
---
@@ -0,0 +1,233
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1230
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1230
sok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1244
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user chenliang613 opened a pull request:
https://github.com/apache/carbondata/pull/1244
[Don't merge] Only for test apache jenkin CIs, to avoid printing too much
error msg.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1225
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1218
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1231
1.please correct your PR title as per :
https://github.com/apache/carbondata/blob/master/docs/How-to-contribute-to-Apache-CarbonData.md
2.Can you please provide the reproduce steps
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1234
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1236
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1235
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user chenliang613 opened a pull request:
https://github.com/apache/carbondata/pull/1232
Fix compile issues
Fix compile issues with "mvn clean package"
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chenliang613/
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1229
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1214
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1226
apache2.1 retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1226
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1226#discussion_r131087095
--- Diff: pom.xml ---
@@ -401,6 +398,9 @@
spark-2.1
+
+true
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1214
@cenyuhai
you mean: use the listener, it is able to sync up table's meta info
between spark and hive:
first i create one table with name "table1" in spark-shell
se
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1218
@anubhav100 i tested the performance again , the latest commit
"9e67c38f9e2c26a888d1fc1b95c5c23dc6f5839f" is slower than
"014e972faad4c51a16473fd965be7428b4bcc55a
GitHub user chenliang613 opened a pull request:
https://github.com/apache/carbondata/pull/1226
[CARBONDATA-1205] Use Spark 2.1 as default from 1.2.0 onwards
From 1.2.0, there are many features developing based on Spark 2.1, so use
Spark2.1 as default compilation in parent pom
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1192
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1224
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1214
@cenyuhai can you provide the steps, how to verify it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1218#discussion_r130582527
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataFilterUtil.java
---
@@ -0,0 +1,223 @@
+/*
+ * Licensed
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1218#discussion_r130558828
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -510,9 +511,16 @@
* LOAD_STATUS
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1207
@sgururajshetty please review it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1134
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1193
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1206
LGTMï¼ thanks for your contribution. @zzcclp
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1197
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1134#discussion_r129874324
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java
---
@@ -465,6 +463,29 @@ public static
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1145
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1200
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1181
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1198
LGTM, very good PR! Thanks for your good contribution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1198
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1198
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1197#discussion_r129736254
--- Diff:
integration/spark-common/src/main/java/org/apache/carbondata/spark/util/SparkDataTypeConverterImp.java
---
@@ -0,0 +1,49
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1197#discussion_r129736197
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java ---
@@ -768,29 +818,6 @@ public QueryModel getQueryModel
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1110
raise a new PR #1197 , close the old one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chenliang613 closed the pull request at:
https://github.com/apache/carbondata/pull/1110
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user chenliang613 opened a pull request:
https://github.com/apache/carbondata/pull/1197
[CARBONDATA-1238] Decouple the datatype convert from Spark code in core
module
Decouple the datatype convert from Spark code in core module.
You can merge this pull request into a Git
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1190#discussion_r129528008
--- Diff: integration/presto/pom.xml ---
@@ -228,6 +228,33 @@
true
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1195
@xuchuanyin everything looks ok, please do rebase.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1192#discussion_r129514137
--- Diff: conf/carbon.properties.template ---
@@ -42,6 +42,9 @@ carbon.enableXXHash=true
#carbon.max.level.cache.size=-1
#enable prefetch
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1192#discussion_r129513477
--- Diff:
integration/spark-common-test/src/test/resources/partition_data.csv ---
@@ -0,0 +1,27 @@
+id,vin,logdate,phonenumber,country,area
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1193#discussion_r129511350
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/CarbonSortColumnsExample.scala
---
@@ -0,0 +1,126
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1196
please change the PR name to : Rebase datamap branch onto master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
501 - 600 of 780 matches
Mail list logo
