Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3064#discussion_r246777849
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/execution/command/CarbonHiveCommands.scala
---
@@ -127,6 +127,9 @@ object
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/3014
LGTM
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2996
LGTM
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3014#discussion_r245884441
--- Diff:
integration/spark2/src/test/scala/org/apache/spark/carbondata/commands/SetCommandTestCase.scala
---
@@ -128,6 +128,34 @@ class
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3014#discussion_r245879143
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/SessionParams.java ---
@@ -229,6 +229,12 @@ private boolean validateKeyValue(String key
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3046#discussion_r245877242
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
@@ -1491,6 +1491,27 @@ private void
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3046#discussion_r245653091
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/DecoderBasedFallbackEncoder.java
---
@@ -57,10 +57,7 @@ public
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/3045
LGTM
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3046#discussion_r24497
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -2076,4 +2076,15 @@ private CarbonCommonConstants
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/3046
@xuchuanyin The problem was that when using varchar column with email data
the key for the dictionary map is very huge. When fallback happens the same
data is kept in memory twice, which
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/3046
[WIP] Added check to start fallback based on size
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/3010
@Shubh18s Please fix 2.3 build
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3010#discussion_r244085456
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/optimizer/CarbonLateDecodeRule.scala
---
@@ -106,22 +106,29 @@ class
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3010#discussion_r244084957
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1449,12 +1449,9 @@ private CarbonCommonConstants
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2988
LGTM
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2951
@shivamasn Please add test cases for map type too
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2983
LGTM
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2899
LGTM
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2983#discussion_r242403727
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/parser/impl/ArrayParserImpl.java
---
@@ -56,6 +56,10 @@ public
Github user kunal642 closed the pull request at:
https://github.com/apache/carbondata/pull/2994
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2994
[WIP][CARBONDATA-2670] changed the impl of s3 renameforce to rewrite
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2989
LGTM
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2925
@xubo245 I dont think we are supporting thriftServer to be run through
IntelliJ on local. In cluster mode this jar would already be available as part
of spark dependency.
For SDK because
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2968
LGTM
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2977#discussion_r240473257
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateListeners.scala
---
@@ -111,6 +113,29
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2977#discussion_r240473230
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateListeners.scala
---
@@ -111,6 +113,29
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2972
LGTM
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2977#discussion_r240180385
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/AggregateDataMapCompactor.scala
---
@@ -79,9 +79,20 @@ class
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2968
retest this please
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2968
LGTM
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2981
LGTM
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2981#discussion_r240026697
--- Diff:
integration/spark-datasource/src/test/scala/org/apache/spark/sql/carbondata/datasource/SparkCarbonDataSourceTest.scala
---
@@ -998,9
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2981#discussion_r240026585
--- Diff:
integration/spark-datasource/src/test/scala/org/apache/spark/sql/carbondata/datasource/SparkCarbonDataSourceTest.scala
---
@@ -998,9
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2977#discussion_r239331535
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateListeners.scala
---
@@ -156,20 +177,20
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2977
[WIP] [CARBONDATA-3147] Fixed concurrent load issue
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2940#discussion_r238161863
--- Diff: integration/spark2/pom.xml ---
@@ -105,6 +105,11 @@
+
+ org.apache.httpcomponents
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2940#discussion_r238142863
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/preaggregate/TestPreAggCreateCommand.scala
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2964
LGTM
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2965
LGTM
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2951
@shivamasn Please add description for the PR. Also attach test report in
the description.
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2951#discussion_r237781038
--- Diff:
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/datasource
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2951#discussion_r237779541
--- Diff:
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/datasource
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2951#discussion_r237779383
--- Diff:
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/datasource
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2951#discussion_r237780471
--- Diff:
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/datasource
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2951#discussion_r237779458
--- Diff:
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/datasource
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2956
@manishgupta88 Please review
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2951#discussion_r236647791
--- Diff:
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/dli/SparkCarbonDataSourceTestCase.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2951#discussion_r236647192
--- Diff:
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/dli/SparkCarbonDataSourceTestCase.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2951#discussion_r236646305
--- Diff:
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/dli
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2951#discussion_r236646395
--- Diff:
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/dli
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2951#discussion_r236646951
--- Diff:
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/dli
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2956#discussion_r236768667
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentPropertiesAndSchemaHolder.java
---
@@ -332,13 +334,42 @@ public void
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2956#discussion_r236768636
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentPropertiesAndSchemaHolder.java
---
@@ -332,13 +334,42 @@ public void
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2956#discussion_r236768643
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentPropertiesAndSchemaHolder.java
---
@@ -332,13 +334,42 @@ public void
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2942
LGTM
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2956
[CARBONDATA-3134] fixed null values when cachelevel is set as blocklet
**Problem:**
For each blocklet an object of SegmentPropertiesAndSchemaHolder is created
to store the schema used
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2945#discussion_r236531750
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java ---
@@ -66,9 +63,6 @@
this.readers = readers
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2945#discussion_r235892400
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java ---
@@ -66,9 +63,6 @@
this.readers = readers
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2945#discussion_r235891858
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java ---
@@ -66,9 +63,6 @@
this.readers = readers
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2945
retest this please
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2945
[CARBONDATA-3123] Fixed JVM crash issue with CarbonRecordReader(SDK Reader).
**Problem:**
As CarbonReaderBuilder is executed on the main thread therefore while
Reader creation we
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2923#discussion_r235681603
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/standardpartition/StandardPartitionTableQueryTestCase.scala
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2929
LGTM
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2929
@xubo245 Please resolve the conflicts
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2935
LGTM
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2921
LGTM
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2923#discussion_r234966352
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/standardpartition/StandardPartitionTableQueryTestCase.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2925#discussion_r234962295
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/thriftserver/CarbonThriftServer.scala
---
@@ -48,8 +48,13 @@ object
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2925#discussion_r234962085
--- Diff: integration/spark2/pom.xml ---
@@ -134,6 +134,11 @@
+
--- End diff --
But nobody
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2921#discussion_r234860057
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonDropTableCommand.scala
---
@@ -143,7 +143,6 @@ case
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2921
retest this please
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2924
LGTM
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2925#discussion_r234191527
--- Diff: integration/spark2/pom.xml ---
@@ -134,6 +134,11 @@
+
--- End diff --
Why
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2925#discussion_r234191597
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/thriftserver/CarbonThriftServer.scala
---
@@ -48,8 +48,13 @@ object
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2925
@xubo245 I what scenario are you facing this issue? I am not facing this
issue.
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2921
retest this please
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2923
@ravipesala @manishgupta88 Please review
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2925
Please add description
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2922
retest this please
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2924#discussion_r234093857
--- Diff:
integration/spark-datasource/src/test/scala/org/apache/spark/sql/carbondata/datasource/SparkCarbonDataSourceTest.scala
---
@@ -1345,6
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2922
@jackylk No this is for ArrayIndexOutOfBoundsException when taking lock on
S3. 3103 seems to be a different issue.
---
Github user kunal642 closed the pull request at:
https://github.com/apache/carbondata/pull/2902
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2923
retest this please
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2923
[WIP] added partition columns to the last when collecting columns
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2903
LGTM
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2903
LGTM
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2903#discussion_r231038773
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/DefaultEncodingFactory.java
---
@@ -325,32 +325,42 @@ static
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2901
retest this please
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2902
[WIP] Fixed data mismatch issue after update
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2901#discussion_r231001835
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/util/CarbonVectorizedRecordReader.java
---
@@ -171,13 +171,20 @@ public Object
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2901#discussion_r231001760
--- Diff:
store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java ---
@@ -1844,4 +1844,53 @@ public void testVectorReader
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2901
retest this please
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2901
[CARBONDATA-3081] Fixed NPE for boolean type column with null value
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2850
LGTM
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2877
LGTM
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2850#discussion_r230315785
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java ---
@@ -114,6 +115,57 @@ public static CarbonReaderBuilder builder
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2869#discussion_r230305381
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java
---
@@ -158,14 +173,31 @@ public CarbonReaderBuilder
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2869#discussion_r230277096
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonFileInputFormat.java
---
@@ -88,6 +99,50 @@ public CarbonTable
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2869#discussion_r230277015
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/compress/DirectCompressCodec.java
---
@@ -347,9 +347,7 @@ private
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2869#discussion_r230277069
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonFileInputFormat.java
---
@@ -88,6 +99,50 @@ public CarbonTable
1 - 100 of 728 matches
Mail list logo
