Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2623#discussion_r212869553
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataPageSourceProvider.java
---
@@ -79,6 +80,7 @@
@Override
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2623
@ravipesala fixed the comments
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2623
@ravipesala Please review.
---
Github user kunal642 closed the pull request at:
https://github.com/apache/carbondata/pull/2655
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2655
[WIP][TEST] sk ak test
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2643
LGTM
---
Github user kunal642 closed the pull request at:
https://github.com/apache/carbondata/pull/2381
---
Github user kunal642 closed the pull request at:
https://github.com/apache/carbondata/pull/2484
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2623#discussion_r208935162
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonConfiguration.java ---
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2623
retest this please
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2623
Retest this please
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2623
[HOTFIX] add sk ak to file factory on creation of carbon env
add SK AK to file factory on creation of carbon env
Be sure to do all of the following checklist to help us incorporate
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2612
[CARBONDATA-2834] Remove unnecessary nested looping over
loadMetadatadetails.
removed nested for loop which causes query performance degradation ifâ¦
Be sure to do all
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2603
LGTM
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2576#discussion_r207250192
--- Diff: docs/s3-guide.md ---
@@ -0,0 +1,64 @@
+
+
+#S3 Guide (Alpha Feature 1.4.1)
+S3 is an Object Storage API on cloud
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2576#discussion_r207250096
--- Diff: docs/configuration-parameters.md ---
@@ -106,7 +106,10 @@ This section provides the details of all the
configurations required for CarbonD
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2576#discussion_r207250066
--- Diff: docs/configuration-parameters.md ---
@@ -106,7 +106,10 @@ This section provides the details of all the
configurations required for CarbonD
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2576#discussion_r207249973
--- Diff: docs/data-management-on-carbondata.md ---
@@ -730,6 +736,8 @@ Users can specify which columns to include and exclude
for local dictionary
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2576#discussion_r207249849
--- Diff: docs/datamap/preaggregate-datamap-guide.md ---
@@ -7,6 +24,7 @@
* [Querying Data](#querying-data)
* [Compaction](#compacting-pre
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2576#discussion_r207249941
--- Diff: docs/s3-guide.md ---
@@ -0,0 +1,63 @@
+
+
+#S3 Guide (Alpha Feature 1.4.1)
+Amazon S3 is a cloud storage service
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2576#discussion_r207249910
--- Diff: docs/s3-guide.md ---
@@ -0,0 +1,63 @@
+
+
+#S3 Guide (Alpha Feature 1.4.1)
+Amazon S3 is a cloud storage service
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2576#discussion_r207249485
--- Diff: docs/configuration-parameters.md ---
@@ -106,7 +106,12 @@ This section provides the details of all the
configurations required for CarbonD
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2599
LGTM
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2571
LGTM
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2600
retest this please
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2576
retest this please
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2600
[CARBONDATA-2813] Fixed code to get data size from LoadDetails if size is
written there.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2578
LGTM
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2578#discussion_r206531160
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestNonTransactionalCarbonTable.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2571#discussion_r206480372
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/util/CarbonSparkUtil.scala
---
@@ -87,18 +88,20 @@ object CarbonSparkUtil
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2578#discussion_r206396378
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/model/LoadOption.java
---
@@ -236,7 +236,7
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2576
@sraghunandan @sgururajshetty @chenliang613 Please review
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2578
Please add a test case to verify the fix
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2578#discussion_r206091924
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/datatypes/ArrayDataType.java
---
@@ -172,7 +191,7 @@ public void
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2517
LGTM. The failures in 2.2.1 build are note related to this PR. Those are
failing on master as well. Need to fix.
---
Github user kunal642 closed the pull request at:
https://github.com/apache/carbondata/pull/2563
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2576
[CARBONDATA-2795] disable preagg datamap on dataload for s3 store
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2575
@rahulforallp Please fix the build.
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2562
LGTM
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2552
@praveenmeenakshi56 Please add detailed description stating the issue and
the solution(Why specific handling for preagg and timeseries is required).
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2553
@mohammadshahidkhan Please add description
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2563
retest this please
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2563
retest this please
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2563
WIP test
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2549
@dhatchayani Please rebase
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2535
LGTM
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2535#discussion_r204983701
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
@@ -77,6 +77,7
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2514
LGTM
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2548
[CARBONDATA-2778]Fixed bug when select after delete and cleanup is showing
empty records
Problem: In case if delete operation when it is found that the data being
deleted is leading
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2484
retest this please
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2535#discussion_r204642515
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/complexType/TestComplexDataType.scala
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2511
@gvramana Build passed. Please review
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2535#discussion_r204296432
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/complexType/TestComplexDataType.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2535#discussion_r204296035
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
---
@@ -578,13 +578,19 @@ object
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2535#discussion_r204296013
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
@@ -823,15 +824,21
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2511
retest this please
---
Github user kunal642 closed the pull request at:
https://github.com/apache/carbondata/pull/2536
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2536
@xuchuanyin Closing this PR. Refer #2465
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2484
retest this please
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2536
[CARBONDATA-2766] Added null check on filestatus
**Problem:** While doing any operation on Carbon File if file status
acquiring throws exception then it is logged and not thrown again
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2525
[CARBONDATA-2756] refactored code to use ZSTD compression using Reflection
1. refactored code to use ZSTD compression using Reflection
2. add license
Be sure to do all
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2484
retest this please
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2484#discussion_r203263551
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java
---
@@ -43,11 +45,19 @@
*/
private static
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2484#discussion_r203263435
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonRDD.scala
---
@@ -79,14 +66,11 @@ abstract class CarbonRDD[T
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2502
LGTM
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2501
LGTM
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2484#discussion_r203071359
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonConfiguration.java ---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2448
LGTM
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2501#discussion_r202903937
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/mutation/CarbonProjectForUpdateCommand.scala
---
@@ -59,6 +60,13
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2501#discussion_r202903870
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAlterTableCompactionCommand.scala
---
@@ -82,6
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2501#discussion_r202904039
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala
---
@@ -354,7 +354,13
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2501#discussion_r202904751
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/complexType/TestComplexDataType.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2501#discussion_r202904600
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/complexType/TestComplexDataType.scala
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2511
[CARBONDATA-2745] Added atomic file operations for S3
Problem: AtomicFileOperationImpl creates a temporary file and then renames
the file to actual file name. This is risky in S3 storage
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2484#discussion_r202586005
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java
---
@@ -43,11 +45,19 @@
*/
private static
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2484#discussion_r202585892
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java
---
@@ -43,11 +45,19 @@
*/
private static
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2484#discussion_r202585994
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonConfiguration.java ---
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2484#discussion_r202585871
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/rdd/UpdateCoalescedRDD.scala
---
@@ -0,0 +1,89 @@
+/*
+ * Licensed
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2489
LGTM
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2489
LGTM
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2489#discussion_r202076454
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java
---
@@ -140,6 +140,13 @@ public
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2484
[WIP] added hadoop conf to thread local
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2472
[CARBONDATA-2717] fixed table id empty problem while taking drop lock
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2451
LGTM
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2447
LGTM
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2465
retest sdv please
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2465
[WIP] Refactored CarbonFile interface
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2451#discussion_r200894716
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala
---
@@ -136,14 +136,33
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2451#discussion_r200894679
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala
---
@@ -136,14 +136,33
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2450
LGTM
---
Github user kunal642 closed the pull request at:
https://github.com/apache/carbondata/pull/2406
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2450#discussion_r200610555
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/localdictionary/LocalDictionarySupportAlterTableTest.scala
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2422
LGTM
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2406#discussion_r200554082
--- Diff:
processing/src/test/java/org/apache/carbondata/lcm/locks/LocalFileLockTest.java
---
@@ -68,4 +80,18 @@
Assert.assertTrue
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2406#discussion_r200554062
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonFileMetastore.scala
---
@@ -386,7 +386,8 @@ class CarbonFileMetastore
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2406#discussion_r200554022
--- Diff:
core/src/main/java/org/apache/carbondata/core/locks/CarbonLockFactory.java ---
@@ -105,4 +120,10 @@ private static void
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2406#discussion_r200554007
--- Diff:
core/src/main/java/org/apache/carbondata/core/locks/CarbonLockFactory.java ---
@@ -52,44 +55,56 @@
*/
public static
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2406#discussion_r200553901
--- Diff:
core/src/main/java/org/apache/carbondata/core/locks/CarbonLockFactory.java ---
@@ -52,44 +55,56 @@
*/
public static
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2406#discussion_r200553686
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/S3CarbonFile.java
---
@@ -0,0 +1,136 @@
+/*
+ * Licensed
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2406#discussion_r200553521
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/S3CarbonFile.java
---
@@ -0,0 +1,136 @@
+/*
+ * Licensed
201 - 300 of 728 matches
Mail list logo
