akashrn5 commented on a change in pull request #3619: [HOTFIX] Remove unused
fields in TableInfo
URL: https://github.com/apache/carbondata/pull/3619#discussion_r379276591
##########
File path:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonDropTableCommand.scala
##########
@@ -110,28 +97,6 @@ case class CarbonDropTableCommand(
CarbonEnv.getInstance(sparkSession).carbonMetaStore.dropTable(identifier)(sparkSession)
- if (carbonTable.hasDataMapSchema) {
- // drop all child tables
- val childSchemas = carbonTable.getTableInfo.getDataMapSchemaList
-
- childDropCommands = childSchemas.asScala
- .filter(_.getRelationIdentifier != null)
- .map { childSchema =>
- val childTable =
- CarbonEnv.getCarbonTable(
- TableIdentifier(childSchema.getRelationIdentifier.getTableName,
-
Some(childSchema.getRelationIdentifier.getDatabaseName)))(sparkSession)
- val dropCommand = CarbonDropTableCommand(
- ifExistsSet = true,
- Some(childSchema.getRelationIdentifier.getDatabaseName),
- childSchema.getRelationIdentifier.getTableName,
- dropChildTable = true
- )
- dropCommand.carbonTable = childTable
- dropCommand
- }
- childDropCommands.foreach(_.processMetadata(sparkSession))
- }
val indexDatamapSchemas =
Review comment:
can you please rename this to just `datamapSchemas` because it will have MV
schemas also, so indexDataMapaSchemas will give wrong meaning
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
