[GitHub] [carbondata] kumarvishal09 commented on issue #3182: [CARBONDATA-3343] Compaction for Range Sort

2019-05-07 Thread GitBox
kumarvishal09 commented on issue #3182: [CARBONDATA-3343] Compaction for Range Sort URL: https://github.com/apache/carbondata/pull/3182#issuecomment-490080076 LGTM This is an automated message from the Apache Git Service. To

[GitHub] [carbondata] kumarvishal09 commented on issue #3182: [CARBONDATA-3343] Compaction for Range Sort

2019-05-07 Thread GitBox
kumarvishal09 commented on issue #3182: [CARBONDATA-3343] Compaction for Range Sort URL: https://github.com/apache/carbondata/pull/3182#issuecomment-490034083 LGTM except few formatting issue. @manishnalla1994 Some formatting is not correct + add some comments for specific code added

[GitHub] [carbondata] kumarvishal09 commented on issue #3182: [CARBONDATA-3343] Compaction for Range Sort

2019-04-24 Thread GitBox
kumarvishal09 commented on issue #3182: [CARBONDATA-3343] Compaction for Range Sort URL: https://github.com/apache/carbondata/pull/3182#issuecomment-486327882 @manishnalla1994 After firing the query to get the range we need to clear the data map for those segments as when lru cache is not