[GitHub] carbondata issue #2334: [CARBONDATA-2515][CARBONDATA-2516] fixed Timestamp g...

2018-06-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2334 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5358/ ---

[GitHub] carbondata issue #2334: [CARBONDATA-2515][CARBONDATA-2516] fixed Timestamp g...

2018-06-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2334 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6526/ ---

[GitHub] carbondata issue #2334: [CARBONDATA-2515][CARBONDATA-2516] fixed Timestamp g...

2018-06-23 Thread sv71294
Github user sv71294 commented on the issue: https://github.com/apache/carbondata/pull/2334 @chenliang613 please check this image, condition logic was missing

[GitHub] carbondata issue #2334: [CARBONDATA-2515][CARBONDATA-2516] fixed Timestamp g...

2018-06-23 Thread sv71294
Github user sv71294 commented on the issue: https://github.com/apache/carbondata/pull/2334 @chenliang613 issue is not about the result, in current master filter is getting handled by presto as it is not generated on connector layer, now with this PR it will be generated at connector

[GitHub] carbondata issue #2334: [CARBONDATA-2515][CARBONDATA-2516] fixed Timestamp g...

2018-06-23 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/2334 @sv71294 i can also run successfully at current master with the below test case, so not sure this test case can cover this issue which be fixed in the PR. ``` test("test the

[GitHub] carbondata issue #2334: [CARBONDATA-2515][CARBONDATA-2516] fixed Timestamp g...

2018-06-22 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2334 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5392/ ---

[GitHub] carbondata issue #2334: [CARBONDATA-2515][CARBONDATA-2516] fixed Timestamp g...

2018-06-22 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2334 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5303/ ---

[GitHub] carbondata issue #2334: [CARBONDATA-2515][CARBONDATA-2516] fixed Timestamp g...

2018-06-22 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2334 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5391/ ---

[GitHub] carbondata issue #2334: [CARBONDATA-2515][CARBONDATA-2516] fixed Timestamp g...

2018-06-22 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2334 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6472/ ---

[GitHub] carbondata issue #2334: [CARBONDATA-2515][CARBONDATA-2516] fixed Timestamp g...

2018-06-22 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2334 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5300/ ---

[GitHub] carbondata issue #2334: [CARBONDATA-2515][CARBONDATA-2516] fixed Timestamp g...

2018-06-22 Thread sv71294
Github user sv71294 commented on the issue: https://github.com/apache/carbondata/pull/2334 Retest this please ---

[GitHub] carbondata issue #2334: [CARBONDATA-2515][CARBONDATA-2516] fixed Timestamp g...

2018-06-22 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2334 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6469/ ---

[GitHub] carbondata issue #2334: [CARBONDATA-2515][CARBONDATA-2516] fixed Timestamp g...

2018-06-22 Thread sv71294
Github user sv71294 commented on the issue: https://github.com/apache/carbondata/pull/2334 @chenliang613 I have added the required test case for greater than expresion, please check it now ---

[GitHub] carbondata issue #2334: [CARBONDATA-2515][CARBONDATA-2516] fixed Timestamp g...

2018-06-22 Thread sv71294
Github user sv71294 commented on the issue: https://github.com/apache/carbondata/pull/2334 @chenliang613 adding the test case to cover timestamp greater than expression issue ---

[GitHub] carbondata issue #2334: [CARBONDATA-2515][CARBONDATA-2516] fixed Timestamp g...

2018-06-22 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/2334 For "[CARBONDATA-2515] OR filter Expression issue" , verified. ``` presto:default> select * from carbon_table where ID='No.11' and country='country0' and population > 100 or

[GitHub] carbondata issue #2334: [CARBONDATA-2515][CARBONDATA-2516] fixed Timestamp g...

2018-06-22 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/2334 @sv71294 thank you for your contribution. In this pr, i didn't find the test case to cover "Timestamp greaterthan expression" ---

[GitHub] carbondata issue #2334: [CARBONDATA-2515][CARBONDATA-2516] fixed Timestamp g...

2018-06-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2334 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5286/ ---

[GitHub] carbondata issue #2334: [CARBONDATA-2515][CARBONDATA-2516] fixed Timestamp g...

2018-06-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2334 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6455/ ---

[GitHub] carbondata issue #2334: [CARBONDATA-2515][CARBONDATA-2516] fixed Timestamp g...

2018-06-21 Thread sv71294
Github user sv71294 commented on the issue: https://github.com/apache/carbondata/pull/2334 retest this please ---

[GitHub] carbondata issue #2334: [CARBONDATA-2515][CARBONDATA-2516] fixed Timestamp g...

2018-06-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2334 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5282/ ---

[GitHub] carbondata issue #2334: [CARBONDATA-2515][CARBONDATA-2516] fixed Timestamp g...

2018-06-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2334 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6451/ ---

[GitHub] carbondata issue #2334: [CARBONDATA-2515][CARBONDATA-2516] fixed Timestamp g...

2018-06-21 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/2334 retest this please ---

[GitHub] carbondata issue #2334: [CARBONDATA-2515][CARBONDATA-2516] fixed Timestamp g...

2018-06-21 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/2334 add to whitelist ---

[GitHub] carbondata issue #2334: [CARBONDATA-2515][CARBONDATA-2516] fixed Timestamp g...

2018-05-28 Thread sv71294
Github user sv71294 commented on the issue: https://github.com/apache/carbondata/pull/2334 retest this please ---

[GitHub] carbondata issue #2334: [CARBONDATA-2515][CARBONDATA-2516] fixed Timestamp g...

2018-05-28 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2334 retest this please ---

[GitHub] carbondata issue #2334: [CARBONDATA-2515][CARBONDATA-2516] fixed Timestamp g...

2018-05-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2334 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6146/ ---

[GitHub] carbondata issue #2334: [CARBONDATA-2515][CARBONDATA-2516] fixed Timestamp g...

2018-05-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2334 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4983/ ---

[GitHub] carbondata issue #2334: [CARBONDATA-2515][CARBONDATA-2516] fixed Timestamp g...

2018-05-28 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/2334 retest this please ---

[GitHub] carbondata issue #2334: [CARBONDATA-2515][CARBONDATA-2516] fixed Timestamp g...

2018-05-28 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/2334 LGTM ---

[GitHub] carbondata issue #2334: [CARBONDATA-2515][CARBONDATA-2516] fixed Timestamp g...

2018-05-22 Thread sv71294
Github user sv71294 commented on the issue: https://github.com/apache/carbondata/pull/2334 Please review it now ---

[GitHub] carbondata issue #2334: [CARBONDATA-2515][CARBONDATA-2516] fixed Timestamp g...

2018-05-22 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2334 Please optimize the code style of this PR ---

[GitHub] carbondata issue #2334: [CARBONDATA-2515][CARBONDATA-2516] fixed Timestamp g...

2018-05-22 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2334 Can one of the admins verify this patch? ---