[GitHub] carbondata pull request #1065: [CARBONDATA-1196] Add 3 bytes data type suppo...

2017-06-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/1065 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] carbondata pull request #1065: [CARBONDATA-1196] Add 3 bytes data type suppo...

2017-06-22 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1065#discussion_r123543556 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/aggquery/IntegerDataTypeTestCase.scala ---

[GitHub] carbondata pull request #1065: [CARBONDATA-1196] Add 3 bytes data type suppo...

2017-06-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1065#discussion_r123231904 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/aggquery/IntegerDataTypeTestCase.scala --- @@

[GitHub] carbondata pull request #1065: [CARBONDATA-1196] Add 3 bytes data type suppo...

2017-06-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1065#discussion_r123231920 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/aggquery/IntegerDataTypeTestCase.scala --- @@

[GitHub] carbondata pull request #1065: [CARBONDATA-1196] Add 3 bytes data type suppo...

2017-06-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1065#discussion_r123231835 --- Diff: core/src/main/java/org/apache/carbondata/core/util/ByteUtil.java --- @@ -465,6 +465,39 @@ public static short toShort(byte[] bytes, int

[GitHub] carbondata pull request #1065: [CARBONDATA-1196] Add 3 bytes data type suppo...

2017-06-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1065#discussion_r123231879 --- Diff: core/src/main/java/org/apache/carbondata/core/util/ByteUtil.java --- @@ -465,6 +465,39 @@ public static short toShort(byte[] bytes, int

[GitHub] carbondata pull request #1065: [CARBONDATA-1196] Add 3 bytes data type suppo...

2017-06-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1065#discussion_r123231854 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/DefaultEncodingStrategy.java --- @@ -29,24 +29,31 @@

[GitHub] carbondata pull request #1065: [CARBONDATA-1196] Add 3 bytes data type suppo...

2017-06-21 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1065#discussion_r123183129 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/aggquery/IntegerDataTypeTestCase.scala ---

[GitHub] carbondata pull request #1065: [CARBONDATA-1196] Add 3 bytes data type suppo...

2017-06-21 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1065#discussion_r123177876 --- Diff: core/src/main/java/org/apache/carbondata/core/util/ByteUtil.java --- @@ -465,6 +465,39 @@ public static short toShort(byte[] bytes, int

[GitHub] carbondata pull request #1065: [CARBONDATA-1196] Add 3 bytes data type suppo...

2017-06-21 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1065#discussion_r123177702 --- Diff: core/src/main/java/org/apache/carbondata/core/util/ByteUtil.java --- @@ -465,6 +465,39 @@ public static short toShort(byte[] bytes, int

[GitHub] carbondata pull request #1065: [CARBONDATA-1196] Add 3 bytes data type suppo...

2017-06-21 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1065#discussion_r123176128 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/DefaultEncodingStrategy.java --- @@ -29,24 +29,31 @@

[GitHub] carbondata pull request #1065: [CARBONDATA-1196] Add 3 bytes data type suppo...

2017-06-21 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1065#discussion_r123176230 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/DefaultEncodingStrategy.java --- @@ -29,24 +29,31 @@

[GitHub] carbondata pull request #1065: [CARBONDATA-1196] Add 3 bytes data type suppo...

2017-06-21 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1065#discussion_r123169106 --- Diff: core/src/main/java/org/apache/carbondata/core/util/ByteUtil.java --- @@ -465,6 +465,39 @@ public static short toShort(byte[] bytes, int

[GitHub] carbondata pull request #1065: [CARBONDATA-1196] Add 3 bytes data type suppo...

2017-06-20 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1065#discussion_r123154384 --- Diff: core/src/main/java/org/apache/carbondata/core/util/ByteUtil.java --- @@ -465,6 +465,39 @@ public static short toShort(byte[] bytes, int

[GitHub] carbondata pull request #1065: [CARBONDATA-1196] Add 3 bytes data type suppo...

2017-06-20 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1065#discussion_r123148990 --- Diff: core/src/main/java/org/apache/carbondata/core/util/ByteUtil.java --- @@ -465,6 +465,39 @@ public static short toShort(byte[] bytes, int