[GitHub] carbondata pull request #1104: [CARBONDATA-1239] Add validation for set comm...

2018-02-02 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1104#discussion_r165763372 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java --- @@ -307,17 +307,11 @@ public static

[GitHub] carbondata pull request #1104: [CARBONDATA-1239] Add validation for set comm...

2018-02-01 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1104#discussion_r165571781 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java --- @@ -307,17 +307,11 @@ public static CarbonLoadModel

[GitHub] carbondata pull request #1104: [CARBONDATA-1239] Add validation for set comm...

2017-06-29 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1104#discussion_r124764409 --- Diff: core/src/main/java/org/apache/carbondata/core/util/SessionParams.java --- @@ -96,34 +96,37 @@ private boolean validateKeyValue(String key,

[GitHub] carbondata pull request #1104: [CARBONDATA-1239] Add validation for set comm...

2017-06-28 Thread mohammadshahidkhan
GitHub user mohammadshahidkhan opened a pull request: https://github.com/apache/carbondata/pull/1104 [CARBONDATA-1239] Add validation for set command parameters 1.Correct the validation message for carbon.options.bad.records.action param 2. Correct message for