[GitHub] carbondata pull request #1720: [CARBONDATA-1935]fix the backword compatibili...

2018-01-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/1720 ---

[GitHub] carbondata pull request #1720: [CARBONDATA-1935]fix the backword compatibili...

2017-12-22 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1720#discussion_r158516073 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/datatype/DataTypes.java --- @@ -184,4 +224,60 @@ public static boolean

[GitHub] carbondata pull request #1720: [CARBONDATA-1935]fix the backword compatibili...

2017-12-22 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1720#discussion_r158515927 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/datatype/DataTypes.java --- @@ -184,4 +224,60 @@ public static boolean

[GitHub] carbondata pull request #1720: [CARBONDATA-1935]fix the backword compatibili...

2017-12-22 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1720#discussion_r158515750 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/datatype/DataTypes.java --- @@ -184,4 +224,60 @@ public static boolean

[GitHub] carbondata pull request #1720: [CARBONDATA-1935]fix the backword compatibili...

2017-12-22 Thread akashrn5
Github user akashrn5 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1720#discussion_r158515688 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java --- @@ -1938,6 +1939,12 @@ public static TableInfo

[GitHub] carbondata pull request #1720: [CARBONDATA-1935]fix the backword compatibili...

2017-12-22 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1720#discussion_r158515043 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/datatype/DataTypes.java --- @@ -184,4 +224,60 @@ public static boolean

[GitHub] carbondata pull request #1720: [CARBONDATA-1935]fix the backword compatibili...

2017-12-22 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1720#discussion_r158515028 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/datatype/DataTypes.java --- @@ -184,4 +224,60 @@ public static boolean

[GitHub] carbondata pull request #1720: [CARBONDATA-1935]fix the backword compatibili...

2017-12-22 Thread akashrn5
Github user akashrn5 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1720#discussion_r158512806 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/datatype/DataTypes.java --- @@ -112,6 +118,40 @@ public static DataType valueOf(int

[GitHub] carbondata pull request #1720: [CARBONDATA-1935]fix the backword compatibili...

2017-12-22 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1720#discussion_r158512632 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/datatype/DataTypes.java --- @@ -184,4 +224,58 @@ public static boolean

[GitHub] carbondata pull request #1720: [CARBONDATA-1935]fix the backword compatibili...

2017-12-22 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1720#discussion_r158512534 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java --- @@ -1938,6 +1939,12 @@ public static TableInfo

[GitHub] carbondata pull request #1720: [CARBONDATA-1935]fix the backword compatibili...

2017-12-22 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1720#discussion_r158512233 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/datatype/DataTypes.java --- @@ -184,4 +224,58 @@ public static boolean

[GitHub] carbondata pull request #1720: [CARBONDATA-1935]fix the backword compatibili...

2017-12-22 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1720#discussion_r158511774 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/datatype/DataTypes.java --- @@ -112,6 +118,40 @@ public static DataType valueOf(int

[GitHub] carbondata pull request #1720: [CARBONDATA-1935]fix the backword compatibili...

2017-12-22 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1720#discussion_r158511675 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/datatype/DataTypes.java --- @@ -112,6 +118,40 @@ public static DataType valueOf(int

[GitHub] carbondata pull request #1720: [CARBONDATA-1935]fix the backword compatibili...

2017-12-22 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1720#discussion_r158511629 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/datatype/DataType.java --- @@ -31,7 +31,7 @@ // size of the value of this data

[GitHub] carbondata pull request #1720: [CARBONDATA-1935]fix the backword compatibili...

2017-12-22 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1720#discussion_r158511440 --- Diff: core/pom.xml --- @@ -94,6 +94,11 @@ + + com.google.code.gson --- End diff --