[GitHub] carbondata pull request #1888: [CARBONDATA-2101]Restrict direct query on pre...

2018-02-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/1888 ---

[GitHub] carbondata pull request #1888: [CARBONDATA-2101]Restrict direct query on pre...

2018-02-03 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1888#discussion_r165810948 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala --- @@ -599,6 +599,8 @@

[GitHub] carbondata pull request #1888: [CARBONDATA-2101]Restrict direct query on pre...

2018-02-03 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1888#discussion_r165810950 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonPreAggregateRules.scala --- @@ -259,6 +259,7 @@ case class

[GitHub] carbondata pull request #1888: [CARBONDATA-2101]Restrict direct query on pre...

2018-02-03 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1888#discussion_r165809447 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1590,6 +1590,16 @@

[GitHub] carbondata pull request #1888: [CARBONDATA-2101]Restrict direct query on pre...

2018-02-03 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1888#discussion_r165809409 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1585,6 +1585,16 @@ public static

[GitHub] carbondata pull request #1888: [CARBONDATA-2101]Restrict direct query on pre...

2018-02-03 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1888#discussion_r165809341 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/preaggregate/TestPreAggregateTableSelection.scala

[GitHub] carbondata pull request #1888: [CARBONDATA-2101]Restrict direct query on pre...

2018-02-03 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1888#discussion_r165809302 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonPreAggregateRules.scala --- @@ -259,6 +259,7 @@ case class

[GitHub] carbondata pull request #1888: [CARBONDATA-2101]Restrict direct query on pre...

2018-02-03 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1888#discussion_r165809300 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala --- @@ -599,6 +599,8 @@ object

[GitHub] carbondata pull request #1888: [CARBONDATA-2101]Restrict direct query on pre...

2018-02-03 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1888#discussion_r165809273 --- Diff: core/src/main/java/org/apache/carbondata/core/util/SessionParams.java --- @@ -199,6 +199,8 @@ private boolean validateKeyValue(String key,

[GitHub] carbondata pull request #1888: [CARBONDATA-2101]Restrict direct query on pre...

2018-02-03 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1888#discussion_r165809259 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/preaggregate/TestPreAggregateTableSelection.scala

[GitHub] carbondata pull request #1888: [CARBONDATA-2101]Restrict direct query on pre...

2018-01-31 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1888#discussion_r165013843 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1567,6 +1567,14 @@ public

[GitHub] carbondata pull request #1888: [CARBONDATA-2101]Restrict direct query on pre...

2018-01-30 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1888#discussion_r164933909 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/optimizer/CarbonLateDecodeRule.scala --- @@ -87,6 +88,39 @@ class

[GitHub] carbondata pull request #1888: [CARBONDATA-2101]Restrict direct query on pre...

2018-01-30 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1888#discussion_r164933498 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1567,6 +1567,14 @@ public static

[GitHub] carbondata pull request #1888: [CARBONDATA-2101]Restrict direct query on pre...

2018-01-30 Thread kumarvishal09
GitHub user kumarvishal09 opened a pull request: https://github.com/apache/carbondata/pull/1888 [CARBONDATA-2101]Restrict direct query on pre aggregate and timeseries datamap **Restricting direct query on PreAggregate and timeseries data map Added Property to run direct query