[GitHub] carbondata pull request #2299: [CARBONDATA-2472] Fixed:NonTransactional tabl...

2018-05-13 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2299#discussion_r187843922 --- Diff: core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java --- @@ -401,6 +401,11 @@ public static Object getDataDataTypeForNoDicti

[GitHub] carbondata pull request #2299: [CARBONDATA-2472] Fixed:NonTransactional tabl...

2018-05-13 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2299#discussion_r187842996 --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMapFactory.java --- @@ -115,13 +123,55 @@ public DataMapB

[GitHub] carbondata pull request #2299: [CARBONDATA-2472] Fixed:NonTransactional tabl...

2018-05-12 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2299#discussion_r187768276 --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMapFactory.java --- @@ -115,13 +123,55 @@ public DataMa

[GitHub] carbondata pull request #2299: [CARBONDATA-2472] Fixed:NonTransactional tabl...

2018-05-12 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2299#discussion_r187768333 --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMapFactory.java --- @@ -115,13 +123,55 @@ public DataMa

[GitHub] carbondata pull request #2299: [CARBONDATA-2472] Fixed:NonTransactional tabl...

2018-05-12 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2299#discussion_r187768121 --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/DataMapStoreManager.java --- @@ -297,7 +297,7 @@ public TableDataMap registerDataMap

[GitHub] carbondata pull request #2299: [CARBONDATA-2472] Fixed:NonTransactional tabl...

2018-05-12 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2299#discussion_r187768312 --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMapFactory.java --- @@ -115,13 +123,55 @@ public DataMa

[GitHub] carbondata pull request #2299: [CARBONDATA-2472] Fixed:NonTransactional tabl...

2018-05-11 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2299#discussion_r187762940 --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/DataMapStoreManager.java --- @@ -297,7 +297,7 @@ public TableDataMap registerDataMap(Ca

[GitHub] carbondata pull request #2299: [CARBONDATA-2472] Fixed:NonTransactional tabl...

2018-05-11 Thread ajantha-bhat
GitHub user ajantha-bhat opened a pull request: https://github.com/apache/carbondata/pull/2299 [CARBONDATA-2472] Fixed:NonTransactional table performance degarde issue induced by PR #2273 Be sure to do all of the following checklist to help us incorporate your co