[GitHub] carbondata pull request #2914: [CARBONDATA-3093] Provide property builder fo...

2018-12-13 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2914#discussion_r241631889 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -40,1372 +41,1024 @@ private

[GitHub] carbondata pull request #2914: [CARBONDATA-3093] Provide property builder fo...

2018-12-13 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2914#discussion_r241631816 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -40,1372 +41,1024 @@ private

[GitHub] carbondata pull request #2914: [CARBONDATA-3093] Provide property builder fo...

2018-12-12 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2914#discussion_r241285417 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -40,1372 +41,1024 @@ private

[GitHub] carbondata pull request #2914: [CARBONDATA-3093] Provide property builder fo...

2018-12-12 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2914#discussion_r241285278 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -40,1372 +41,1024 @@ private

[GitHub] carbondata pull request #2914: [CARBONDATA-3093] Provide property builder fo...

2018-12-12 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2914#discussion_r241285056 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -40,1372 +41,1024 @@ private