Github user WangQingNa closed the pull request at:
https://github.com/apache/carbondata/pull/3040
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3040#discussion_r244592133
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/converter/impl/NonDictionaryFieldConverterImpl.java
---
@@ -34,21 +34,21
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3040#discussion_r244592098
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/datatypes/GenericDataType.java
---
@@ -43,7 +43,7 @@
/**
* @return
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3040#discussion_r244592034
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/datatypes/ArrayDataType.java
---
@@ -55,7 +55,7 @@
/**
* parent
GitHub user WangQingNa opened a pull request:
https://github.com/apache/carbondata/pull/3040
There are some spell error in CarbonData:
parentname => parentName
nullformat => nullFormat
Be sure to do all of the following checklist to help us incorporate
your
