[GitHub] carbondata issue #2816: [CARBONDATA-3003] Suppor read batch row in CSDK
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2816 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1478/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1264/ ---
[jira] [Created] (CARBONDATA-3073) Support configure TableProperties in carbon writer of C++ SDK
xubo245 created CARBONDATA-3073: --- Summary: Support configure TableProperties in carbon writer of C++ SDK Key: CARBONDATA-3073 URL: https://issues.apache.org/jira/browse/CARBONDATA-3073 Project: CarbonData Issue Type: Sub-task Affects Versions: 1.5.1 Reporter: xubo245 Assignee: xubo245 Fix For: 1.5.1 when user create table and write data in C++ SDK, user sometimes need configure withTableProperties, so we should Support configure TableProperties in carbon writer of C++ SDK -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] carbondata issue #2816: [CARBONDATA-3003] Suppor read batch row in CSDK
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2816 retest this please ---
[jira] [Created] (CARBONDATA-3074) Change default sort temp compressor to SNAPPY
jiangmanhua created CARBONDATA-3074: --- Summary: Change default sort temp compressor to SNAPPY Key: CARBONDATA-3074 URL: https://issues.apache.org/jira/browse/CARBONDATA-3074 Project: CarbonData Issue Type: Improvement Reporter: jiangmanhua Assignee: jiangmanhua -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] carbondata issue #2886: [CARBONDATA-3065]make inverted index false by defaul...
Github user akashrn5 commented on the issue: https://github.com/apache/carbondata/pull/2886 @ravipesala in existing flow, all the sort columns and dimensions will have inverted index and, in current implementation, if measure columns are given in inverted_index property, then i ll not set it as inverted index. Basically i wont throw any exception. Do we need to throw exception? and currently im allowing the inverted index for all dimension columns and not restricting to sort columns only. So basically, user can mention columns in inverted_index columns (dimensions), i am setting those as inverted index. it is correct right ---
[GitHub] carbondata issue #2885: [CARBONDATA-3064] Support separate audit log
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2885 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1265/ ---
[GitHub] carbondata issue #2885: [CARBONDATA-3064] Support separate audit log
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2885 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9529/ ---
[GitHub] carbondata issue #2885: [CARBONDATA-3064] Support separate audit log
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2885 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1480/ ---
[GitHub] carbondata issue #2816: [CARBONDATA-3003] Suppor read batch row in CSDK
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2816 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1267/ ---
[GitHub] carbondata pull request #2886: [CARBONDATA-3065]make inverted index false by...
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2886#discussion_r230684559
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/dataload/TestNoInvertedIndexLoadAndQuery.scala
---
@@ -289,6 +292,44 @@ class TestNoInvertedIndexLoadAndQuery extends
QueryTest with BeforeAndAfterAll {
checkAnswer(sql("""select c2 from testNull where c2 is null"""),
Seq(Row(null), Row(null), Row(null), Row(null), Row(null), Row(null)))
}
+ test("inverted index with Dictionary_EXCLUDE and INVERTED_INDEX") {
+sql("drop table if exists index1")
+sql(
+ """
+ CREATE TABLE IF NOT EXISTS index1
+ (id Int, name String, city String)
+ STORED BY 'org.apache.carbondata.format'
+
TBLPROPERTIES('DICTIONARY_EXCLUDE'='city','INVERTED_INDEX'='city')
+ """)
+sql(
+ s"""
+ LOAD DATA LOCAL INPATH '$testData1' into table index1
+ """)
+checkAnswer(
+ sql(
+"""
+ SELECT * FROM index1 WHERE city = "Bangalore"
+"""),
+ Seq(Row(19.0, "Emily", "Bangalore")))
--- End diff --
done
---
[GitHub] carbondata issue #2863: [WIP] Optimise decompressing while filling the vecto...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2863 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1266/ ---
[GitHub] carbondata issue #2816: [CARBONDATA-3003] Suppor read batch row in CSDK
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2816 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9527/ ---
[GitHub] carbondata pull request #2894: [CARBONDATA-3074] Change default sort temp co...
GitHub user kevinjmh opened a pull request: https://github.com/apache/carbondata/pull/2894 [CARBONDATA-3074] Change default sort temp compressor to SNAPPY Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kevinjmh/carbondata sorttempDefault Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/2894.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2894 commit 7877c797230b58fd4c51ffa21a026bc13493ac1f Author: Manhua Date: 2018-11-05T09:28:07Z change default sort temp compressor from empty to snappy ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1479/ ---
[GitHub] carbondata issue #2886: [CARBONDATA-3065]make inverted index false by defaul...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2886 ok, its fine ---
[GitHub] carbondata issue #2894: [CARBONDATA-3074] Change default sort temp compresso...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2894 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1268/ ---
[GitHub] carbondata pull request #2895: [HOTFIX] Fix NPE in spark, when same vector r...
GitHub user ajantha-bhat opened a pull request: https://github.com/apache/carbondata/pull/2895 [HOTFIX] Fix NPE in spark, when same vector reads files with local dictionary and without local dictionary problem: NPE in spark, when same vector reads files with local dictionary and without local dictionary cause: when two carbondata files are present, one with local dictionary and one without local dictionary. If same vector is used to read this files [can happen if task is launched to group of files]. If local dictionary files are found first, dictionary is set for that vector. But it was never reset for another file reading. solution: reset dictionary once batch is processed,set only for local dictionary batch processing. Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? NA - [ ] Any backward compatibility impacted? NA - [ ] Document update required? NA - [ ] Testing done yes, cluster testing done. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. NA You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajantha-bhat/carbondata master_new Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/2895.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2895 commit 99c7621336e3cf180bfa0c3a326a2f1fafe51631 Author: ajantha-bhat Date: 2018-11-05T10:00:27Z Fix vectcor reading with local dictionary and without local dictionary ---
[GitHub] carbondata issue #2886: [CARBONDATA-3065]make inverted index false by defaul...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2886 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9533/ ---
[GitHub] carbondata issue #2886: [CARBONDATA-3065]make inverted index false by defaul...
Github user akashrn5 commented on the issue: https://github.com/apache/carbondata/pull/2886 2.2.1 and 2.3.1 failed test cases, which are not related and these are random ---
[GitHub] carbondata issue #2886: [CARBONDATA-3065]make inverted index false by defaul...
Github user akashrn5 commented on the issue: https://github.com/apache/carbondata/pull/2886 retest this please ---
[GitHub] carbondata pull request #2898: [WIP] Fixed query failure in fileformat due s...
GitHub user manishgupta88 opened a pull request: https://github.com/apache/carbondata/pull/2898 [WIP] Fixed query failure in fileformat due stale cache issue **Problem** While using FileFormat API, if a table created, dropped and then recreated with the same name the query fails because of schema mismatch issue **Analysis** In case of carbondata used through FileFormat API, once a table is dropped and recreated with the same name again then because the dataMap contains the stale carbon table schema mismatch exception is thrown **Solution** To avoid such scenarios it is always better to update the carbon table object retrieved - [ ] Any interfaces changed? No - [ ] Any backward compatibility impacted? No - [ ] Document update required? No - [ ] Testing done Added UT to verify the scenario - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. NA You can merge this pull request into a Git repository by running: $ git pull https://github.com/manishgupta88/carbondata stale_carbon_table Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/2898.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2898 commit 2b6789ee5464f90f43ecac3654e58424257eaa29 Author: m00258959 Date: 2018-11-05T10:15:46Z Fixed select query failure due to stale carbonTable in dataMapFactory class ---
[jira] [Created] (CARBONDATA-3078) Exception caused by explain command for count star query without filter
jiangmanhua created CARBONDATA-3078: --- Summary: Exception caused by explain command for count star query without filter Key: CARBONDATA-3078 URL: https://issues.apache.org/jira/browse/CARBONDATA-3078 Project: CarbonData Issue Type: Bug Reporter: jiangmanhua Procedure to reproduce the problem: - create table test_tbl; - load some data into table; - run query as "explain select count(*) from test_tbl" ``` Exception in thread "main" java.lang.IllegalStateException at org.apache.carbondata.core.profiler.ExplainCollector.getCurrentTablePruningInfo(ExplainCollector.java:162) at org.apache.carbondata.core.profiler.ExplainCollector.setShowPruningInfo(ExplainCollector.java:106) at org.apache.carbondata.core.indexstore.blockletindex.BlockDataMap.prune(BlockDataMap.java:696) at org.apache.carbondata.core.indexstore.blockletindex.BlockDataMap.prune(BlockDataMap.java:743) at org.apache.carbondata.core.indexstore.blockletindex.BlockletDataMapFactory.getAllBlocklets(BlockletDataMapFactory.java:391) at org.apache.carbondata.core.datamap.TableDataMap.prune(TableDataMap.java:132) at org.apache.carbondata.hadoop.api.CarbonTableInputFormat.getBlockRowCount(CarbonTableInputFormat.java:618) at org.apache.spark.sql.CarbonCountStar.doExecute(CarbonCountStar.scala:59) at org.apache.spark.sql.execution.SparkPlan$$anonfun$execute$1.apply(SparkPlan.scala:117) at org.apache.spark.sql.execution.SparkPlan$$anonfun$execute$1.apply(SparkPlan.scala:117) at org.apache.spark.sql.execution.SparkPlan$$anonfun$executeQuery$1.apply(SparkPlan.scala:138) at org.apache.spark.rdd.RDDOperationScope$.withScope(RDDOperationScope.scala:151) at org.apache.spark.sql.execution.SparkPlan.executeQuery(SparkPlan.scala:135) at org.apache.spark.sql.execution.SparkPlan.execute(SparkPlan.scala:116) at org.apache.spark.sql.execution.QueryExecution.toRdd$lzycompute(QueryExecution.scala:92) at org.apache.spark.sql.execution.QueryExecution.toRdd(QueryExecution.scala:92) at org.apache.spark.sql.execution.command.table.CarbonExplainCommand.collectProfiler(CarbonExplainCommand.scala:54) at org.apache.spark.sql.execution.command.table.CarbonExplainCommand.processMetadata(CarbonExplainCommand.scala:45) at org.apache.spark.sql.execution.command.MetadataCommand.run(package.scala:68) at org.apache.spark.sql.execution.command.ExecutedCommandExec.sideEffectResult$lzycompute(commands.scala:58) at org.apache.spark.sql.execution.command.ExecutedCommandExec.sideEffectResult(commands.scala:56) at org.apache.spark.sql.execution.command.ExecutedCommandExec.executeCollect(commands.scala:67) at org.apache.spark.sql.Dataset.(Dataset.scala:183) at org.apache.spark.sql.CarbonSession$$anonfun$sql$1.apply(CarbonSession.scala:106) at org.apache.spark.sql.CarbonSession$$anonfun$sql$1.apply(CarbonSession.scala:95) at org.apache.spark.sql.CarbonSession.withProfiler(CarbonSession.scala:154) at org.apache.spark.sql.CarbonSession.sql(CarbonSession.scala:93) at org.apache.carbondata.examples.SQL_Prune$.main(Test.scala:101) at org.apache.carbondata.examples.SQL_Prune.main(Test.scala) Process finished with exit code 1 ``` -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] carbondata issue #2896: [WIP] Select Filter fails for Legacy store if Direct...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2896 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1486/ ---
[GitHub] carbondata issue #2896: [CARBONDATA-3075] Select Filter fails for Legacy sto...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2896 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9535/ ---
[GitHub] carbondata issue #2897: [WIP] Supporting local dictionary enable by default ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2897 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1274/ ---
[GitHub] carbondata issue #2886: [CARBONDATA-3065]make inverted index false by defaul...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2886 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1269/ ---
[GitHub] carbondata issue #2895: [HOTFIX] Fix NPE in spark, when same vector reads fi...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2895 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1270/ ---
[GitHub] carbondata issue #2894: [CARBONDATA-3074] Change default sort temp compresso...
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2894 please add description in the PR ``` Some experiments in local cluster shows that setting the compressor âsnappyâ will slightly enhance the loading performance and reduce lots of disk IO during data loading. ``` ---
[GitHub] carbondata issue #2875: [CARBONDATA-3038] Refactor dynamic configuration
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2875 @jackylk CI pass, please check it. ---
[jira] [Created] (CARBONDATA-3076) Set streaming=false not working for streaming table.
Pawan Malwal created CARBONDATA-3076:
Summary: Set streaming=false not working for streaming table.
Key: CARBONDATA-3076
URL: https://issues.apache.org/jira/browse/CARBONDATA-3076
Project: CarbonData
Issue Type: Bug
Components: data-query
Affects Versions: 1.5.1
Reporter: Pawan Malwal
Create streaming table.
CREATE TABLE table_st(CUST_ID String,CUST_NAME String) STORED BY
'org.apache.carbondata.format' TBLPROPERTIES('streaming'='true');
Alter table
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] carbondata issue #2894: [CARBONDATA-3074] Change default sort temp compresso...
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2894 LGTM waiting for the build ---
[GitHub] carbondata issue #2896: [WIP] Select Filter fails for Legacy store if Direct...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2896 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1272/ ---
[GitHub] carbondata issue #2895: [HOTFIX] Fix NPE in spark, when same vector reads fi...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2895 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9534/ ---
[GitHub] carbondata issue #2895: [HOTFIX] Fix NPE in spark, when same vector reads fi...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2895 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1485/ ---
[GitHub] carbondata issue #2816: [CARBONDATA-3003] Suppor read batch row in CSDK
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2816 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1273/ ---
[jira] [Updated] (CARBONDATA-3077) Fixed query failure in fileformat due stale cache issue
[ https://issues.apache.org/jira/browse/CARBONDATA-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Gupta updated CARBONDATA-3077: - Attachment: 20181102101536.jpg > Fixed query failure in fileformat due stale cache issue > --- > > Key: CARBONDATA-3077 > URL: https://issues.apache.org/jira/browse/CARBONDATA-3077 > Project: CarbonData > Issue Type: Bug >Reporter: Manish Gupta >Assignee: Manish Gupta >Priority: Major > Attachments: 20181102101536.jpg > > > *Problem* > While using FileFormat API, if a table created, dropped and then recreated > with the same name the query fails because of schema mismatch issue -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] carbondata issue #2894: [CARBONDATA-3074] Change default sort temp compresso...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2894 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9536/ ---
[GitHub] carbondata issue #2898: [CARBONDATA-3077] Fixed query failure in fileformat ...
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2898 I think the current modification does not fix the root of the problem. If you think the table information is not get cleared, you should get it cleared, not just update it when you need it. The current implementation means at some time, the table information is kept somewhere as outdated. ---
[GitHub] carbondata pull request #2896: [CARBONDATA-3075] Select Filter fails for Leg...
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2896#discussion_r230728849
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/executor/impl/AbstractQueryExecutor.java
---
@@ -230,6 +230,11 @@ protected void initQuery(QueryModel queryModel) throws
IOException {
updateColumns(queryModel, fileFooter.getColumnInTable(),
blockInfo.getFilePath());
filePathToSegmentPropertiesMap.put(blockInfo.getFilePath(),
segmentProperties);
}
+//In case of Legacy store, set setDirectVectorFill to false,
+// as filling vector directly is not supported for V2 store
--- End diff --
not only v2... 'not supported for legacy store prior to v3'. Besides I do
like you to add a warn log here and remove the comments.
---
[GitHub] carbondata issue #2816: [CARBONDATA-3003] Suppor read batch row in CSDK
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2816 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1488/ ---
[GitHub] carbondata pull request #2897: [WIP] Supporting local dictionary enable by d...
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2897#discussion_r230729869 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java --- @@ -64,7 +64,8 @@ private Map options; private String taskNo; private int localDictionaryThreshold; - private boolean isLocalDictionaryEnabled; + private boolean isLocalDictionaryEnabled = Boolean.parseBoolean( --- End diff -- So what about the `localDictionaryThreshold`? To keep the same behavior, each configurations should be assigned the default value while init. ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9528/ ---
[GitHub] carbondata issue #2863: [WIP] Optimise decompressing while filling the vecto...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2863 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1481/ ---
[GitHub] carbondata issue #2863: [WIP] Optimise decompressing while filling the vecto...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2863 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9530/ ---
[GitHub] carbondata issue #2894: [CARBONDATA-3074] Change default sort temp compresso...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2894 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9532/ ---
[GitHub] carbondata pull request #2896: [WIP] Select Filter fails for Legacy store if...
GitHub user Indhumathi27 opened a pull request: https://github.com/apache/carbondata/pull/2896 [WIP] Select Filter fails for Legacy store if DirectVecorFill is enabled **Why this PR?** When **isDirectVectorFill** is set to true, Select filter fails in Legacy Store throwing UnsupportedOperationException **Solution:** Set **isDirectVectorFill** to false for Legacy store - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [ ] Testing done - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Indhumathi27/carbondata scan_comp Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/2896.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2896 commit c2af1dc8ed8ea9ec5671d3fa107007c338ecbbef Author: Indhumathi27 Date: 2018-11-05T10:42:24Z [CARBONDATA-3075] Select Filter fails for Legacy store if DirectVectorFill is enabled ---
[GitHub] carbondata issue #2894: [CARBONDATA-3074] Change default sort temp compresso...
Github user kevinjmh commented on the issue: https://github.com/apache/carbondata/pull/2894 retest this please ---
[GitHub] carbondata issue #2894: [CARBONDATA-3074] Change default sort temp compresso...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2894 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1271/ ---
[jira] [Created] (CARBONDATA-3077) Fixed query failure in fileformat due stale cache issue
Manish Gupta created CARBONDATA-3077: Summary: Fixed query failure in fileformat due stale cache issue Key: CARBONDATA-3077 URL: https://issues.apache.org/jira/browse/CARBONDATA-3077 Project: CarbonData Issue Type: Bug Reporter: Manish Gupta Assignee: Manish Gupta *Problem* While using FileFormat API, if a table created, dropped and then recreated with the same name the query fails because of schema mismatch issue -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (CARBONDATA-3079) Improve the C++ SDK read performance by merging column in JNI
xubo245 created CARBONDATA-3079: --- Summary: Improve the C++ SDK read performance by merging column in JNI Key: CARBONDATA-3079 URL: https://issues.apache.org/jira/browse/CARBONDATA-3079 Project: CarbonData Issue Type: Sub-task Reporter: xubo245 Assignee: xubo245 Fix For: 1.5.1 Improve the C++ SDK read performance by merging column in JNI -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] carbondata issue #2893: [HOTFIX] Refactor java CarbonSessionExample to use C...
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/2893 retest this please ---
[GitHub] carbondata issue #2894: [CARBONDATA-3074] Change default sort temp compresso...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2894 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1483/ ---
[jira] [Created] (CARBONDATA-3075) Select Filter fails for Legacy store if DirectVectorFill is enabled
Indhumathi Muthumurugesh created CARBONDATA-3075: Summary: Select Filter fails for Legacy store if DirectVectorFill is enabled Key: CARBONDATA-3075 URL: https://issues.apache.org/jira/browse/CARBONDATA-3075 Project: CarbonData Issue Type: Improvement Reporter: Indhumathi Muthumurugesh -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] carbondata issue #2816: [CARBONDATA-3003] Suppor read batch row in CSDK
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2816 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9531/ ---
[GitHub] carbondata issue #2886: [CARBONDATA-3065]make inverted index false by defaul...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2886 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1484/ ---
[GitHub] carbondata issue #2816: [CARBONDATA-3003] Suppor read batch row in CSDK
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2816 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1482/ ---
[jira] [Updated] (CARBONDATA-3076) Set streaming=false not working for streaming table.
[
https://issues.apache.org/jira/browse/CARBONDATA-3076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pawan Malwal updated CARBONDATA-3076:
-
Environment: Spark2.1
Description:
1. Create streaming table.
CREATE TABLE table_st(CUST_ID String,CUST_NAME String) STORED BY
'org.apache.carbondata.format' TBLPROPERTIES('streaming'='true');
2. Alter table to set 'streaming'='false'
alter table table_st set tblproperties('streaming'='false');
_Alter table throws below exception_
_Error:
org.apache.carbondata.common.exceptions.sql.MalformedCarbonCommandException:
Streaming property can not be changed once it is 'true' (state=,code=0)_
was:
Create streaming table.
CREATE TABLE table_st(CUST_ID String,CUST_NAME String) STORED BY
'org.apache.carbondata.format' TBLPROPERTIES('streaming'='true');
Alter table
> Set streaming=false not working for streaming table.
>
>
> Key: CARBONDATA-3076
> URL: https://issues.apache.org/jira/browse/CARBONDATA-3076
> Project: CarbonData
> Issue Type: Bug
> Components: data-query
>Affects Versions: 1.5.1
> Environment: Spark2.1
>Reporter: Pawan Malwal
>Priority: Minor
>
> 1. Create streaming table.
> CREATE TABLE table_st(CUST_ID String,CUST_NAME String) STORED BY
> 'org.apache.carbondata.format' TBLPROPERTIES('streaming'='true');
> 2. Alter table to set 'streaming'='false'
> alter table table_st set tblproperties('streaming'='false');
> _Alter table throws below exception_
> _Error:
> org.apache.carbondata.common.exceptions.sql.MalformedCarbonCommandException:
> Streaming property can not be changed once it is 'true' (state=,code=0)_
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] carbondata issue #2816: [CARBONDATA-3003] Suppor read batch row in CSDK
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2816 retest this please ---
[GitHub] carbondata pull request #2897: [WIP] Supporting local dictionary enable by d...
GitHub user BJangir opened a pull request: https://github.com/apache/carbondata/pull/2897 [WIP] Supporting local dictionary enable by default for SDK Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. You can merge this pull request into a Git repository by running: $ git pull https://github.com/BJangir/incubator-carbondata sdk_local_dic_default Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/2897.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2897 commit 83d11643f1c9acc2b8d3f206fd304ae8ee686160 Author: BJangir Date: 2018-11-05T11:11:16Z Supporting local dictionary enable by default for SDK ---
[GitHub] carbondata pull request #2899: [CARBONDATA-3073] Support configure TableProp...
GitHub user xubo245 opened a pull request: https://github.com/apache/carbondata/pull/2899 [CARBONDATA-3073] Support configure TableProperties in carbon writer of C++ SDK Support configure TableProperties in carbon writer of C++ SDK Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? No - [ ] Any backward compatibility impacted? No - [ ] Document update required? No - [ ] Testing done No - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. No You can merge this pull request into a Git repository by running: $ git pull https://github.com/xubo245/carbondata CARBONDATA-3073_TableProperties Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/2899.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2899 commit e5dbe559258d9902f117536a3e698d9e47b0c683 Author: xubo245 Date: 2018-11-05T11:43:19Z [CARBONDATA-3073] Support configure TableProperties in carbon writer of C++ SDK ---
[GitHub] carbondata pull request #2896: [CARBONDATA-3075] Select Filter fails for Leg...
Github user Indhumathi27 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2896#discussion_r230731270
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/executor/impl/AbstractQueryExecutor.java
---
@@ -230,6 +230,11 @@ protected void initQuery(QueryModel queryModel) throws
IOException {
updateColumns(queryModel, fileFooter.getColumnInTable(),
blockInfo.getFilePath());
filePathToSegmentPropertiesMap.put(blockInfo.getFilePath(),
segmentProperties);
}
+//In case of Legacy store, set setDirectVectorFill to false,
+// as filling vector directly is not supported for V2 store
--- End diff --
okay
---
[jira] [Resolved] (CARBONDATA-3074) Change default sort temp compressor to SNAPPY
[ https://issues.apache.org/jira/browse/CARBONDATA-3074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuchuanyin resolved CARBONDATA-3074. Resolution: Fixed Fix Version/s: 1.5.1 > Change default sort temp compressor to SNAPPY > -- > > Key: CARBONDATA-3074 > URL: https://issues.apache.org/jira/browse/CARBONDATA-3074 > Project: CarbonData > Issue Type: Improvement >Reporter: jiangmanhua >Assignee: jiangmanhua >Priority: Major > Fix For: 1.5.1 > > Time Spent: 1h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] carbondata issue #2897: [CARBONDATA-3080] Supporting local dictionary enable...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2897 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9538/ ---
[GitHub] carbondata issue #2816: [CARBONDATA-3003] Suppor read batch row in CSDK
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2816 LGTM ---
[GitHub] carbondata issue #2896: [CARBONDATA-3075] Select Filter fails for Legacy sto...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2896 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9541/ ---
[GitHub] carbondata issue #2898: [CARBONDATA-3077] Fixed query failure in fileformat ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2898 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9540/ ---
[jira] [Created] (CARBONDATA-3081) NPE when boolean column has null values with Vectorized SDK reader
Kunal Kapoor created CARBONDATA-3081: Summary: NPE when boolean column has null values with Vectorized SDK reader Key: CARBONDATA-3081 URL: https://issues.apache.org/jira/browse/CARBONDATA-3081 Project: CarbonData Issue Type: Bug Reporter: Kunal Kapoor -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] carbondata pull request #2901: [CARBONDATA-3081] Fixed NPE for boolean type ...
GitHub user kunal642 opened a pull request: https://github.com/apache/carbondata/pull/2901 [CARBONDATA-3081] Fixed NPE for boolean type column with null value Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kunal642/carbondata npe_fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/2901.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2901 commit 906eee74f20fbc1a9983db1ce0073356649a7724 Author: kunal642 Date: 2018-11-05T13:16:44Z fixed NPE for boolean type column with null value ---
[GitHub] carbondata issue #2886: [CARBONDATA-3065]make inverted index false by defaul...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2886 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1282/ ---
[GitHub] carbondata issue #2816: [CARBONDATA-3003] Suppor read batch row in CSDK
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2816 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1283/ ---
[jira] [Assigned] (CARBONDATA-3072) Show segment data size and index size does not display correctly for table created in older version upgraded to latest version
[ https://issues.apache.org/jira/browse/CARBONDATA-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Bhat reassigned CARBONDATA-3072: --- Assignee: Jacky Li > Show segment data size and index size does not display correctly for table > created in older version upgraded to latest version > -- > > Key: CARBONDATA-3072 > URL: https://issues.apache.org/jira/browse/CARBONDATA-3072 > Project: CarbonData > Issue Type: Bug > Components: data-query >Affects Versions: 1.5.0, 1.5.1 > Environment: Spark 2.1 >Reporter: Chetan Bhat >Assignee: Jacky Li >Priority: Minor > > Steps : > Create table in version older than 1.5.0 and load data to table. > Create a database in 1.5.0 or 1.5.1. > Copy the older version store to HDFS path of 1.5.0 or 1.5.1. > Refresh the table using the refresh table command. > Execute show segment command for the table. > > Issue : Show segment data size and index size displays incorrectly as 0.0B > and 0.0B. > 0: jdbc:hive2://10.18.98.225:22550/default> show segments for table brinjal; > +++--+--++--++-+--+ > | SegmentSequenceId | Status | Load Start Time | Load End Time | Merged To | > File Format | Data Size | Index Size | > +++--+--++--++-+--+ > | 3 | Marked for Delete | 2017-12-27 19:27:43.471 | 2017-12-27 19:27:50.737 | > NA | COLUMNAR_V3 | 0.0B | 0.0B | > | 2 | Success | 2017-12-26 20:18:22.775 | 2017-12-26 20:18:23.793 | NA | > COLUMNAR_V3 | 0.0B | 0.0B | > | 1 | Success | 2017-12-26 20:18:19.822 | 2017-12-26 20:18:20.371 | NA | > COLUMNAR_V3 | 0.0B | 0.0B | > | 0 | Success | 2017-12-26 20:18:09.392 | 2017-12-26 20:18:16.024 | NA | > COLUMNAR_V3 | 0.0B | 0.0B | > +++--+--++--++-+--+ > 4 rows selected (0.56 seconds) > > Expected : Show segment data size and index size should display correct size > as shown below. > 0: jdbc:hive2://10.18.98.225:22550/default> show segments for table brinjal; > ++--+--+--++--++-+--+ > | SegmentSequenceId | Status | Load Start Time | Load End Time | Merged To | > File Format | Data Size | Index Size | > ++--+--+--++--++-+--+ > | 1 | Success | 2018-11-02 22:31:34.103 | 2018-11-02 22:31:34.77 | NA | > COLUMNAR_V3 | 6.52KB | 1.63KB | > | 0 | Success | 2018-11-02 22:31:20.54 | 2018-11-02 22:31:21.273 | NA | > COLUMNAR_V3 | 6.52KB | 1.63KB | > ++--+--+--++--++-+--+ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (CARBONDATA-3076) Set streaming=false not working for streaming table.
[
https://issues.apache.org/jira/browse/CARBONDATA-3076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chetan Bhat reassigned CARBONDATA-3076:
---
Assignee: Jacky Li
> Set streaming=false not working for streaming table.
>
>
> Key: CARBONDATA-3076
> URL: https://issues.apache.org/jira/browse/CARBONDATA-3076
> Project: CarbonData
> Issue Type: Bug
> Components: data-query
>Affects Versions: 1.5.1
> Environment: Spark2.1
>Reporter: Pawan Malwal
>Assignee: Jacky Li
>Priority: Minor
>
> 1. Create streaming table.
> CREATE TABLE table_st(CUST_ID String,CUST_NAME String) STORED BY
> 'org.apache.carbondata.format' TBLPROPERTIES('streaming'='true');
> 2. Alter table to set 'streaming'='false'
> alter table table_st set tblproperties('streaming'='false');
> _Alter table throws below exception_
> _Error:
> org.apache.carbondata.common.exceptions.sql.MalformedCarbonCommandException:
> Streaming property can not be changed once it is 'true' (state=,code=0)_
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] carbondata issue #2900: [CARBONDATA-3078] Disable explain collector for coun...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2900 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1495/ ---
[GitHub] carbondata issue #2893: [HOTFIX] Refactor java CarbonSessionExample to use C...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2893 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9542/ ---
[GitHub] carbondata issue #2886: [CARBONDATA-3065]make inverted index false by defaul...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2886 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9543/ ---
[GitHub] carbondata issue #2896: [CARBONDATA-3075] Select Filter fails for Legacy sto...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2896 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1496/ ---
[GitHub] carbondata issue #2896: [CARBONDATA-3075] Select Filter fails for Legacy sto...
Github user Indhumathi27 commented on the issue: https://github.com/apache/carbondata/pull/2896 Retest this please ---
[GitHub] carbondata issue #2816: [CARBONDATA-3003] Suppor read batch row in CSDK
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2816 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1498/ ---
[GitHub] carbondata issue #2886: [CARBONDATA-3065]make inverted index false by defaul...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2886 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1275/ ---
[GitHub] carbondata issue #2816: [CARBONDATA-3003] Suppor read batch row in CSDK
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2816 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9537/ ---
[GitHub] carbondata pull request #2894: [CARBONDATA-3074] Change default sort temp co...
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2894 ---
[jira] [Created] (CARBONDATA-3080) Supporting local dictionary enable by default for SDK
Babulal created CARBONDATA-3080: --- Summary: Supporting local dictionary enable by default for SDK Key: CARBONDATA-3080 URL: https://issues.apache.org/jira/browse/CARBONDATA-3080 Project: CarbonData Issue Type: Bug Reporter: Babulal h1. Supporting local dictionary enable by default for SDK -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] carbondata pull request #2897: [WIP] Supporting local dictionary enable by d...
Github user BJangir commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2897#discussion_r230736008 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java --- @@ -64,7 +64,8 @@ private Map options; private String taskNo; private int localDictionaryThreshold; - private boolean isLocalDictionaryEnabled; + private boolean isLocalDictionaryEnabled = Boolean.parseBoolean( --- End diff -- it is already handled in below method when isLocalDictionaryEnabled is true org.apache.carbondata.core.metadata.schema.table.TableSchemaBuilder#build ---
[GitHub] carbondata issue #2899: [CARBONDATA-3073] Support configure TableProperties ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2899 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9539/ ---
[GitHub] carbondata issue #2893: [HOTFIX] Refactor java CarbonSessionExample to use C...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2893 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1493/ ---
[GitHub] carbondata issue #2816: [CARBONDATA-3003] Suppor read batch row in CSDK
Github user KanakaKumar commented on the issue: https://github.com/apache/carbondata/pull/2816 LGTM ---
[GitHub] carbondata issue #2900: [CARBONDATA-3078] Disable explain collector for coun...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2900 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1276/ ---
[GitHub] carbondata issue #2897: [CARBONDATA-3080] Supporting local dictionary enable...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2897 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1497/ ---
[GitHub] carbondata issue #2898: [CARBONDATA-3077] Fixed query failure in fileformat ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2898 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1278/ ---
[GitHub] carbondata issue #2897: [WIP] Supporting local dictionary enable by default ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2897 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1489/ ---
[GitHub] carbondata issue #2894: [CARBONDATA-3074] Change default sort temp compresso...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2894 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1487/ ---
[GitHub] carbondata pull request #2900: [CARBONDATA-3078] Disable explain collector f...
GitHub user kevinjmh opened a pull request: https://github.com/apache/carbondata/pull/2900 [CARBONDATA-3078] Disable explain collector for count star query without filter An issue is found about count star query without filter in explain command. It is a special case. It uses different plan. Considering no useful information about block/blocklet pruning for count star query without filter, so disable explain collector and avoid the exception in https://issues.apache.org/jira/browse/CARBONDATA-3078 Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kevinjmh/carbondata explain_countstar Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/2900.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2900 commit 46f07a25924e98d43dd9dcfad3a1c7cb0cd4d895 Author: Manhua Date: 2018-11-05T12:17:59Z disable explain collector for count star query without filter ---
[GitHub] carbondata issue #2898: [CARBONDATA-3077] Fixed query failure in fileformat ...
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2898 @xuchuanyin ...your point is correct. To explain this in detail 1. We have already a way to clear the cached DataMaps through API call `DataMapStoreManager.getInstance().clearDataMaps(AbsoluteTableIdentifier identifier)`. This API call ensures that for a given table all the dataMaps are cleared. 2. For FileFormat case if the above API is not integrated by the customer there is a possibility that drop table call will not come to carbondata layer and there can be few stale objects which can cause query failure. The PR is raised to handle the 2nd case. The other stale DataMaps are being already taken care by the LRU cache which will clear the stale entries one LRU cache threshold is reached. Let me know if you still have doubts ---
[GitHub] carbondata issue #2897: [CARBONDATA-3080] Supporting local dictionary enable...
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2897 @BJangir ...please go through the discussion and then decide whether for SDK be default we should enable local dictionary or not. We can further discuss on it based on your view http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/Feature-Proposal-Proposal-for-offline-and-DDL-local-dictionary-support-td67620.html ---
[GitHub] carbondata issue #2898: [CARBONDATA-3077] Fixed query failure in fileformat ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2898 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1491/ ---
[GitHub] carbondata issue #2816: [CARBONDATA-3003] Suppor read batch row in CSDK
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2816 retest this please ---
[GitHub] carbondata issue #2886: [CARBONDATA-3065]make inverted index false by defaul...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2886 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1494/ ---
[GitHub] carbondata issue #2899: [CARBONDATA-3073] Support configure TableProperties ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2899 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1277/ ---
[GitHub] carbondata issue #2901: [CARBONDATA-3081] Fixed NPE for boolean type column ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2901 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1499/ ---
