[jira] [Resolved] (CARBONDATA-3208) Remove unused parameter from code

2018-12-30 Thread xubo245 (JIRA) 


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

xubo245 resolved CARBONDATA-3208.
-
Resolution: Resolved

> Remove unused parameter from code
> -
>
> Key: CARBONDATA-3208
> URL: https://issues.apache.org/jira/browse/CARBONDATA-3208
> Project: CarbonData
>  Issue Type: Bug
>Reporter: xubo245
>Assignee: Liu Runzhong
>Priority: Major
>  Time Spent: 7h 10m
>  Remaining Estimate: 0h
>
> Remove unused parameter from code：
> for example， sparkSession parameter in：
> org.apache.carbondata.spark.rdd.CarbonColumnDictGenerateRDD



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] carbondata pull request #3036: [CARBONDATA-3208] Remove unused parameters, i...

2018-12-30 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/3036


---

[GitHub] carbondata issue #3036: [CARBONDATA-3208] Remove unused parameters, imports ...

2018-12-30 Thread xubo245 
Github user xubo245 commented on the issue:

https://github.com/apache/carbondata/pull/3036
  
LGTM. Thank you for working on it.


---

[jira] [Resolved] (CARBONDATA-3202) updated schema is not updated in session catalog after add, drop or rename column.

2018-12-30 Thread Manish Gupta (JIRA) 


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Manish Gupta resolved CARBONDATA-3202.
--
   Resolution: Fixed
 Assignee: Akash R Nilugal
Fix Version/s: 1.5.3

> updated schema is not updated in session catalog after add, drop or rename 
> column. 
> ---
>
> Key: CARBONDATA-3202
> URL: https://issues.apache.org/jira/browse/CARBONDATA-3202
> Project: CarbonData
>  Issue Type: Bug
>Reporter: Akash R Nilugal
>Assignee: Akash R Nilugal
>Priority: Minor
> Fix For: 1.5.3
>
>  Time Spent: 5h 10m
>  Remaining Estimate: 0h
>
> updated schema is not updated in session catalog after add, drop or rename 
> column. 
>  
> Spark does not support drop column , rename column, and supports add column 
> from spark2.2 onwards, so after rename, or add or drop column, the new 
> updated schema is not updated in catalog



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] carbondata pull request #3027: [CARBONDATA-3202]update the schema to session...

2018-12-30 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/3027


---

[GitHub] carbondata issue #3027: [CARBONDATA-3202]update the schema to session catalo...

2018-12-30 Thread manishgupta88 
Github user manishgupta88 commented on the issue:

https://github.com/apache/carbondata/pull/3027
  
LGTM


---

[GitHub] carbondata issue #3036: [CARBONDATA-3208] Remove unused parameters, imports ...

2018-12-30 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3036
  
Build Success with Spark 2.3.2, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10347/



---

[GitHub] carbondata issue #3036: [CARBONDATA-3208] Remove unused parameters, imports ...

2018-12-30 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3036
  
Build Success with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2298/



---

[GitHub] carbondata issue #3036: [CARBONDATA-3208] Remove unused parameters, imports ...

2018-12-30 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3036
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2093/



---

[GitHub] carbondata issue #3036: [CARBONDATA-3208] Remove unused parameters, imports ...

2018-12-30 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3036
  
Build Success with Spark 2.3.2, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10346/



---

[GitHub] carbondata issue #3036: [CARBONDATA-3208] Remove unused parameters, imports ...

2018-12-30 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3036
  
Build Success with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2297/



---

[GitHub] carbondata issue #3036: [CARBONDATA-3208] Remove unused parameters, imports ...

2018-12-30 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3036
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2092/



---

[GitHub] carbondata pull request #3036: [CARBONDATA-3208] Remove unused parameters, i...

2018-12-30 Thread runzhliu 
Github user runzhliu commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/3036#discussion_r244537813
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentProperties.java
 ---
@@ -287,31 +287,31 @@ private void 
fillDimensionAndMeasureDetails(List columnsInTable,
   // if it is a columnar dimension participated in mdkey then added
   // key ordinal and dimension ordinal
   carbonDimension =
-  new CarbonDimension(columnSchema, dimensonOrdinal++, 
keyOrdinal++, -1);
+  new CarbonDimension(columnSchema, dimensionOrdinal++, 
keyOrdinal++, -1);
 }
 // as complex type will be stored at last so once complex type 
started all the dimension
 // will be added to complex type
 else if (isComplexDimensionStarted || 
columnSchema.getDataType().isComplexType()) {
   cardinalityIndexForComplexDimensionColumn.add(tableOrdinal);
   carbonDimension =
-  new CarbonDimension(columnSchema, dimensonOrdinal++, -1, 
++complexTypeOrdinal);
+  new CarbonDimension(columnSchema, dimensionOrdinal++, -1, 
++complexTypeOrdinal);
   
carbonDimension.initializeChildDimensionsList(columnSchema.getNumberOfChild());
   complexDimensions.add(carbonDimension);
   isComplexDimensionStarted = true;
-  int previouseOrdinal = dimensonOrdinal;
-  dimensonOrdinal =
-  readAllComplexTypeChildren(dimensonOrdinal, 
columnSchema.getNumberOfChild(),
+  int previouseOrdinal = dimensionOrdinal;
--- End diff --

Thanks to point it out! I have fixed it :)


---

[GitHub] carbondata pull request #3036: [CARBONDATA-3208] Remove unused parameters, i...

2018-12-30 Thread xuchuanyin 
Github user xuchuanyin commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/3036#discussion_r244535093
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentProperties.java
 ---
@@ -287,31 +287,31 @@ private void 
fillDimensionAndMeasureDetails(List columnsInTable,
   // if it is a columnar dimension participated in mdkey then added
   // key ordinal and dimension ordinal
   carbonDimension =
-  new CarbonDimension(columnSchema, dimensonOrdinal++, 
keyOrdinal++, -1);
+  new CarbonDimension(columnSchema, dimensionOrdinal++, 
keyOrdinal++, -1);
 }
 // as complex type will be stored at last so once complex type 
started all the dimension
 // will be added to complex type
 else if (isComplexDimensionStarted || 
columnSchema.getDataType().isComplexType()) {
   cardinalityIndexForComplexDimensionColumn.add(tableOrdinal);
   carbonDimension =
-  new CarbonDimension(columnSchema, dimensonOrdinal++, -1, 
++complexTypeOrdinal);
+  new CarbonDimension(columnSchema, dimensionOrdinal++, -1, 
++complexTypeOrdinal);
   
carbonDimension.initializeChildDimensionsList(columnSchema.getNumberOfChild());
   complexDimensions.add(carbonDimension);
   isComplexDimensionStarted = true;
-  int previouseOrdinal = dimensonOrdinal;
-  dimensonOrdinal =
-  readAllComplexTypeChildren(dimensonOrdinal, 
columnSchema.getNumberOfChild(),
+  int previouseOrdinal = dimensionOrdinal;
--- End diff --

um, part of the variable name 'previouse' is also typo, which should be 
'previous'...
Please correct this also and others LGTM.


---