[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3766: [WIP][Perf] Support RuntimeFilter for inner/leftsemi equi-join

2020-05-22 Thread GitBox


CarbonDataQA1 commented on pull request #3766:
URL: https://github.com/apache/carbondata/pull/3766#issuecomment-632580405


   Build Failed  with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1333/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3766: [WIP][Perf] Support RuntimeFilter for inner/leftsemi equi-join

2020-05-22 Thread GitBox


CarbonDataQA1 commented on pull request #3766:
URL: https://github.com/apache/carbondata/pull/3766#issuecomment-632581597


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3053/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3771: [WIP] pushdown array_contains filter to carbon

2020-05-22 Thread GitBox


CarbonDataQA1 commented on pull request #3771:
URL: https://github.com/apache/carbondata/pull/3771#issuecomment-632597680


   Build Failed  with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1334/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3771: [WIP] pushdown array_contains filter to carbon

2020-05-22 Thread GitBox


CarbonDataQA1 commented on pull request #3771:
URL: https://github.com/apache/carbondata/pull/3771#issuecomment-632599089


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3054/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (CARBONDATA-3833) Make GeoID visible to the user

2020-05-22 Thread SHREELEKHYA GAMPA (Jira)
SHREELEKHYA GAMPA created CARBONDATA-3833:
-

 Summary: Make GeoID visible to the user
 Key: CARBONDATA-3833
 URL: https://issues.apache.org/jira/browse/CARBONDATA-3833
 Project: CarbonData
  Issue Type: New Feature
Reporter: SHREELEKHYA GAMPA


Make GeoID visible to the user



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (CARBONDATA-3833) Make GeoID visible to the user

2020-05-22 Thread SHREELEKHYA GAMPA (Jira)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-3833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

SHREELEKHYA GAMPA updated CARBONDATA-3833:
--
Description: GeoID is a column created internally for spatial tables and 
currently it is not visible to the users while querying. This feature is to 
make GeoID visible to the user.  (was: Make GeoID visible to the user)

> Make GeoID visible to the user
> --
>
> Key: CARBONDATA-3833
> URL: https://issues.apache.org/jira/browse/CARBONDATA-3833
> Project: CarbonData
>  Issue Type: New Feature
>Reporter: SHREELEKHYA GAMPA
>Priority: Minor
>
> GeoID is a column created internally for spatial tables and currently it is 
> not visible to the users while querying. This feature is to make GeoID 
> visible to the user.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3771: [WIP] pushdown array_contains filter to carbon

2020-05-22 Thread GitBox


CarbonDataQA1 commented on pull request #3771:
URL: https://github.com/apache/carbondata/pull/3771#issuecomment-632972441


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3055/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3771: [WIP] pushdown array_contains filter to carbon

2020-05-22 Thread GitBox


CarbonDataQA1 commented on pull request #3771:
URL: https://github.com/apache/carbondata/pull/3771#issuecomment-632972849


   Build Failed  with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1335/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3771: [WIP] pushdown array_contains filter to carbon

2020-05-22 Thread GitBox


Indhumathi27 commented on a change in pull request #3771:
URL: https://github.com/apache/carbondata/pull/3771#discussion_r429519286



##
File path: 
integration/spark/src/test/scala/org/apache/carbondata/integration/spark/testsuite/complexType/TestCompactionComplexType.scala
##
@@ -47,6 +47,33 @@ class TestCompactionComplexType extends QueryTest with 
BeforeAndAfterAll {
 sql("DROP TABLE IF EXISTS compactComplex")
   }
 
+  test("complex issue") {
+sql("drop table if exists complex1")
+sql("create table complex1 (arr array) stored as carbondata")
+sql("insert into complex1 select array('as') union all " +
+"select array('sd','df','gh') union all " +
+"select array('rt','ew','rtyu','jk','sder') union all " +
+"select array('ghsf','dbv','fg','ty') union all " +
+"select array('hjsd','fggb','nhj','sd','asd')")
+

Review comment:
   Please add test scenario with data as null. array(null)





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3771: [WIP] pushdown array_contains filter to carbon

2020-05-22 Thread GitBox


ajantha-bhat commented on a change in pull request #3771:
URL: https://github.com/apache/carbondata/pull/3771#discussion_r429519687



##
File path: 
integration/spark/src/test/scala/org/apache/carbondata/integration/spark/testsuite/complexType/TestCompactionComplexType.scala
##
@@ -47,6 +47,33 @@ class TestCompactionComplexType extends QueryTest with 
BeforeAndAfterAll {
 sql("DROP TABLE IF EXISTS compactComplex")
   }
 
+  test("complex issue") {
+sql("drop table if exists complex1")
+sql("create table complex1 (arr array) stored as carbondata")
+sql("insert into complex1 select array('as') union all " +
+"select array('sd','df','gh') union all " +
+"select array('rt','ew','rtyu','jk','sder') union all " +
+"select array('ghsf','dbv','fg','ty') union all " +
+"select array('hjsd','fggb','nhj','sd','asd')")
+

Review comment:
   This is WIP temp, cannot merge this poc code. Why review? 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3771: [WIP] pushdown array_contains filter to carbon

2020-05-22 Thread GitBox


Indhumathi27 commented on a change in pull request #3771:
URL: https://github.com/apache/carbondata/pull/3771#discussion_r429519286



##
File path: 
integration/spark/src/test/scala/org/apache/carbondata/integration/spark/testsuite/complexType/TestCompactionComplexType.scala
##
@@ -47,6 +47,33 @@ class TestCompactionComplexType extends QueryTest with 
BeforeAndAfterAll {
 sql("DROP TABLE IF EXISTS compactComplex")
   }
 
+  test("complex issue") {
+sql("drop table if exists complex1")
+sql("create table complex1 (arr array) stored as carbondata")
+sql("insert into complex1 select array('as') union all " +
+"select array('sd','df','gh') union all " +
+"select array('rt','ew','rtyu','jk','sder') union all " +
+"select array('ghsf','dbv','fg','ty') union all " +
+"select array('hjsd','fggb','nhj','sd','asd')")
+

Review comment:
   Please add test scenario with data as null. array(null)





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3771: [WIP] pushdown array_contains filter to carbon

2020-05-22 Thread GitBox


ajantha-bhat commented on a change in pull request #3771:
URL: https://github.com/apache/carbondata/pull/3771#discussion_r429519687



##
File path: 
integration/spark/src/test/scala/org/apache/carbondata/integration/spark/testsuite/complexType/TestCompactionComplexType.scala
##
@@ -47,6 +47,33 @@ class TestCompactionComplexType extends QueryTest with 
BeforeAndAfterAll {
 sql("DROP TABLE IF EXISTS compactComplex")
   }
 
+  test("complex issue") {
+sql("drop table if exists complex1")
+sql("create table complex1 (arr array) stored as carbondata")
+sql("insert into complex1 select array('as') union all " +
+"select array('sd','df','gh') union all " +
+"select array('rt','ew','rtyu','jk','sder') union all " +
+"select array('ghsf','dbv','fg','ty') union all " +
+"select array('hjsd','fggb','nhj','sd','asd')")
+

Review comment:
   This is WIP temp, cannot merge this poc code. Why review? 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org