[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3848: [CARBONDATA-3891] Fix loading data will update all segments updateDeltaEndTimestamp

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3848: URL: https://github.com/apache/carbondata/pull/3848#issuecomment-661238447 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3446/

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3842: [CARBONDATA-3702] Clean temp index files in parallel in merge index flow

2020-07-20 Thread GitBox
VenuReddy2103 commented on a change in pull request #3842: URL: https://github.com/apache/carbondata/pull/3842#discussion_r457648464 ## File path: integration/spark/src/main/scala/org/apache/spark/rdd/CarbonMergeFilesRDD.scala ## @@ -157,21 +157,21 @@ object

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3848: [CARBONDATA-3891] Fix loading data will update all segments updateDeltaEndTimestamp

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3848: URL: https://github.com/apache/carbondata/pull/3848#issuecomment-661245090 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1704/

[GitHub] [carbondata] QiangCai commented on pull request #3845: [CARBONDATA-3871][FOLLOW-UP] Fix memory issue when get data from row page

2020-07-20 Thread GitBox
QiangCai commented on pull request #3845: URL: https://github.com/apache/carbondata/pull/3845#issuecomment-661609054 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] QiangCai commented on pull request #3812: [CARBONDATA-3895]Fx FileNotFound exception in query after global sort compaction

2020-07-20 Thread GitBox
QiangCai commented on pull request #3812: URL: https://github.com/apache/carbondata/pull/3812#issuecomment-661570120 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Created] (CARBONDATA-3917) The rows of data loading is not accurate, more rows has been loaded

2020-07-20 Thread Taoli (Jira)
Taoli created CARBONDATA-3917: - Summary: The rows of data loading is not accurate, more rows has been loaded Key: CARBONDATA-3917 URL: https://issues.apache.org/jira/browse/CARBONDATA-3917 Project:

[GitHub] [carbondata] asfgit closed pull request #3771: [CARBONDATA-3849] pushdown array_contains filter to carbon for array of primitive types

2020-07-20 Thread GitBox
asfgit closed pull request #3771: URL: https://github.com/apache/carbondata/pull/3771 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3847: [CARBONDATA-3906] Optimize sort performance in writting file

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3847: URL: https://github.com/apache/carbondata/pull/3847#issuecomment-661617787 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3447/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3847: [CARBONDATA-3906] Optimize sort performance in writting file

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3847: URL: https://github.com/apache/carbondata/pull/3847#issuecomment-661618161 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1705/

[GitHub] [carbondata] QiangCai commented on pull request #3771: [CARBONDATA-3849] pushdown array_contains filter to carbon for array of primitive types

2020-07-20 Thread GitBox
QiangCai commented on pull request #3771: URL: https://github.com/apache/carbondata/pull/3771#issuecomment-661559605 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] asfgit closed pull request #3812: [CARBONDATA-3895]Fx FileNotFound exception in query after global sort compaction

2020-07-20 Thread GitBox
asfgit closed pull request #3812: URL: https://github.com/apache/carbondata/pull/3812 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] asfgit closed pull request #3845: [CARBONDATA-3871][FOLLOW-UP] Fix memory issue when get data from row page

2020-07-20 Thread GitBox
asfgit closed pull request #3845: URL: https://github.com/apache/carbondata/pull/3845 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] QiangCai commented on a change in pull request #3842: [CARBONDATA-3702] Clean temp index files in parallel in merge index flow

2020-07-20 Thread GitBox
QiangCai commented on a change in pull request #3842: URL: https://github.com/apache/carbondata/pull/3842#discussion_r457795146 ## File path: integration/spark/src/main/scala/org/apache/spark/rdd/CarbonMergeFilesRDD.scala ## @@ -157,21 +157,21 @@ object CarbonMergeFilesRDD {

[GitHub] [carbondata] akashrn5 opened a new pull request #3854: [WIP]Fix compaction failure issue for SI table and metadata mismatch in concurrency

2020-07-20 Thread GitBox
akashrn5 opened a new pull request #3854: URL: https://github.com/apache/carbondata/pull/3854 ### Why is this PR needed? ### What changes were proposed in this PR? ### Does this PR introduce any user interface change? - No - Yes. (please

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3810: [CARBONDATA-3900] [CARBONDATA-3882] [CARBONDATA-3881] Fix multiple concurrent issues in table status lock and segment lock for SI a

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3810: URL: https://github.com/apache/carbondata/pull/3810#issuecomment-660855887 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1687/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3778: [WIP] Support array with SI

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3778: URL: https://github.com/apache/carbondata/pull/3778#issuecomment-660867814 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3431/

[GitHub] [carbondata] shunlean commented on pull request #3847: [CARBONDATA-3906] Optimize sort performance in writting file

2020-07-20 Thread GitBox
shunlean commented on pull request #3847: URL: https://github.com/apache/carbondata/pull/3847#issuecomment-660882567 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] kunal642 commented on a change in pull request #3775: [WIP] Bloom Index Server Fallback Issue

2020-07-20 Thread GitBox
kunal642 commented on a change in pull request #3775: URL: https://github.com/apache/carbondata/pull/3775#discussion_r457209918 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/index/CarbonCreateIndexCommand.scala ## @@ -238,11 +238,22 @@

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3847: [CARBONDATA-3906] Optimize sort performance in writting file

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3847: URL: https://github.com/apache/carbondata/pull/3847#issuecomment-660909683 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1695/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3848: [CARBONDATA-3891] Fix loading data will update all segments updateDeltaEndTimestamp

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3848: URL: https://github.com/apache/carbondata/pull/3848#issuecomment-660922590 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3434/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3853: [WIP]Fix extra data in count(*) after multiple updates and index server running

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3853: URL: https://github.com/apache/carbondata/pull/3853#issuecomment-660876888 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1691/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3853: [WIP]Fix extra data in count(*) after multiple updates and index server running

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3853: URL: https://github.com/apache/carbondata/pull/3853#issuecomment-660913680 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3433/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3778: [WIP] Support array with SI

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3778: URL: https://github.com/apache/carbondata/pull/3778#issuecomment-660869540 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1689/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3847: [CARBONDATA-3906] Optimize sort performance in writting file

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3847: URL: https://github.com/apache/carbondata/pull/3847#issuecomment-660910195 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3437/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3848: [CARBONDATA-3891] Fix loading data will update all segments updateDeltaEndTimestamp

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3848: URL: https://github.com/apache/carbondata/pull/3848#issuecomment-660918396 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1692/

[GitHub] [carbondata] ajantha-bhat commented on pull request #3831: [CARBONDATA-3846]Data load issue for boolean column configured as BUCKET_COLUMNS

2020-07-20 Thread GitBox
ajantha-bhat commented on pull request #3831: URL: https://github.com/apache/carbondata/pull/3831#issuecomment-661636140 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3841: [CARBONDATA-3899] Drop materialized view when executed concurrently from 4 concurrent client fails in all 4 clients.

2020-07-20 Thread GitBox
akashrn5 commented on a change in pull request #3841: URL: https://github.com/apache/carbondata/pull/3841#discussion_r457843327 ## File path: integration/spark/src/test/scala/org/apache/carbondata/view/MVTest.scala ## @@ -178,6 +180,13 @@ class MVTest extends QueryTest with

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3850: [CARBONDATA-3907]Reuse firePreLoadEvents and firePostLoadEvents methods from CommonLoadUtils to trigger LoadTablePreExecutio

2020-07-20 Thread GitBox
akashrn5 commented on a change in pull request #3850: URL: https://github.com/apache/carbondata/pull/3850#discussion_r457848505 ## File path: processing/src/main/java/org/apache/carbondata/processing/loading/events/LoadEvents.java ## @@ -51,12 +51,6 @@ public

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3847: [CARBONDATA-3906] Optimize sort performance in writting file

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3847: URL: https://github.com/apache/carbondata/pull/3847#issuecomment-660858429 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3435/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3785: [CARBONDATA-3843] Fix merge index issue in streaming table

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3785: URL: https://github.com/apache/carbondata/pull/3785#issuecomment-660858224 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1688/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3785: [CARBONDATA-3843] Fix merge index issue in streaming table

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3785: URL: https://github.com/apache/carbondata/pull/3785#issuecomment-660857742 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3430/

[GitHub] [carbondata] shunlean commented on pull request #3847: [CARBONDATA-3906] Optimize sort performance in writting file

2020-07-20 Thread GitBox
shunlean commented on pull request #3847: URL: https://github.com/apache/carbondata/pull/3847#issuecomment-660848771 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3771: [CARBONDATA-3849] pushdown array_contains filter to carbon for array of primitive types

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3771: URL: https://github.com/apache/carbondata/pull/3771#issuecomment-660848132 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3432/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3771: [CARBONDATA-3849] pushdown array_contains filter to carbon for array of primitive types

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3771: URL: https://github.com/apache/carbondata/pull/3771#issuecomment-660848087 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1690/

[jira] [Created] (CARBONDATA-3915) Correction in the documentation for spark-shell

2020-07-20 Thread Prasanna Ravichandran (Jira)
Prasanna Ravichandran created CARBONDATA-3915: - Summary: Correction in the documentation for spark-shell Key: CARBONDATA-3915 URL: https://issues.apache.org/jira/browse/CARBONDATA-3915

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3810: [CARBONDATA-3900] [CARBONDATA-3882] [CARBONDATA-3881] Fix multiple concurrent issues in table status lock and segment lock for SI a

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3810: URL: https://github.com/apache/carbondata/pull/3810#issuecomment-660853350 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3429/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3847: [CARBONDATA-3906] Optimize sort performance in writting file

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3847: URL: https://github.com/apache/carbondata/pull/3847#issuecomment-660857142 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1693/

[GitHub] [carbondata] Indhumathi27 commented on pull request #3848: [CARBONDATA-3891] Fix loading data will update all segments updateDeltaEndTimestamp

2020-07-20 Thread GitBox
Indhumathi27 commented on pull request #3848: URL: https://github.com/apache/carbondata/pull/3848#issuecomment-660840922 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3812: [CARBONDATA-3895]Fx FileNotFound exception in query after global sort compaction

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3812: URL: https://github.com/apache/carbondata/pull/3812#issuecomment-661240606 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1703/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3778: [WIP] Support array with SI

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3778: URL: https://github.com/apache/carbondata/pull/3778#issuecomment-660968353 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1696/

[GitHub] [carbondata] ajantha-bhat commented on pull request #3818: [Carbondata-3883] Added filtering for the deleted rows for local dictionary fields

2020-07-20 Thread GitBox
ajantha-bhat commented on pull request #3818: URL: https://github.com/apache/carbondata/pull/3818#issuecomment-660996463 @Nitin-Kashyap : Can you please add a test here in `PrestoAllDataTypeLocalDictTest.scala` for this scenario. May be just add one more query for existing table local

[GitHub] [carbondata] kevinjmh commented on pull request #3828: [CARBONDATA-3889] Cleanup typo code for carbondata-core module

2020-07-20 Thread GitBox
kevinjmh commented on pull request #3828: URL: https://github.com/apache/carbondata/pull/3828#issuecomment-660982882 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3854: [WIP]Fix compaction failure issue for SI table and metadata mismatch in concurrency

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3854: URL: https://github.com/apache/carbondata/pull/3854#issuecomment-660976081 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1697/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3854: [WIP]Fix compaction failure issue for SI table and metadata mismatch in concurrency

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3854: URL: https://github.com/apache/carbondata/pull/3854#issuecomment-660975867 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3439/

[GitHub] [carbondata] asfgit closed pull request #3827: [CARBONDATA-3889] Cleanup code for carbondata-hadoop module

2020-07-20 Thread GitBox
asfgit closed pull request #3827: URL: https://github.com/apache/carbondata/pull/3827 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3778: [WIP] Support array with SI

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3778: URL: https://github.com/apache/carbondata/pull/3778#issuecomment-660967562 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3438/

[GitHub] [carbondata] kevinjmh commented on pull request #3827: [CARBONDATA-3889] Cleanup code for carbondata-hadoop module

2020-07-20 Thread GitBox
kevinjmh commented on pull request #3827: URL: https://github.com/apache/carbondata/pull/3827#issuecomment-660979881 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] asfgit closed pull request #3828: [CARBONDATA-3889] Cleanup typo code for carbondata-core module

2020-07-20 Thread GitBox
asfgit closed pull request #3828: URL: https://github.com/apache/carbondata/pull/3828 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] dependabot[bot] commented on pull request #3447: Bump dep.jackson.version from 2.6.5 to 2.10.1 in /store/sdk

2020-07-20 Thread GitBox
dependabot[bot] commented on pull request #3447: URL: https://github.com/apache/carbondata/pull/3447#issuecomment-660989521 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting

[GitHub] [carbondata] dependabot[bot] commented on pull request #3456: Bump solr.version from 6.3.0 to 8.3.0 in /datamap/lucene

2020-07-20 Thread GitBox
dependabot[bot] commented on pull request #3456: URL: https://github.com/apache/carbondata/pull/3456#issuecomment-660989407 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3818: [Carbondata-3883] Added filtering for the deleted rows for local dictionary fields

2020-07-20 Thread GitBox
ajantha-bhat commented on a change in pull request #3818: URL: https://github.com/apache/carbondata/pull/3818#discussion_r457364156 ## File path: integration/presto/src/main/java/org/apache/carbondata/presto/CarbonColumnVectorWrapper.java ## @@ -273,7 +279,7 @@ public boolean

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3848: [CARBONDATA-3891] Fix loading data will update all segments updateDeltaEndTimestamp

2020-07-20 Thread GitBox
Indhumathi27 commented on a change in pull request #3848: URL: https://github.com/apache/carbondata/pull/3848#discussion_r457401996 ## File path: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonOutputCommitter.java ## @@ -234,13 +234,7 @@ private void

[GitHub] [carbondata] QiangCai commented on pull request #3849: [CARBONDATA-3913] Table level timestampformat support

2020-07-20 Thread GitBox
QiangCai commented on pull request #3849: URL: https://github.com/apache/carbondata/pull/3849#issuecomment-661062638 two suggestions: 1. support DATEFORMAT AND TIMESTAMPFORMAT 2. use the same property name with load options.

[GitHub] [carbondata] IceMimosa commented on a change in pull request #3848: [CARBONDATA-3891] Fix loading data will update all segments updateDeltaEndTimestamp

2020-07-20 Thread GitBox
IceMimosa commented on a change in pull request #3848: URL: https://github.com/apache/carbondata/pull/3848#discussion_r457424849 ## File path: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonOutputCommitter.java ## @@ -234,13 +234,7 @@ private void

[jira] [Created] (CARBONDATA-3916) Support array with SI

2020-07-20 Thread Indhumathi Muthumurugesh (Jira)
Indhumathi Muthumurugesh created CARBONDATA-3916: Summary: Support array with SI Key: CARBONDATA-3916 URL: https://issues.apache.org/jira/browse/CARBONDATA-3916 Project: CarbonData

[GitHub] [carbondata] QiangCai commented on pull request #3785: [CARBONDATA-3843] Fix merge index issue in streaming table

2020-07-20 Thread GitBox
QiangCai commented on pull request #3785: URL: https://github.com/apache/carbondata/pull/3785#issuecomment-661034882 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] MarvinLitt opened a new pull request #3855: [CARBONDATA-3863], after using index service clean the temp data

2020-07-20 Thread GitBox
MarvinLitt opened a new pull request #3855: URL: https://github.com/apache/carbondata/pull/3855 ### Why is this PR needed? ### What changes were proposed in this PR? ### Does this PR introduce any user interface change? - No - Yes. (please explain the

[GitHub] [carbondata] QiangCai commented on pull request #3812: [CARBONDATA-3895]Fx FileNotFound exception in query after global sort compaction

2020-07-20 Thread GitBox
QiangCai commented on pull request #3812: URL: https://github.com/apache/carbondata/pull/3812#issuecomment-661065588 please rebase it This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] QiangCai commented on pull request #3778: [WIP] Support array with SI

2020-07-20 Thread GitBox
QiangCai commented on pull request #3778: URL: https://github.com/apache/carbondata/pull/3778#issuecomment-661065769 please rebase it This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3778: [CARBONDATA-3916] Support array with SI

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3778: URL: https://github.com/apache/carbondata/pull/3778#issuecomment-661075813 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3442/

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3818: [Carbondata-3883] Added filtering for the deleted rows for local dictionary fields

2020-07-20 Thread GitBox
ajantha-bhat commented on a change in pull request #3818: URL: https://github.com/apache/carbondata/pull/3818#discussion_r457364156 ## File path: integration/presto/src/main/java/org/apache/carbondata/presto/CarbonColumnVectorWrapper.java ## @@ -273,7 +279,7 @@ public boolean

[GitHub] [carbondata] QiangCai commented on pull request #3810: [CARBONDATA-3900] [CARBONDATA-3882] [CARBONDATA-3881] Fix multiple concurrent issues in table status lock and segment lock for SI and ma

2020-07-20 Thread GitBox
QiangCai commented on pull request #3810: URL: https://github.com/apache/carbondata/pull/3810#issuecomment-661033191 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3848: [CARBONDATA-3891] Fix loading data will update all segments updateDeltaEndTimestamp

2020-07-20 Thread GitBox
Indhumathi27 commented on a change in pull request #3848: URL: https://github.com/apache/carbondata/pull/3848#discussion_r457401996 ## File path: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonOutputCommitter.java ## @@ -234,13 +234,7 @@ private void

[GitHub] [carbondata] QiangCai commented on a change in pull request #3849: [CARBONDATA-3913] Table level timestampformat support

2020-07-20 Thread GitBox
QiangCai commented on a change in pull request #3849: URL: https://github.com/apache/carbondata/pull/3849#discussion_r457429601 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/dataload/TestLoadDataWithDiffTimestampFormat.scala ## @@ -122,6

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3778: [WIP][CARBONDATA-3916] Support array with SI

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3778: URL: https://github.com/apache/carbondata/pull/3778#issuecomment-661078111 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1700/

[GitHub] [carbondata] Nitin-Kashyap commented on pull request #3818: [Carbondata-3883] Added filtering for the deleted rows for local dictionary fields

2020-07-20 Thread GitBox
Nitin-Kashyap commented on pull request #3818: URL: https://github.com/apache/carbondata/pull/3818#issuecomment-661134146 > @Nitin-Kashyap : Can you please add a test here in `PrestoAllDataTypeLocalDictTest.scala` for this scenario. May be just add one more query for existing table local

[GitHub] [carbondata] ajantha-bhat commented on pull request #3818: [Carbondata-3883] Added filtering for the deleted rows for local dictionary fields

2020-07-20 Thread GitBox
ajantha-bhat commented on pull request #3818: URL: https://github.com/apache/carbondata/pull/3818#issuecomment-661139354 > Since the test step required me to insert and delete record using Spark-Integration; The same feature is unavailable in Presto-Integration; I'm not sure how to add

[GitHub] [carbondata] ajantha-bhat commented on pull request #3818: [Carbondata-3883] Added filtering for the deleted rows for local dictionary fields

2020-07-20 Thread GitBox
ajantha-bhat commented on pull request #3818: URL: https://github.com/apache/carbondata/pull/3818#issuecomment-661139652 LGTM. Thanks for the contribution ! This is an automated message from the Apache Git Service. To

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3855: [CARBONDATA-3863], after using index service clean the temp data

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3855: URL: https://github.com/apache/carbondata/pull/3855#issuecomment-661143216 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1699/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3855: [CARBONDATA-3863], after using index service clean the temp data

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3855: URL: https://github.com/apache/carbondata/pull/3855#issuecomment-661143881 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3441/

[GitHub] [carbondata] asfgit closed pull request #3818: [Carbondata-3883] Added filtering for the deleted rows for local dictionary fields

2020-07-20 Thread GitBox
asfgit closed pull request #3818: URL: https://github.com/apache/carbondata/pull/3818 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (CARBONDATA-3883) Table result shows invalid data for local diction column In Presto

2020-07-20 Thread Ajantha Bhat (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajantha Bhat resolved CARBONDATA-3883. -- Fix Version/s: 2.1.0 Resolution: Fixed > Table result shows invalid data

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3771: [CARBONDATA-3849] pushdown array_contains filter to carbon for array of primitive types

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3771: URL: https://github.com/apache/carbondata/pull/3771#issuecomment-661117575 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3440/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3771: [CARBONDATA-3849] pushdown array_contains filter to carbon for array of primitive types

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3771: URL: https://github.com/apache/carbondata/pull/3771#issuecomment-661122494 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1698/

[GitHub] [carbondata] Nitin-Kashyap commented on a change in pull request #3818: [Carbondata-3883] Added filtering for the deleted rows for local dictionary fields

2020-07-20 Thread GitBox
Nitin-Kashyap commented on a change in pull request #3818: URL: https://github.com/apache/carbondata/pull/3818#discussion_r457520179 ## File path: integration/presto/src/main/java/org/apache/carbondata/presto/CarbonColumnVectorWrapper.java ## @@ -273,7 +279,7 @@ public

[GitHub] [carbondata] Nitin-Kashyap commented on a change in pull request #3818: [Carbondata-3883] Added filtering for the deleted rows for local dictionary fields

2020-07-20 Thread GitBox
Nitin-Kashyap commented on a change in pull request #3818: URL: https://github.com/apache/carbondata/pull/3818#discussion_r457523394 ## File path: integration/presto/src/main/java/org/apache/carbondata/presto/CarbonColumnVectorWrapper.java ## @@ -273,7 +279,7 @@ public

[GitHub] [carbondata] akashrn5 commented on pull request #3812: [CARBONDATA-3895]Fx FileNotFound exception in query after global sort compaction

2020-07-20 Thread GitBox
akashrn5 commented on pull request #3812: URL: https://github.com/apache/carbondata/pull/3812#issuecomment-661104272 @QiangCai rebased, please review. This is an automated message from the Apache Git Service. To respond to

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3818: [Carbondata-3883] Added filtering for the deleted rows for local dictionary fields

2020-07-20 Thread GitBox
ajantha-bhat commented on a change in pull request #3818: URL: https://github.com/apache/carbondata/pull/3818#discussion_r457524287 ## File path: integration/presto/src/main/java/org/apache/carbondata/presto/CarbonColumnVectorWrapper.java ## @@ -273,7 +279,7 @@ public boolean

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3778: [WIP][CARBONDATA-3916] Support array with SI

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3778: URL: https://github.com/apache/carbondata/pull/3778#issuecomment-661187440 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3443/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3778: [WIP][CARBONDATA-3916] Support array with SI

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3778: URL: https://github.com/apache/carbondata/pull/3778#issuecomment-661191872 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1701/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3812: [CARBONDATA-3895]Fx FileNotFound exception in query after global sort compaction

2020-07-20 Thread GitBox
CarbonDataQA1 commented on pull request #3812: URL: https://github.com/apache/carbondata/pull/3812#issuecomment-661224955 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3445/