[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3896: [CARBONDATA-3955] Fix load failures due to daylight saving time changes

2020-08-23 Thread GitBox
ShreelekhyaG commented on a change in pull request #3896: URL: https://github.com/apache/carbondata/pull/3896#discussion_r475378412 ## File path: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ## @@ -816,10 +816,13 @@ object CarbonD

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3896: [CARBONDATA-3955] Fix load failures due to daylight saving time changes

2020-08-23 Thread GitBox
ShreelekhyaG commented on a change in pull request #3896: URL: https://github.com/apache/carbondata/pull/3896#discussion_r475377552 ## File path: integration/spark/src/test/resources/badrecords/invalidTimeStampRange.csv ## @@ -0,0 +1,2 @@ +ID,date,starttime,country,name,phonet

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3896: [CARBONDATA-3955] Fix load failures due to daylight saving time changes

2020-08-23 Thread GitBox
ShreelekhyaG commented on a change in pull request #3896: URL: https://github.com/apache/carbondata/pull/3896#discussion_r475377258 ## File path: core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ## @@ -435,19 +436,48 @@ public static Object getDataDataTypeF

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3896: [CARBONDATA-3955] Fix load failures due to daylight saving time changes

2020-08-23 Thread GitBox
ShreelekhyaG commented on a change in pull request #3896: URL: https://github.com/apache/carbondata/pull/3896#discussion_r475377325 ## File path: core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ## @@ -435,19 +436,48 @@ public static Object getDataDataTypeF

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3896: [CARBONDATA-3955] Fix load failures due to daylight saving time changes

2020-08-23 Thread GitBox
ShreelekhyaG commented on a change in pull request #3896: URL: https://github.com/apache/carbondata/pull/3896#discussion_r475377187 ## File path: core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ## @@ -435,19 +436,48 @@ public static Object getDataDataTypeF

[GitHub] [carbondata] akkio-97 commented on a change in pull request #3866: [CARBONDATA-3915] Correction in the documentation for spark-shell

2020-08-23 Thread GitBox
akkio-97 commented on a change in pull request #3866: URL: https://github.com/apache/carbondata/pull/3866#discussion_r475362156 ## File path: docs/hive-guide.md ## @@ -52,16 +52,11 @@ $HADOOP_HOME/bin/hadoop fs -put sample.csv /sample.csv ``` import org.apache.spark.sql.Spark

[GitHub] [carbondata] Indhumathi27 commented on pull request #3893: Added new property to set the value of executor LRU cache size to 70% of the total executor memory in IndexServer, if executor LRU c

2020-08-23 Thread GitBox
Indhumathi27 commented on pull request #3893: URL: https://github.com/apache/carbondata/pull/3893#issuecomment-678918781 @Karan980 Please create JIRA and update the PR description This is an automated message from the Apache

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3862: [CARBONDATA-3933]Fix DDL/DML failures after table is created with column names having special characters like #,\,%

2020-08-23 Thread GitBox
akashrn5 commented on a change in pull request #3862: URL: https://github.com/apache/carbondata/pull/3862#discussion_r475353691 ## File path: integration/spark/src/test/scala/org/apache/spark/carbondata/restructure/AlterTableRevertTestCase.scala ## @@ -30,6 +32,13 @@ import o

[GitHub] [carbondata] QiangCai commented on a change in pull request #3862: [CARBONDATA-3933]Fix DDL/DML failures after table is created with column names having special characters like #,\,%

2020-08-23 Thread GitBox
QiangCai commented on a change in pull request #3862: URL: https://github.com/apache/carbondata/pull/3862#discussion_r475347003 ## File path: integration/spark/src/test/scala/org/apache/spark/carbondata/restructure/AlterTableRevertTestCase.scala ## @@ -30,6 +32,13 @@ import o

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3896: [CARBONDATA-3955] Fix load failures due to daylight saving time changes

2020-08-23 Thread GitBox
ShreelekhyaG commented on a change in pull request #3896: URL: https://github.com/apache/carbondata/pull/3896#discussion_r475346002 ## File path: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ## @@ -1592,6 +1592,13 @@ private CarbonCommonCo

[GitHub] [carbondata] Karan980 commented on pull request #3876: TestingCI

2020-08-23 Thread GitBox
Karan980 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-678905253 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3862: [CARBONDATA-3933]Fix DDL/DML failures after table is created with column names having special characters like #,\,%

2020-08-23 Thread GitBox
akashrn5 commented on a change in pull request #3862: URL: https://github.com/apache/carbondata/pull/3862#discussion_r475336910 ## File path: integration/spark/src/test/scala/org/apache/spark/carbondata/restructure/AlterTableRevertTestCase.scala ## @@ -30,6 +32,13 @@ import o

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3862: [CARBONDATA-3933]Fix DDL/DML failures after table is created with column names having special characters like #,\,%

2020-08-23 Thread GitBox
akashrn5 commented on a change in pull request #3862: URL: https://github.com/apache/carbondata/pull/3862#discussion_r475336497 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/hive/CarbonSessionCatalogUtil.scala ## @@ -61,21 +61,6 @@ object CarbonSessionCat

[GitHub] [carbondata] QiangCai commented on a change in pull request #3862: [CARBONDATA-3933]Fix DDL/DML failures after table is created with column names having special characters like #,\,%

2020-08-23 Thread GitBox
QiangCai commented on a change in pull request #3862: URL: https://github.com/apache/carbondata/pull/3862#discussion_r475301804 ## File path: integration/spark/src/test/scala/org/apache/spark/carbondata/restructure/AlterTableRevertTestCase.scala ## @@ -30,6 +32,13 @@ import o

[GitHub] [carbondata] QiangCai commented on a change in pull request #3862: [CARBONDATA-3933]Fix DDL/DML failures after table is created with column names having special characters like #,\,%

2020-08-23 Thread GitBox
QiangCai commented on a change in pull request #3862: URL: https://github.com/apache/carbondata/pull/3862#discussion_r475298980 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/hive/CarbonSessionCatalogUtil.scala ## @@ -61,21 +61,6 @@ object CarbonSessionCat

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

2020-08-23 Thread GitBox
CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-678825751 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2101/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

2020-08-23 Thread GitBox
CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-678824999 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3842/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3862: [CARBONDATA-3933]Fix DDL/DML failures after table is created with column names having special characters like #,\,%

2020-08-23 Thread GitBox
CarbonDataQA1 commented on pull request #3862: URL: https://github.com/apache/carbondata/pull/3862#issuecomment-678814227 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2100/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3862: [CARBONDATA-3933]Fix DDL/DML failures after table is created with column names having special characters like #,\,%

2020-08-23 Thread GitBox
CarbonDataQA1 commented on pull request #3862: URL: https://github.com/apache/carbondata/pull/3862#issuecomment-678813779 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3841/ -

[GitHub] [carbondata] Karan980 commented on pull request #3876: TestingCI

2020-08-23 Thread GitBox
Karan980 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-678812610 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

2020-08-23 Thread GitBox
CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-678812332 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2099/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

2020-08-23 Thread GitBox
CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-678811731 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3840/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3896: [CARBONDATA-3955] Fix load failures due to daylight saving time changes

2020-08-23 Thread GitBox
CarbonDataQA1 commented on pull request #3896: URL: https://github.com/apache/carbondata/pull/3896#issuecomment-678811108 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [carbondata] kunal642 commented on a change in pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

2020-08-23 Thread GitBox
kunal642 commented on a change in pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#discussion_r475244586 ## File path: sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonIUD.java ## @@ -0,0 +1,275 @@ +package org.apache.carbondata.sdk.file; + +imp

[GitHub] [carbondata] kunal642 commented on pull request #3862: [CARBONDATA-3933]Fix DDL/DML failures after table is created with column names having special characters like #,\,%

2020-08-23 Thread GitBox
kunal642 commented on pull request #3862: URL: https://github.com/apache/carbondata/pull/3862#issuecomment-678801642 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[jira] [Resolved] (CARBONDATA-3946) Support IndexServer with Presto Engine

2020-08-23 Thread Kunal Kapoor (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kunal Kapoor resolved CARBONDATA-3946. -- Fix Version/s: 2.1.0 Resolution: Fixed > Support IndexServer with Presto En

[GitHub] [carbondata] asfgit closed pull request #3885: [CARBONDATA-3946] Support IndexServer with Presto Engine

2020-08-23 Thread GitBox
asfgit closed pull request #3885: URL: https://github.com/apache/carbondata/pull/3885 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [carbondata] kunal642 commented on pull request #3885: [CARBONDATA-3946] Support IndexServer with Presto Engine

2020-08-23 Thread GitBox
kunal642 commented on pull request #3885: URL: https://github.com/apache/carbondata/pull/3885#issuecomment-678801176 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [carbondata] Karan980 commented on pull request #3876: TestingCI

2020-08-23 Thread GitBox
Karan980 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-678799256 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3885: [CARBONDATA-3946] Support IndexServer with Presto Engine

2020-08-23 Thread GitBox
CarbonDataQA1 commented on pull request #3885: URL: https://github.com/apache/carbondata/pull/3885#issuecomment-678798742 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2097/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3885: [CARBONDATA-3946] Support IndexServer with Presto Engine

2020-08-23 Thread GitBox
CarbonDataQA1 commented on pull request #3885: URL: https://github.com/apache/carbondata/pull/3885#issuecomment-678798596 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3838/ -

[GitHub] [carbondata] kunal642 commented on pull request #3885: [CARBONDATA-3946] Support IndexServer with Presto Engine

2020-08-23 Thread GitBox
kunal642 commented on pull request #3885: URL: https://github.com/apache/carbondata/pull/3885#issuecomment-678782325 please rebase This is an automated message from the Apache Git Service. To respond to the message, please lo